[INFO] cloning repository https://github.com/linuxboot/uefisettings [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/linuxboot/uefisettings" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinuxboot%2Fuefisettings", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinuxboot%2Fuefisettings'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 149bc92970949d44be641ae1e3e942220d7390e7 [INFO] linting linuxboot/uefisettings against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinuxboot%2Fuefisettings" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/linuxboot/uefisettings [INFO] finished tweaking git repo https://github.com/linuxboot/uefisettings [INFO] tweaked toml for git repo https://github.com/linuxboot/uefisettings written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/linuxboot/uefisettings on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/linuxboot/uefisettings already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.194 [INFO] [stderr] Downloaded terminal_size v0.2.6 [INFO] [stderr] Downloaded value-bag-serde1 v1.4.2 [INFO] [stderr] Downloaded sval_dynamic v2.11.0 [INFO] [stderr] Downloaded sval_buffer v2.11.0 [INFO] [stderr] Downloaded binrw_derive v0.13.3 [INFO] [stderr] Downloaded sval v2.11.0 [INFO] [stderr] Downloaded serde v1.0.194 [INFO] [stderr] Downloaded binrw v0.13.3 [INFO] [stderr] Downloaded serde_json v1.0.110 [INFO] [stderr] Downloaded sval_nested v2.11.0 [INFO] [stderr] Downloaded value-bag v1.4.2 [INFO] [stderr] Downloaded sval_ref v2.11.0 [INFO] [stderr] Downloaded partition-identity v0.3.0 [INFO] [stderr] Downloaded ghost v0.1.17 [INFO] [stderr] Downloaded sval_fmt v2.11.0 [INFO] [stderr] Downloaded sval_json v2.11.0 [INFO] [stderr] Downloaded syn v2.0.46 [INFO] [stderr] Downloaded value-bag-sval2 v1.4.2 [INFO] [stderr] Downloaded proc-mounts v0.3.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.74 [INFO] [stderr] Downloaded fbthrift v0.0.3 [INFO] [stderr] Downloaded sval_serde v2.11.0 [INFO] [stderr] Downloaded bufsize v1.0.7 [INFO] [stderr] Downloaded panic-message v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 277c7253bd643fd4bef7e801763e0ddb593b72385a4b50299a4a9d6fafa7f4b9 [INFO] running `Command { std: "docker" "start" "-a" "277c7253bd643fd4bef7e801763e0ddb593b72385a4b50299a4a9d6fafa7f4b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "277c7253bd643fd4bef7e801763e0ddb593b72385a4b50299a4a9d6fafa7f4b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "277c7253bd643fd4bef7e801763e0ddb593b72385a4b50299a4a9d6fafa7f4b9", kill_on_drop: false }` [INFO] [stdout] 277c7253bd643fd4bef7e801763e0ddb593b72385a4b50299a4a9d6fafa7f4b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe51fabd185a1fa76dcf0b1f99843af43c9de2627502bacebcbd740b69c644cc [INFO] running `Command { std: "docker" "start" "-a" "fe51fabd185a1fa76dcf0b1f99843af43c9de2627502bacebcbd740b69c644cc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling serde_json v1.0.110 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling binrw_derive v0.13.3 [INFO] [stderr] Checking panic-message v0.3.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking value-bag v1.4.2 [INFO] [stderr] Compiling binrw v0.13.3 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking partition-identity v0.3.0 [INFO] [stderr] Checking proc-mounts v0.3.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking bufsize v1.0.7 [INFO] [stderr] Checking fbthrift v0.0.3 [INFO] [stderr] Checking uefisettings_backend_thrift v0.1.0 (/opt/rustwide/workdir/thrift/rust/uefisettings_backend_thrift) [INFO] [stderr] Checking uefisettings_spellings_db_thrift v0.1.0 (/opt/rustwide/workdir/thrift/rust/uefisettings_spellings_db_thrift) [INFO] [stdout] warning: unused import: `self::errors::*` [INFO] [stdout] --> thrift/rust/uefisettings_spellings_db_thrift/uefisettings_spellings_db.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use self::errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::errors::*` [INFO] [stdout] --> thrift/rust/uefisettings_backend_thrift/uefisettings_backend.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking uefisettings v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `anyhow::anyhow` [INFO] [stdout] --> src/lib/exports.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use anyhow::anyhow; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::var` [INFO] [stdout] --> src/lib/hii/forms.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use std::env::var; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/lib/hii/forms.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::error` [INFO] [stdout] --> src/lib/hii/forms.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | use log::error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/lib/hii/package.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | / /// ``` [INFO] [stdout] 55 | | [INFO] [stdout] | |_^ [INFO] [stdout] 56 | pub struct Transport<'a> { [INFO] [stdout] | -------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::anyhow` [INFO] [stdout] --> src/lib/exports.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use anyhow::anyhow; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::var` [INFO] [stdout] --> src/lib/hii/forms.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use std::env::var; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/lib/hii/forms.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::error` [INFO] [stdout] --> src/lib/hii/forms.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | use log::error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:54:1 [INFO] [stdout] | [INFO] [stdout] 54 | / /// ``` [INFO] [stdout] 55 | | [INFO] [stdout] | |_^ [INFO] [stdout] 56 | pub struct Transport<'a> { [INFO] [stdout] | -------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:302:18 [INFO] [stdout] | [INFO] [stdout] 302 | DefaultStore(DefaultStore), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 302 - DefaultStore(DefaultStore), [INFO] [stdout] 302 + DefaultStore(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:304:10 [INFO] [stdout] | [INFO] [stdout] 304 | Form(Form), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 304 - Form(Form), [INFO] [stdout] 304 + Form(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:305:10 [INFO] [stdout] | [INFO] [stdout] 305 | Text(Text), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 305 - Text(Text), [INFO] [stdout] 305 + Text(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:308:18 [INFO] [stdout] | [INFO] [stdout] 308 | QuestionRef1(QuestionRef1), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 308 - QuestionRef1(QuestionRef1), [INFO] [stdout] 308 + QuestionRef1(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | EqIdVal(EqIdVal), [INFO] [stdout] | ------- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 309 - EqIdVal(EqIdVal), [INFO] [stdout] 309 + EqIdVal(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | EqIdValList(EqIdValList), [INFO] [stdout] | ----------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 310 - EqIdValList(EqIdValList), [INFO] [stdout] 310 + EqIdValList(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/lib/hii/forms.rs:717:5 [INFO] [stdout] | [INFO] [stdout] 711 | pub enum TypeValue { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 717 | Time(Time), [INFO] [stdout] | ^^^^ [INFO] [stdout] 718 | Date(Date), [INFO] [stdout] | ^^^^ [INFO] [stdout] 719 | StringID(u16), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 720 | Other, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 721 | Undefined, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 722 | Action(u16), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 723 | // Buffer(Vec), - spec unclear ; FIXME [INFO] [stdout] 724 | Ref(Ref), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeValue` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_max_buffer_size`, `get_blob_request_size`, `get_finalize_request_size`, `get_create_request_size`, `get_info_request_size`, and `get_delete_request_size` are never used [INFO] [stdout] --> src/lib/ilorest/chif.rs:460:8 [INFO] [stdout] | [INFO] [stdout] 456 | pub trait IloRestChifInterface { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 460 | fn get_max_buffer_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 480 | fn get_blob_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 497 | fn get_finalize_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 498 | fn get_create_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 499 | fn get_key_info(&self, response_key: &CStr, namespace: &CStr) -> &[u8]; [INFO] [stdout] 500 | fn get_info_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 503 | fn get_delete_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedfishSettingsInfo` is never constructed [INFO] [stdout] --> src/lib/ilorest/requests.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | pub struct RedfishSettingsInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `post` and `put` are never used [INFO] [stdout] --> src/lib/ilorest/rest.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl RestClient { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 47 | pub fn post(&self, endpoint: &str, body: &str) -> Result<(u16, Vec)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn put(&self, endpoint: &str, body: &str) -> Result<(u16, Vec)> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file_lock.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / return Err(anyhow!(format!( [INFO] [stdout] 53 | | "failed to get lock on fd {} path {}", [INFO] [stdout] 54 | | &self.file_descriptor, &self.path [INFO] [stdout] 55 | | ))); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ Err(anyhow!(format!( [INFO] [stdout] 53 + "failed to get lock on fd {} path {}", [INFO] [stdout] 54 + &self.file_descriptor, &self.path [INFO] [stdout] 55 ~ ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/lib/file_lock.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/file_lock.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / match flock(self.file_descriptor, FlockArg::UnlockNonblock) { [INFO] [stdout] 65 | | Err(error_code) => { [INFO] [stdout] 66 | | error!("file lock unlock failed with error code {}", error_code) [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Err(error_code) = flock(self.file_descriptor, FlockArg::UnlockNonblock) { [INFO] [stdout] 65 + error!("file lock unlock failed with error code {}", error_code) [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:302:18 [INFO] [stdout] | [INFO] [stdout] 302 | DefaultStore(DefaultStore), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 302 - DefaultStore(DefaultStore), [INFO] [stdout] 302 + DefaultStore(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:304:10 [INFO] [stdout] | [INFO] [stdout] 304 | Form(Form), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 304 - Form(Form), [INFO] [stdout] 304 + Form(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:305:10 [INFO] [stdout] | [INFO] [stdout] 305 | Text(Text), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 305 - Text(Text), [INFO] [stdout] 305 + Text(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:308:18 [INFO] [stdout] | [INFO] [stdout] 308 | QuestionRef1(QuestionRef1), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 308 - QuestionRef1(QuestionRef1), [INFO] [stdout] 308 + QuestionRef1(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | EqIdVal(EqIdVal), [INFO] [stdout] | ------- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 309 - EqIdVal(EqIdVal), [INFO] [stdout] 309 + EqIdVal(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib/hii/forms.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | EqIdValList(EqIdValList), [INFO] [stdout] | ----------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsedOperation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 310 - EqIdValList(EqIdValList), [INFO] [stdout] 310 + EqIdValList(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/lib/hii/forms.rs:717:5 [INFO] [stdout] | [INFO] [stdout] 711 | pub enum TypeValue { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 717 | Time(Time), [INFO] [stdout] | ^^^^ [INFO] [stdout] 718 | Date(Date), [INFO] [stdout] | ^^^^ [INFO] [stdout] 719 | StringID(u16), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 720 | Other, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 721 | Undefined, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 722 | Action(u16), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 723 | // Buffer(Vec), - spec unclear ; FIXME [INFO] [stdout] 724 | Ref(Ref), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeValue` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_max_buffer_size`, `get_blob_request_size`, `get_finalize_request_size`, `get_create_request_size`, `get_info_request_size`, and `get_delete_request_size` are never used [INFO] [stdout] --> src/lib/ilorest/chif.rs:460:8 [INFO] [stdout] | [INFO] [stdout] 456 | pub trait IloRestChifInterface { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 460 | fn get_max_buffer_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 480 | fn get_blob_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 497 | fn get_finalize_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 498 | fn get_create_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 499 | fn get_key_info(&self, response_key: &CStr, namespace: &CStr) -> &[u8]; [INFO] [stdout] 500 | fn get_info_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 503 | fn get_delete_request_size(&self) -> u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedfishSettingsInfo` is never constructed [INFO] [stdout] --> src/lib/ilorest/requests.rs:402:12 [INFO] [stdout] | [INFO] [stdout] 402 | pub struct RedfishSettingsInfo { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `post` and `put` are never used [INFO] [stdout] --> src/lib/ilorest/rest.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl RestClient { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 47 | pub fn post(&self, endpoint: &str, body: &str) -> Result<(u16, Vec)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn put(&self, endpoint: &str, body: &str) -> Result<(u16, Vec)> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib/hii/forms.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | #[br(count = length - 2)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u8` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 268 - #[br(count = length - 2)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] 268 + #[br(count = From::from)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib/hii/forms.rs:313:1 [INFO] [stdout] | [INFO] [stdout] 313 | / impl Default for ParsedOperation { [INFO] [stdout] 314 | | fn default() -> Self { [INFO] [stdout] 315 | | ParsedOperation::Placeholder [INFO] [stdout] 316 | | } [INFO] [stdout] 317 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 295 + #[derive(Default)] [INFO] [stdout] 296 | pub enum ParsedOperation { [INFO] [stdout] 297 | FormSet(FormSet), [INFO] [stdout] ... [INFO] [stdout] 311 | EqIdValList(EqIdValList), [INFO] [stdout] 312 ~ #[default] [INFO] [stdout] 313 ~ Placeholder, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/hii/forms.rs:495:35 [INFO] [stdout] | [INFO] [stdout] 495 | let mut file = File::open(&self.store_filename()).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.store_filename()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/file_lock.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / return Err(anyhow!(format!( [INFO] [stdout] 53 | | "failed to get lock on fd {} path {}", [INFO] [stdout] 54 | | &self.file_descriptor, &self.path [INFO] [stdout] 55 | | ))); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ Err(anyhow!(format!( [INFO] [stdout] 53 + "failed to get lock on fd {} path {}", [INFO] [stdout] 54 + &self.file_descriptor, &self.path [INFO] [stdout] 55 ~ ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/lib/file_lock.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/file_lock.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / match flock(self.file_descriptor, FlockArg::UnlockNonblock) { [INFO] [stdout] 65 | | Err(error_code) => { [INFO] [stdout] 66 | | error!("file lock unlock failed with error code {}", error_code) [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Err(error_code) = flock(self.file_descriptor, FlockArg::UnlockNonblock) { [INFO] [stdout] 65 + error!("file lock unlock failed with error code {}", error_code) [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib/hii/forms.rs:679:18 [INFO] [stdout] | [INFO] [stdout] 679 | #[br(count = list_length)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u16` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 679 - #[br(count = list_length)] [INFO] [stdout] 679 + #[br(count = From::from)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:798:21 [INFO] [stdout] | [INFO] [stdout] 798 | / match parent_ref.upgrade() { [INFO] [stdout] 799 | | Some(parent_ref_rc) => { [INFO] [stdout] 800 | | // current_scope = current_scope 's parent [INFO] [stdout] 801 | | current_scope = Rc::clone(&parent_ref_rc); [INFO] [stdout] 802 | | } [INFO] [stdout] 803 | | None => {} [INFO] [stdout] 804 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 798 ~ if let Some(parent_ref_rc) = parent_ref.upgrade() { [INFO] [stdout] 799 + // current_scope = current_scope 's parent [INFO] [stdout] 800 + current_scope = Rc::clone(&parent_ref_rc); [INFO] [stdout] 801 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:1286:13 [INFO] [stdout] | [INFO] [stdout] 1286 | / match &child.borrow().parsed_data { [INFO] [stdout] 1287 | | ParsedOperation::IFRDefault(o) => { [INFO] [stdout] 1288 | | chosen_value = u64::from(o.default_id); [INFO] [stdout] ... | [INFO] [stdout] 1291 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1286 ~ if let ParsedOperation::IFRDefault(o) = &child.borrow().parsed_data { [INFO] [stdout] 1287 + chosen_value = u64::from(o.default_id); [INFO] [stdout] 1288 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:1300:9 [INFO] [stdout] | [INFO] [stdout] 1300 | / match &child.borrow().parsed_data { [INFO] [stdout] 1301 | | ParsedOperation::OneOfOption(o) => { [INFO] [stdout] 1302 | | let current_value: u64 = match o.value { [INFO] [stdout] 1303 | | TypeValue::NumSize8(c) => c as u64, [INFO] [stdout] ... | [INFO] [stdout] 1324 | | _ => {} [INFO] [stdout] 1325 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1300 ~ if let ParsedOperation::OneOfOption(o) = &child.borrow().parsed_data { [INFO] [stdout] 1301 + let current_value: u64 = match o.value { [INFO] [stdout] 1302 + TypeValue::NumSize8(c) => c as u64, [INFO] [stdout] 1303 + TypeValue::NumSize16(c) => c as u64, [INFO] [stdout] 1304 + TypeValue::NumSize32(c) => c as u64, [INFO] [stdout] 1305 + TypeValue::NumSize64(c) => c as u64, [INFO] [stdout] 1306 + _ => 0, [INFO] [stdout] 1307 + }; [INFO] [stdout] 1308 + [INFO] [stdout] 1309 + let opt = AnswerOption { [INFO] [stdout] 1310 + raw_value: o.value.clone(), [INFO] [stdout] 1311 + value: find_corresponding_string(o.option_string_id, string_packages) [INFO] [stdout] 1312 + .to_string(), [INFO] [stdout] 1313 + }; [INFO] [stdout] 1314 + [INFO] [stdout] 1315 + if !varstore_not_found && current_value == chosen_value && !found_option { [INFO] [stdout] 1316 + found_option = true; [INFO] [stdout] 1317 + answer.push_str(opt.value.trim()); [INFO] [stdout] 1318 + // cannot break here because we want to add all options to possible_options [INFO] [stdout] 1319 + } [INFO] [stdout] 1320 + [INFO] [stdout] 1321 + possible_options.push(opt); [INFO] [stdout] 1322 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib/hii/forms.rs:1306:48 [INFO] [stdout] | [INFO] [stdout] 1306 | TypeValue::NumSize64(c) => c as u64, [INFO] [stdout] | ^^^^^^^^ help: try: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TypeValue` which implements the `Copy` trait [INFO] [stdout] --> src/lib/hii/forms.rs:1311:32 [INFO] [stdout] | [INFO] [stdout] 1311 | raw_value: o.value.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `o.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib/hii/forms.rs:1470:28 [INFO] [stdout] | [INFO] [stdout] 1470 | parsed.name.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib/hii/forms.rs:1721:30 [INFO] [stdout] | [INFO] [stdout] 1721 | fn find_corresponding_string<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 1722 | string_id: u16, [INFO] [stdout] 1723 | string_packages: &'a Vec>, [INFO] [stdout] | ^^ [INFO] [stdout] 1724 | ) -> &'a str { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1721 ~ fn find_corresponding_string( [INFO] [stdout] 1722 | string_id: u16, [INFO] [stdout] 1723 ~ string_packages: &Vec>, [INFO] [stdout] 1724 ~ ) -> &str { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/hii/forms.rs:1758:21 [INFO] [stdout] | [INFO] [stdout] 1758 | / if v.var_store_id == var_store_id { [INFO] [stdout] 1759 | | return Ok(Box::new(v.clone())); [INFO] [stdout] 1760 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1757 ~ ParsedOperation::VarStore(v) [INFO] [stdout] 1758 ~ if v.var_store_id == var_store_id => { [INFO] [stdout] 1759 | return Ok(Box::new(v.clone())); [INFO] [stdout] 1760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/hii/forms.rs:1763:21 [INFO] [stdout] | [INFO] [stdout] 1763 | / if v.var_store_id == var_store_id { [INFO] [stdout] 1764 | | return Ok(Box::new(v.clone())); [INFO] [stdout] 1765 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1762 ~ ParsedOperation::VarStoreEfi(v) [INFO] [stdout] 1763 ~ if v.var_store_id == var_store_id => { [INFO] [stdout] 1764 | return Ok(Box::new(v.clone())); [INFO] [stdout] 1765 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib/hii/forms.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | #[br(count = length - 2)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u8` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 268 - #[br(count = length - 2)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] 268 + #[br(count = From::from)] // first 3 fields make up 16 bits = 2 bytes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lib/hii/forms.rs:313:1 [INFO] [stdout] | [INFO] [stdout] 313 | / impl Default for ParsedOperation { [INFO] [stdout] 314 | | fn default() -> Self { [INFO] [stdout] 315 | | ParsedOperation::Placeholder [INFO] [stdout] 316 | | } [INFO] [stdout] 317 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 295 + #[derive(Default)] [INFO] [stdout] 296 | pub enum ParsedOperation { [INFO] [stdout] 297 | FormSet(FormSet), [INFO] [stdout] ... [INFO] [stdout] 311 | EqIdValList(EqIdValList), [INFO] [stdout] 312 ~ #[default] [INFO] [stdout] 313 ~ Placeholder, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib/hii/package.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | /// In the end return a ParsedHiiDB struct which will have the parsed and saved data. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 199 | /// In the end return a ParsedHiiDB struct which will have the parsed and saved data. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/hii/forms.rs:495:35 [INFO] [stdout] | [INFO] [stdout] 495 | let mut file = File::open(&self.store_filename()).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.store_filename()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | let rest_resp; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `rest_resp` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ let rest_resp = if (request.len() as u32) [INFO] [stdout] 76 | < (self.ilo.get_max_write_size() + self.ilo.get_immediate_request_size()) [INFO] [stdout] ... [INFO] [stdout] 88 | [INFO] [stdout] 89 ~ self [INFO] [stdout] 90 | .exchange_packet(&packet_to_send) [INFO] [stdout] 91 ~ .context("Failed to get rest response")? [INFO] [stdout] 92 | } else { [INFO] [stdout] ... [INFO] [stdout] 106 | [INFO] [stdout] 107 ~ self [INFO] [stdout] 108 | .exchange_packet(&packet_to_send) [INFO] [stdout] 109 ~ .context("Failed to get rest response")? [INFO] [stdout] 110 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | let count; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `count` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 166 ~ [INFO] [stdout] 167 ~ let count = if (max_read_size - read_request_size) < (data_length - bytes_read) { [INFO] [stdout] 168 ~ max_read_size - read_request_size [INFO] [stdout] 169 | } else { [INFO] [stdout] 170 ~ data_length - bytes_read [INFO] [stdout] 171 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:179:68 [INFO] [stdout] | [INFO] [stdout] 179 | .prepare_read_fragment(read_block_size, count, &response_key, &namespace); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `response_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:179:83 [INFO] [stdout] | [INFO] [stdout] 179 | .prepare_read_fragment(read_block_size, count, &response_key, &namespace); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:194:21 [INFO] [stdout] | [INFO] [stdout] 194 | fragment_bytes.push(0u8); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0u8;SIZE]` [INFO] [stdout] = help: or `fragment_bytes.extend(std::iter::repeat_n(0u8, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let count: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `count` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 298 ~ [INFO] [stdout] 299 ~ let count: u32 = if (max_write_size - write_request_size) < (data_length - bytes_written) { [INFO] [stdout] 300 ~ max_write_size - write_request_size [INFO] [stdout] 301 | } else { [INFO] [stdout] 302 ~ data_length - bytes_written [INFO] [stdout] 303 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:358:17 [INFO] [stdout] | [INFO] [stdout] 358 | return Err(anyhow!("Unexpected Status code: {}", status_code)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return Err(anyhow!("Unexpected Status code: {}", status_code)); [INFO] [stdout] 358 + Err(anyhow!("Unexpected Status code: {}", status_code)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/lib/hii/forms.rs:679:18 [INFO] [stdout] | [INFO] [stdout] 679 | #[br(count = list_length)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u16` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 679 - #[br(count = list_length)] [INFO] [stdout] 679 + #[br(count = From::from)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:798:21 [INFO] [stdout] | [INFO] [stdout] 798 | / match parent_ref.upgrade() { [INFO] [stdout] 799 | | Some(parent_ref_rc) => { [INFO] [stdout] 800 | | // current_scope = current_scope 's parent [INFO] [stdout] 801 | | current_scope = Rc::clone(&parent_ref_rc); [INFO] [stdout] 802 | | } [INFO] [stdout] 803 | | None => {} [INFO] [stdout] 804 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 798 ~ if let Some(parent_ref_rc) = parent_ref.upgrade() { [INFO] [stdout] 799 + // current_scope = current_scope 's parent [INFO] [stdout] 800 + current_scope = Rc::clone(&parent_ref_rc); [INFO] [stdout] 801 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:308:17 [INFO] [stdout] | [INFO] [stdout] 308 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:349:17 [INFO] [stdout] | [INFO] [stdout] 349 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 350 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:371:17 [INFO] [stdout] | [INFO] [stdout] 371 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:402:17 [INFO] [stdout] | [INFO] [stdout] 402 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:424:17 [INFO] [stdout] | [INFO] [stdout] 424 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:442:36 [INFO] [stdout] | [INFO] [stdout] 442 | (self.delete_blob)(key.as_ptr() as *const i8, namespace.as_ptr() as *const i8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:442:63 [INFO] [stdout] | [INFO] [stdout] 442 | (self.delete_blob)(key.as_ptr() as *const i8, namespace.as_ptr() as *const i8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:1286:13 [INFO] [stdout] | [INFO] [stdout] 1286 | / match &child.borrow().parsed_data { [INFO] [stdout] 1287 | | ParsedOperation::IFRDefault(o) => { [INFO] [stdout] 1288 | | chosen_value = u64::from(o.default_id); [INFO] [stdout] ... | [INFO] [stdout] 1291 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1286 ~ if let ParsedOperation::IFRDefault(o) = &child.borrow().parsed_data { [INFO] [stdout] 1287 + chosen_value = u64::from(o.default_id); [INFO] [stdout] 1288 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/hii/forms.rs:1300:9 [INFO] [stdout] | [INFO] [stdout] 1300 | / match &child.borrow().parsed_data { [INFO] [stdout] 1301 | | ParsedOperation::OneOfOption(o) => { [INFO] [stdout] 1302 | | let current_value: u64 = match o.value { [INFO] [stdout] 1303 | | TypeValue::NumSize8(c) => c as u64, [INFO] [stdout] ... | [INFO] [stdout] 1324 | | _ => {} [INFO] [stdout] 1325 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1300 ~ if let ParsedOperation::OneOfOption(o) = &child.borrow().parsed_data { [INFO] [stdout] 1301 + let current_value: u64 = match o.value { [INFO] [stdout] 1302 + TypeValue::NumSize8(c) => c as u64, [INFO] [stdout] 1303 + TypeValue::NumSize16(c) => c as u64, [INFO] [stdout] 1304 + TypeValue::NumSize32(c) => c as u64, [INFO] [stdout] 1305 + TypeValue::NumSize64(c) => c as u64, [INFO] [stdout] 1306 + _ => 0, [INFO] [stdout] 1307 + }; [INFO] [stdout] 1308 + [INFO] [stdout] 1309 + let opt = AnswerOption { [INFO] [stdout] 1310 + raw_value: o.value.clone(), [INFO] [stdout] 1311 + value: find_corresponding_string(o.option_string_id, string_packages) [INFO] [stdout] 1312 + .to_string(), [INFO] [stdout] 1313 + }; [INFO] [stdout] 1314 + [INFO] [stdout] 1315 + if !varstore_not_found && current_value == chosen_value && !found_option { [INFO] [stdout] 1316 + found_option = true; [INFO] [stdout] 1317 + answer.push_str(opt.value.trim()); [INFO] [stdout] 1318 + // cannot break here because we want to add all options to possible_options [INFO] [stdout] 1319 + } [INFO] [stdout] 1320 + [INFO] [stdout] 1321 + possible_options.push(opt); [INFO] [stdout] 1322 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/lib/hii/forms.rs:1306:48 [INFO] [stdout] | [INFO] [stdout] 1306 | TypeValue::NumSize64(c) => c as u64, [INFO] [stdout] | ^^^^^^^^ help: try: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TypeValue` which implements the `Copy` trait [INFO] [stdout] --> src/lib/hii/forms.rs:1311:32 [INFO] [stdout] | [INFO] [stdout] 1311 | raw_value: o.value.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `o.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib/hii/forms.rs:1470:28 [INFO] [stdout] | [INFO] [stdout] 1470 | parsed.name.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib/hii/forms.rs:1721:30 [INFO] [stdout] | [INFO] [stdout] 1721 | fn find_corresponding_string<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] 1722 | string_id: u16, [INFO] [stdout] 1723 | string_packages: &'a Vec>, [INFO] [stdout] | ^^ [INFO] [stdout] 1724 | ) -> &'a str { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1721 ~ fn find_corresponding_string( [INFO] [stdout] 1722 | string_id: u16, [INFO] [stdout] 1723 ~ string_packages: &Vec>, [INFO] [stdout] 1724 ~ ) -> &str { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/hii/forms.rs:1758:21 [INFO] [stdout] | [INFO] [stdout] 1758 | / if v.var_store_id == var_store_id { [INFO] [stdout] 1759 | | return Ok(Box::new(v.clone())); [INFO] [stdout] 1760 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1757 ~ ParsedOperation::VarStore(v) [INFO] [stdout] 1758 ~ if v.var_store_id == var_store_id => { [INFO] [stdout] 1759 | return Ok(Box::new(v.clone())); [INFO] [stdout] 1760 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/hii/forms.rs:1763:21 [INFO] [stdout] | [INFO] [stdout] 1763 | / if v.var_store_id == var_store_id { [INFO] [stdout] 1764 | | return Ok(Box::new(v.clone())); [INFO] [stdout] 1765 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1762 ~ ParsedOperation::VarStoreEfi(v) [INFO] [stdout] 1763 ~ if v.var_store_id == var_store_id => { [INFO] [stdout] 1764 | return Ok(Box::new(v.clone())); [INFO] [stdout] 1765 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/lib/ilorest/rest.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | body.as_bytes().len().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib/hii/package.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | /// In the end return a ParsedHiiDB struct which will have the parsed and saved data. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 199 | /// In the end return a ParsedHiiDB struct which will have the parsed and saved data. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/hii/package.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 258 | if !fs::metadata(file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `res.strings [INFO] [stdout] .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] .unwrap().get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / res.strings [INFO] [stdout] 273 | | .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 274 | | .unwrap() [INFO] [stdout] 275 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 ~ res.strings [INFO] [stdout] 273 + .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 274 + .unwrap().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `res.strings [INFO] [stdout] .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] .unwrap().get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | / res.strings [INFO] [stdout] 285 | | .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 286 | | .unwrap() [INFO] [stdout] 287 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 ~ res.strings [INFO] [stdout] 285 + .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 286 + .unwrap().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/hii/package.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 306 | if !fs::metadata(file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `res [INFO] [stdout] .forms [INFO] [stdout] .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] .unwrap().get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:315:25 [INFO] [stdout] | [INFO] [stdout] 315 | let root_node = res [INFO] [stdout] | _________________________^ [INFO] [stdout] 316 | | .forms [INFO] [stdout] 317 | | .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 318 | | .unwrap() [INFO] [stdout] 319 | | .get(0) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 315 ~ let root_node = res [INFO] [stdout] 316 + .forms [INFO] [stdout] 317 + .get("ABBCE13D-E25A-4D9F-A1F9-2F7710786892") [INFO] [stdout] 318 + .unwrap().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `root_node.children.get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | root_node.children.get(0).unwrap().borrow().op_code, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_node.children.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `root_node.children.get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:333:17 [INFO] [stdout] | [INFO] [stdout] 333 | assert!(root_node.children.get(0).unwrap().borrow().open_scope); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_node.children.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `root_node [INFO] [stdout] .children.get(0)` [INFO] [stdout] --> src/lib/hii/package.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | / root_node [INFO] [stdout] 340 | | .children [INFO] [stdout] 341 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 339 ~ root_node [INFO] [stdout] 340 + .children.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | let rest_resp; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `rest_resp` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ let rest_resp = if (request.len() as u32) [INFO] [stdout] 76 | < (self.ilo.get_max_write_size() + self.ilo.get_immediate_request_size()) [INFO] [stdout] ... [INFO] [stdout] 88 | [INFO] [stdout] 89 ~ self [INFO] [stdout] 90 | .exchange_packet(&packet_to_send) [INFO] [stdout] 91 ~ .context("Failed to get rest response")? [INFO] [stdout] 92 | } else { [INFO] [stdout] ... [INFO] [stdout] 106 | [INFO] [stdout] 107 ~ self [INFO] [stdout] 108 | .exchange_packet(&packet_to_send) [INFO] [stdout] 109 ~ .context("Failed to get rest response")? [INFO] [stdout] 110 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | let count; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `count` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 166 ~ [INFO] [stdout] 167 ~ let count = if (max_read_size - read_request_size) < (data_length - bytes_read) { [INFO] [stdout] 168 ~ max_read_size - read_request_size [INFO] [stdout] 169 | } else { [INFO] [stdout] 170 ~ data_length - bytes_read [INFO] [stdout] 171 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:179:68 [INFO] [stdout] | [INFO] [stdout] 179 | .prepare_read_fragment(read_block_size, count, &response_key, &namespace); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `response_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:179:83 [INFO] [stdout] | [INFO] [stdout] 179 | .prepare_read_fragment(read_block_size, count, &response_key, &namespace); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `namespace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:194:21 [INFO] [stdout] | [INFO] [stdout] 194 | fragment_bytes.push(0u8); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0u8;SIZE]` [INFO] [stdout] = help: or `fragment_bytes.extend(std::iter::repeat_n(0u8, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | let count: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `count` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 298 ~ [INFO] [stdout] 299 ~ let count: u32 = if (max_write_size - write_request_size) < (data_length - bytes_written) { [INFO] [stdout] 300 ~ max_write_size - write_request_size [INFO] [stdout] 301 | } else { [INFO] [stdout] 302 ~ data_length - bytes_written [INFO] [stdout] 303 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/ilorest/blobstore.rs:358:17 [INFO] [stdout] | [INFO] [stdout] 358 | return Err(anyhow!("Unexpected Status code: {}", status_code)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 - return Err(anyhow!("Unexpected Status code: {}", status_code)); [INFO] [stdout] 358 + Err(anyhow!("Unexpected Status code: {}", status_code)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 307 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:308:17 [INFO] [stdout] | [INFO] [stdout] 308 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:349:17 [INFO] [stdout] | [INFO] [stdout] 349 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:350:17 [INFO] [stdout] | [INFO] [stdout] 350 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:371:17 [INFO] [stdout] | [INFO] [stdout] 371 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:390:17 [INFO] [stdout] | [INFO] [stdout] 390 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | request_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `request_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:402:17 [INFO] [stdout] | [INFO] [stdout] 402 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:423:17 [INFO] [stdout] | [INFO] [stdout] 423 | response_key.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:424:17 [INFO] [stdout] | [INFO] [stdout] 424 | namespace.as_ptr() as *const i8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:442:36 [INFO] [stdout] | [INFO] [stdout] 442 | (self.delete_blob)(key.as_ptr() as *const i8, namespace.as_ptr() as *const i8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`) [INFO] [stdout] --> src/lib/ilorest/chif.rs:442:63 [INFO] [stdout] | [INFO] [stdout] 442 | (self.delete_blob)(key.as_ptr() as *const i8, namespace.as_ptr() as *const i8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `namespace.as_ptr()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/lib/ilorest/rest.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | body.as_bytes().len().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:311:35 [INFO] [stdout] | [INFO] [stdout] 311 | let mut file = File::open(&dbdump_path) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dbdump_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:311:35 [INFO] [stdout] | [INFO] [stdout] 311 | let mut file = File::open(&dbdump_path) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dbdump_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.91s [INFO] running `Command { std: "docker" "inspect" "fe51fabd185a1fa76dcf0b1f99843af43c9de2627502bacebcbd740b69c644cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe51fabd185a1fa76dcf0b1f99843af43c9de2627502bacebcbd740b69c644cc", kill_on_drop: false }` [INFO] [stdout] fe51fabd185a1fa76dcf0b1f99843af43c9de2627502bacebcbd740b69c644cc