[INFO] cloning repository https://github.com/linepi/chatserver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/linepi/chatserver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinepi%2Fchatserver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinepi%2Fchatserver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0add0b3da2bab0413d8050a1a8b43a17d1f816b9 [INFO] linting linepi/chatserver against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flinepi%2Fchatserver" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/linepi/chatserver [INFO] finished tweaking git repo https://github.com/linepi/chatserver [INFO] tweaked toml for git repo https://github.com/linepi/chatserver written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/linepi/chatserver on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/linepi/chatserver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anstyle-query v1.0.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.83 [INFO] [stderr] Downloaded syn v2.0.65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bf00a52e7c7a1e07cb8564109840ebd06d4705645865c324dae2cfbe78ef6d5 [INFO] running `Command { std: "docker" "start" "-a" "4bf00a52e7c7a1e07cb8564109840ebd06d4705645865c324dae2cfbe78ef6d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bf00a52e7c7a1e07cb8564109840ebd06d4705645865c324dae2cfbe78ef6d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bf00a52e7c7a1e07cb8564109840ebd06d4705645865c324dae2cfbe78ef6d5", kill_on_drop: false }` [INFO] [stdout] 4bf00a52e7c7a1e07cb8564109840ebd06d4705645865c324dae2cfbe78ef6d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1bb48fe316f3d742087862d10db85b9f77e572820465537bf696011d3b871fa4 [INFO] running `Command { std: "docker" "start" "-a" "1bb48fe316f3d742087862d10db85b9f77e572820465537bf696011d3b871fa4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Compiling prost-types v0.12.6 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Compiling tonic-build v0.11.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling chatserver v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking tonic v0.11.0 [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/common.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | let datetime_str = datetime.to_rfc2822(); [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 22 | datetime_str [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 21 ~ [INFO] [stdout] 22 ~ datetime.to_rfc2822() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return false; [INFO] [stdout] 31 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return false; [INFO] [stdout] 41 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return false; [INFO] [stdout] 51 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:35:81 [INFO] [stdout] | [INFO] [stdout] 35 | let response_wrapper = state.channel.join(tonic::Request::new(request)).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/clib.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if printlines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!printlines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:61:86 [INFO] [stdout] | [INFO] [stdout] 61 | let response_wrapper = state.channel.heartbeat(tonic::Request::new(request)).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/clib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if printlines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!printlines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:92:64 [INFO] [stdout] | [INFO] [stdout] 92 | state.channel.send(tonic::Request::new(self.sd_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:98:89 [INFO] [stdout] | [INFO] [stdout] 98 | let response_wrapper = state.channel.signup(tonic::Request::new(self.su_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:108:70 [INFO] [stdout] | [INFO] [stdout] 108 | state.channel.createroom(tonic::Request::new(self.cr_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:115:80 [INFO] [stdout] | [INFO] [stdout] 115 | state.channel.exitroom(tonic::Request::new(self.er_req(cur_roomname))).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:124:91 [INFO] [stdout] | [INFO] [stdout] 124 | let response_wrapper = state.channel.getrooms(tonic::Request::new(self.gr_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:141:91 [INFO] [stdout] | [INFO] [stdout] 141 | let response_wrapper = state.channel.getusers(tonic::Request::new(self.gu_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/client/clib.rs:233:30 [INFO] [stdout] | [INFO] [stdout] 233 | history_visible: self.req.history_visible.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.req.history_visible` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none` [INFO] [stdout] --> src/server/slib.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 142 | if user.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = user` [INFO] [stdout] ... [INFO] [stdout] 153 | if user.unwrap().read().unwrap().password != req.password { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/server/slib.rs:317:25 [INFO] [stdout] | [INFO] [stdout] 317 | v.iter().map(|s_ref| s_ref.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/slib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !room.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `room.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/common.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | let datetime_str = datetime.to_rfc2822(); [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 22 | datetime_str [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 21 ~ [INFO] [stdout] 22 ~ datetime.to_rfc2822() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return false; [INFO] [stdout] 31 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return false; [INFO] [stdout] 41 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return false; [INFO] [stdout] 51 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:35:81 [INFO] [stdout] | [INFO] [stdout] 35 | let response_wrapper = state.channel.join(tonic::Request::new(request)).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/clib.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if printlines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!printlines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:61:86 [INFO] [stdout] | [INFO] [stdout] 61 | let response_wrapper = state.channel.heartbeat(tonic::Request::new(request)).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/clib.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if printlines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!printlines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:92:64 [INFO] [stdout] | [INFO] [stdout] 92 | state.channel.send(tonic::Request::new(self.sd_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:98:89 [INFO] [stdout] | [INFO] [stdout] 98 | let response_wrapper = state.channel.signup(tonic::Request::new(self.su_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:108:70 [INFO] [stdout] | [INFO] [stdout] 108 | state.channel.createroom(tonic::Request::new(self.cr_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:115:80 [INFO] [stdout] | [INFO] [stdout] 115 | state.channel.exitroom(tonic::Request::new(self.er_req(cur_roomname))).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:124:91 [INFO] [stdout] | [INFO] [stdout] 124 | let response_wrapper = state.channel.getrooms(tonic::Request::new(self.gr_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/client/clib.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | let mut state = self.state.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/client/clib.rs:141:91 [INFO] [stdout] | [INFO] [stdout] 141 | let response_wrapper = state.channel.getusers(tonic::Request::new(self.gu_req())).await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/client/clib.rs:233:30 [INFO] [stdout] | [INFO] [stdout] 233 | history_visible: self.req.history_visible.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.req.history_visible` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none` [INFO] [stdout] --> src/server/slib.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 142 | if user.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = user` [INFO] [stdout] ... [INFO] [stdout] 153 | if user.unwrap().read().unwrap().password != req.password { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/server/slib.rs:317:25 [INFO] [stdout] | [INFO] [stdout] 317 | v.iter().map(|s_ref| s_ref.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/slib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !room.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `room.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tosd` after checking its variant with `is_ok` [INFO] [stdout] --> src/client/main.rs:141:24 [INFO] [stdout] | [INFO] [stdout] 140 | if tosd.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = &tosd` [INFO] [stdout] 141 | if tosd.as_ref().unwrap() == "exit()" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tosd` after checking its variant with `is_ok` [INFO] [stdout] --> src/client/main.rs:145:48 [INFO] [stdout] | [INFO] [stdout] 140 | if tosd.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = tosd` [INFO] [stdout] ... [INFO] [stdout] 145 | client.req.send_str = Some(tosd.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/main.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if args.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tosd` after checking its variant with `is_ok` [INFO] [stdout] --> src/client/main.rs:141:24 [INFO] [stdout] | [INFO] [stdout] 140 | if tosd.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = &tosd` [INFO] [stdout] 141 | if tosd.as_ref().unwrap() == "exit()" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tosd` after checking its variant with `is_ok` [INFO] [stdout] --> src/client/main.rs:145:48 [INFO] [stdout] | [INFO] [stdout] 140 | if tosd.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = tosd` [INFO] [stdout] ... [INFO] [stdout] 145 | client.req.send_str = Some(tosd.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/client/main.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if args.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.37s [INFO] running `Command { std: "docker" "inspect" "1bb48fe316f3d742087862d10db85b9f77e572820465537bf696011d3b871fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bb48fe316f3d742087862d10db85b9f77e572820465537bf696011d3b871fa4", kill_on_drop: false }` [INFO] [stdout] 1bb48fe316f3d742087862d10db85b9f77e572820465537bf696011d3b871fa4