[INFO] cloning repository https://github.com/lileeei/mcp-git-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lileeei/mcp-git-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flileeei%2Fmcp-git-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flileeei%2Fmcp-git-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce1501a504c8cb3541c6d176109a43ade12ea4fa [INFO] linting lileeei/mcp-git-tools against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flileeei%2Fmcp-git-tools" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lileeei/mcp-git-tools [INFO] finished tweaking git repo https://github.com/lileeei/mcp-git-tools [INFO] tweaked toml for git repo https://github.com/lileeei/mcp-git-tools written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lileeei/mcp-git-tools on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lileeei/mcp-git-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gix-validate v0.11.0 [INFO] [stderr] Downloaded gix-worktree v0.47.0 [INFO] [stderr] Downloaded gix-trace v0.1.17 [INFO] [stderr] Downloaded windows-link v0.1.0 [INFO] [stderr] Downloaded rmcp-macros v0.14.0 [INFO] [stderr] Downloaded gix-path v0.11.0 [INFO] [stderr] Downloaded gix-actor v0.38.0 [INFO] [stderr] Downloaded gix-ignore v0.19.0 [INFO] [stderr] Downloaded gix-lock v21.0.0 [INFO] [stderr] Downloaded gix-glob v0.24.0 [INFO] [stderr] Downloaded gix-shallow v0.8.0 [INFO] [stderr] Downloaded gix-object v0.55.0 [INFO] [stderr] Downloaded gix-packetline v0.21.0 [INFO] [stderr] Downloaded gix-protocol v0.56.0 [INFO] [stderr] Downloaded gix-odb v0.75.0 [INFO] [stderr] Downloaded gix-config v0.51.0 [INFO] [stderr] Downloaded prodash v31.0.0 [INFO] [stderr] Downloaded gix-transport v0.53.0 [INFO] [stderr] Downloaded gix-pack v0.65.0 [INFO] [stderr] Downloaded gix-diff v0.58.0 [INFO] [stderr] Downloaded gix-dir v0.20.0 [INFO] [stderr] Downloaded rmcp v0.14.0 [INFO] [stderr] Downloaded gix-ref v0.58.0 [INFO] [stderr] Downloaded gix-index v0.46.0 [INFO] [stderr] Downloaded gix v0.78.0 [INFO] [stderr] Downloaded gix-discover v0.46.0 [INFO] [stderr] Downloaded gix-filter v0.25.0 [INFO] [stderr] Downloaded gix-status v0.25.0 [INFO] [stderr] Downloaded gix-pathspec v0.15.0 [INFO] [stderr] Downloaded gix-revision v0.40.0 [INFO] [stderr] Downloaded gix-url v0.35.0 [INFO] [stderr] Downloaded gix-fs v0.19.0 [INFO] [stderr] Downloaded gix-commitgraph v0.32.0 [INFO] [stderr] Downloaded gix-error v0.0.0 [INFO] [stderr] Downloaded gix-date v0.13.0 [INFO] [stderr] Downloaded gix-features v0.46.0 [INFO] [stderr] Downloaded gix-hash v0.22.0 [INFO] [stderr] Downloaded gix-config-value v0.17.0 [INFO] [stderr] Downloaded gix-refspec v0.36.0 [INFO] [stderr] Downloaded gix-submodule v0.25.0 [INFO] [stderr] Downloaded gix-attributes v0.30.0 [INFO] [stderr] Downloaded gix-tempfile v21.0.0 [INFO] [stderr] Downloaded gix-chunk v0.5.0 [INFO] [stderr] Downloaded gix-revwalk v0.26.0 [INFO] [stderr] Downloaded gix-traverse v0.52.0 [INFO] [stderr] Downloaded gix-command v0.7.0 [INFO] [stderr] Downloaded gix-sec v0.13.0 [INFO] [stderr] Downloaded gix-hashtable v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8597332c05c9a137d4c8dd863f9dffa4fb55e6c2a631eb384375650a89d26275 [INFO] running `Command { std: "docker" "start" "-a" "8597332c05c9a137d4c8dd863f9dffa4fb55e6c2a631eb384375650a89d26275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8597332c05c9a137d4c8dd863f9dffa4fb55e6c2a631eb384375650a89d26275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8597332c05c9a137d4c8dd863f9dffa4fb55e6c2a631eb384375650a89d26275", kill_on_drop: false }` [INFO] [stdout] 8597332c05c9a137d4c8dd863f9dffa4fb55e6c2a631eb384375650a89d26275 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59251b42869922f8dfe2b26a26c995685ad3a57d057be1085832417767dd43eb [INFO] running `Command { std: "docker" "start" "-a" "59251b42869922f8dfe2b26a26c995685ad3a57d057be1085832417767dd43eb", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Checking gix-trace v0.1.17 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking zlib-rs v0.5.5 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking jiff v0.2.18 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking faster-hex v0.10.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking gix-sec v0.13.0 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling rustversion v1.0.19 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking sha1-checked v0.10.0 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Checking imara-diff v0.1.8 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Checking prodash v31.0.0 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking dyn-clone v1.0.18 [INFO] [stderr] Compiling rmcp v0.14.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking arc-swap v1.8.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking gix-validate v0.11.0 [INFO] [stderr] Checking gix-utils v0.3.1 [INFO] [stderr] Checking gix-error v0.0.0 [INFO] [stderr] Checking gix-chunk v0.5.0 [INFO] [stderr] Checking gix-date v0.13.0 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Compiling schemars_derive v1.2.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking gix-path v0.11.0 [INFO] [stderr] Checking gix-actor v0.38.0 [INFO] [stderr] Checking gix-quote v0.6.1 [INFO] [stderr] Checking gix-bitmap v0.2.15 [INFO] [stderr] Checking gix-packetline v0.21.0 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking gix-features v0.46.0 [INFO] [stderr] Checking gix-config-value v0.17.0 [INFO] [stderr] Checking gix-command v0.7.0 [INFO] [stderr] Checking gix-url v0.35.0 [INFO] [stderr] Checking gix-hash v0.22.0 [INFO] [stderr] Checking gix-fs v0.19.0 [INFO] [stderr] Checking gix-glob v0.24.0 [INFO] [stderr] Checking gix-transport v0.53.0 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking gix-hashtable v0.12.0 [INFO] [stderr] Checking gix-commitgraph v0.32.0 [INFO] [stderr] Checking gix-attributes v0.30.0 [INFO] [stderr] Checking gix-ignore v0.19.0 [INFO] [stderr] Checking gix-tempfile v21.0.0 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking gix-object v0.55.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking gix-lock v21.0.0 [INFO] [stderr] Compiling rmcp-macros v0.14.0 [INFO] [stderr] Checking gix-pathspec v0.15.0 [INFO] [stderr] Checking gix-shallow v0.8.0 [INFO] [stderr] Checking gix-revwalk v0.26.0 [INFO] [stderr] Checking gix-ref v0.58.0 [INFO] [stderr] Checking gix-filter v0.25.0 [INFO] [stderr] Checking gix-pack v0.65.0 [INFO] [stderr] Checking schemars v1.2.0 [INFO] [stderr] Checking gix-traverse v0.52.0 [INFO] [stderr] Checking gix-revision v0.40.0 [INFO] [stderr] Checking gix-index v0.46.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking gix-refspec v0.36.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking gix-odb v0.75.0 [INFO] [stderr] Checking gix-worktree v0.47.0 [INFO] [stderr] Checking gix-discover v0.46.0 [INFO] [stderr] Checking gix-config v0.51.0 [INFO] [stderr] Checking gix-protocol v0.56.0 [INFO] [stderr] Checking gix-diff v0.58.0 [INFO] [stderr] Checking gix-dir v0.20.0 [INFO] [stderr] Checking gix-status v0.25.0 [INFO] [stderr] Checking gix-submodule v0.25.0 [INFO] [stderr] Checking gix v0.78.0 [INFO] [stderr] Checking mcp-git-tools v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | while let Some(info) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for info in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | / if let Some(count) = max_count { [INFO] [stdout] 176 | | if commits.len() >= count as usize { [INFO] [stdout] 177 | | break; [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 175 ~ if let Some(count) = max_count [INFO] [stdout] 176 ~ && commits.len() >= count as usize { [INFO] [stdout] 177 | break; [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | while let Some(info) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for info in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | / if let Some(count) = max_count { [INFO] [stdout] 176 | | if commits.len() >= count as usize { [INFO] [stdout] 177 | | break; [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 175 ~ if let Some(count) = max_count [INFO] [stdout] 176 ~ && commits.len() >= count as usize { [INFO] [stdout] 177 | break; [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> tests/lib_tests.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | let handler2 = GitToolsHandler::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 35 - let handler2 = GitToolsHandler::default(); [INFO] [stdout] 35 + let handler2 = GitToolsHandler; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> tests/lib_tests.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 137 | if !result.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 138 | let error = result.as_ref().unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/lib_tests.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> tests/lib_tests.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 336 | if !result.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 337 | eprintln!("Error: {:?}", result.as_ref().unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/lib_tests.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 336 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.64s [INFO] running `Command { std: "docker" "inspect" "59251b42869922f8dfe2b26a26c995685ad3a57d057be1085832417767dd43eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59251b42869922f8dfe2b26a26c995685ad3a57d057be1085832417767dd43eb", kill_on_drop: false }` [INFO] [stdout] 59251b42869922f8dfe2b26a26c995685ad3a57d057be1085832417767dd43eb