[INFO] cloning repository https://github.com/leoneltrich/my-ip-api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/leoneltrich/my-ip-api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleoneltrich%2Fmy-ip-api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleoneltrich%2Fmy-ip-api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 294e0a63bf324dc3beea6a4af006554b8607cafc [INFO] linting leoneltrich/my-ip-api against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fleoneltrich%2Fmy-ip-api" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/leoneltrich/my-ip-api [INFO] finished tweaking git repo https://github.com/leoneltrich/my-ip-api [INFO] tweaked toml for git repo https://github.com/leoneltrich/my-ip-api written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/leoneltrich/my-ip-api on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/leoneltrich/my-ip-api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quinn-udp v0.5.13 [INFO] [stderr] Downloaded hyper-util v0.1.15 [INFO] [stderr] Downloaded reqwest v0.12.22 [INFO] [stderr] Downloaded quinn v0.11.8 [INFO] [stderr] Downloaded webpki-roots v1.0.1 [INFO] [stderr] Downloaded quinn-proto v0.11.12 [INFO] [stderr] Downloaded rustls v0.23.29 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7542b57704bb55b0d965cf8472497bed5e119791e24d4c72e4318c291a78e740 [INFO] running `Command { std: "docker" "start" "-a" "7542b57704bb55b0d965cf8472497bed5e119791e24d4c72e4318c291a78e740", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7542b57704bb55b0d965cf8472497bed5e119791e24d4c72e4318c291a78e740", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7542b57704bb55b0d965cf8472497bed5e119791e24d4c72e4318c291a78e740", kill_on_drop: false }` [INFO] [stdout] 7542b57704bb55b0d965cf8472497bed5e119791e24d4c72e4318c291a78e740 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19b787f528ac2898af5de98ee9a6c8675c8873798d5ba282c74557afdee0c4c0 [INFO] running `Command { std: "docker" "start" "-a" "19b787f528ac2898af5de98ee9a6c8675c8873798d5ba282c74557afdee0c4c0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling rustls v0.23.29 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking webpki-roots v1.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking hyper-util v0.1.15 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking axum v0.8.4 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking ip_lookup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/services/auth_service.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !Argon2::default().verify_password(token.as_bytes(), &parsed_hash).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Argon2::default().verify_password(token.as_bytes(), &parsed_hash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/services/auth_service.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / if let Some(token) = auth_header.strip_prefix("Bearer ") { [INFO] [stdout] 52 | | Some(token.to_string()) [INFO] [stdout] 53 | | } else { [INFO] [stdout] 54 | | None [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ help: try: `auth_header.strip_prefix("Bearer ").map(|token| token.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/services/ip_service.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 37 | / let ipv6 = match ipv6_result { [INFO] [stdout] 38 | | Ok(res) => { [INFO] [stdout] 39 | | match res.text().await { [INFO] [stdout] 40 | | Ok(text) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | Err(_) => None, [INFO] [stdout] 55 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 56 | ipv6 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ match ipv6_result { [INFO] [stdout] 39 + Ok(res) => { [INFO] [stdout] 40 + match res.text().await { [INFO] [stdout] 41 + Ok(text) => { [INFO] [stdout] 42 + if let Ok(addr) = text.parse::() { [INFO] [stdout] 43 + if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] 44 + Some(ipv6_addr.to_string()) [INFO] [stdout] 45 + } else { [INFO] [stdout] 46 + None [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } else { [INFO] [stdout] 49 + None [INFO] [stdout] 50 + } [INFO] [stdout] 51 + }, [INFO] [stdout] 52 + Err(_) => None, [INFO] [stdout] 53 + } [INFO] [stdout] 54 + }, [INFO] [stdout] 55 + Err(_) => None, [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/services/ip_service.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] 43 | | Some(ipv6_addr.to_string()) [INFO] [stdout] 44 | | } else { [INFO] [stdout] 45 | | None [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/services/ip_service.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | if let Ok(addr) = text.parse::() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 42 | if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/services/ip_service.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 61 | / let ipv4 = match ipv4_result { [INFO] [stdout] 62 | | Ok(res) => { [INFO] [stdout] 63 | | match res.text().await { [INFO] [stdout] 64 | | Ok(text) => { [INFO] [stdout] ... | [INFO] [stdout] 78 | | Err(_) => None, [INFO] [stdout] 79 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 80 | ipv4 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 61 ~ [INFO] [stdout] 62 ~ match ipv4_result { [INFO] [stdout] 63 + Ok(res) => { [INFO] [stdout] 64 + match res.text().await { [INFO] [stdout] 65 + Ok(text) => { [INFO] [stdout] 66 + if let Ok(addr) = text.parse::() { [INFO] [stdout] 67 + if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] 68 + Some(ipv4_addr.to_string()) [INFO] [stdout] 69 + } else { [INFO] [stdout] 70 + None [INFO] [stdout] 71 + } [INFO] [stdout] 72 + } else { [INFO] [stdout] 73 + None [INFO] [stdout] 74 + } [INFO] [stdout] 75 + }, [INFO] [stdout] 76 + Err(_) => None, [INFO] [stdout] 77 + } [INFO] [stdout] 78 + }, [INFO] [stdout] 79 + Err(_) => None, [INFO] [stdout] 80 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/services/ip_service.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | / if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] 67 | | Some(ipv4_addr.to_string()) [INFO] [stdout] 68 | | } else { [INFO] [stdout] 69 | | None [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/services/ip_service.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | if let Ok(addr) = text.parse::() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 66 | if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/services/auth_service.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !Argon2::default().verify_password(token.as_bytes(), &parsed_hash).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Argon2::default().verify_password(token.as_bytes(), &parsed_hash).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/services/auth_service.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / if let Some(token) = auth_header.strip_prefix("Bearer ") { [INFO] [stdout] 52 | | Some(token.to_string()) [INFO] [stdout] 53 | | } else { [INFO] [stdout] 54 | | None [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ help: try: `auth_header.strip_prefix("Bearer ").map(|token| token.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/services/ip_service.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 37 | / let ipv6 = match ipv6_result { [INFO] [stdout] 38 | | Ok(res) => { [INFO] [stdout] 39 | | match res.text().await { [INFO] [stdout] 40 | | Ok(text) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | Err(_) => None, [INFO] [stdout] 55 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 56 | ipv6 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ match ipv6_result { [INFO] [stdout] 39 + Ok(res) => { [INFO] [stdout] 40 + match res.text().await { [INFO] [stdout] 41 + Ok(text) => { [INFO] [stdout] 42 + if let Ok(addr) = text.parse::() { [INFO] [stdout] 43 + if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] 44 + Some(ipv6_addr.to_string()) [INFO] [stdout] 45 + } else { [INFO] [stdout] 46 + None [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } else { [INFO] [stdout] 49 + None [INFO] [stdout] 50 + } [INFO] [stdout] 51 + }, [INFO] [stdout] 52 + Err(_) => None, [INFO] [stdout] 53 + } [INFO] [stdout] 54 + }, [INFO] [stdout] 55 + Err(_) => None, [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/services/ip_service.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] 43 | | Some(ipv6_addr.to_string()) [INFO] [stdout] 44 | | } else { [INFO] [stdout] 45 | | None [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/services/ip_service.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | if let Ok(addr) = text.parse::() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 42 | if let IpAddr::V6(ipv6_addr) = addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/services/ip_service.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 61 | / let ipv4 = match ipv4_result { [INFO] [stdout] 62 | | Ok(res) => { [INFO] [stdout] 63 | | match res.text().await { [INFO] [stdout] 64 | | Ok(text) => { [INFO] [stdout] ... | [INFO] [stdout] 78 | | Err(_) => None, [INFO] [stdout] 79 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 80 | ipv4 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 61 ~ [INFO] [stdout] 62 ~ match ipv4_result { [INFO] [stdout] 63 + Ok(res) => { [INFO] [stdout] 64 + match res.text().await { [INFO] [stdout] 65 + Ok(text) => { [INFO] [stdout] 66 + if let Ok(addr) = text.parse::() { [INFO] [stdout] 67 + if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] 68 + Some(ipv4_addr.to_string()) [INFO] [stdout] 69 + } else { [INFO] [stdout] 70 + None [INFO] [stdout] 71 + } [INFO] [stdout] 72 + } else { [INFO] [stdout] 73 + None [INFO] [stdout] 74 + } [INFO] [stdout] 75 + }, [INFO] [stdout] 76 + Err(_) => None, [INFO] [stdout] 77 + } [INFO] [stdout] 78 + }, [INFO] [stdout] 79 + Err(_) => None, [INFO] [stdout] 80 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/services/ip_service.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | / if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] 67 | | Some(ipv4_addr.to_string()) [INFO] [stdout] 68 | | } else { [INFO] [stdout] 69 | | None [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/services/ip_service.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | if let Ok(addr) = text.parse::() { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 66 | if let IpAddr::V4(ipv4_addr) = addr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.02s [INFO] running `Command { std: "docker" "inspect" "19b787f528ac2898af5de98ee9a6c8675c8873798d5ba282c74557afdee0c4c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19b787f528ac2898af5de98ee9a6c8675c8873798d5ba282c74557afdee0c4c0", kill_on_drop: false }` [INFO] [stdout] 19b787f528ac2898af5de98ee9a6c8675c8873798d5ba282c74557afdee0c4c0