[INFO] cloning repository https://github.com/lelandbatey/rust_buddhabrot
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lelandbatey/rust_buddhabrot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flelandbatey%2Frust_buddhabrot", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flelandbatey%2Frust_buddhabrot'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 696932f66bcb34a17286adde7f4227b8e31e333e
[INFO] linting lelandbatey/rust_buddhabrot against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flelandbatey%2Frust_buddhabrot" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/lelandbatey/rust_buddhabrot
[INFO] finished tweaking git repo https://github.com/lelandbatey/rust_buddhabrot
[INFO] tweaked toml for git repo https://github.com/lelandbatey/rust_buddhabrot written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/lelandbatey/rust_buddhabrot on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/lelandbatey/rust_buddhabrot already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: /workspace/builds/worker-7-tc1/source/trajectory-gen/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: /workspace/builds/worker-7-tc1/source/trajectory-render/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: /workspace/builds/worker-7-tc1/source/buddhabrot/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] Downloading crates ...
[INFO] [stderr] Downloaded ucd-util v0.1.10
[INFO] [stderr] Downloaded serde_derive v1.0.209
[INFO] [stderr] Downloaded avif-serialize v0.8.1
[INFO] [stderr] Downloaded aligned-vec v0.5.0
[INFO] [stderr] Downloaded av1-grain v0.2.3
[INFO] [stderr] Downloaded image-webp v0.1.3
[INFO] [stderr] Downloaded imgref v1.10.1
[INFO] [stderr] Downloaded serde v1.0.209
[INFO] [stderr] Downloaded serde_json v1.0.127
[INFO] [stderr] Downloaded libfuzzer-sys v0.4.7
[INFO] [stderr] Downloaded bytemuck v1.17.1
[INFO] [stderr] Downloaded zune-jpeg v0.4.13
[INFO] [stderr] Downloaded bitstream-io v2.5.3
[INFO] [stderr] Downloaded built v0.7.4
[INFO] [stderr] Downloaded image v0.25.2
[INFO] [stderr] Downloaded rgb v0.8.48
[INFO] [stderr] Downloaded profiling-procmacros v1.0.15
[INFO] [stderr] Downloaded v_frame v0.3.8
[INFO] [stderr] Downloaded ravif v0.11.10
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5b079f90989b80780701713dfc83ebd43f984161b0fde00a9459618e99077382
[INFO] running `Command { std: "docker" "start" "-a" "5b079f90989b80780701713dfc83ebd43f984161b0fde00a9459618e99077382", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5b079f90989b80780701713dfc83ebd43f984161b0fde00a9459618e99077382", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5b079f90989b80780701713dfc83ebd43f984161b0fde00a9459618e99077382", kill_on_drop: false }`
[INFO] [stdout] 5b079f90989b80780701713dfc83ebd43f984161b0fde00a9459618e99077382
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f49c180d118395cd73d855998f18ba47a67fc5c5b2c3d258f03f6fd5d2b4ff2b
[INFO] running `Command { std: "docker" "start" "-a" "f49c180d118395cd73d855998f18ba47a67fc5c5b2c3d258f03f6fd5d2b4ff2b", kill_on_drop: false }`
[INFO] [stderr] warning: /opt/rustwide/workdir/buddhabrot/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: /opt/rustwide/workdir/trajectory-render/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: /opt/rustwide/workdir/trajectory-gen/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] Compiling num-traits v0.2.19
[INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93
[INFO] [stderr] Compiling crossbeam-utils v0.8.20
[INFO] [stderr] Compiling log v0.4.22
[INFO] [stderr] Compiling bumpalo v3.16.0
[INFO] [stderr] Compiling anyhow v1.0.86
[INFO] [stderr] Checking simd-adler32 v0.3.7
[INFO] [stderr] Compiling built v0.7.4
[INFO] [stderr] Compiling rayon-core v1.12.1
[INFO] [stderr] Checking either v1.13.0
[INFO] [stderr] Checking aligned-vec v0.5.0
[INFO] [stderr] Compiling wasm-bindgen v0.2.93
[INFO] [stderr] Checking nom v7.1.3
[INFO] [stderr] Compiling syn v2.0.76
[INFO] [stderr] Checking bytemuck v1.17.1
[INFO] [stderr] Compiling simd_helpers v0.1.0
[INFO] [stderr] Checking miniz_oxide v0.7.4
[INFO] [stderr] Checking spin v0.9.8
[INFO] [stderr] Checking maybe-rayon v0.1.1
[INFO] [stderr] Compiling serde v1.0.209
[INFO] [stderr] Checking bitstream-io v2.5.3
[INFO] [stderr] Checking weezl v0.1.8
[INFO] [stderr] Checking quick-error v2.0.1
[INFO] [stderr] Compiling noop_proc_macro v0.3.0
[INFO] [stderr] Checking imgref v1.10.1
[INFO] [stderr] Checking flume v0.11.0
[INFO] [stderr] Checking itertools v0.12.1
[INFO] [stderr] Checking rgb v0.8.48
[INFO] [stderr] Checking fdeflate v0.3.4
[INFO] [stderr] Checking loop9 v0.1.5
[INFO] [stderr] Checking zune-inflate v0.2.54
[INFO] [stderr] Checking avif-serialize v0.8.1
[INFO] [stderr] Checking half v2.4.1
[INFO] [stderr] Checking ucd-util v0.1.10
[INFO] [stderr] Compiling serde_json v1.0.127
[INFO] [stderr] Compiling rav1e v0.7.1
[INFO] [stderr] Checking zune-core v0.4.12
[INFO] [stderr] Checking byteorder-lite v0.1.0
[INFO] [stderr] Checking lebe v0.5.2
[INFO] [stderr] Compiling regex v0.2.11
[INFO] [stderr] Checking crossbeam-epoch v0.9.18
[INFO] [stderr] Checking jpeg-decoder v0.3.1
[INFO] [stderr] Checking color_quant v1.1.0
[INFO] [stderr] Checking png v0.17.13
[INFO] [stderr] Checking image-webp v0.1.3
[INFO] [stderr] Checking regex-syntax v0.5.6
[INFO] [stderr] Checking crossbeam-deque v0.8.5
[INFO] [stderr] Checking qoi v0.4.1
[INFO] [stderr] Checking gif v0.13.1
[INFO] [stderr] Checking thread_local v0.3.6
[INFO] [stderr] Checking rand v0.4.6
[INFO] [stderr] Checking aho-corasick v0.6.10
[INFO] [stderr] Checking zune-jpeg v0.4.13
[INFO] [stderr] Checking time v0.3.36
[INFO] [stderr] Checking argparse v0.2.2
[INFO] [stderr] Checking crossbeam-utils v0.6.6
[INFO] [stderr] Checking num-integer v0.1.46
[INFO] [stderr] Checking v_frame v0.3.8
[INFO] [stderr] Checking tiff v0.9.1
[INFO] [stderr] Checking num-complex v0.4.6
[INFO] [stderr] Checking crossbeam-channel v0.3.9
[INFO] [stderr] Checking exr v1.72.0
[INFO] [stderr] Checking rayon v1.10.0
[INFO] [stderr] Checking num-bigint v0.4.6
[INFO] [stderr] Checking num-iter v0.1.45
[INFO] [stderr] Checking rand v0.3.23
[INFO] [stderr] Checking num-rational v0.4.2
[INFO] [stderr] Checking av1-grain v0.2.3
[INFO] [stderr] Checking num v0.4.3
[INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93
[INFO] [stderr] Compiling profiling-procmacros v1.0.15
[INFO] [stderr] Compiling thiserror-impl v1.0.63
[INFO] [stderr] Compiling num-derive v0.4.2
[INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4
[INFO] [stderr] Compiling serde_derive v1.0.209
[INFO] [stderr] Checking profiling v1.0.15
[INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93
[INFO] [stderr] Checking thiserror v1.0.63
[INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93
[INFO] [stderr] Checking ravif v0.11.10
[INFO] [stderr] Checking image v0.25.2
[INFO] [stderr] Checking buddhabrot v0.1.0 (/opt/rustwide/workdir/buddhabrot)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:26
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^ help: replace it with: `re`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:34
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^ help: replace it with: `im`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:28
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 256 - Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] 256 + Box::new(|val, mx| fexp(val as f64, 0.001) / fexp(mx as f64, 0.001) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:28
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 260 - Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] 260 + Box::new(|val, mx| fexp(val as f64, 0.005) / fexp(mx as f64, 0.005) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:28
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 264 - Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] 264 + Box::new(|val, mx| fexp(val as f64, 0.010) / fexp(mx as f64, 0.010) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:28
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 268 - Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] 268 + Box::new(|val, mx| fexp(val as f64, 0.050) / fexp(mx as f64, 0.050) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:28
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 272 - Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] 272 + Box::new(|val, mx| fexp(val as f64, 0.100) / fexp(mx as f64, 0.100) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:26
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^ help: replace it with: `re`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:34
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^ help: replace it with: `im`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:28
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 256 - Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] 256 + Box::new(|val, mx| fexp(val as f64, 0.001) / fexp(mx as f64, 0.001) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:28
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 260 - Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] 260 + Box::new(|val, mx| fexp(val as f64, 0.005) / fexp(mx as f64, 0.005) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:28
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 264 - Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] 264 + Box::new(|val, mx| fexp(val as f64, 0.010) / fexp(mx as f64, 0.010) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:28
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 268 - Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] 268 + Box::new(|val, mx| fexp(val as f64, 0.050) / fexp(mx as f64, 0.050) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unnecessary parentheses around closure body
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:28
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^ ^
[INFO] [stdout] |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout] |
[INFO] [stdout] 272 - Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] 272 + Box::new(|val, mx| fexp(val as f64, 0.100) / fexp(mx as f64, 0.100) ),
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:9
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 61 - return Complex { re: re, im: im };
[INFO] [stdout] 61 + Complex { re: re, im: im }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:148:5
[INFO] [stdout] |
[INFO] [stdout] 148 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 148 - return false;
[INFO] [stdout] 148 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:330:5
[INFO] [stdout] |
[INFO] [stdout] 330 | return imgs;
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 330 - return imgs;
[INFO] [stdout] 330 + imgs
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:61:9
[INFO] [stdout] |
[INFO] [stdout] 61 | return Complex { re: re, im: im };
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 61 - return Complex { re: re, im: im };
[INFO] [stdout] 61 + Complex { re: re, im: im }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:155:34
[INFO] [stdout] |
[INFO] [stdout] 155 | c.centerx - (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:156:34
[INFO] [stdout] |
[INFO] [stdout] 156 | c.centerx + (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:159:34
[INFO] [stdout] |
[INFO] [stdout] 159 | c.centery - (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:160:34
[INFO] [stdout] |
[INFO] [stdout] 160 | c.centery + (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> buddhabrot/src/buddha.rs:242:24
[INFO] [stdout] |
[INFO] [stdout] 242 | if !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(trajectory.length >= tconf.min_iterations)`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `clone` on type `Complex` which implements the `Copy` trait
[INFO] [stdout] --> buddhabrot/src/buddha.rs:223:36
[INFO] [stdout] |
[INFO] [stdout] 223 | ... point: z.clone(),
[INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `z`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/buddha.rs:241:17
[INFO] [stdout] |
[INFO] [stdout] 241 | / if escaped {
[INFO] [stdout] 242 | | if !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] 243 | | match child_tx.send(trajectory) {
[INFO] [stdout] 244 | | Ok(_) => (),
[INFO] [stdout] ... |
[INFO] [stdout] 249 | | }
[INFO] [stdout] | |_________________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 241 ~ if escaped
[INFO] [stdout] 242 ~ && !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] 243 | match child_tx.send(trajectory) {
[INFO] [stdout] ...
[INFO] [stdout] 247 | valid_traj += 1;
[INFO] [stdout] 248 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:148:5
[INFO] [stdout] |
[INFO] [stdout] 148 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 148 - return false;
[INFO] [stdout] 148 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout] --> buddhabrot/src/buddha.rs:265:38
[INFO] [stdout] |
[INFO] [stdout] 265 | let mut json_file = File::create(&std::path::Path::new(c.json_file.as_str())).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::path::Path::new(c.json_file.as_str())`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/buddha.rs:288:17
[INFO] [stdout] |
[INFO] [stdout] 288 | / write!(
[INFO] [stdout] 289 | | json_file,
[INFO] [stdout] 290 | | "{}\n",
[INFO] [stdout] 291 | | serde_json::to_string(&trajectory).unwrap()
[INFO] [stdout] 292 | | ).unwrap();
[INFO] [stdout] | |_________________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 288 ~ writeln!(
[INFO] [stdout] 289 | json_file,
[INFO] [stdout] 290 ~ "{}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/buddha.rs:330:5
[INFO] [stdout] |
[INFO] [stdout] 330 | return imgs;
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 330 - return imgs;
[INFO] [stdout] 330 + imgs
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:155:34
[INFO] [stdout] |
[INFO] [stdout] 155 | c.centerx - (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:156:34
[INFO] [stdout] |
[INFO] [stdout] 156 | c.centerx + (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:159:34
[INFO] [stdout] |
[INFO] [stdout] 159 | c.centery - (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting float literal to `f64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/buddha.rs:160:34
[INFO] [stdout] |
[INFO] [stdout] 160 | c.centery + (startzoom / (2.0 as f64).powf(c.zoomlevel)),
[INFO] [stdout] | ^^^^^^^^^^^^ help: try: `2.0_f64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> buddhabrot/src/buddha.rs:242:24
[INFO] [stdout] |
[INFO] [stdout] 242 | if !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(trajectory.length >= tconf.min_iterations)`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/buddha.rs:326:9
[INFO] [stdout] |
[INFO] [stdout] 326 | write!(logfile, "{} {}\n", key, val).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 326 - write!(logfile, "{} {}\n", key, val).unwrap();
[INFO] [stdout] 326 + writeln!(logfile, "{} {}", key, val).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/ppm.rs:46:9
[INFO] [stdout] |
[INFO] [stdout] 46 | / if x < self.width && x >= 0 {
[INFO] [stdout] 47 | | if y < self.height && y >= 0 {
[INFO] [stdout] 48 | | if val > self.maximum {
[INFO] [stdout] 49 | | self.maximum = val
[INFO] [stdout] ... |
[INFO] [stdout] 56 | | }
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 46 ~ if x < self.width && x >= 0
[INFO] [stdout] 47 ~ && y < self.height && y >= 0 {
[INFO] [stdout] 48 | if val > self.maximum {
[INFO] [stdout] ...
[INFO] [stdout] 54 | self.pixels[((self.height * y) + x) as usize] = val
[INFO] [stdout] 55 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/ppm.rs:59:9
[INFO] [stdout] |
[INFO] [stdout] 59 | / if x < self.width && x >= 0 {
[INFO] [stdout] 60 | | if y < self.height && y >= 0 {
[INFO] [stdout] 61 | | let mut px = self.pixels[((self.height * y) + x) as usize];
[INFO] [stdout] 62 | | px = px + 1;
[INFO] [stdout] ... |
[INFO] [stdout] 71 | | }
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 59 ~ if x < self.width && x >= 0
[INFO] [stdout] 60 ~ && y < self.height && y >= 0 {
[INFO] [stdout] 61 | let mut px = self.pixels[((self.height * y) + x) as usize];
[INFO] [stdout] ...
[INFO] [stdout] 69 | self.pixels[((self.height * y) + x) as usize] = px;
[INFO] [stdout] 70 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout] --> buddhabrot/src/ppm.rs:62:17
[INFO] [stdout] |
[INFO] [stdout] 62 | px = px + 1;
[INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `px += 1`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:80:47
[INFO] [stdout] |
[INFO] [stdout] 80 | let val = self.pixels[((self.height * y as i64) + x as i64) as usize] as f64;
[INFO] [stdout] | ^^^^^^^^ help: try: `y`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:80:59
[INFO] [stdout] |
[INFO] [stdout] 80 | let val = self.pixels[((self.height * y as i64) + x as i64) as usize] as f64;
[INFO] [stdout] | ^^^^^^^^ help: try: `x`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:85:18
[INFO] [stdout] |
[INFO] [stdout] 85 | fexp(val as f64, 0.001) / fexp(mx as f64, 0.001)
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:85:44
[INFO] [stdout] |
[INFO] [stdout] 85 | fexp(val as f64, 0.001) / fexp(mx as f64, 0.001)
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:91:24
[INFO] [stdout] |
[INFO] [stdout] 91 | pub fn write_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 91 - pub fn write_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] 91 + pub fn write_ppm(imgs: &[Img], fname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:95:5
[INFO] [stdout] |
[INFO] [stdout] 95 | write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 95 - write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] 95 + writeln!(ppm, "{} {}", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:96:5
[INFO] [stdout] |
[INFO] [stdout] 96 | / write!(
[INFO] [stdout] 97 | | ppm,
[INFO] [stdout] 98 | | "{}\n",
[INFO] [stdout] 99 | | max(imgs[0].maximum, max(imgs[1].maximum, imgs[2].maximum))
[INFO] [stdout] 100 | | )
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 96 ~ writeln!(
[INFO] [stdout] 97 | ppm,
[INFO] [stdout] 98 ~ "{}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:103:9
[INFO] [stdout] |
[INFO] [stdout] 103 | / write!(
[INFO] [stdout] 104 | | ppm,
[INFO] [stdout] 105 | | "{} {} {}\n",
[INFO] [stdout] 106 | | imgs[0].pixels[pidx], imgs[1].pixels[pidx], imgs[2].pixels[pidx]
[INFO] [stdout] 107 | | )
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 103 ~ writeln!(
[INFO] [stdout] 104 | ppm,
[INFO] [stdout] 105 ~ "{} {} {}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:114:31
[INFO] [stdout] |
[INFO] [stdout] 114 | pub fn write_scaled_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 114 - pub fn write_scaled_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] 114 + pub fn write_scaled_ppm(imgs: &[Img], fname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:121:13
[INFO] [stdout] |
[INFO] [stdout] 121 | return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 121 - return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] 121 + (mx / 255 + 1 as i64) as u8
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:123:13
[INFO] [stdout] |
[INFO] [stdout] 123 | return scaled_val;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 123 - return scaled_val;
[INFO] [stdout] 123 + scaled_val
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `clone` on type `Complex` which implements the `Copy` trait
[INFO] [stdout] --> buddhabrot/src/buddha.rs:223:36
[INFO] [stdout] |
[INFO] [stdout] 223 | ... point: z.clone(),
[INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `z`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting integer literal to `i64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/ppm.rs:121:32
[INFO] [stdout] |
[INFO] [stdout] 121 | return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] | ^^^^^^^^ help: try: `1_i64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:129:5
[INFO] [stdout] |
[INFO] [stdout] 129 | write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 129 - write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] 129 + writeln!(ppm, "{} {}", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:130:5
[INFO] [stdout] |
[INFO] [stdout] 130 | write!(ppm, "{}\n", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 130 - write!(ppm, "{}\n", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] 130 + writeln!(ppm, "{}", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/buddha.rs:241:17
[INFO] [stdout] |
[INFO] [stdout] 241 | / if escaped {
[INFO] [stdout] 242 | | if !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] 243 | | match child_tx.send(trajectory) {
[INFO] [stdout] 244 | | Ok(_) => (),
[INFO] [stdout] ... |
[INFO] [stdout] 249 | | }
[INFO] [stdout] | |_________________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 241 ~ if escaped
[INFO] [stdout] 242 ~ && !(trajectory.length < tconf.min_iterations) {
[INFO] [stdout] 243 | match child_tx.send(trajectory) {
[INFO] [stdout] ...
[INFO] [stdout] 247 | valid_traj += 1;
[INFO] [stdout] 248 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:132:9
[INFO] [stdout] |
[INFO] [stdout] 132 | / write!(
[INFO] [stdout] 133 | | ppm,
[INFO] [stdout] 134 | | "{} {} {}\n",
[INFO] [stdout] 135 | | scale_fn(imgs[0].pixels[pidx], max_brightness),
[INFO] [stdout] 136 | | scale_fn(imgs[1].pixels[pidx], max_brightness),
[INFO] [stdout] 137 | | scale_fn(imgs[2].pixels[pidx], max_brightness),
[INFO] [stdout] 138 | | )
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 132 ~ writeln!(
[INFO] [stdout] 133 | ppm,
[INFO] [stdout] 134 ~ "{} {} {}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:143:34
[INFO] [stdout] |
[INFO] [stdout] 143 | pub fn write_scaled_png(imgs: &Vec
, fname: String, scale_func: F)
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 143 - pub fn write_scaled_png(imgs: &Vec
, fname: String, scale_func: F)
[INFO] [stdout] 143 + pub fn write_scaled_png(imgs: &[Img], fname: String, scale_func: F)
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout] --> buddhabrot/src/buddha.rs:265:38
[INFO] [stdout] |
[INFO] [stdout] 265 | let mut json_file = File::create(&std::path::Path::new(c.json_file.as_str())).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::path::Path::new(c.json_file.as_str())`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:244:5
[INFO] [stdout] |
[INFO] [stdout] 244 | return imgs;
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 244 - return imgs;
[INFO] [stdout] 244 + imgs
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/buddha.rs:288:17
[INFO] [stdout] |
[INFO] [stdout] 288 | / write!(
[INFO] [stdout] 289 | | json_file,
[INFO] [stdout] 290 | | "{}\n",
[INFO] [stdout] 291 | | serde_json::to_string(&trajectory).unwrap()
[INFO] [stdout] 292 | | ).unwrap();
[INFO] [stdout] | |_________________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 288 ~ writeln!(
[INFO] [stdout] 289 | json_file,
[INFO] [stdout] 290 ~ "{}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: all variants have the same prefix: `Await`
[INFO] [stdout] --> buddhabrot/src/ppm.rs:174:5
[INFO] [stdout] |
[INFO] [stdout] 174 | / enum State {
[INFO] [stdout] 175 | | AwaitMagicNum,
[INFO] [stdout] 176 | | AwaitWidth,
[INFO] [stdout] 177 | | AwaitHeight,
[INFO] [stdout] ... |
[INFO] [stdout] 181 | | AwaitBlue,
[INFO] [stdout] 182 | | }
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout] --> buddhabrot/src/ppm.rs:192:12
[INFO] [stdout] |
[INFO] [stdout] 192 | if line == "" {
[INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout] --> buddhabrot/src/ppm.rs:197:16
[INFO] [stdout] |
[INFO] [stdout] 197 | if token == "" {
[INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `token.is_empty()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/buddha.rs:326:9
[INFO] [stdout] |
[INFO] [stdout] 326 | write!(logfile, "{} {}\n", key, val).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 326 - write!(logfile, "{} {}\n", key, val).unwrap();
[INFO] [stdout] 326 + writeln!(logfile, "{} {}", key, val).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:250:26
[INFO] [stdout] |
[INFO] [stdout] 250 | pub fn rescale_ppm(imgs: &Vec
, ppmname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 250 - pub fn rescale_ppm(imgs: &Vec
, ppmname: String) {
[INFO] [stdout] 250 + pub fn rescale_ppm(imgs: &[Img], ppmname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout] --> buddhabrot/src/ppm.rs:253:28
[INFO] [stdout] |
[INFO] [stdout] 253 | let mut scaling_funcs: Vec<(&str, Box f64>)> = Vec::new();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:34
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:60
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:34
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:60
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:34
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:60
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:34
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:60
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:34
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:60
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:276:32
[INFO] [stdout] |
[INFO] [stdout] 276 | Box::new(|val, mx| log(val as f64, 1.0) / log(mx as f64, 1.0)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:276:55
[INFO] [stdout] |
[INFO] [stdout] 276 | Box::new(|val, mx| log(val as f64, 1.0) / log(mx as f64, 1.0)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:280:32
[INFO] [stdout] |
[INFO] [stdout] 280 | Box::new(|val, mx| log(val as f64, 0.5) / log(mx as f64, 0.5)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:280:55
[INFO] [stdout] |
[INFO] [stdout] 280 | Box::new(|val, mx| log(val as f64, 0.5) / log(mx as f64, 0.5)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:284:32
[INFO] [stdout] |
[INFO] [stdout] 284 | Box::new(|val, mx| log(val as f64, 0.1) / log(mx as f64, 0.1)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:284:55
[INFO] [stdout] |
[INFO] [stdout] 284 | Box::new(|val, mx| log(val as f64, 0.1) / log(mx as f64, 0.1)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:288:32
[INFO] [stdout] |
[INFO] [stdout] 288 | Box::new(|val, mx| log(val as f64, 0.01) / log(mx as f64, 0.01)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/ppm.rs:46:9
[INFO] [stdout] |
[INFO] [stdout] 46 | / if x < self.width && x >= 0 {
[INFO] [stdout] 47 | | if y < self.height && y >= 0 {
[INFO] [stdout] 48 | | if val > self.maximum {
[INFO] [stdout] 49 | | self.maximum = val
[INFO] [stdout] ... |
[INFO] [stdout] 56 | | }
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 46 ~ if x < self.width && x >= 0
[INFO] [stdout] 47 ~ && y < self.height && y >= 0 {
[INFO] [stdout] 48 | if val > self.maximum {
[INFO] [stdout] ...
[INFO] [stdout] 54 | self.pixels[((self.height * y) + x) as usize] = val
[INFO] [stdout] 55 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:288:56
[INFO] [stdout] |
[INFO] [stdout] 288 | Box::new(|val, mx| log(val as f64, 0.01) / log(mx as f64, 0.01)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:296:13
[INFO] [stdout] |
[INFO] [stdout] 296 | return 0.0;
[INFO] [stdout] | ^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 296 - return 0.0;
[INFO] [stdout] 296 + 0.0
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout] --> buddhabrot/src/ppm.rs:59:9
[INFO] [stdout] |
[INFO] [stdout] 59 | / if x < self.width && x >= 0 {
[INFO] [stdout] 60 | | if y < self.height && y >= 0 {
[INFO] [stdout] 61 | | let mut px = self.pixels[((self.height * y) + x) as usize];
[INFO] [stdout] 62 | | px = px + 1;
[INFO] [stdout] ... |
[INFO] [stdout] 71 | | }
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout] |
[INFO] [stdout] 59 ~ if x < self.width && x >= 0
[INFO] [stdout] 60 ~ && y < self.height && y >= 0 {
[INFO] [stdout] 61 | let mut px = self.pixels[((self.height * y) + x) as usize];
[INFO] [stdout] ...
[INFO] [stdout] 69 | self.pixels[((self.height * y) + x) as usize] = px;
[INFO] [stdout] 70 ~ }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout] --> buddhabrot/src/ppm.rs:62:17
[INFO] [stdout] |
[INFO] [stdout] 62 | px = px + 1;
[INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `px += 1`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:80:47
[INFO] [stdout] |
[INFO] [stdout] 80 | let val = self.pixels[((self.height * y as i64) + x as i64) as usize] as f64;
[INFO] [stdout] | ^^^^^^^^ help: try: `y`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:80:59
[INFO] [stdout] |
[INFO] [stdout] 80 | let val = self.pixels[((self.height * y as i64) + x as i64) as usize] as f64;
[INFO] [stdout] | ^^^^^^^^ help: try: `x`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:85:18
[INFO] [stdout] |
[INFO] [stdout] 85 | fexp(val as f64, 0.001) / fexp(mx as f64, 0.001)
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:85:44
[INFO] [stdout] |
[INFO] [stdout] 85 | fexp(val as f64, 0.001) / fexp(mx as f64, 0.001)
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:91:24
[INFO] [stdout] |
[INFO] [stdout] 91 | pub fn write_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 91 - pub fn write_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] 91 + pub fn write_ppm(imgs: &[Img], fname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:95:5
[INFO] [stdout] |
[INFO] [stdout] 95 | write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 95 - write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] 95 + writeln!(ppm, "{} {}", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:96:5
[INFO] [stdout] |
[INFO] [stdout] 96 | / write!(
[INFO] [stdout] 97 | | ppm,
[INFO] [stdout] 98 | | "{}\n",
[INFO] [stdout] 99 | | max(imgs[0].maximum, max(imgs[1].maximum, imgs[2].maximum))
[INFO] [stdout] 100 | | )
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 96 ~ writeln!(
[INFO] [stdout] 97 | ppm,
[INFO] [stdout] 98 ~ "{}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:103:9
[INFO] [stdout] |
[INFO] [stdout] 103 | / write!(
[INFO] [stdout] 104 | | ppm,
[INFO] [stdout] 105 | | "{} {} {}\n",
[INFO] [stdout] 106 | | imgs[0].pixels[pidx], imgs[1].pixels[pidx], imgs[2].pixels[pidx]
[INFO] [stdout] 107 | | )
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 103 ~ writeln!(
[INFO] [stdout] 104 | ppm,
[INFO] [stdout] 105 ~ "{} {} {}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:114:31
[INFO] [stdout] |
[INFO] [stdout] 114 | pub fn write_scaled_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 114 - pub fn write_scaled_ppm(imgs: &Vec
, fname: String) {
[INFO] [stdout] 114 + pub fn write_scaled_ppm(imgs: &[Img], fname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:121:13
[INFO] [stdout] |
[INFO] [stdout] 121 | return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 121 - return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] 121 + (mx / 255 + 1 as i64) as u8
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:123:13
[INFO] [stdout] |
[INFO] [stdout] 123 | return scaled_val;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 123 - return scaled_val;
[INFO] [stdout] 123 + scaled_val
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting integer literal to `i64` is unnecessary
[INFO] [stdout] --> buddhabrot/src/ppm.rs:121:32
[INFO] [stdout] |
[INFO] [stdout] 121 | return (mx / 255 + 1 as i64) as u8;
[INFO] [stdout] | ^^^^^^^^ help: try: `1_i64`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:129:5
[INFO] [stdout] |
[INFO] [stdout] 129 | write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 129 - write!(ppm, "{} {}\n", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] 129 + writeln!(ppm, "{} {}", imgs[0].width, imgs[0].height).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:130:5
[INFO] [stdout] |
[INFO] [stdout] 130 | write!(ppm, "{}\n", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 130 - write!(ppm, "{}\n", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] 130 + writeln!(ppm, "{}", scale_fn(max_brightness, max_brightness)).unwrap();
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline
[INFO] [stdout] --> buddhabrot/src/ppm.rs:132:9
[INFO] [stdout] |
[INFO] [stdout] 132 | / write!(
[INFO] [stdout] 133 | | ppm,
[INFO] [stdout] 134 | | "{} {} {}\n",
[INFO] [stdout] 135 | | scale_fn(imgs[0].pixels[pidx], max_brightness),
[INFO] [stdout] 136 | | scale_fn(imgs[1].pixels[pidx], max_brightness),
[INFO] [stdout] 137 | | scale_fn(imgs[2].pixels[pidx], max_brightness),
[INFO] [stdout] 138 | | )
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stdout] help: use `writeln!` instead
[INFO] [stdout] |
[INFO] [stdout] 132 ~ writeln!(
[INFO] [stdout] 133 | ppm,
[INFO] [stdout] 134 ~ "{} {} {}",
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:143:34
[INFO] [stdout] |
[INFO] [stdout] 143 | pub fn write_scaled_png(imgs: &Vec
, fname: String, scale_func: F)
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 143 - pub fn write_scaled_png(imgs: &Vec
, fname: String, scale_func: F)
[INFO] [stdout] 143 + pub fn write_scaled_png(imgs: &[Img], fname: String, scale_func: F)
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:244:5
[INFO] [stdout] |
[INFO] [stdout] 244 | return imgs;
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 244 - return imgs;
[INFO] [stdout] 244 + imgs
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: all variants have the same prefix: `Await`
[INFO] [stdout] --> buddhabrot/src/ppm.rs:174:5
[INFO] [stdout] |
[INFO] [stdout] 174 | / enum State {
[INFO] [stdout] 175 | | AwaitMagicNum,
[INFO] [stdout] 176 | | AwaitWidth,
[INFO] [stdout] 177 | | AwaitHeight,
[INFO] [stdout] ... |
[INFO] [stdout] 181 | | AwaitBlue,
[INFO] [stdout] 182 | | }
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout] --> buddhabrot/src/ppm.rs:192:12
[INFO] [stdout] |
[INFO] [stdout] 192 | if line == "" {
[INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout] --> buddhabrot/src/ppm.rs:197:16
[INFO] [stdout] |
[INFO] [stdout] 197 | if token == "" {
[INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `token.is_empty()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout] --> buddhabrot/src/ppm.rs:250:26
[INFO] [stdout] |
[INFO] [stdout] 250 | pub fn rescale_ppm(imgs: &Vec
, ppmname: String) {
[INFO] [stdout] | ^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout] |
[INFO] [stdout] 250 - pub fn rescale_ppm(imgs: &Vec
, ppmname: String) {
[INFO] [stdout] 250 + pub fn rescale_ppm(imgs: &[Img], ppmname: String) {
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout] --> buddhabrot/src/ppm.rs:253:28
[INFO] [stdout] |
[INFO] [stdout] 253 | let mut scaling_funcs: Vec<(&str, Box f64>)> = Vec::new();
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:34
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:256:60
[INFO] [stdout] |
[INFO] [stdout] 256 | Box::new(|val, mx| (fexp(val as f64, 0.001) / fexp(mx as f64, 0.001))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:34
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:260:60
[INFO] [stdout] |
[INFO] [stdout] 260 | Box::new(|val, mx| (fexp(val as f64, 0.005) / fexp(mx as f64, 0.005))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:34
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:264:60
[INFO] [stdout] |
[INFO] [stdout] 264 | Box::new(|val, mx| (fexp(val as f64, 0.010) / fexp(mx as f64, 0.010))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:34
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:268:60
[INFO] [stdout] |
[INFO] [stdout] 268 | Box::new(|val, mx| (fexp(val as f64, 0.050) / fexp(mx as f64, 0.050))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:34
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:272:60
[INFO] [stdout] |
[INFO] [stdout] 272 | Box::new(|val, mx| (fexp(val as f64, 0.100) / fexp(mx as f64, 0.100))),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:276:32
[INFO] [stdout] |
[INFO] [stdout] 276 | Box::new(|val, mx| log(val as f64, 1.0) / log(mx as f64, 1.0)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:276:55
[INFO] [stdout] |
[INFO] [stdout] 276 | Box::new(|val, mx| log(val as f64, 1.0) / log(mx as f64, 1.0)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:280:32
[INFO] [stdout] |
[INFO] [stdout] 280 | Box::new(|val, mx| log(val as f64, 0.5) / log(mx as f64, 0.5)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:280:55
[INFO] [stdout] |
[INFO] [stdout] 280 | Box::new(|val, mx| log(val as f64, 0.5) / log(mx as f64, 0.5)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:284:32
[INFO] [stdout] |
[INFO] [stdout] 284 | Box::new(|val, mx| log(val as f64, 0.1) / log(mx as f64, 0.1)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:284:55
[INFO] [stdout] |
[INFO] [stdout] 284 | Box::new(|val, mx| log(val as f64, 0.1) / log(mx as f64, 0.1)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:288:32
[INFO] [stdout] |
[INFO] [stdout] 288 | Box::new(|val, mx| log(val as f64, 0.01) / log(mx as f64, 0.01)),
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> buddhabrot/src/ppm.rs:288:56
[INFO] [stdout] |
[INFO] [stdout] 288 | Box::new(|val, mx| log(val as f64, 0.01) / log(mx as f64, 0.01)),
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> buddhabrot/src/ppm.rs:296:13
[INFO] [stdout] |
[INFO] [stdout] 296 | return 0.0;
[INFO] [stdout] | ^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 296 - return 0.0;
[INFO] [stdout] 296 + 0.0
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stderr] Checking trajectory-render v0.1.0 (/opt/rustwide/workdir/trajectory-render)
[INFO] [stderr] Checking trajectory-gen v0.1.0 (/opt/rustwide/workdir/trajectory-gen)
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout] --> trajectory-gen/src/main.rs:83:17
[INFO] [stdout] |
[INFO] [stdout] 83 | let t = trajs.clone();
[INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*trajs`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout] --> trajectory-gen/src/main.rs:83:17
[INFO] [stdout] |
[INFO] [stdout] 83 | let t = trajs.clone();
[INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*trajs`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-gen/src/main.rs:124:5
[INFO] [stdout] |
[INFO] [stdout] 124 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 124 - return false;
[INFO] [stdout] 124 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-gen/src/main.rs:124:5
[INFO] [stdout] |
[INFO] [stdout] 124 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 124 - return false;
[INFO] [stdout] 124 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> trajectory-gen/src/main.rs:181:23
[INFO] [stdout] |
[INFO] [stdout] 181 | if escaped && !(trajectory.length < min_iterations) {
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(trajectory.length >= min_iterations)`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> trajectory-gen/src/main.rs:181:23
[INFO] [stdout] |
[INFO] [stdout] 181 | if escaped && !(trajectory.length < min_iterations) {
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(trajectory.length >= min_iterations)`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> trajectory-gen/src/main.rs:161:33
[INFO] [stdout] |
[INFO] [stdout] 161 | trajectory.length = itercount as i64;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `itercount`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> trajectory-gen/src/main.rs:161:33
[INFO] [stdout] |
[INFO] [stdout] 161 | trajectory.length = itercount as i64;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `itercount`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: usage of a legacy numeric constant
[INFO] [stdout] --> trajectory-render/src/main.rs:105:13
[INFO] [stdout] |
[INFO] [stdout] 105 | std::i64::MAX,
[INFO] [stdout] | ^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout] |
[INFO] [stdout] 105 - std::i64::MAX,
[INFO] [stdout] 105 + i64::MAX,
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:167:19
[INFO] [stdout] |
[INFO] [stdout] 167 | ppm::fexp(val as f64, 0.100) / ppm::fexp(mx as f64, 0.100)
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:167:50
[INFO] [stdout] |
[INFO] [stdout] 167 | ppm::fexp(val as f64, 0.100) / ppm::fexp(mx as f64, 0.100)
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-render/src/main.rs:185:5
[INFO] [stdout] |
[INFO] [stdout] 185 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 185 - return false;
[INFO] [stdout] 185 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: usage of a legacy numeric constant
[INFO] [stdout] --> trajectory-render/src/main.rs:105:13
[INFO] [stdout] |
[INFO] [stdout] 105 | std::i64::MAX,
[INFO] [stdout] | ^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout] |
[INFO] [stdout] 105 - std::i64::MAX,
[INFO] [stdout] 105 + i64::MAX,
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout] --> trajectory-render/src/main.rs:193:5
[INFO] [stdout] |
[INFO] [stdout] 193 | / loop {
[INFO] [stdout] 194 | | let old_traj: Trajectory = match receive_traj.try_recv() {
[INFO] [stdout] 195 | | Ok(t) => t,
[INFO] [stdout] 196 | | Err(_) => {
[INFO] [stdout] ... |
[INFO] [stdout] 246 | | }
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout] |
[INFO] [stdout] 193 ~ while let Ok(t) = receive_traj.try_recv() {
[INFO] [stdout] 194 + let old_traj: Trajectory = t;
[INFO] [stdout] 195 + ..
[INFO] [stdout] 196 + }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:213:33
[INFO] [stdout] |
[INFO] [stdout] 213 | trajectory.length = itercount as i64;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `itercount`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:167:19
[INFO] [stdout] |
[INFO] [stdout] 167 | ppm::fexp(val as f64, 0.100) / ppm::fexp(mx as f64, 0.100)
[INFO] [stdout] | ^^^^^^^^^^ help: try: `val`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:167:50
[INFO] [stdout] |
[INFO] [stdout] 167 | ppm::fexp(val as f64, 0.100) / ppm::fexp(mx as f64, 0.100)
[INFO] [stdout] | ^^^^^^^^^ help: try: `mx`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-render/src/main.rs:185:5
[INFO] [stdout] |
[INFO] [stdout] 185 | return false;
[INFO] [stdout] | ^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 185 - return false;
[INFO] [stdout] 185 + false
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `clone` on type `Complex` which implements the `Copy` trait
[INFO] [stdout] --> trajectory-render/src/main.rs:222:24
[INFO] [stdout] |
[INFO] [stdout] 222 | point: z.clone(),
[INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `z`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this loop could be written as a `while let` loop
[INFO] [stdout] --> trajectory-render/src/main.rs:193:5
[INFO] [stdout] |
[INFO] [stdout] 193 | / loop {
[INFO] [stdout] 194 | | let old_traj: Trajectory = match receive_traj.try_recv() {
[INFO] [stdout] 195 | | Ok(t) => t,
[INFO] [stdout] 196 | | Err(_) => {
[INFO] [stdout] ... |
[INFO] [stdout] 246 | | }
[INFO] [stdout] | |_____^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout] |
[INFO] [stdout] 193 ~ while let Ok(t) = receive_traj.try_recv() {
[INFO] [stdout] 194 + let old_traj: Trajectory = t;
[INFO] [stdout] 195 + ..
[INFO] [stdout] 196 + }
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-render/src/main.rs:273:5
[INFO] [stdout] |
[INFO] [stdout] 273 | return (xp as i64, yp as i64);
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 273 - return (xp as i64, yp as i64);
[INFO] [stdout] 273 + (xp as i64, yp as i64)
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`)
[INFO] [stdout] --> trajectory-render/src/main.rs:213:33
[INFO] [stdout] |
[INFO] [stdout] 213 | trajectory.length = itercount as i64;
[INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `itercount`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: using `clone` on type `Complex` which implements the `Copy` trait
[INFO] [stdout] --> trajectory-render/src/main.rs:222:24
[INFO] [stdout] |
[INFO] [stdout] 222 | point: z.clone(),
[INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `z`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout] --> trajectory-render/src/main.rs:273:5
[INFO] [stdout] |
[INFO] [stdout] 273 | return (xp as i64, yp as i64);
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout] |
[INFO] [stdout] 273 - return (xp as i64, yp as i64);
[INFO] [stdout] 273 + (xp as i64, yp as i64)
[INFO] [stdout] |
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.30s
[INFO] running `Command { std: "docker" "inspect" "f49c180d118395cd73d855998f18ba47a67fc5c5b2c3d258f03f6fd5d2b4ff2b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f49c180d118395cd73d855998f18ba47a67fc5c5b2c3d258f03f6fd5d2b4ff2b", kill_on_drop: false }`
[INFO] [stdout] f49c180d118395cd73d855998f18ba47a67fc5c5b2c3d258f03f6fd5d2b4ff2b