[INFO] cloning repository https://github.com/legendiguess/simple_snake [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/legendiguess/simple_snake" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flegendiguess%2Fsimple_snake", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flegendiguess%2Fsimple_snake'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 51afc2f8cae26d2ac6dc38239d62add04ec78523 [INFO] linting legendiguess/simple_snake/51afc2f8cae26d2ac6dc38239d62add04ec78523 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flegendiguess%2Fsimple_snake" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/legendiguess/simple_snake [INFO] finished tweaking git repo https://github.com/legendiguess/simple_snake [INFO] tweaked toml for git repo https://github.com/legendiguess/simple_snake written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/legendiguess/simple_snake on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/legendiguess/simple_snake already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand v0.3.22 [INFO] [stderr] Downloaded user32-sys v0.1.3 [INFO] [stderr] Downloaded gdi32-sys v0.1.2 [INFO] [stderr] Downloaded minifb v0.11.1 [INFO] [stderr] Downloaded x11-dl v2.14.0 [INFO] [stderr] Downloaded sdl2 v0.31.0 [INFO] [stderr] Downloaded sdl2-sys v0.31.0 [INFO] [stderr] Downloaded orbclient v0.3.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50a0db32cb33c68ac56ba54829504bf1ffa1134ed6ec380d52806c61c31a0a09 [INFO] running `Command { std: "docker" "start" "-a" "50a0db32cb33c68ac56ba54829504bf1ffa1134ed6ec380d52806c61c31a0a09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50a0db32cb33c68ac56ba54829504bf1ffa1134ed6ec380d52806c61c31a0a09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50a0db32cb33c68ac56ba54829504bf1ffa1134ed6ec380d52806c61c31a0a09", kill_on_drop: false }` [INFO] [stdout] 50a0db32cb33c68ac56ba54829504bf1ffa1134ed6ec380d52806c61c31a0a09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42ea1eccfdbffa4f2af89aab547100c08fc389ed53c471b13adee1062d6a1782 [INFO] running `Command { std: "docker" "start" "-a" "42ea1eccfdbffa4f2af89aab547100c08fc389ed53c471b13adee1062d6a1782", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling minifb v0.11.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking simple_snake v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/main.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 12 | struct Snake { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 13 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:26:36 [INFO] [stdout] | [INFO] [stdout] 26 | fn logic(snake: &mut Snake, area: &mut Vec, window: &mut Window) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - fn logic(snake: &mut Snake, area: &mut Vec, window: &mut Window) { [INFO] [stdout] 26 + fn logic(snake: &mut Snake, area: &mut [u32], window: &mut Window) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `area` [INFO] [stdout] --> src/main.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | for i in 0..area.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 83 - for i in 0..area.len() { [INFO] [stdout] 83 + for (i, ) in area.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | area[i] = area[i] -1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area[i] -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | let mut window = Window::new(&"GL HF!".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"GL HF!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:125:11 [INFO] [stdout] | [INFO] [stdout] 125 | else if game_over == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!game_over` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | window.set_title(&"Game Over ;c".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"Game Over ;c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/main.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 12 | struct Snake { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 13 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:26:36 [INFO] [stdout] | [INFO] [stdout] 26 | fn logic(snake: &mut Snake, area: &mut Vec, window: &mut Window) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - fn logic(snake: &mut Snake, area: &mut Vec, window: &mut Window) { [INFO] [stdout] 26 + fn logic(snake: &mut Snake, area: &mut [u32], window: &mut Window) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `area` [INFO] [stdout] --> src/main.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | for i in 0..area.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 83 - for i in 0..area.len() { [INFO] [stdout] 83 + for (i, ) in area.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | area[i] = area[i] -1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area[i] -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | let mut window = Window::new(&"GL HF!".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"GL HF!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:125:11 [INFO] [stdout] | [INFO] [stdout] 125 | else if game_over == false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!game_over` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | window.set_title(&"Game Over ;c".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"Game Over ;c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `Command { std: "docker" "inspect" "42ea1eccfdbffa4f2af89aab547100c08fc389ed53c471b13adee1062d6a1782", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42ea1eccfdbffa4f2af89aab547100c08fc389ed53c471b13adee1062d6a1782", kill_on_drop: false }` [INFO] [stdout] 42ea1eccfdbffa4f2af89aab547100c08fc389ed53c471b13adee1062d6a1782