[INFO] cloning repository https://github.com/lcosmin/mikrotik-firewall [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lcosmin/mikrotik-firewall" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcosmin%2Fmikrotik-firewall", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcosmin%2Fmikrotik-firewall'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7ca4e1ec4a0c55e724d20f97cecce8d418b7f53 [INFO] linting lcosmin/mikrotik-firewall against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flcosmin%2Fmikrotik-firewall" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lcosmin/mikrotik-firewall [INFO] finished tweaking git repo https://github.com/lcosmin/mikrotik-firewall [INFO] tweaked toml for git repo https://github.com/lcosmin/mikrotik-firewall written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lcosmin/mikrotik-firewall on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lcosmin/mikrotik-firewall already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tracing-forest v0.1.6 [INFO] [stderr] Downloaded serde_valid_derive v0.24.0 [INFO] [stderr] Downloaded serde_valid_literal v0.24.0 [INFO] [stderr] Downloaded slog-term v2.9.1 [INFO] [stderr] Downloaded assert2-macros v0.3.15 [INFO] [stderr] Downloaded cactus v1.0.7 [INFO] [stderr] Downloaded packedvec v1.2.4 [INFO] [stderr] Downloaded bytes v1.7.0 [INFO] [stderr] Downloaded assert2 v0.3.15 [INFO] [stderr] Downloaded lrlex v0.13.7 [INFO] [stderr] Downloaded cc v1.1.7 [INFO] [stderr] Downloaded cfgrammar v0.13.7 [INFO] [stderr] Downloaded vergen v8.3.2 [INFO] [stderr] Downloaded vob v3.0.3 [INFO] [stderr] Downloaded lrpar v0.13.7 [INFO] [stderr] Downloaded pest_meta v2.7.11 [INFO] [stderr] Downloaded pest_generator v2.7.11 [INFO] [stderr] Downloaded syn v2.0.85 [INFO] [stderr] Downloaded pest v2.7.11 [INFO] [stderr] Downloaded minijinja v2.0.2 [INFO] [stderr] Downloaded object v0.36.2 [INFO] [stderr] Downloaded pest_derive v2.7.11 [INFO] [stderr] Downloaded lrtable v0.13.7 [INFO] [stderr] Downloaded sparsevec v0.2.0 [INFO] [stderr] Downloaded memo-map v0.3.3 [INFO] [stderr] Downloaded serde_valid v0.24.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ace03fe18c436d690ebecfabdd48b6cd65bdda7f2cd1db65d5e171babf9de8af [INFO] running `Command { std: "docker" "start" "-a" "ace03fe18c436d690ebecfabdd48b6cd65bdda7f2cd1db65d5e171babf9de8af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ace03fe18c436d690ebecfabdd48b6cd65bdda7f2cd1db65d5e171babf9de8af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ace03fe18c436d690ebecfabdd48b6cd65bdda7f2cd1db65d5e171babf9de8af", kill_on_drop: false }` [INFO] [stdout] ace03fe18c436d690ebecfabdd48b6cd65bdda7f2cd1db65d5e171babf9de8af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63fe93562eef688e74402c9bf0899b40ce7005f3782e5577d0979998664a244f [INFO] running `Command { std: "docker" "start" "-a" "63fe93562eef688e74402c9bf0899b40ce7005f3782e5577d0979998664a244f", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling hashbrown v0.15.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling indexmap v2.6.0 [INFO] [stderr] Compiling syn v2.0.85 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling assert2-macros v0.3.15 [INFO] [stderr] Compiling rstest_macros v0.23.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking bytes v1.7.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking serde_valid_literal v0.24.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking memo-map v0.3.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking slog-term v2.9.1 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_valid_derive v0.24.0 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking assert2 v0.3.15 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking rstest v0.23.0 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking tracing-forest v0.1.6 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_valid v0.24.0 [INFO] [stderr] Checking minijinja v2.0.2 [INFO] [stderr] Checking mikrotik-firewall v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/firewall/config_files.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/firewall/rules.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 187 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/firewall/config_files.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/firewall/rules.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 187 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_str` is never used [INFO] [stdout] --> src/firewall/rules.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 121 | impl RuleBuilder { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 133 | pub fn from_str(s: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/firewall/chains.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | if !iter_rules.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter_rules.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/firewall/chains.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(ref to_remove) = removed_chains { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 - if let Some(ref to_remove) = removed_chains { [INFO] [stdout] 79 + if let Some(to_remove) = removed_chains { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/firewall/chains.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | if let Some(ref fc) = final_chains { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - if let Some(ref fc) = final_chains { [INFO] [stdout] 114 + if let Some(fc) = final_chains { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/firewall/config_files.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn load(config_path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 ~ pub fn load(config_path: &Path) -> Result { [INFO] [stdout] 29 ~ let mut p = config_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/firewall/firewalls.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 22 | ..self [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/firewall/loader.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if p.rules.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `p.rules.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/firewall/templates.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(root_dir: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn new(root_dir: &PathBuf) -> Result { [INFO] [stdout] 14 + pub fn new(root_dir: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/firewall/templates.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 75 | tpl.render(context).map_err(|x| anyhow::Error::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/firewall/utils.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if zones.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `zones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/firewall/loader.rs:131:31 [INFO] [stdout] | [INFO] [stdout] 131 | let firewall_tables = vec!["filter", "mangle", "raw", "nat"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["filter", "mangle", "raw", "nat"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/firewall/chains.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 101 | if !iter_rules.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter_rules.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/firewall/chains.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | if let Some(ref to_remove) = removed_chains { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 - if let Some(ref to_remove) = removed_chains { [INFO] [stdout] 79 + if let Some(to_remove) = removed_chains { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/firewall/chains.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | if let Some(ref fc) = final_chains { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 114 - if let Some(ref fc) = final_chains { [INFO] [stdout] 114 + if let Some(fc) = final_chains { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/firewall/config_files.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn load(config_path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 ~ pub fn load(config_path: &Path) -> Result { [INFO] [stdout] 29 ~ let mut p = config_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/firewall/firewalls.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 22 | ..self [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/firewall/loader.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if p.rules.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `p.rules.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/firewall/parser.rs:148:68 [INFO] [stdout] | [INFO] [stdout] 148 | let res = expand_string_and_parse_rule(&jinja, Some(&ctx), &s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/firewall/templates.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(root_dir: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn new(root_dir: &PathBuf) -> Result { [INFO] [stdout] 14 + pub fn new(root_dir: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/firewall/templates.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 75 | tpl.render(context).map_err(|x| anyhow::Error::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `anyhow::Error::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/firewall/utils.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if zones.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `zones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/firewall/loader.rs:131:31 [INFO] [stdout] | [INFO] [stdout] 131 | let firewall_tables = vec!["filter", "mangle", "raw", "nat"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["filter", "mangle", "raw", "nat"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `Command { std: "docker" "inspect" "63fe93562eef688e74402c9bf0899b40ce7005f3782e5577d0979998664a244f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63fe93562eef688e74402c9bf0899b40ce7005f3782e5577d0979998664a244f", kill_on_drop: false }` [INFO] [stdout] 63fe93562eef688e74402c9bf0899b40ce7005f3782e5577d0979998664a244f