[INFO] cloning repository https://github.com/lclarkmichalek/smellysat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lclarkmichalek/smellysat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flclarkmichalek%2Fsmellysat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flclarkmichalek%2Fsmellysat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 42c6ad21a2a8441cc8eed148454925365a72b277 [INFO] linting lclarkmichalek/smellysat against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flclarkmichalek%2Fsmellysat" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-6-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/lclarkmichalek/smellysat [INFO] finished tweaking git repo https://github.com/lclarkmichalek/smellysat [INFO] tweaked toml for git repo https://github.com/lclarkmichalek/smellysat written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lclarkmichalek/smellysat on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lclarkmichalek/smellysat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded is_sorted v0.1.1 [INFO] [stderr] Downloaded jiff-static v0.2.17 [INFO] [stderr] Downloaded syn v2.0.113 [INFO] [stderr] Downloaded jiff v0.2.17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1553be9521d0f26ba2f21af2a439c0c579549c5de58d0f24b3558e56b396a422 [INFO] running `Command { std: "docker" "start" "-a" "1553be9521d0f26ba2f21af2a439c0c579549c5de58d0f24b3558e56b396a422", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1553be9521d0f26ba2f21af2a439c0c579549c5de58d0f24b3558e56b396a422", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1553be9521d0f26ba2f21af2a439c0c579549c5de58d0f24b3558e56b396a422", kill_on_drop: false }` [INFO] [stdout] 1553be9521d0f26ba2f21af2a439c0c579549c5de58d0f24b3558e56b396a422 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] feb9ba312a2297087bde47622f7b6b24a1a4e91c55ee203424ddd4eb3f988f4e [INFO] running `Command { std: "docker" "start" "-a" "feb9ba312a2297087bde47622f7b6b24a1a4e91c55ee203424ddd4eb3f988f4e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling protobuf v3.7.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling prometheus v0.14.0 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking jiff v0.2.17 [INFO] [stderr] Checking is_sorted v0.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking protobuf-support v3.7.2 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking smellysat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `self.rst` after checking its variant with `is_some` [INFO] [stdout] --> src/solver/clause_store.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 324 | } else if self.rst.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = self.rst` [INFO] [stdout] 325 | self.rst.unwrap().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/solver/trail.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | let b = Variable(1); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `strategy` [INFO] [stdout] --> src/solver/trail.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | let strategy = DumbBacktrackStrategy {}; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_strategy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `conflict` [INFO] [stdout] --> src/solver/trail.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let conflict = Conflict { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_conflict` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dimacs/mod.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 341 | assert!(!instance.variables.iter().next().is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `instance.variables.iter().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/instance/literal.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(lit.polarity(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(lit.polarity(), true); [INFO] [stdout] 51 + assert!(lit.polarity()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/instance/literal.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(lit.invert().polarity(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(lit.invert().polarity(), false); [INFO] [stdout] 52 + assert!(!lit.invert().polarity()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/problem_builder.rs:158:18 [INFO] [stdout] | [INFO] [stdout] 158 | &by_child[child] [INFO] [stdout] | __________________^ [INFO] [stdout] 159 | | .values() [INFO] [stdout] 160 | | .map(|x| *x) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 158 ~ &by_child[child] [INFO] [stdout] 159 + .values().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/problem_builder.rs:170:41 [INFO] [stdout] | [INFO] [stdout] 170 | fn or_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 170 - fn or_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] 170 + fn or_list(pb: &ProblemBuilder, xs: &[BoolExpr]) -> BoolExpr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `xs` [INFO] [stdout] --> src/problem_builder.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 176 | for i in 1..xs.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 176 - for i in 1..xs.len() { [INFO] [stdout] 176 + for in xs.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.rst` after checking its variant with `is_some` [INFO] [stdout] --> src/solver/clause_store.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 324 | } else if self.rst.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = self.rst` [INFO] [stdout] 325 | self.rst.unwrap().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> examples/n_queens.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | / constraints [INFO] [stdout] 44 | | .iter() [INFO] [stdout] 45 | | .map(|x| *x) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 43 ~ constraints [INFO] [stdout] 44 + .iter().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::info` [INFO] [stdout] --> examples/evaluate_dimacs.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use log::info; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/instance/literal.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | for idx in vec![0, 10000000, 1000, 1 << 46] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0, 10000000, 1000, 1 << 46]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/problem_builder.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | let seats = vec!["a", "b", "c", "d"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["a", "b", "c", "d"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/assignment_set.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | let clause = vec![Literal::new(a, true), Literal::new(c, false)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Literal::new(a, true), Literal::new(c, false)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/assignment_set.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | let c = vec![Literal::new(Variable(0), true)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Literal::new(Variable(0), true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/backtrack.rs:207:23 [INFO] [stdout] | [INFO] [stdout] 207 | let clauses = vec![ [INFO] [stdout] | _______________________^ [INFO] [stdout] 208 | | vec![xs[1].invert(), xs[2].invert()], [INFO] [stdout] 209 | | vec![xs[1].invert(), xs[3]], [INFO] [stdout] 210 | | vec![xs[3].invert(), xs[4].invert()], [INFO] [stdout] ... | [INFO] [stdout] 218 | | vec![xs[11].invert(), xs[12]], [INFO] [stdout] 219 | | ] [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 207 ~ let clauses = [vec![xs[1].invert(), xs[2].invert()], [INFO] [stdout] 208 + vec![xs[1].invert(), xs[3]], [INFO] [stdout] 209 + vec![xs[3].invert(), xs[4].invert()], [INFO] [stdout] 210 + vec![xs[2], xs[4], xs[5]], [INFO] [stdout] 211 + vec![xs[5].invert(), xs[6], xs[7].invert()], [INFO] [stdout] 212 + vec![xs[2], xs[7], xs[8]], [INFO] [stdout] 213 + vec![xs[8].invert(), xs[9].invert()], [INFO] [stdout] 214 + vec![xs[8].invert(), xs[10]], [INFO] [stdout] 215 + vec![xs[9], xs[10].invert(), xs[11]], [INFO] [stdout] 216 + vec![xs[10].invert(), xs[12].invert()], [INFO] [stdout] 217 + vec![xs[11].invert(), xs[12]]] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_index.rs:205:25 [INFO] [stdout] | [INFO] [stdout] 205 | Clause::new(&vec![Literal::new(a, true), Literal::new(c, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, true), Literal::new(c, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_index.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | Clause::new(&vec![Literal::new(b, true), Literal::new(c, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(b, true), Literal::new(c, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_index.rs:209:25 [INFO] [stdout] | [INFO] [stdout] 209 | Clause::new(&vec![Literal::new(c, true), Literal::new(c, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(c, true), Literal::new(c, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_index.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 211 | Clause::new(&vec![Literal::new(b, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(b, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_store.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | Clause::new(&vec![a, b, c]), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[a, b, c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_store.rs:370:25 [INFO] [stdout] | [INFO] [stdout] 370 | Clause::new(&vec![b, c]), [INFO] [stdout] | ^^^^^^^^^^^ help: you can use a slice directly: `&[b, c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/clause_store.rs:371:25 [INFO] [stdout] | [INFO] [stdout] 371 | Clause::new(&vec![c]), [INFO] [stdout] | ^^^^^^^^ help: you can use a slice directly: `&[c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/unit_propagator.rs:190:34 [INFO] [stdout] | [INFO] [stdout] 190 | let clause = Clause::new(&vec![a, b.invert()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[a, b.invert()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/unit_propagator.rs:221:38 [INFO] [stdout] | [INFO] [stdout] 221 | let clause_one = Clause::new(&vec![Literal::new(a, true), Literal::new(b, false)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, true), Literal::new(b, false)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/unit_propagator.rs:223:38 [INFO] [stdout] | [INFO] [stdout] 223 | let clause_two = Clause::new(&vec![Literal::new(a, true), Literal::new(b, false)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, true), Literal::new(b, false)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:354:25 [INFO] [stdout] | [INFO] [stdout] 354 | Clause::new(&vec![Literal::new(a, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:355:25 [INFO] [stdout] | [INFO] [stdout] 355 | Clause::new(&vec![Literal::new(a, false), Literal::new(b, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, false), Literal::new(b, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:356:25 [INFO] [stdout] | [INFO] [stdout] 356 | Clause::new(&vec![Literal::new(b, false), Literal::new(c, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(b, false), Literal::new(c, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:377:25 [INFO] [stdout] | [INFO] [stdout] 377 | Clause::new(&vec![Literal::new(a, true), Literal::new(b, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, true), Literal::new(b, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:378:25 [INFO] [stdout] | [INFO] [stdout] 378 | Clause::new(&vec![Literal::new(a, false), Literal::new(b, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(a, false), Literal::new(b, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:379:25 [INFO] [stdout] | [INFO] [stdout] 379 | Clause::new(&vec![Literal::new(b, false), Literal::new(c, true)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Literal::new(b, false), Literal::new(c, true)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:406:25 [INFO] [stdout] | [INFO] [stdout] 406 | Clause::new(&vec![a.invert(), b.invert()]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[a.invert(), b.invert()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:407:25 [INFO] [stdout] | [INFO] [stdout] 407 | Clause::new(&vec![a.invert(), c.invert()]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[a.invert(), c.invert()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/solver/dfs.rs:408:25 [INFO] [stdout] | [INFO] [stdout] 408 | Clause::new(&vec![b, c]), [INFO] [stdout] | ^^^^^^^^^^^ help: you can use a slice directly: `&[b, c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> examples/seating_plan.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | &by_child[child] [INFO] [stdout] | ______________^ [INFO] [stdout] 34 | | .values() [INFO] [stdout] 35 | | .map(|x| *x) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 33 ~ &by_child[child] [INFO] [stdout] 34 + .values().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> examples/seating_plan.rs:60:37 [INFO] [stdout] | [INFO] [stdout] 60 | fn or_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - fn or_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] 60 + fn or_list(pb: &ProblemBuilder, xs: &[BoolExpr]) -> BoolExpr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `xs` [INFO] [stdout] --> examples/seating_plan.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | for i in 1..xs.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for i in 1..xs.len() { [INFO] [stdout] 66 + for in xs.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> examples/seating_plan.rs:74:38 [INFO] [stdout] | [INFO] [stdout] 74 | fn and_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 74 - fn and_list(pb: &ProblemBuilder, xs: &Vec) -> BoolExpr { [INFO] [stdout] 74 + fn and_list(pb: &ProblemBuilder, xs: &[BoolExpr]) -> BoolExpr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `xs` [INFO] [stdout] --> examples/seating_plan.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | for i in 1..xs.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 80 - for i in 1..xs.len() { [INFO] [stdout] 80 + for in xs.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> examples/evaluate_dimacs.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(()) => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 35 - Ok(()) => return, [INFO] [stdout] 35 + Ok(()) => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.42s [INFO] running `Command { std: "docker" "inspect" "feb9ba312a2297087bde47622f7b6b24a1a4e91c55ee203424ddd4eb3f988f4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feb9ba312a2297087bde47622f7b6b24a1a4e91c55ee203424ddd4eb3f988f4e", kill_on_drop: false }` [INFO] [stdout] feb9ba312a2297087bde47622f7b6b24a1a4e91c55ee203424ddd4eb3f988f4e