[INFO] cloning repository https://github.com/laralex/des-encryptor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/laralex/des-encryptor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaralex%2Fdes-encryptor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaralex%2Fdes-encryptor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8624bd5cb1ed38493574b7408a372a76b439ab2b [INFO] linting laralex/des-encryptor against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaralex%2Fdes-encryptor" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/laralex/des-encryptor [INFO] finished tweaking git repo https://github.com/laralex/des-encryptor [INFO] tweaked toml for git repo https://github.com/laralex/des-encryptor written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/laralex/des-encryptor on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/laralex/des-encryptor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c60982b3d40227b7b4b6b3349b73dfdd0862c8d663bd8386e7039e1987a4ade7 [INFO] running `Command { std: "docker" "start" "-a" "c60982b3d40227b7b4b6b3349b73dfdd0862c8d663bd8386e7039e1987a4ade7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c60982b3d40227b7b4b6b3349b73dfdd0862c8d663bd8386e7039e1987a4ade7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c60982b3d40227b7b4b6b3349b73dfdd0862c8d663bd8386e7039e1987a4ade7", kill_on_drop: false }` [INFO] [stdout] c60982b3d40227b7b4b6b3349b73dfdd0862c8d663bd8386e7039e1987a4ade7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d802f75e98ffd3642a8d02dddb26783e85478a9d7c2e1e418339af7dda81af2f [INFO] running `Command { std: "docker" "start" "-a" "d802f75e98ffd3642a8d02dddb26783e85478a9d7c2e1e418339af7dda81af2f", kill_on_drop: false }` [INFO] [stderr] Checking des v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first defined here [INFO] [stdout] --> src/math/bit_arithmetics.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] help: remove this attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes [INFO] [stdout] = note: `#[warn(clippy::duplicated_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / #[inline] [INFO] [stdout] 288 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 296 | pub fn filter_bit_range(number: u64, begin_bit: u32, end_bit: u32, size_bits: u32) -> Option { [INFO] [stdout] | ----------------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/des/api.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | (mut src: R, dst: W, block_affector: &Fn(u64, &mut I) -> u64, mut key_iterator: I, endianess: Endianess) -> io::Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | (mut src: R, dst: W, block_affector: &dyn Fn(u64, &mut I) -> u64, mut key_iterator: I, endianess: Endianess) -> io::Result<()> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/des/api.rs:100:65 [INFO] [stdout] | [INFO] [stdout] 100 | fn transform_padded_slice(bytes: &mut [u8], block_affector: &Fn(u64, &mut I) -> u64, key_iterator: &mut I) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | fn transform_padded_slice(bytes: &mut [u8], block_affector: &dyn Fn(u64, &mut I) -> u64, key_iterator: &mut I) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first defined here [INFO] [stdout] --> src/math/bit_arithmetics.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] help: remove this attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes [INFO] [stdout] = note: `#[warn(clippy::duplicated_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/math/bit_arithmetics.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / #[inline] [INFO] [stdout] 288 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 296 | pub fn filter_bit_range(number: u64, begin_bit: u32, end_bit: u32, size_bits: u32) -> Option { [INFO] [stdout] | ----------------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/math/bit_arithmetics.rs:391:33 [INFO] [stdout] | [INFO] [stdout] 391 | assert_eq!(bit_mask(5), 0b_10_0000, "5th bit = 2**5"); [INFO] [stdout] | ^^^^^^^^^^ help: consider: `0b10_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/math/bit_arithmetics.rs:392:33 [INFO] [stdout] | [INFO] [stdout] 392 | assert_eq!(bit_mask(0), 0b_00_0001, "1st bit = 1"); [INFO] [stdout] | ^^^^^^^^^^ help: consider: `0b00_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/math/bit_arithmetics.rs:395:40 [INFO] [stdout] | [INFO] [stdout] 395 | assert_eq!(bit_lower_mask(5), 0b_01_1111, "mask of 5 first bits"); [INFO] [stdout] | ^^^^^^^^^^ help: consider: `0b01_1111` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/math/bit_arithmetics.rs:396:40 [INFO] [stdout] | [INFO] [stdout] 396 | assert_eq!(bit_lower_mask(0), 0b_00_0000, "mask of 0 first bits"); [INFO] [stdout] | ^^^^^^^^^^ help: consider: `0b00_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/math/bit_arithmetics.rs:453:14 [INFO] [stdout] | [INFO] [stdout] 453 | (0b_0101_0111_011, 63), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider: `0b010_1011_1011` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/des/details/round.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | 0b1111_0000_1010_1010_1111_0000_1010_1010__1110_1111_0100_1010_0110_0101_0100_0100, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_1010_1010_1111_0000_1010_1010_1110_1111_0100_1010_0110_0101_0100_0100` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/des/api.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | (mut src: R, dst: W, block_affector: &Fn(u64, &mut I) -> u64, mut key_iterator: I, endianess: Endianess) -> io::Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 60 | (mut src: R, dst: W, block_affector: &dyn Fn(u64, &mut I) -> u64, mut key_iterator: I, endianess: Endianess) -> io::Result<()> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/des/api.rs:100:65 [INFO] [stdout] | [INFO] [stdout] 100 | fn transform_padded_slice(bytes: &mut [u8], block_affector: &Fn(u64, &mut I) -> u64, key_iterator: &mut I) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 100 | fn transform_padded_slice(bytes: &mut [u8], block_affector: &dyn Fn(u64, &mut I) -> u64, key_iterator: &mut I) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | else { std::u64::MAX } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 29 - else { std::u64::MAX } [INFO] [stdout] 29 + else { u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | std::u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - std::u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] 37 + u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/math/bit_arithmetics.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn drop_bits<'a, T>(number: u64, ordered_drop_indices: T, size_bits: u32) -> (u64, u32) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/math/bit_arithmetics.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let None = first { [INFO] [stdout] | -------^^^^-------- help: try: `if first.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:174:26 [INFO] [stdout] | [INFO] [stdout] 174 | let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 174 - let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] 174 + let outer_mask = u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:200:26 [INFO] [stdout] | [INFO] [stdout] 200 | let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 200 - let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] 200 + let outer_mask = u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/math/bit_arithmetics.rs:319:22 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn drop_bits<'a, T>(number: u64, ordered_drop_indices: T, size_bits: u32) -> (u64, u32) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/des/api.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | (BITS_IN_BLOCK / 8) + (BITS_IN_BLOCK % 8 == 0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `BITS_IN_BLOCK.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/des/details/bit_permutation.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if self.bit_destinations.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bit_destinations.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/des/details/round.rs:166:41 [INFO] [stdout] | [INFO] [stdout] 166 | let expanded_data = EXPANSION.apply(data as u64); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/des/details/round.rs:184:29 [INFO] [stdout] | [INFO] [stdout] 184 | FINAL_PERMUTATION.apply(merged_data as u64) as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `merged_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_io.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return Ok( (read_file, write_file) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Ok( (read_file, write_file) ); [INFO] [stdout] 18 + Ok( (read_file, write_file) ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reinterpret_bytes.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | fn default() -> Self { return Endianess::Big; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - fn default() -> Self { return Endianess::Big; } [INFO] [stdout] 15 + fn default() -> Self { Endianess::Big} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/reinterpret_bytes.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | assert!(bytes_in_data % bytes_in_dst == 0); // can be evenly split [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `bytes_in_data.is_multiple_of(bytes_in_dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `File` [INFO] [stdout] --> src/ui/cli/cli_main.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | / pub enum Action { [INFO] [stdout] 57 | | EncryptFile, [INFO] [stdout] 58 | | DecryptFile, [INFO] [stdout] 59 | | TripleEncryptFile, [INFO] [stdout] 60 | | TripleDecryptFile, [INFO] [stdout] 61 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cli/cli_main.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 64 | fn default() -> Self { return Action::EncryptFile; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - fn default() -> Self { return Action::EncryptFile; } [INFO] [stdout] 64 + fn default() -> Self { Action::EncryptFile} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/cli/cli_main.rs:91:1 [INFO] [stdout] | [INFO] [stdout] 91 | / impl Default for MessagingLevel { [INFO] [stdout] 92 | | fn default() -> Self { MessagingLevel::Normal } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 85 + #[derive(Default)] [INFO] [stdout] 86 | pub enum MessagingLevel { [INFO] [stdout] 87 | Verbose, [INFO] [stdout] 88 ~ #[default] [INFO] [stdout] 89 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/ui/cli/cli_main.rs:230:23 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn parse_args<'a, T, S>(mut self, mut args: T) -> Option [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ui/cli/cli_main.rs:293:43 [INFO] [stdout] | [INFO] [stdout] 293 | ... } else if let Some(_) = dst_path.file_name() { [INFO] [stdout] | -------^^^^^^^----------------------- help: try: `if dst_path.file_name().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/ui/cli/cli_main.rs:294:40 [INFO] [stdout] | [INFO] [stdout] 294 | ... if let None = dst_path.extension() { [INFO] [stdout] | -------^^^^----------------------- help: try: `if dst_path.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/ui/cli/cli_main.rs:313:24 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn default_key<'a, T> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | else { std::u64::MAX } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 29 - else { std::u64::MAX } [INFO] [stdout] 29 + else { u64::MAX } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | std::u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - std::u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] 37 + u64::MAX - bit_lower_mask(bit + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = cli { [INFO] [stdout] | -------^^^^------ help: try: `if cli.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/math/bit_arithmetics.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn drop_bits<'a, T>(number: u64, ordered_drop_indices: T, size_bits: u32) -> (u64, u32) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/math/bit_arithmetics.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let None = first { [INFO] [stdout] | -------^^^^-------- help: try: `if first.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:174:26 [INFO] [stdout] | [INFO] [stdout] 174 | let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 174 - let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] 174 + let outer_mask = u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/des/details/bit_encoding.rs:18:54 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(encoding_rules: Vec, row_bits: &'a [u32], [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 18 | input_size: u32, output_size: u32) -> EncodingTable { [INFO] [stdout] | ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 18 | input_size: u32, output_size: u32) -> EncodingTable<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/des/details/bit_encoding.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn encoding_rules(&'e self) -> &Vec { &self.encoding_rules } [INFO] [stdout] | -- ^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'e` [INFO] [stdout] | [INFO] [stdout] 46 | pub fn encoding_rules(&'e self) -> &'e Vec { &self.encoding_rules } [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:200:26 [INFO] [stdout] | [INFO] [stdout] 200 | let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 200 - let outer_mask = std::u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] 200 + let outer_mask = u64::MAX - (cutoff_mask | remain_mask); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/math/bit_arithmetics.rs:319:22 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn drop_bits<'a, T>(number: u64, ordered_drop_indices: T, size_bits: u32) -> (u64, u32) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:398:40 [INFO] [stdout] | [INFO] [stdout] 398 | assert_eq!(bit_lower_mask(64), std::u64::MAX, "mask of all bits"); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 398 - assert_eq!(bit_lower_mask(64), std::u64::MAX, "mask of all bits"); [INFO] [stdout] 398 + assert_eq!(bit_lower_mask(64), u64::MAX, "mask of all bits"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:429:23 [INFO] [stdout] | [INFO] [stdout] 429 | let big_val = std::u64::MAX - 7; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 429 - let big_val = std::u64::MAX - 7; [INFO] [stdout] 429 + let big_val = u64::MAX - 7; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:462:23 [INFO] [stdout] | [INFO] [stdout] 462 | drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 462 - drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] 462 + drop_bits(u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/math/bit_arithmetics.rs:462:38 [INFO] [stdout] | [INFO] [stdout] 462 | drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/math/bit_arithmetics.rs:467:38 [INFO] [stdout] | [INFO] [stdout] 467 | idx_from_high::drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 467 - idx_from_high::drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] 467 + idx_from_high::drop_bits(u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/math/bit_arithmetics.rs:467:53 [INFO] [stdout] | [INFO] [stdout] 467 | idx_from_high::drop_bits(std::u64::MAX, (0..100).into_iter(), BITS_IN_INPUT), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/des/api.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | (BITS_IN_BLOCK / 8) + (BITS_IN_BLOCK % 8 == 0) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `BITS_IN_BLOCK.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/des/details/bit_permutation.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if self.bit_destinations.len() == 0 { return 0; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.bit_destinations.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/des/details/bit_permutation.rs:78:22 [INFO] [stdout] | [INFO] [stdout] 78 | pt.apply(std::u64::MAX), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 78 - pt.apply(std::u64::MAX), [INFO] [stdout] 78 + pt.apply(u64::MAX), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/des/details/bit_permutation.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | std::u64::MAX, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 79 - std::u64::MAX, [INFO] [stdout] 79 + u64::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/des/details/round.rs:166:41 [INFO] [stdout] | [INFO] [stdout] 166 | let expanded_data = EXPANSION.apply(data as u64); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/des/details/round.rs:184:29 [INFO] [stdout] | [INFO] [stdout] 184 | FINAL_PERMUTATION.apply(merged_data as u64) as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `merged_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data_io.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return Ok( (read_file, write_file) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return Ok( (read_file, write_file) ); [INFO] [stdout] 18 + Ok( (read_file, write_file) ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data_io.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if !open_rw_files(&impossible_name_2, &impossible_name).is_err(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `open_rw_files(&impossible_name_2, &impossible_name).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data_io.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | if !open_rw_files(&impossible_name, &dir).is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `open_rw_files(&impossible_name, &dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data_io.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if !open_rw_files(&impossible_name, &impossible_name_2).is_ok(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `open_rw_files(&impossible_name, &impossible_name_2).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reinterpret_bytes.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | fn default() -> Self { return Endianess::Big; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - fn default() -> Self { return Endianess::Big; } [INFO] [stdout] 15 + fn default() -> Self { Endianess::Big} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/reinterpret_bytes.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | assert!(bytes_in_data % bytes_in_dst == 0); // can be evenly split [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `bytes_in_data.is_multiple_of(bytes_in_dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `File` [INFO] [stdout] --> src/ui/cli/cli_main.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | / pub enum Action { [INFO] [stdout] 57 | | EncryptFile, [INFO] [stdout] 58 | | DecryptFile, [INFO] [stdout] 59 | | TripleEncryptFile, [INFO] [stdout] 60 | | TripleDecryptFile, [INFO] [stdout] 61 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cli/cli_main.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 64 | fn default() -> Self { return Action::EncryptFile; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - fn default() -> Self { return Action::EncryptFile; } [INFO] [stdout] 64 + fn default() -> Self { Action::EncryptFile} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/cli/cli_main.rs:91:1 [INFO] [stdout] | [INFO] [stdout] 91 | / impl Default for MessagingLevel { [INFO] [stdout] 92 | | fn default() -> Self { MessagingLevel::Normal } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 85 + #[derive(Default)] [INFO] [stdout] 86 | pub enum MessagingLevel { [INFO] [stdout] 87 | Verbose, [INFO] [stdout] 88 ~ #[default] [INFO] [stdout] 89 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/ui/cli/cli_main.rs:230:23 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn parse_args<'a, T, S>(mut self, mut args: T) -> Option [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/ui/cli/cli_main.rs:293:43 [INFO] [stdout] | [INFO] [stdout] 293 | ... } else if let Some(_) = dst_path.file_name() { [INFO] [stdout] | -------^^^^^^^----------------------- help: try: `if dst_path.file_name().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/ui/cli/cli_main.rs:294:40 [INFO] [stdout] | [INFO] [stdout] 294 | ... if let None = dst_path.extension() { [INFO] [stdout] | -------^^^^----------------------- help: try: `if dst_path.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/ui/cli/cli_main.rs:313:24 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn default_key<'a, T> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if let None = cli { [INFO] [stdout] | -------^^^^------ help: try: `if cli.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/math/bit_arithmetics.rs:457:42 [INFO] [stdout] | [INFO] [stdout] 457 | drop_bits(0b_0101_0111_0110, vec![0,1,2,3,5,60,61,62,63,64].iter().cloned(), BITS_IN_INPUT), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0,1,2,3,5,60,61,62,63,64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/des/details/bit_encoding.rs:18:54 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(encoding_rules: Vec, row_bits: &'a [u32], [INFO] [stdout] | -- the lifetime is named here [INFO] [stdout] 18 | input_size: u32, output_size: u32) -> EncodingTable { [INFO] [stdout] | ^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 18 | input_size: u32, output_size: u32) -> EncodingTable<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/des/details/bit_encoding.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn encoding_rules(&'e self) -> &Vec { &self.encoding_rules } [INFO] [stdout] | -- ^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'e` [INFO] [stdout] | [INFO] [stdout] 46 | pub fn encoding_rules(&'e self) -> &'e Vec { &self.encoding_rules } [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `Command { std: "docker" "inspect" "d802f75e98ffd3642a8d02dddb26783e85478a9d7c2e1e418339af7dda81af2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d802f75e98ffd3642a8d02dddb26783e85478a9d7c2e1e418339af7dda81af2f", kill_on_drop: false }` [INFO] [stdout] d802f75e98ffd3642a8d02dddb26783e85478a9d7c2e1e418339af7dda81af2f