[INFO] cloning repository https://github.com/lancelet/beamline [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lancelet/beamline" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flancelet%2Fbeamline", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flancelet%2Fbeamline'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 08a84b70e97c3bd2db6d3e9156d2a4dbc1b1c2ed [INFO] linting lancelet/beamline against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flancelet%2Fbeamline" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/lancelet/beamline [INFO] finished tweaking git repo https://github.com/lancelet/beamline [INFO] tweaked toml for git repo https://github.com/lancelet/beamline written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lancelet/beamline on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lancelet/beamline already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitflags v2.7.0 [INFO] [stderr] Downloaded pin-project v1.1.8 [INFO] [stderr] Downloaded equator-macro v0.2.1 [INFO] [stderr] Downloaded approx v0.4.0 [INFO] [stderr] Downloaded xml-rs v0.8.25 [INFO] [stderr] Downloaded clap v4.5.26 [INFO] [stderr] Downloaded cgmath v0.18.0 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.5 [INFO] [stderr] Downloaded generator v0.8.4 [INFO] [stderr] Downloaded equator v0.2.2 [INFO] [stderr] Downloaded pin-project-internal v1.1.8 [INFO] [stderr] Downloaded aligned-vec v0.6.1 [INFO] [stderr] Downloaded cmov v0.3.1 [INFO] [stderr] Downloaded rustix v0.38.43 [INFO] [stderr] Downloaded divrem v1.0.0 [INFO] [stderr] Downloaded cc v1.2.8 [INFO] [stderr] Downloaded kiddo v5.0.3 [INFO] [stderr] Downloaded elapsed v0.1.2 [INFO] [stderr] Downloaded init_with v1.1.0 [INFO] [stderr] Downloaded clap_builder v4.5.26 [INFO] [stderr] Downloaded sorted-vec v0.8.5 [INFO] [stderr] Downloaded winit v0.30.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 171ac55ab8dbee2d1ec1bc261aa7ca59b319793a09af78cb0f37ab812a8f9a1b [INFO] running `Command { std: "docker" "start" "-a" "171ac55ab8dbee2d1ec1bc261aa7ca59b319793a09af78cb0f37ab812a8f9a1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "171ac55ab8dbee2d1ec1bc261aa7ca59b319793a09af78cb0f37ab812a8f9a1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "171ac55ab8dbee2d1ec1bc261aa7ca59b319793a09af78cb0f37ab812a8f9a1b", kill_on_drop: false }` [INFO] [stdout] 171ac55ab8dbee2d1ec1bc261aa7ca59b319793a09af78cb0f37ab812a8f9a1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91adbbad6238cda5f49a6a855cd7d51135c2b7c98bcb0f2b9875780e71f36cc8 [INFO] running `Command { std: "docker" "start" "-a" "91adbbad6238cda5f49a6a855cd7d51135c2b7c98bcb0f2b9875780e71f36cc8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking bitflags v2.7.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Compiling rustix v0.38.43 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cc v1.2.8 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling wayland-sys v0.31.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling wayland-client v0.31.7 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling naga v23.1.0 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Compiling wayland-scanner v0.31.5 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Compiling wgpu-hal v23.0.1 [INFO] [stderr] Checking gpu-descriptor v0.3.1 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Compiling wayland-backend v0.3.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking wgpu-types v23.0.0 [INFO] [stderr] Compiling wgpu-core v23.0.1 [INFO] [stderr] Checking glow v0.14.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Compiling wgpu v23.0.1 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling rustversion v1.0.19 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling generator v0.8.4 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling fixed v1.28.0 [INFO] [stderr] Compiling winit v0.30.8 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tempfile v3.15.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking wayland-protocols v0.32.5 [INFO] [stderr] Checking wayland-cursor v0.31.7 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking ubyte v0.10.4 [INFO] [stderr] Checking elapsed v0.1.2 [INFO] [stderr] Checking divrem v1.0.0 [INFO] [stderr] Checking cmov v0.3.1 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking sorted-vec v0.8.5 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking init_with v1.1.0 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.26 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling bytemuck_derive v1.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling equator-macro v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking equator v0.2.2 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.5 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.5 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking aligned-vec v0.6.1 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking proptest v1.6.0 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking clap v4.5.26 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking kiddo v5.0.3 [INFO] [stderr] Checking beamline v0.1.0 (/opt/rustwide/workdir/beamline) [INFO] [stderr] Checking beamline-line v0.1.0 (/opt/rustwide/workdir/beamline-line) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> beamline/src/buffers.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|tile_info| TileInfo::new_from_tiler_tileinfo(tile_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `TileInfo::new_from_tiler_tileinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> beamline/src/buffers.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|styled_line| StyledLine::new_from_style_line(styled_line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `StyledLine::new_from_style_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> beamline-line/src/internal/pushbuf.rs:331:23 [INFO] [stdout] | [INFO] [stdout] 331 | debug_assert!(self.chunk_size_bytes() % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.chunk_size_bytes().is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> beamline-line/src/internal/stack.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | / ///---- Property Testing Stack -------------------------------------------- [INFO] [stdout] ... | [INFO] [stdout] 192 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 195 | enum StackOp { [INFO] [stdout] | ------------ the comment documents this enum [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the doc comment should not document enum `StackOp` then comment it out [INFO] [stdout] | [INFO] [stdout] 184 | // ///---- Property Testing Stack -------------------------------------------- [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> beamline/src/renderer.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | view: &output_texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `output_texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> beamline/src/style.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 83 | / let polygon = Polygon::new(vec![ [INFO] [stdout] 84 | | self.line.start() - ovp, [INFO] [stdout] 85 | | self.line.start() - ovn, [INFO] [stdout] 86 | | self.line.end() + ovp, [INFO] [stdout] 87 | | self.line.end() + ovn, [INFO] [stdout] 88 | | ]); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 89 | [INFO] [stdout] 90 | polygon [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 | [INFO] [stdout] 85 ~ Polygon::new(vec![ [INFO] [stdout] 86 + self.line.start() - ovp, [INFO] [stdout] 87 + self.line.start() - ovn, [INFO] [stdout] 88 + self.line.end() + ovp, [INFO] [stdout] 89 + self.line.end() + ovn, [INFO] [stdout] 90 + ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> beamline/src/tiler.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | let ix = self.n_x_tiles as usize * tile_y as usize + tile_x as usize; [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 174 | ix [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 173 ~ [INFO] [stdout] 174 ~ self.n_x_tiles as usize * tile_y as usize + tile_x as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> beamline/src/types.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | (a + b - 1) / b [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `a.div_ceil(b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking asteroids v0.1.0 (/opt/rustwide/workdir/asteroids) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> beamline/src/buffers.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|tile_info| TileInfo::new_from_tiler_tileinfo(tile_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `TileInfo::new_from_tiler_tileinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> beamline/src/buffers.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|styled_line| StyledLine::new_from_style_line(styled_line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `StyledLine::new_from_style_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> beamline/src/renderer.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | view: &output_texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `output_texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> beamline/src/style.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 83 | / let polygon = Polygon::new(vec![ [INFO] [stdout] 84 | | self.line.start() - ovp, [INFO] [stdout] 85 | | self.line.start() - ovn, [INFO] [stdout] 86 | | self.line.end() + ovp, [INFO] [stdout] 87 | | self.line.end() + ovn, [INFO] [stdout] 88 | | ]); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 89 | [INFO] [stdout] 90 | polygon [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 | [INFO] [stdout] 85 ~ Polygon::new(vec![ [INFO] [stdout] 86 + self.line.start() - ovp, [INFO] [stdout] 87 + self.line.start() - ovn, [INFO] [stdout] 88 + self.line.end() + ovp, [INFO] [stdout] 89 + self.line.end() + ovn, [INFO] [stdout] 90 + ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> beamline/src/tiler.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | let ix = self.n_x_tiles as usize * tile_y as usize + tile_x as usize; [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 174 | ix [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 173 ~ [INFO] [stdout] 174 ~ self.n_x_tiles as usize * tile_y as usize + tile_x as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> beamline/src/types.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | (a + b - 1) / b [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `a.div_ceil(b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> beamline-line/src/internal/pushbuf.rs:331:23 [INFO] [stdout] | [INFO] [stdout] 331 | debug_assert!(self.chunk_size_bytes() % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.chunk_size_bytes().is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> beamline-line/src/internal/pushbuf.rs:536:42 [INFO] [stdout] | [INFO] [stdout] 536 | ... |result| sender.send(result.unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 536 ~ |result| { [INFO] [stdout] 537 + let _: () = result.unwrap(); [INFO] [stdout] 538 + sender.send(()) [INFO] [stdout] 539 ~ }.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> beamline-line/src/internal/stack.rs:378:14 [INFO] [stdout] | [INFO] [stdout] 378 | ops: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 378 - ops: &Vec>, [INFO] [stdout] 378 + ops: &[StackOp], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> beamline-line/src/internal/stack.rs:418:28 [INFO] [stdout] | [INFO] [stdout] 418 | let aslice: &[T] = &astack; [INFO] [stdout] | ^^^^^^^ help: change this to: `astack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AABB` contains a capitalized acronym [INFO] [stdout] --> asteroids/src/bucketer.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub struct AABB { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aabb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> asteroids/src/wgpu_context.rs:109:1 [INFO] [stdout] | [INFO] [stdout] 109 | / pub enum AsyncWgpuContextResult { [INFO] [stdout] 110 | | /// The [`WgpuContext`] has been created. [INFO] [stdout] 111 | | Done(WgpuContext), [INFO] [stdout] | | ----------------- the largest variant contains at least 216 bytes [INFO] [stdout] 112 | | /// The async computation has not yet been completed. [INFO] [stdout] 113 | | NotReady, [INFO] [stdout] | | -------- the second-largest variant carries no data at all [INFO] [stdout] 114 | | /// The async computation was canceled. [INFO] [stdout] 115 | | Canceled, [INFO] [stdout] 116 | | } [INFO] [stdout] | |_^ the entire enum is at least 224 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 111 - Done(WgpuContext), [INFO] [stdout] 111 + Done(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> asteroids/src/wgpu_context.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn surface(&self) -> &wgpu::Surface { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | | || [INFO] [stdout] | | |the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 87 | pub fn surface(&self) -> &wgpu::Surface<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AABB` contains a capitalized acronym [INFO] [stdout] --> asteroids/src/bucketer.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub struct AABB { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aabb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> asteroids/src/wgpu_context.rs:109:1 [INFO] [stdout] | [INFO] [stdout] 109 | / pub enum AsyncWgpuContextResult { [INFO] [stdout] 110 | | /// The [`WgpuContext`] has been created. [INFO] [stdout] 111 | | Done(WgpuContext), [INFO] [stdout] | | ----------------- the largest variant contains at least 216 bytes [INFO] [stdout] 112 | | /// The async computation has not yet been completed. [INFO] [stdout] 113 | | NotReady, [INFO] [stdout] | | -------- the second-largest variant carries no data at all [INFO] [stdout] 114 | | /// The async computation was canceled. [INFO] [stdout] 115 | | Canceled, [INFO] [stdout] 116 | | } [INFO] [stdout] | |_^ the entire enum is at least 224 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 111 - Done(WgpuContext), [INFO] [stdout] 111 + Done(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> asteroids/src/wgpu_context.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn surface(&self) -> &wgpu::Surface { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | | || [INFO] [stdout] | | |the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 87 | pub fn surface(&self) -> &wgpu::Surface<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `Command { std: "docker" "inspect" "91adbbad6238cda5f49a6a855cd7d51135c2b7c98bcb0f2b9875780e71f36cc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91adbbad6238cda5f49a6a855cd7d51135c2b7c98bcb0f2b9875780e71f36cc8", kill_on_drop: false }` [INFO] [stdout] 91adbbad6238cda5f49a6a855cd7d51135c2b7c98bcb0f2b9875780e71f36cc8