[INFO] cloning repository https://github.com/laelath/pushcrate
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/laelath/pushcrate" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaelath%2Fpushcrate", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaelath%2Fpushcrate'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] cc62cda6653baf16bf61300885de70b176a0c420
[INFO] linting laelath/pushcrate against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flaelath%2Fpushcrate" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/laelath/pushcrate
[INFO] finished tweaking git repo https://github.com/laelath/pushcrate
[INFO] tweaked toml for git repo https://github.com/laelath/pushcrate written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/laelath/pushcrate on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/laelath/pushcrate already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 75516ef11d6970f4d9279ccc27796bf1b7d3825810b0f1e215896bdf5b07a1a7
[INFO] running `Command { std: "docker" "start" "-a" "75516ef11d6970f4d9279ccc27796bf1b7d3825810b0f1e215896bdf5b07a1a7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "75516ef11d6970f4d9279ccc27796bf1b7d3825810b0f1e215896bdf5b07a1a7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "75516ef11d6970f4d9279ccc27796bf1b7d3825810b0f1e215896bdf5b07a1a7", kill_on_drop: false }`
[INFO] [stdout] 75516ef11d6970f4d9279ccc27796bf1b7d3825810b0f1e215896bdf5b07a1a7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c990ee10a6c8b3071df4fffef06025294d4ea40023fc9072e72366bd097d5dd3
[INFO] running `Command { std: "docker" "start" "-a" "c990ee10a6c8b3071df4fffef06025294d4ea40023fc9072e72366bd097d5dd3", kill_on_drop: false }`
[INFO] [stderr]     Checking pushcrate v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/search.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             frequency: frequency,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/search.rs:134:25
[INFO] [stdout]     |
[INFO] [stdout] 134 |                         h: h,
[INFO] [stdout]     |                         ^^^^ help: replace it with: `h`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/search.rs:135:25
[INFO] [stdout]     |
[INFO] [stdout] 135 |                         g: g,
[INFO] [stdout]     |                         ^^^^ help: replace it with: `g`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/board.rs:367:17
[INFO] [stdout]     |
[INFO] [stdout] 367 |                 width: width,
[INFO] [stdout]     |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/search.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             frequency: frequency,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/search.rs:134:25
[INFO] [stdout]     |
[INFO] [stdout] 134 |                         h: h,
[INFO] [stdout]     |                         ^^^^ help: replace it with: `h`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/search.rs:135:25
[INFO] [stdout]     |
[INFO] [stdout] 135 |                         g: g,
[INFO] [stdout]     |                         ^^^^ help: replace it with: `g`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/board.rs:367:17
[INFO] [stdout]     |
[INFO] [stdout] 367 |                 width: width,
[INFO] [stdout]     |                 ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]   --> src/search.rs:23:12
[INFO] [stdout]    |
[INFO] [stdout] 23 |         if self.counter % self.frequency == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.counter.is_multiple_of(self.frequency)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/search.rs:123:40
[INFO] [stdout]     |
[INFO] [stdout] 123 |                 if board.is_goal_state(&state) {
[INFO] [stdout]     |                                        ^^^^^^ help: change this to: `state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/search.rs:128:63
[INFO] [stdout]     |
[INFO] [stdout] 128 |                 for (child, actions) in board.create_children(&state) {
[INFO] [stdout]     |                                                               ^^^^^^ help: change this to: `state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> src/board.rs:14:12
[INFO] [stdout]    |
[INFO] [stdout] 14 |     goals: Box<[((u32, u32), Box<[u32]>)]>,
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]    = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/board.rs:97:13
[INFO] [stdout]     |
[INFO] [stdout]  97 | /             if self.is_crate(state, x + 1, y)
[INFO] [stdout]  98 | |                 && (self.is_wall(x, y - 1) || self.is_wall(x, y + 1))
[INFO] [stdout]  99 | |                 && (self.is_wall(x + 1, y - 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] ...   |
[INFO] [stdout] 104 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  99 ~                 && (self.is_wall(x + 1, y - 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] 100 ~                 && !(self.is_goal(x, y) && self.is_goal(x + 1, y)) {
[INFO] [stdout] 101 |                     return true;
[INFO] [stdout] 102 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/board.rs:106:13
[INFO] [stdout]     |
[INFO] [stdout] 106 | /             if self.is_crate(state, x, y + 1)
[INFO] [stdout] 107 | |                 && (self.is_wall(x - 1, y) || self.is_wall(x + 1, y))
[INFO] [stdout] 108 | |                 && (self.is_wall(x - 1, y + 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] ...   |
[INFO] [stdout] 113 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 108 ~                 && (self.is_wall(x - 1, y + 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] 109 ~                 && !(self.is_goal(x, y) && self.is_goal(x, y + 1)) {
[INFO] [stdout] 110 |                     return true;
[INFO] [stdout] 111 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/board.rs:245:38
[INFO] [stdout]     |
[INFO] [stdout] 245 |     pub fn parse_level_string(level: &String) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout]     |                                      ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 245 -     pub fn parse_level_string(level: &String) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout] 245 +     pub fn parse_level_string(level: &str) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/board.rs:300:12
[INFO] [stdout]     |
[INFO] [stdout] 300 |         if players.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `players.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:429:20
[INFO] [stdout]     |
[INFO] [stdout] 429 |                   if walls[i - width] && walls[i + 1]
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 430 | |                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 | |                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 | |                     || walls[i - 1] && walls[i - width]
[INFO] [stdout]     | |_______________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 -                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 -                     || walls[i - 1] && walls[i - width]
[INFO] [stdout] 429 +                 if !(!walls[i - width] && !walls[i + width] || !walls[i + 1] && !walls[i - 1])
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 -                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 -                     || walls[i - 1] && walls[i - width]
[INFO] [stdout] 429 +                 if (walls[i - 1] || walls[i + 1]) && (walls[i + width] || walls[i - width])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:429:20
[INFO] [stdout]     |
[INFO] [stdout] 429 |                   if walls[i - width] && walls[i + 1]
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 430 | |                     || walls[i + 1] && walls[i + width]
[INFO] [stdout]     | |_______________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 429 +                 if !(!walls[i + 1] || !walls[i - width] && !walls[i + width])
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 429 +                 if (walls[i + width] || walls[i - width]) && walls[i + 1]
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]  --> src/main.rs:9:10
[INFO] [stdout]   |
[INFO] [stdout] 9 |     path.into_iter()
[INFO] [stdout]   |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]   = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]   --> src/search.rs:23:12
[INFO] [stdout]    |
[INFO] [stdout] 23 |         if self.counter % self.frequency == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.counter.is_multiple_of(self.frequency)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/search.rs:123:40
[INFO] [stdout]     |
[INFO] [stdout] 123 |                 if board.is_goal_state(&state) {
[INFO] [stdout]     |                                        ^^^^^^ help: change this to: `state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/search.rs:128:63
[INFO] [stdout]     |
[INFO] [stdout] 128 |                 for (child, actions) in board.create_children(&state) {
[INFO] [stdout]     |                                                               ^^^^^^ help: change this to: `state`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> src/board.rs:14:12
[INFO] [stdout]    |
[INFO] [stdout] 14 |     goals: Box<[((u32, u32), Box<[u32]>)]>,
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]    = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/board.rs:97:13
[INFO] [stdout]     |
[INFO] [stdout]  97 | /             if self.is_crate(state, x + 1, y)
[INFO] [stdout]  98 | |                 && (self.is_wall(x, y - 1) || self.is_wall(x, y + 1))
[INFO] [stdout]  99 | |                 && (self.is_wall(x + 1, y - 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] ...   |
[INFO] [stdout] 104 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  99 ~                 && (self.is_wall(x + 1, y - 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] 100 ~                 && !(self.is_goal(x, y) && self.is_goal(x + 1, y)) {
[INFO] [stdout] 101 |                     return true;
[INFO] [stdout] 102 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/board.rs:106:13
[INFO] [stdout]     |
[INFO] [stdout] 106 | /             if self.is_crate(state, x, y + 1)
[INFO] [stdout] 107 | |                 && (self.is_wall(x - 1, y) || self.is_wall(x + 1, y))
[INFO] [stdout] 108 | |                 && (self.is_wall(x - 1, y + 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] ...   |
[INFO] [stdout] 113 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 108 ~                 && (self.is_wall(x - 1, y + 1) || self.is_wall(x + 1, y + 1))
[INFO] [stdout] 109 ~                 && !(self.is_goal(x, y) && self.is_goal(x, y + 1)) {
[INFO] [stdout] 110 |                     return true;
[INFO] [stdout] 111 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/board.rs:245:38
[INFO] [stdout]     |
[INFO] [stdout] 245 |     pub fn parse_level_string(level: &String) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout]     |                                      ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 245 -     pub fn parse_level_string(level: &String) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout] 245 +     pub fn parse_level_string(level: &str) -> Result<(Self, BoardState), &'static str> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/board.rs:300:12
[INFO] [stdout]     |
[INFO] [stdout] 300 |         if players.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `players.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:429:20
[INFO] [stdout]     |
[INFO] [stdout] 429 |                   if walls[i - width] && walls[i + 1]
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 430 | |                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 | |                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 | |                     || walls[i - 1] && walls[i - width]
[INFO] [stdout]     | |_______________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 -                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 -                     || walls[i - 1] && walls[i - width]
[INFO] [stdout] 429 +                 if !(!walls[i - width] && !walls[i + width] || !walls[i + 1] && !walls[i - 1])
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 431 -                     || walls[i + width] && walls[i - 1]
[INFO] [stdout] 432 -                     || walls[i - 1] && walls[i - width]
[INFO] [stdout] 429 +                 if (walls[i - 1] || walls[i + 1]) && (walls[i + width] || walls[i - width])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/board.rs:429:20
[INFO] [stdout]     |
[INFO] [stdout] 429 |                   if walls[i - width] && walls[i + 1]
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 430 | |                     || walls[i + 1] && walls[i + width]
[INFO] [stdout]     | |_______________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 429 +                 if !(!walls[i + 1] || !walls[i - width] && !walls[i + width])
[INFO] [stdout]     |
[INFO] [stdout] 429 -                 if walls[i - width] && walls[i + 1]
[INFO] [stdout] 430 -                     || walls[i + 1] && walls[i + width]
[INFO] [stdout] 429 +                 if (walls[i + width] || walls[i - width]) && walls[i + 1]
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]  --> src/main.rs:9:10
[INFO] [stdout]   |
[INFO] [stdout] 9 |     path.into_iter()
[INFO] [stdout]   |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]   = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.60s
[INFO] running `Command { std: "docker" "inspect" "c990ee10a6c8b3071df4fffef06025294d4ea40023fc9072e72366bd097d5dd3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c990ee10a6c8b3071df4fffef06025294d4ea40023fc9072e72366bd097d5dd3", kill_on_drop: false }`
[INFO] [stdout] c990ee10a6c8b3071df4fffef06025294d4ea40023fc9072e72366bd097d5dd3