[INFO] cloning repository https://github.com/lacodda/rellr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lacodda/rellr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flacodda%2Frellr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flacodda%2Frellr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 62ec5cce4517d5becb322f861314409bfcb84001 [INFO] linting lacodda/rellr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flacodda%2Frellr" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lacodda/rellr [INFO] finished tweaking git repo https://github.com/lacodda/rellr [INFO] tweaked toml for git repo https://github.com/lacodda/rellr written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lacodda/rellr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lacodda/rellr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded path-dedot v3.1.1 [INFO] [stderr] Downloaded slug v0.1.5 [INFO] [stderr] Downloaded path-absolutize v3.1.1 [INFO] [stderr] Downloaded git-cliff-core v1.4.0 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Downloaded chrono-tz-build v0.2.1 [INFO] [stderr] Downloaded conventional_commit_parser v0.9.4 [INFO] [stderr] Downloaded lazy-regex v3.1.0 [INFO] [stderr] Downloaded next_version v0.2.10 [INFO] [stderr] Downloaded git-conventional v0.12.4 [INFO] [stderr] Downloaded rust-embed-utils v8.1.0 [INFO] [stderr] Downloaded rust-embed-impl v8.1.0 [INFO] [stderr] Downloaded pest_generator v2.7.5 [INFO] [stderr] Downloaded pest_meta v2.7.5 [INFO] [stderr] Downloaded pest_derive v2.7.5 [INFO] [stderr] Downloaded ignore v0.4.21 [INFO] [stderr] Downloaded config v0.13.4 [INFO] [stderr] Downloaded parse-zoneinfo v0.3.0 [INFO] [stderr] Downloaded tera v1.19.1 [INFO] [stderr] Downloaded pest v2.7.5 [INFO] [stderr] Downloaded winnow v0.5.28 [INFO] [stderr] Downloaded openssl-sys v0.9.96 [INFO] [stderr] Downloaded deunicode v1.4.2 [INFO] [stderr] Downloaded git2 v0.18.1 [INFO] [stderr] Downloaded rustix v0.38.25 [INFO] [stderr] Downloaded bstr v1.8.0 [INFO] [stderr] Downloaded chrono-tz v0.8.4 [INFO] [stderr] Downloaded rust-embed v8.1.0 [INFO] [stderr] Downloaded libgit2-sys v0.16.1+1.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 309e0f17705c3351f8e15a84be07f1cb11978f7781c148cd502b6eb156fef097 [INFO] running `Command { std: "docker" "start" "-a" "309e0f17705c3351f8e15a84be07f1cb11978f7781c148cd502b6eb156fef097", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "309e0f17705c3351f8e15a84be07f1cb11978f7781c148cd502b6eb156fef097", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "309e0f17705c3351f8e15a84be07f1cb11978f7781c148cd502b6eb156fef097", kill_on_drop: false }` [INFO] [stdout] 309e0f17705c3351f8e15a84be07f1cb11978f7781c148cd502b6eb156fef097 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e1fafa26fc2cc7f056fefc6e8b65d2f830cf9a257d0de328de7d6090f709328 [INFO] running `Command { std: "docker" "start" "-a" "7e1fafa26fc2cc7f056fefc6e8b65d2f830cf9a257d0de328de7d6090f709328", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Compiling cpufeatures v0.2.11 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling openssl-sys v0.9.96 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling libgit2-sys v0.16.1+1.7.1 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking winnow v0.5.28 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking ignore v0.4.21 [INFO] [stderr] Compiling rust-embed-utils v8.1.0 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Checking deunicode v1.4.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling rust-embed-impl v8.1.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.4 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking rust-embed v8.1.0 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking lazy-regex v3.1.0 [INFO] [stderr] Compiling pest v2.7.5 [INFO] [stderr] Compiling pest_meta v2.7.5 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Compiling pest_generator v2.7.5 [INFO] [stderr] Compiling pest_derive v2.7.5 [INFO] [stderr] Checking conventional_commit_parser v0.9.4 [INFO] [stderr] Checking next_version v0.2.10 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking git-conventional v0.12.4 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking tera v1.19.1 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking git2 v0.18.1 [INFO] [stderr] Checking git-cliff-core v1.4.0 [INFO] [stderr] Checking rellr v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libs/git.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | repo: repo, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/libs/project_config.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | pub const NPM: &'static str = "npm"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libs/git.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | repo: repo, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/libs/project_config.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | pub const NPM: &'static str = "npm"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `builtin_config` is never read [INFO] [stdout] --> src/libs/changelog.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Changelog { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 22 | pub project_config: ProjectConfig, [INFO] [stdout] 23 | pub builtin_config: Result, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/commands/init.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | let _ = ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 14 - let _ = ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] 14 + ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/commands/next.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | let _ = project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 27 - let _ = project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] 27 + project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:52:38 [INFO] [stdout] | [INFO] [stdout] 52 | update_version_in_file(path, &project_name, &version)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | update_version_in_file(path, &project_name, &version)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let mut changelog = Changelog::new(&project_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `project_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/changelog.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(toml::from_str(&BUILTIN_CONFIG)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `BUILTIN_CONFIG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/git.rs:36:42 [INFO] [stdout] | [INFO] [stdout] 36 | let open_repo = Repository::open(&repo_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:39:29 [INFO] [stdout] | [INFO] [stdout] 39 | _ => Self::init(&repo_path, &project_config.main_branch).unwrap(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 50 | init_options.initial_head(&main_branch); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `main_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/git.rs:51:54 [INFO] [stdout] | [INFO] [stdout] 51 | let repo: Repository = Repository::init_opts(&repo_path, &init_options)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:57:48 [INFO] [stdout] | [INFO] [stdout] 57 | let branch_name = self.get_branch_name(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:99:56 [INFO] [stdout] | [INFO] [stdout] 99 | let branch_name = self.get_branch_name(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:190:33 [INFO] [stdout] | [INFO] [stdout] 190 | self.repo.reference(&target_ref.name().unwrap(), source_commit.id(), true, &log_msg)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `target_ref.name().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/helpers.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if !fs::metadata(file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:123:38 [INFO] [stdout] | [INFO] [stdout] 123 | paths.append(&mut Cargo::new(&self).paths()); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | paths.append(&mut Npm::new(&self).paths()); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 133 | Cargo::new(&self).publish()?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | Npm::new(&self).publish()?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `version_vec` [INFO] [stdout] --> src/libs/project_config.rs:143:22 [INFO] [stdout] | [INFO] [stdout] 143 | for i in (index + 1)..version_vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for i in (index + 1)..version_vec.len() { [INFO] [stdout] 143 + for in version_vec.iter_mut().skip((index + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/project_config.rs:250:38 [INFO] [stdout] | [INFO] [stdout] 250 | assert!(env::set_current_dir(&npm).is_ok()); [INFO] [stdout] | ^^^^ help: change this to: `npm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `builtin_config` is never read [INFO] [stdout] --> src/libs/changelog.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Changelog { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 22 | pub project_config: ProjectConfig, [INFO] [stdout] 23 | pub builtin_config: Result, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/commands/init.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | let _ = ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 14 - let _ = ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] 14 + ProjectConfig::new_if_not_exist(init_args)?.save()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/commands/next.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | let _ = project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 27 - let _ = project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] 27 + project_config.up_version(&next_args.update_type)?.save()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:52:38 [INFO] [stdout] | [INFO] [stdout] 52 | update_version_in_file(path, &project_name, &version)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | update_version_in_file(path, &project_name, &version)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/release.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let mut changelog = Changelog::new(&project_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `project_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/changelog.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(toml::from_str(&BUILTIN_CONFIG)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `BUILTIN_CONFIG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/git.rs:36:42 [INFO] [stdout] | [INFO] [stdout] 36 | let open_repo = Repository::open(&repo_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:39:29 [INFO] [stdout] | [INFO] [stdout] 39 | _ => Self::init(&repo_path, &project_config.main_branch).unwrap(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 50 | init_options.initial_head(&main_branch); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `main_branch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/git.rs:51:54 [INFO] [stdout] | [INFO] [stdout] 51 | let repo: Repository = Repository::init_opts(&repo_path, &init_options)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `repo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:57:48 [INFO] [stdout] | [INFO] [stdout] 57 | let branch_name = self.get_branch_name(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:99:56 [INFO] [stdout] | [INFO] [stdout] 99 | let branch_name = self.get_branch_name(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/git.rs:190:33 [INFO] [stdout] | [INFO] [stdout] 190 | self.repo.reference(&target_ref.name().unwrap(), source_commit.id(), true, &log_msg)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `target_ref.name().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/helpers.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if !fs::metadata(file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:123:38 [INFO] [stdout] | [INFO] [stdout] 123 | paths.append(&mut Cargo::new(&self).paths()); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | paths.append(&mut Npm::new(&self).paths()); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 133 | Cargo::new(&self).publish()?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/project_config.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | Npm::new(&self).publish()?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `version_vec` [INFO] [stdout] --> src/libs/project_config.rs:143:22 [INFO] [stdout] | [INFO] [stdout] 143 | for i in (index + 1)..version_vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for i in (index + 1)..version_vec.len() { [INFO] [stdout] 143 + for in version_vec.iter_mut().skip((index + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libs/project_config.rs:250:38 [INFO] [stdout] | [INFO] [stdout] 250 | assert!(env::set_current_dir(&npm).is_ok()); [INFO] [stdout] | ^^^^ help: change this to: `npm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 45s [INFO] running `Command { std: "docker" "inspect" "7e1fafa26fc2cc7f056fefc6e8b65d2f830cf9a257d0de328de7d6090f709328", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e1fafa26fc2cc7f056fefc6e8b65d2f830cf9a257d0de328de7d6090f709328", kill_on_drop: false }` [INFO] [stdout] 7e1fafa26fc2cc7f056fefc6e8b65d2f830cf9a257d0de328de7d6090f709328