[INFO] cloning repository https://github.com/kyhei/local-dev-insights [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kyhei/local-dev-insights" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyhei%2Flocal-dev-insights", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyhei%2Flocal-dev-insights'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb6c06cb0be30a3580a956419239b6531c97df8a [INFO] linting kyhei/local-dev-insights against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyhei%2Flocal-dev-insights" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kyhei/local-dev-insights [INFO] finished tweaking git repo https://github.com/kyhei/local-dev-insights [INFO] tweaked toml for git repo https://github.com/kyhei/local-dev-insights written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kyhei/local-dev-insights on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kyhei/local-dev-insights already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy-derive v0.8.37 [INFO] [stderr] Downloaded zerocopy v0.8.37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fa2ac61b16659d3df4d101d369aae54a45b5ef600cca9dde0c4fab635e88043 [INFO] running `Command { std: "docker" "start" "-a" "0fa2ac61b16659d3df4d101d369aae54a45b5ef600cca9dde0c4fab635e88043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fa2ac61b16659d3df4d101d369aae54a45b5ef600cca9dde0c4fab635e88043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fa2ac61b16659d3df4d101d369aae54a45b5ef600cca9dde0c4fab635e88043", kill_on_drop: false }` [INFO] [stdout] 0fa2ac61b16659d3df4d101d369aae54a45b5ef600cca9dde0c4fab635e88043 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ecf188acd203e62b341e5ce3505ca26b3bde33fc55eafdbe5b4a52ab12d015e3 [INFO] running `Command { std: "docker" "start" "-a" "ecf188acd203e62b341e5ce3505ca26b3bde33fc55eafdbe5b4a52ab12d015e3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling libsqlite3-sys v0.27.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling socket2 v0.6.2 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Compiling tempfile v3.24.0 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Compiling sqlx-core v0.7.4 [INFO] [stderr] Checking sqlx-sqlite v0.7.4 [INFO] [stderr] Compiling sqlx-macros-core v0.7.4 [INFO] [stderr] Compiling sqlx-macros v0.7.4 [INFO] [stderr] Checking sqlx v0.7.4 [INFO] [stderr] Checking local-dev-insights v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/db.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/db.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_pool` is never used [INFO] [stdout] --> src/db.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Db { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn get_pool(&self) -> &Pool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/db.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | let path_str = &db_url["sqlite://".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/db.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | if db_url.starts_with("sqlite://") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 24 ~ if !Path::new(path_str).exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if db_url.starts_with("sqlite://") { [INFO] [stdout] 22 | | if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if db_url.starts_with("sqlite://") [INFO] [stdout] 22 ~ && let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 | } [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | / if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Some(path_str) = db_url.strip_prefix("sqlite://") [INFO] [stdout] 23 ~ && let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | / return JsonRpcResponse { [INFO] [stdout] 144 | | jsonrpc: "2.0".to_string(), [INFO] [stdout] 145 | | result: None, [INFO] [stdout] 146 | | error: None, [INFO] [stdout] 147 | | id: None, [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ JsonRpcResponse { [INFO] [stdout] 144 + jsonrpc: "2.0".to_string(), [INFO] [stdout] 145 + result: None, [INFO] [stdout] 146 + error: None, [INFO] [stdout] 147 + id: None, [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tools.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | / if path.is_file() { [INFO] [stdout] 127 | | if let Some(ext) = path.extension() { [INFO] [stdout] 128 | | if ext.to_string_lossy() == extension { [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if path.is_file() [INFO] [stdout] 127 ~ && let Some(ext) = path.extension() { [INFO] [stdout] 128 | if ext.to_string_lossy() == extension { [INFO] [stdout] ... [INFO] [stdout] 133 | } [INFO] [stdout] 134 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tools.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | / if let Some(ext) = path.extension() { [INFO] [stdout] 128 | | if ext.to_string_lossy() == extension { [INFO] [stdout] 129 | | // Valid path check (simple since we walk from current dir) [INFO] [stdout] 130 | | if let Ok(rel) = path.strip_prefix(&root) { [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ if let Some(ext) = path.extension() [INFO] [stdout] 128 ~ && ext.to_string_lossy() == extension { [INFO] [stdout] 129 | // Valid path check (simple since we walk from current dir) [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_pool` is never used [INFO] [stdout] --> src/db.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Db { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn get_pool(&self) -> &Pool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/db.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | let path_str = &db_url["sqlite://".len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/db.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | if db_url.starts_with("sqlite://") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 24 ~ if !Path::new(path_str).exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if db_url.starts_with("sqlite://") { [INFO] [stdout] 22 | | if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if db_url.starts_with("sqlite://") [INFO] [stdout] 22 ~ && let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 | } [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | / if let Some(path_str) = db_url.strip_prefix("sqlite://") { [INFO] [stdout] 23 | | if let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Some(path_str) = db_url.strip_prefix("sqlite://") [INFO] [stdout] 23 ~ && let Some(parent) = std::path::Path::new(path_str).parent() { [INFO] [stdout] 24 | let _ = std::fs::create_dir_all(parent); [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | / return JsonRpcResponse { [INFO] [stdout] 144 | | jsonrpc: "2.0".to_string(), [INFO] [stdout] 145 | | result: None, [INFO] [stdout] 146 | | error: None, [INFO] [stdout] 147 | | id: None, [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ JsonRpcResponse { [INFO] [stdout] 144 + jsonrpc: "2.0".to_string(), [INFO] [stdout] 145 + result: None, [INFO] [stdout] 146 + error: None, [INFO] [stdout] 147 + id: None, [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tools.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | / if path.is_file() { [INFO] [stdout] 127 | | if let Some(ext) = path.extension() { [INFO] [stdout] 128 | | if ext.to_string_lossy() == extension { [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 126 ~ if path.is_file() [INFO] [stdout] 127 ~ && let Some(ext) = path.extension() { [INFO] [stdout] 128 | if ext.to_string_lossy() == extension { [INFO] [stdout] ... [INFO] [stdout] 133 | } [INFO] [stdout] 134 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tools.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | / if let Some(ext) = path.extension() { [INFO] [stdout] 128 | | if ext.to_string_lossy() == extension { [INFO] [stdout] 129 | | // Valid path check (simple since we walk from current dir) [INFO] [stdout] 130 | | if let Ok(rel) = path.strip_prefix(&root) { [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ if let Some(ext) = path.extension() [INFO] [stdout] 128 ~ && ext.to_string_lossy() == extension { [INFO] [stdout] 129 | // Valid path check (simple since we walk from current dir) [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 51.05s [INFO] running `Command { std: "docker" "inspect" "ecf188acd203e62b341e5ce3505ca26b3bde33fc55eafdbe5b4a52ab12d015e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecf188acd203e62b341e5ce3505ca26b3bde33fc55eafdbe5b4a52ab12d015e3", kill_on_drop: false }` [INFO] [stdout] ecf188acd203e62b341e5ce3505ca26b3bde33fc55eafdbe5b4a52ab12d015e3