[INFO] cloning repository https://github.com/kyfreed/buckshot-roulette [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kyfreed/buckshot-roulette" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyfreed%2Fbuckshot-roulette", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyfreed%2Fbuckshot-roulette'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0ee87037d735cbef048ffcfbb5f00a944d3725ca [INFO] linting kyfreed/buckshot-roulette against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkyfreed%2Fbuckshot-roulette" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kyfreed/buckshot-roulette [INFO] finished tweaking git repo https://github.com/kyfreed/buckshot-roulette [INFO] tweaked toml for git repo https://github.com/kyfreed/buckshot-roulette written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kyfreed/buckshot-roulette on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kyfreed/buckshot-roulette already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-ordinal v0.2.0 [INFO] [stderr] Downloaded clearscreen v2.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5de365de6d17e280db4390bd76a06eaac25fc4e2f2c5fddbcef89924e4f4e2ab [INFO] running `Command { std: "docker" "start" "-a" "5de365de6d17e280db4390bd76a06eaac25fc4e2f2c5fddbcef89924e4f4e2ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5de365de6d17e280db4390bd76a06eaac25fc4e2f2c5fddbcef89924e4f4e2ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5de365de6d17e280db4390bd76a06eaac25fc4e2f2c5fddbcef89924e4f4e2ab", kill_on_drop: false }` [INFO] [stdout] 5de365de6d17e280db4390bd76a06eaac25fc4e2f2c5fddbcef89924e4f4e2ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] beb3eb1626415dcc811041678685024cf81e2d69ff82c37074d4a67f0d35c714 [INFO] running `Command { std: "docker" "start" "-a" "beb3eb1626415dcc811041678685024cf81e2d69ff82c37074d4a67f0d35c714", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking num-ordinal v0.2.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking clearscreen v2.0.1 [INFO] [stderr] Checking buckshot-roulette v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / fn use_item( [INFO] [stdout] 125 | | &mut self, [INFO] [stdout] 126 | | item: &Item, [INFO] [stdout] 127 | | target: &mut Player, [INFO] [stdout] ... | [INFO] [stdout] 132 | | dealer_steal_choice: usize, [INFO] [stdout] 133 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | dealer_known_shell: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 273 - dealer_known_shell: &mut Vec>, [INFO] [stdout] 273 + dealer_known_shell: &mut [Option], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 322 | dealer_known_shell: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 322 - dealer_known_shell: &mut Vec>, [INFO] [stdout] 322 + dealer_known_shell: &mut [Option], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 324 | if dealer_known_shell[0] != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `dealer_known_shell[0].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is only used to index `dealer_known_shell` [INFO] [stdout] --> src/main.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 346 | for c in 0..dealer_known_shell.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 346 - for c in 0..dealer_known_shell.len() { [INFO] [stdout] 346 + for in &dealer_known_shell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:597:45 [INFO] [stdout] | [INFO] [stdout] 597 | fn get_choice_from_menu(prompt: &str, menu: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 597 - fn get_choice_from_menu(prompt: &str, menu: &Vec) -> usize { [INFO] [stdout] 597 + fn get_choice_from_menu(prompt: &str, menu: &[String]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:640:34 [INFO] [stdout] | [INFO] [stdout] 640 | let mut loadout: Vec = std::iter::repeat(true) [INFO] [stdout] | __________________________________^ [INFO] [stdout] 641 | | .take(params.0 as usize) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(true, params.0 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:642:16 [INFO] [stdout] | [INFO] [stdout] 642 | .chain(std::iter::repeat(false).take(params.1 as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(false, params.1 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:805:30 [INFO] [stdout] | [INFO] [stdout] 805 | || (coin_flip && !(dealer_known_shell[0] == Some(false))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(dealer_known_shell[0] != Some(false))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / fn use_item( [INFO] [stdout] 125 | | &mut self, [INFO] [stdout] 126 | | item: &Item, [INFO] [stdout] 127 | | target: &mut Player, [INFO] [stdout] ... | [INFO] [stdout] 132 | | dealer_steal_choice: usize, [INFO] [stdout] 133 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | dealer_known_shell: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 273 - dealer_known_shell: &mut Vec>, [INFO] [stdout] 273 + dealer_known_shell: &mut [Option], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 322 | dealer_known_shell: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 322 - dealer_known_shell: &mut Vec>, [INFO] [stdout] 322 + dealer_known_shell: &mut [Option], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 324 | if dealer_known_shell[0] != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `dealer_known_shell[0].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is only used to index `dealer_known_shell` [INFO] [stdout] --> src/main.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 346 | for c in 0..dealer_known_shell.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 346 - for c in 0..dealer_known_shell.len() { [INFO] [stdout] 346 + for in &dealer_known_shell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:597:45 [INFO] [stdout] | [INFO] [stdout] 597 | fn get_choice_from_menu(prompt: &str, menu: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 597 - fn get_choice_from_menu(prompt: &str, menu: &Vec) -> usize { [INFO] [stdout] 597 + fn get_choice_from_menu(prompt: &str, menu: &[String]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:640:34 [INFO] [stdout] | [INFO] [stdout] 640 | let mut loadout: Vec = std::iter::repeat(true) [INFO] [stdout] | __________________________________^ [INFO] [stdout] 641 | | .take(params.0 as usize) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(true, params.0 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/main.rs:642:16 [INFO] [stdout] | [INFO] [stdout] 642 | .chain(std::iter::repeat(false).take(params.1 as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(false, params.1 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:805:30 [INFO] [stdout] | [INFO] [stdout] 805 | || (coin_flip && !(dealer_known_shell[0] == Some(false))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(dealer_known_shell[0] != Some(false))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.15s [INFO] running `Command { std: "docker" "inspect" "beb3eb1626415dcc811041678685024cf81e2d69ff82c37074d4a67f0d35c714", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "beb3eb1626415dcc811041678685024cf81e2d69ff82c37074d4a67f0d35c714", kill_on_drop: false }` [INFO] [stdout] beb3eb1626415dcc811041678685024cf81e2d69ff82c37074d4a67f0d35c714