[INFO] cloning repository https://github.com/kvark/seeker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kvark/seeker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkvark%2Fseeker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkvark%2Fseeker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 99492f48c938c8a94f59372864aba8f5463214a6 [INFO] linting kvark/seeker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkvark%2Fseeker" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kvark/seeker [INFO] finished tweaking git repo https://github.com/kvark/seeker [INFO] tweaked toml for git repo https://github.com/kvark/seeker written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kvark/seeker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kvark/seeker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/kvark/blade` [INFO] [stderr] Updating git repository `https://github.com/kvark/choir` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/gfx-rs/wgpu` [INFO] [stderr] Updating git repository `https://github.com/gfx-rs/rspirv` [INFO] [stderr] Updating git submodule `https://github.com/KhronosGroup/SPIRV-Headers.git` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded is-terminal v0.4.17 [INFO] [stderr] Downloaded cast v0.3.0 [INFO] [stderr] Downloaded instability v0.3.12 [INFO] [stderr] Downloaded raw-window-metal v0.4.0 [INFO] [stderr] Downloaded hidden-trait v0.1.2 [INFO] [stderr] Downloaded tinytemplate v1.2.1 [INFO] [stderr] Downloaded criterion-plot v0.5.0 [INFO] [stderr] Downloaded oorandom v11.1.5 [INFO] [stderr] Downloaded anes v0.1.6 [INFO] [stderr] Downloaded cocoa-foundation v0.1.2 [INFO] [stderr] Downloaded gpu-alloc-ash v0.7.0 [INFO] [stderr] Downloaded objc2-quartz-core v0.3.2 [INFO] [stderr] Downloaded cocoa v0.25.0 [INFO] [stderr] Downloaded ash-window v0.13.0 [INFO] [stderr] Downloaded openxr v0.19.0 [INFO] [stderr] Downloaded criterion v0.5.1 [INFO] [stderr] Downloaded objc2-metal v0.3.2 [INFO] [stderr] Downloaded objc2-ui-kit v0.3.2 [INFO] [stderr] Downloaded openxr-sys v0.11.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05bbeba47c17c2c746e4adfa65683750a2787e0afc44b4ba8f9debfc9515b274 [INFO] running `Command { std: "docker" "start" "-a" "05bbeba47c17c2c746e4adfa65683750a2787e0afc44b4ba8f9debfc9515b274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05bbeba47c17c2c746e4adfa65683750a2787e0afc44b4ba8f9debfc9515b274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05bbeba47c17c2c746e4adfa65683750a2787e0afc44b4ba8f9debfc9515b274", kill_on_drop: false }` [INFO] [stdout] 05bbeba47c17c2c746e4adfa65683750a2787e0afc44b4ba8f9debfc9515b274 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c12054351b33b74734655aacbe511ce18d09b2af8cfa6b506008543b21d426bf [INFO] running `Command { std: "docker" "start" "-a" "c12054351b33b74734655aacbe511ce18d09b2af8cfa6b506008543b21d426bf", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking rayon-core v1.13.0 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking choir v0.7.0 (https://github.com/kvark/choir#207a7b0e) [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking seeker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/analysis.rs:147:16 [INFO] [stdout] | [INFO] [stdout] 147 | if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if !(!alive && count != 3 || count != 2 && count != 3) { [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if (count == 3 || count == 2) && (count == 3 || alive) { [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if count == 3 || alive && count == 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NarrativeTracker` [INFO] [stdout] --> src/narrative.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / pub fn new() -> Self { [INFO] [stdout] 55 | | Self { [INFO] [stdout] 56 | | prev_snapshot: Vec::new(), [INFO] [stdout] 57 | | stats: NarrativeStats::default(), [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 53 + impl Default for NarrativeTracker { [INFO] [stdout] 54 + fn default() -> Self { [INFO] [stdout] 55 + Self::new() [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/render.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | frame.width = w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Frame::<'_> { width: w, height: h, delay: 8, buffer: std::borrow::Cow::Borrowed(&pixels), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/render.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | let mut frame = gif::Frame::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/render.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 81 | if sim.last_step() % frame_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sim.last_step().is_multiple_of(frame_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/render.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | frame.width = w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Frame::<'_> { width: w, height: h, delay: 8, buffer: std::borrow::Cow::Borrowed(&pixels), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/render.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | let mut frame = gif::Frame::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&Coordinates::default()).is_some()` [INFO] [stdout] --> src/sim.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if self.kernel.get(&Coordinates::default()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&Coordinates::default())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/sim.rs:267:76 [INFO] [stdout] | [INFO] [stdout] 267 | proto_kernel[index as usize] = char::from_u32('0' as u32 + weight as u32).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/sim.rs:316:1 [INFO] [stdout] | [INFO] [stdout] 316 | / pub enum Conclusion { [INFO] [stdout] 317 | | Extinct, [INFO] [stdout] | | ------- the second-largest variant carries no data at all [INFO] [stdout] 318 | | Saturate, [INFO] [stdout] 319 | | Done(Statistics, Snap), [INFO] [stdout] | | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] 320 | | Crash, [INFO] [stdout] 321 | | } [INFO] [stdout] | |_^ the entire enum is at least 224 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 319 - Done(Statistics, Snap), [INFO] [stdout] 319 + Done(Statistics, Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/sim.rs:343:10 [INFO] [stdout] | [INFO] [stdout] 319 | Done(Statistics, Snap), [INFO] [stdout] | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] ... [INFO] [stdout] 343 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `sim::Conclusion`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/sim.rs:473:34 [INFO] [stdout] | [INFO] [stdout] 319 | Done(Statistics, Snap), [INFO] [stdout] | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] ... [INFO] [stdout] 473 | pub fn advance(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `sim::Conclusion`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/sim.rs:541:12 [INFO] [stdout] | [INFO] [stdout] 541 | if self.step % narrative::SAMPLE_INTERVAL == 0 && self.stats.period == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.step.is_multiple_of(narrative::SAMPLE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | survivors.sort_by(|a, b| b.fit.cmp(&a.fit)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 - survivors.sort_by(|a, b| b.fit.cmp(&a.fit)); [INFO] [stdout] 92 + survivors.sort_by_key(|b| std::cmp::Reverse(b.fit)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | / ... loop { [INFO] [stdout] 145 | | ... match sim.advance() { [INFO] [stdout] 146 | | ... Ok(_) => {} [INFO] [stdout] 147 | | ... Err(_) => break, [INFO] [stdout] 148 | | ... } [INFO] [stdout] 149 | | ... } [INFO] [stdout] | |_______________________^ help: try: `while let Ok(_) = sim.advance() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:198:22 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|s| PathBuf::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | survivors.sort_by(|a, b| b.fit.cmp(&a.fit)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 - survivors.sort_by(|a, b| b.fit.cmp(&a.fit)); [INFO] [stdout] 92 + survivors.sort_by_key(|b| std::cmp::Reverse(b.fit)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | / ... loop { [INFO] [stdout] 145 | | ... match sim.advance() { [INFO] [stdout] 146 | | ... Ok(_) => {} [INFO] [stdout] 147 | | ... Err(_) => break, [INFO] [stdout] 148 | | ... } [INFO] [stdout] 149 | | ... } [INFO] [stdout] | |_______________________^ help: try: `while let Ok(_) = sim.advance() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:198:22 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|s| PathBuf::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/analysis.rs:147:16 [INFO] [stdout] | [INFO] [stdout] 147 | if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if !(!alive && count != 3 || count != 2 && count != 3) { [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if (count == 3 || count == 2) && (count == 3 || alive) { [INFO] [stdout] | [INFO] [stdout] 147 - if (alive && (count == 2 || count == 3)) || (!alive && count == 3) { [INFO] [stdout] 147 + if count == 3 || alive && count == 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NarrativeTracker` [INFO] [stdout] --> src/narrative.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / pub fn new() -> Self { [INFO] [stdout] 55 | | Self { [INFO] [stdout] 56 | | prev_snapshot: Vec::new(), [INFO] [stdout] 57 | | stats: NarrativeStats::default(), [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 53 + impl Default for NarrativeTracker { [INFO] [stdout] 54 + fn default() -> Self { [INFO] [stdout] 55 + Self::new() [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/render.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | frame.width = w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Frame::<'_> { width: w, height: h, delay: 8, buffer: std::borrow::Cow::Borrowed(&pixels), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/render.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | let mut frame = gif::Frame::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/render.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 81 | if sim.last_step() % frame_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sim.last_step().is_multiple_of(frame_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/render.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | frame.width = w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Frame::<'_> { width: w, height: h, delay: 8, buffer: std::borrow::Cow::Borrowed(&pixels), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/render.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | let mut frame = gif::Frame::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&Coordinates::default()).is_some()` [INFO] [stdout] --> src/sim.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if self.kernel.get(&Coordinates::default()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&Coordinates::default())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/sim.rs:267:76 [INFO] [stdout] | [INFO] [stdout] 267 | proto_kernel[index as usize] = char::from_u32('0' as u32 + weight as u32).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/sim.rs:316:1 [INFO] [stdout] | [INFO] [stdout] 316 | / pub enum Conclusion { [INFO] [stdout] 317 | | Extinct, [INFO] [stdout] | | ------- the second-largest variant carries no data at all [INFO] [stdout] 318 | | Saturate, [INFO] [stdout] 319 | | Done(Statistics, Snap), [INFO] [stdout] | | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] 320 | | Crash, [INFO] [stdout] 321 | | } [INFO] [stdout] | |_^ the entire enum is at least 224 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 319 - Done(Statistics, Snap), [INFO] [stdout] 319 + Done(Statistics, Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/sim.rs:343:10 [INFO] [stdout] | [INFO] [stdout] 319 | Done(Statistics, Snap), [INFO] [stdout] | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] ... [INFO] [stdout] 343 | ) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `sim::Conclusion`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/sim.rs:473:34 [INFO] [stdout] | [INFO] [stdout] 319 | Done(Statistics, Snap), [INFO] [stdout] | ---------------------- the largest variant contains at least 224 bytes [INFO] [stdout] ... [INFO] [stdout] 473 | pub fn advance(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `sim::Conclusion`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/sim.rs:541:12 [INFO] [stdout] | [INFO] [stdout] 541 | if self.step % narrative::SAMPLE_INTERVAL == 0 && self.stats.period == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.step.is_multiple_of(narrative::SAMPLE_INTERVAL)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.25s [INFO] running `Command { std: "docker" "inspect" "c12054351b33b74734655aacbe511ce18d09b2af8cfa6b506008543b21d426bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c12054351b33b74734655aacbe511ce18d09b2af8cfa6b506008543b21d426bf", kill_on_drop: false }` [INFO] [stdout] c12054351b33b74734655aacbe511ce18d09b2af8cfa6b506008543b21d426bf