[INFO] cloning repository https://github.com/krotokrit/postfix-notation-calculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/krotokrit/postfix-notation-calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkrotokrit%2Fpostfix-notation-calculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkrotokrit%2Fpostfix-notation-calculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 78d35370a5f60ae85c9b5dbbe86c1203f6222c56 [INFO] linting krotokrit/postfix-notation-calculator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkrotokrit%2Fpostfix-notation-calculator" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/krotokrit/postfix-notation-calculator [INFO] finished tweaking git repo https://github.com/krotokrit/postfix-notation-calculator [INFO] tweaked toml for git repo https://github.com/krotokrit/postfix-notation-calculator written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/krotokrit/postfix-notation-calculator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/krotokrit/postfix-notation-calculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f9af31a757213d59240a8cc213fb59b8f03e65fa8943ebaf605ec7d45df4e5d [INFO] running `Command { std: "docker" "start" "-a" "6f9af31a757213d59240a8cc213fb59b8f03e65fa8943ebaf605ec7d45df4e5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f9af31a757213d59240a8cc213fb59b8f03e65fa8943ebaf605ec7d45df4e5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f9af31a757213d59240a8cc213fb59b8f03e65fa8943ebaf605ec7d45df4e5d", kill_on_drop: false }` [INFO] [stdout] 6f9af31a757213d59240a8cc213fb59b8f03e65fa8943ebaf605ec7d45df4e5d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4022dfd8731408b31b1ee486decbec8b2b5771465b036f17d137ba6b620154d [INFO] running `Command { std: "docker" "start" "-a" "e4022dfd8731408b31b1ee486decbec8b2b5771465b036f17d137ba6b620154d", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking Calculator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/functions.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | ... while stack.len() > 0 && stack.last().cloned().unwrap() != '(' && operators_priorities[&c] >= operators_priorities[stack.last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/functions.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / loop { [INFO] [stdout] 59 | | if let Some(caps) = re.captures(&postfix_notation) { [INFO] [stdout] 60 | | let first = caps.name("f").unwrap().as_str().parse::().unwrap(); [INFO] [stdout] 61 | | let second = caps.name("s").unwrap().as_str().parse::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(caps) = re.captures(&postfix_notation) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return Default::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return Default::default(); [INFO] [stdout] 103 + Default::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 115 | if !(braces_checker_result == char::default()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(braces_checker_result != char::default())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/functions.rs:111:39 [INFO] [stdout] | [INFO] [stdout] 111 | if infix_notation.chars().any(|c| matches!(c, 'a'..='z')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if infix_notation.chars().any(|c| matches!(c, 'a'..='z')) { [INFO] [stdout] 111 + if infix_notation.chars().any(|c: char| c.is_ascii_lowercase()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/functions.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | ... while stack.len() > 0 && stack.last().cloned().unwrap() != '(' && operators_priorities[&c] >= operators_priorities[stack.last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/functions.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / loop { [INFO] [stdout] 59 | | if let Some(caps) = re.captures(&postfix_notation) { [INFO] [stdout] 60 | | let first = caps.name("f").unwrap().as_str().parse::().unwrap(); [INFO] [stdout] 61 | | let second = caps.name("s").unwrap().as_str().parse::().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(caps) = re.captures(&postfix_notation) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | return Default::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return Default::default(); [INFO] [stdout] 103 + Default::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 115 | if !(braces_checker_result == char::default()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(braces_checker_result != char::default())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/functions.rs:111:39 [INFO] [stdout] | [INFO] [stdout] 111 | if infix_notation.chars().any(|c| matches!(c, 'a'..='z')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 111 - if infix_notation.chars().any(|c| matches!(c, 'a'..='z')) { [INFO] [stdout] 111 + if infix_notation.chars().any(|c: char| c.is_ascii_lowercase()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.68s [INFO] running `Command { std: "docker" "inspect" "e4022dfd8731408b31b1ee486decbec8b2b5771465b036f17d137ba6b620154d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4022dfd8731408b31b1ee486decbec8b2b5771465b036f17d137ba6b620154d", kill_on_drop: false }` [INFO] [stdout] e4022dfd8731408b31b1ee486decbec8b2b5771465b036f17d137ba6b620154d