[INFO] cloning repository https://github.com/kphpkphp/rust-grep [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kphpkphp/rust-grep" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkphpkphp%2Frust-grep", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkphpkphp%2Frust-grep'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cc5b9aa57c7bcc4c1f3e1b3fe3ef53f84bf69822 [INFO] linting kphpkphp/rust-grep against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkphpkphp%2Frust-grep" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kphpkphp/rust-grep [INFO] finished tweaking git repo https://github.com/kphpkphp/rust-grep [INFO] tweaked toml for git repo https://github.com/kphpkphp/rust-grep written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kphpkphp/rust-grep on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kphpkphp/rust-grep already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 461e64c6d3fa1ee0a07fb7263b27a3dd58fcef3dab9ec3af4916640a14dc74b4 [INFO] running `Command { std: "docker" "start" "-a" "461e64c6d3fa1ee0a07fb7263b27a3dd58fcef3dab9ec3af4916640a14dc74b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "461e64c6d3fa1ee0a07fb7263b27a3dd58fcef3dab9ec3af4916640a14dc74b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "461e64c6d3fa1ee0a07fb7263b27a3dd58fcef3dab9ec3af4916640a14dc74b4", kill_on_drop: false }` [INFO] [stdout] 461e64c6d3fa1ee0a07fb7263b27a3dd58fcef3dab9ec3af4916640a14dc74b4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] abe6993f1f2a938267b046960920f166d09262dfc2dd9d166bbb33a552739961 [INFO] running `Command { std: "docker" "start" "-a" "abe6993f1f2a938267b046960920f166d09262dfc2dd9d166bbb33a552739961", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking time-core v0.1.7 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking time v0.3.45 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking rust_grep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/file_read.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::{Path,PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ErrorKind` [INFO] [stdout] --> src/file_read.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{BufRead,BufReader, ErrorKind}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thiserror::Error` [INFO] [stdout] --> src/file_read.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use thiserror::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/content_check.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | search_hit_map:search_hit_map, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `search_hit_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/file_read.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::{Path,PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ErrorKind` [INFO] [stdout] --> src/file_read.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{BufRead,BufReader, ErrorKind}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thiserror::Error` [INFO] [stdout] --> src/file_read.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use thiserror::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/content_check.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | search_hit_map:search_hit_map, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `search_hit_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/content_check.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | data_struct:data_struct, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_struct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash::Hash` [INFO] [stdout] --> src/show.rs:428:15 [INFO] [stdout] | [INFO] [stdout] 428 | use std::{hash::Hash, path::PathBuf}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `show::AppState<'_>` is more private than the item `show::Visualizer::handle_key_event` [INFO] [stdout] --> src/show.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn handle_key_event(app: &mut AppState, key: event::KeyEvent)-> anyhow::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `show::Visualizer::handle_key_event` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `show::AppState<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/show.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | struct AppState<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `show::AppState<'_>` is more private than the item `show::Visualizer::process_key_action` [INFO] [stdout] --> src/show.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn process_key_action(app: &mut AppState) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `show::Visualizer::process_key_action` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `show::AppState<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/show.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | struct AppState<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_path_valid` is never used [INFO] [stdout] --> src/file_read.rs:169:4 [INFO] [stdout] | [INFO] [stdout] 169 | fn check_path_valid(path: &str) -> Result<(), PathReadError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Config` is never constructed [INFO] [stdout] --> src/data_struct.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/data_struct.rs:76:11 [INFO] [stdout] | [INFO] [stdout] 76 | ERROR(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DataStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 76 - ERROR(String), [INFO] [stdout] 76 + ERROR(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data_status` is never read [INFO] [stdout] --> src/data_struct.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct DataStructPackage{ [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 80 | pub data_status: DataStatus, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QueryLine` is never constructed [INFO] [stdout] --> src/data_struct.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct QueryLine{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PageMetaDataContainer` is never constructed [INFO] [stdout] --> src/data_struct.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct PageMetaDataContainer{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_page_metadata`, `get_mut_page_metadata`, and `set_page_metadata` are never used [INFO] [stdout] --> src/data_struct.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 154 | impl PageMetaDataContainer { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] 155 | pub fn get_page_metadata(&self, page_index: usize) -> Option<&PageMetaData> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 161 | pub fn get_mut_page_metadata(&mut self, page_index: usize) -> Option<&mut PageMetaData> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | pub fn set_page_metadata(&mut self,page_index:usize,pmd:PageMetaData)->(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_file_metadata` is never used [INFO] [stdout] --> src/data_struct.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 189 | impl <'a> FilePageContainer<'a>{ [INFO] [stdout] | ------------------------------- method in this implementation [INFO] [stdout] 190 | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `QueryMode` is never used [INFO] [stdout] --> src/content_check.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | enum QueryMode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QueryResultRef` is never constructed [INFO] [stdout] --> src/content_check.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct QueryResultRef<'a>{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mock_fetch_detail` is never used [INFO] [stdout] --> src/show.rs:387:4 [INFO] [stdout] | [INFO] [stdout] 387 | fn mock_fetch_detail<'a>() -> FileContentPage<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUCCESS` contains a capitalized acronym [INFO] [stdout] --> src/data_struct.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | SUCCESS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Success` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERROR` contains a capitalized acronym [INFO] [stdout] --> src/data_struct.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ERROR(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/data_struct.rs:166:74 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn set_page_metadata(&mut self,page_index:usize,pmd:PageMetaData)->(){ [INFO] [stdout] | ^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/content_check.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | .enumerate() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 | //map、filter_map必须有collect()才执行，for_each是直接执行 [INFO] [stdout] 67 ~ .for_each(|data_struct_package| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/show.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Err(e) = Self::process_key_action(app) { [INFO] [stdout] 167 | | return Err(e); [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________________^ help: replace it with: `Self::process_key_action(app)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/show.rs:419:5 [INFO] [stdout] | [INFO] [stdout] 415 | / let fcp = FileContentPage{ [INFO] [stdout] 416 | | query_result_page:&static_ref.query_result[0..static_ref.query_result.len()] [INFO] [stdout] 417 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 418 | [INFO] [stdout] 419 | fcp [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 | [INFO] [stdout] 417 ~ FileContentPage{ [INFO] [stdout] 418 + query_result_page:&static_ref.query_result[0..static_ref.query_result.len()] [INFO] [stdout] 419 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/data_struct.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `show::AppState<'_>` is more private than the item `show::Visualizer::handle_key_event` [INFO] [stdout] --> src/show.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn handle_key_event(app: &mut AppState, key: event::KeyEvent)-> anyhow::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `show::Visualizer::handle_key_event` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `show::AppState<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/show.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | struct AppState<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `show::AppState<'_>` is more private than the item `show::Visualizer::process_key_action` [INFO] [stdout] --> src/show.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn process_key_action(app: &mut AppState) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `show::Visualizer::process_key_action` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `show::AppState<'_>` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/show.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | struct AppState<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_path_valid` is never used [INFO] [stdout] --> src/file_read.rs:169:4 [INFO] [stdout] | [INFO] [stdout] 169 | fn check_path_valid(path: &str) -> Result<(), PathReadError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Config` is never constructed [INFO] [stdout] --> src/data_struct.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct Config { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QueryLine` is never constructed [INFO] [stdout] --> src/data_struct.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct QueryLine{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PageMetaDataContainer` is never constructed [INFO] [stdout] --> src/data_struct.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct PageMetaDataContainer{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_page_metadata`, `get_mut_page_metadata`, and `set_page_metadata` are never used [INFO] [stdout] --> src/data_struct.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 154 | impl PageMetaDataContainer { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] 155 | pub fn get_page_metadata(&self, page_index: usize) -> Option<&PageMetaData> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 161 | pub fn get_mut_page_metadata(&mut self, page_index: usize) -> Option<&mut PageMetaData> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | pub fn set_page_metadata(&mut self,page_index:usize,pmd:PageMetaData)->(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_file_metadata` is never used [INFO] [stdout] --> src/data_struct.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 189 | impl <'a> FilePageContainer<'a>{ [INFO] [stdout] | ------------------------------- method in this implementation [INFO] [stdout] 190 | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `QueryMode` is never used [INFO] [stdout] --> src/content_check.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | enum QueryMode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QueryResultRef` is never constructed [INFO] [stdout] --> src/content_check.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct QueryResultRef<'a>{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mock_fetch_detail` is never used [INFO] [stdout] --> src/show.rs:387:4 [INFO] [stdout] | [INFO] [stdout] 387 | fn mock_fetch_detail<'a>() -> FileContentPage<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUCCESS` contains a capitalized acronym [INFO] [stdout] --> src/data_struct.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | SUCCESS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Success` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERROR` contains a capitalized acronym [INFO] [stdout] --> src/data_struct.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | ERROR(String), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/data_struct.rs:166:74 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn set_page_metadata(&mut self,page_index:usize,pmd:PageMetaData)->(){ [INFO] [stdout] | ^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/content_check.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | .enumerate() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 | //map、filter_map必须有collect()才执行，for_each是直接执行 [INFO] [stdout] 67 ~ .for_each(|data_struct_package| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/content_check.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / let mut dsp_vec = Vec::new(); [INFO] [stdout] 121 | | dsp_vec.push(&data_struct_package); [INFO] [stdout] | |___________________________________________^ help: consider using the `vec![]` macro: `let dsp_vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/show.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Err(e) = Self::process_key_action(app) { [INFO] [stdout] 167 | | return Err(e); [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________________^ help: replace it with: `Self::process_key_action(app)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/show.rs:419:5 [INFO] [stdout] | [INFO] [stdout] 415 | / let fcp = FileContentPage{ [INFO] [stdout] 416 | | query_result_page:&static_ref.query_result[0..static_ref.query_result.len()] [INFO] [stdout] 417 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 418 | [INFO] [stdout] 419 | fcp [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 | [INFO] [stdout] 417 ~ FileContentPage{ [INFO] [stdout] 418 + query_result_page:&static_ref.query_result[0..static_ref.query_result.len()] [INFO] [stdout] 419 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/show.rs:503:46 [INFO] [stdout] | [INFO] [stdout] 503 | let meta1 = FileMetadata { file_path:&file_pathbuf_1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `file_pathbuf_1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/show.rs:504:46 [INFO] [stdout] | [INFO] [stdout] 504 | let meta2 = FileMetadata { file_path:&file_pathbuf_2 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `file_pathbuf_2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/show.rs:594:17 [INFO] [stdout] | [INFO] [stdout] 594 | assert!(!app.current_file_path.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `app.current_file_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/data_struct.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | | [INFO] [stdout] | | | the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 191 | pub fn get_file_metadata(&self)->&Vec> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.67s [INFO] running `Command { std: "docker" "inspect" "abe6993f1f2a938267b046960920f166d09262dfc2dd9d166bbb33a552739961", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abe6993f1f2a938267b046960920f166d09262dfc2dd9d166bbb33a552739961", kill_on_drop: false }` [INFO] [stdout] abe6993f1f2a938267b046960920f166d09262dfc2dd9d166bbb33a552739961