[INFO] cloning repository https://github.com/kovalensky/mnemonic_magnets [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kovalensky/mnemonic_magnets" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkovalensky%2Fmnemonic_magnets", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkovalensky%2Fmnemonic_magnets'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bfc2fce86dec6845ee7951356b33e6d8c78a0c7d [INFO] linting kovalensky/mnemonic_magnets against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkovalensky%2Fmnemonic_magnets" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kovalensky/mnemonic_magnets [INFO] finished tweaking git repo https://github.com/kovalensky/mnemonic_magnets [INFO] tweaked toml for git repo https://github.com/kovalensky/mnemonic_magnets written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kovalensky/mnemonic_magnets on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kovalensky/mnemonic_magnets already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_core v0.9.1 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded rust-embed-impl v8.5.0 [INFO] [stderr] Downloaded rust-embed-utils v8.5.0 [INFO] [stderr] Downloaded serde_json_borrow v0.7.1 [INFO] [stderr] Downloaded crystals-dilithium v1.0.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.18 [INFO] [stderr] Downloaded zerocopy v0.8.18 [INFO] [stderr] Downloaded rust-embed v8.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8edeb207adee0be24cac2bd64037f0846852322dd2a130ce2107f20164605937 [INFO] running `Command { std: "docker" "start" "-a" "8edeb207adee0be24cac2bd64037f0846852322dd2a130ce2107f20164605937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8edeb207adee0be24cac2bd64037f0846852322dd2a130ce2107f20164605937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8edeb207adee0be24cac2bd64037f0846852322dd2a130ce2107f20164605937", kill_on_drop: false }` [INFO] [stdout] 8edeb207adee0be24cac2bd64037f0846852322dd2a130ce2107f20164605937 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd548c0f6a82bea23bb41e3b7d7443182560a02f23fe5dba02c774d986ce474d [INFO] running `Command { std: "docker" "start" "-a" "bd548c0f6a82bea23bb41e3b7d7443182560a02f23fe5dba02c774d986ce474d", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling zerocopy v0.8.18 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking rust-embed-utils v8.5.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking getrandom v0.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking rand_core v0.9.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Checking serde_json_borrow v0.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crystals-dilithium v1.0.0 [INFO] [stderr] Checking mnm v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | encode(&payload, &mode); [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | decode(&payload); [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&dictionary_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&dictionary_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:43:56 [INFO] [stdout] | [INFO] [stdout] 43 | if !hash.chars().all(|c| c.is_ascii_hexdigit()) || hash.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!hash.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | format_text(&"Can't find the hash snippet in dictionary:", 196), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"Can't find the hash snippet in dictionary:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:128:46 [INFO] [stdout] | [INFO] [stdout] 128 | print!("{}", format_text(&"\nEnter the number: ", 250)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"\nEnter the number: "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:158:30 [INFO] [stdout] | [INFO] [stdout] 158 | format_text(&format!("{}", hash_snippet), 196) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `hash_snippet.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | encode(&payload, &mode); [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | decode(&payload); [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&dictionary_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&dictionary_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:43:56 [INFO] [stdout] | [INFO] [stdout] 43 | if !hash.chars().all(|c| c.is_ascii_hexdigit()) || hash.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!hash.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:100:37 [INFO] [stdout] | [INFO] [stdout] 100 | format_text(&"Can't find the hash snippet in dictionary:", 196), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"Can't find the hash snippet in dictionary:"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:128:46 [INFO] [stdout] | [INFO] [stdout] 128 | print!("{}", format_text(&"\nEnter the number: ", 250)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"\nEnter the number: "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:158:30 [INFO] [stdout] | [INFO] [stdout] 158 | format_text(&format!("{}", hash_snippet), 196) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `hash_snippet.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.64s [INFO] running `Command { std: "docker" "inspect" "bd548c0f6a82bea23bb41e3b7d7443182560a02f23fe5dba02c774d986ce474d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd548c0f6a82bea23bb41e3b7d7443182560a02f23fe5dba02c774d986ce474d", kill_on_drop: false }` [INFO] [stdout] bd548c0f6a82bea23bb41e3b7d7443182560a02f23fe5dba02c774d986ce474d