[INFO] cloning repository https://github.com/koeqaife-soft/linkverse-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/koeqaife-soft/linkverse-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkoeqaife-soft%2Flinkverse-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkoeqaife-soft%2Flinkverse-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5e1e039dfa928d756cc2b0b40c6f106ba85e7c4 [INFO] linting koeqaife-soft/linkverse-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkoeqaife-soft%2Flinkverse-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/koeqaife-soft/linkverse-rs [INFO] finished tweaking git repo https://github.com/koeqaife-soft/linkverse-rs [INFO] tweaked toml for git repo https://github.com/koeqaife-soft/linkverse-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/koeqaife-soft/linkverse-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/koeqaife-soft/linkverse-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_with_macros v3.16.1 [INFO] [stderr] Downloaded whoami v1.6.1 [INFO] [stderr] Downloaded postgres-types v0.2.11 [INFO] [stderr] Downloaded validator_derive v0.20.0 [INFO] [stderr] Downloaded float-cmp v0.10.0 [INFO] [stderr] Downloaded fred-macros v0.1.0 [INFO] [stderr] Downloaded crc16 v0.4.0 [INFO] [stderr] Downloaded cookie-factory v0.3.2 [INFO] [stderr] Downloaded postgres-protocol v0.6.9 [INFO] [stderr] Downloaded deadpool-postgres v0.14.1 [INFO] [stderr] Downloaded bytes-utils v0.1.4 [INFO] [stderr] Downloaded icu_properties v2.1.1 [INFO] [stderr] Downloaded tokio-postgres v0.7.15 [INFO] [stderr] Downloaded redis-protocol v6.0.0 [INFO] [stderr] Downloaded schemars v0.9.0 [INFO] [stderr] Downloaded schemars v1.2.0 [INFO] [stderr] Downloaded serde_with v3.16.1 [INFO] [stderr] Downloaded icu_properties_data v2.1.1 [INFO] [stderr] Downloaded fred v10.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f08f5ef7468b09cc6f7167bc477fde671751d0c05d4728e1f54cafe63679ad9 [INFO] running `Command { std: "docker" "start" "-a" "9f08f5ef7468b09cc6f7167bc477fde671751d0c05d4728e1f54cafe63679ad9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f08f5ef7468b09cc6f7167bc477fde671751d0c05d4728e1f54cafe63679ad9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f08f5ef7468b09cc6f7167bc477fde671751d0c05d4728e1f54cafe63679ad9", kill_on_drop: false }` [INFO] [stdout] 9f08f5ef7468b09cc6f7167bc477fde671751d0c05d4728e1f54cafe63679ad9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3a906864a2ec4a73e66cb0589e93656eb178b79a6c467295f7e00c119d06eaa [INFO] running `Command { std: "docker" "start" "-a" "f3a906864a2ec4a73e66cb0589e93656eb178b79a6c467295f7e00c119d06eaa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking phf_shared v0.13.1 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking cookie-factory v0.3.2 [INFO] [stderr] Checking whoami v1.6.1 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking redis-protocol v6.0.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking postgres-protocol v0.6.9 [INFO] [stderr] Checking postgres-types v0.2.11 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Compiling fred-macros v0.1.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking axum-core v0.5.5 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling validator_derive v0.20.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking validator v0.20.0 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking deadpool v0.12.3 [INFO] [stderr] Checking tokio-postgres v0.7.15 [INFO] [stderr] Checking fred v10.1.0 [INFO] [stderr] Checking hyper-util v0.1.18 [INFO] [stderr] Checking axum v0.8.7 [INFO] [stderr] Checking deadpool-postgres v0.14.1 [INFO] [stderr] Checking linkverse-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | is_expired: is_expired, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_expired` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | secret: secret, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | key_type: key_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | is_expired: is_expired, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_expired` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | secret: secret, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils/security.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | key_type: key_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `for_user_id` [INFO] [stdout] --> src/views/for_user.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for_user_id: &i64, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_for_user_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `for_user_id` [INFO] [stdout] --> src/views/for_user.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | pub async fn get_full_post(post: Post, for_user_id: &i64, conn: &mut LazyConn) -> ForUserPostView { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_for_user_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `for_user_id` [INFO] [stdout] --> src/views/for_user.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for_user_id: &i64, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_for_user_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `for_user_id` [INFO] [stdout] --> src/views/for_user.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | pub async fn get_full_post(post: Post, for_user_id: &i64, conn: &mut LazyConn) -> ForUserPostView { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_for_user_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `delete_comment` is never used [INFO] [stdout] --> src/database/comments.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | pub async fn delete_comment(comment_id: &i64, tx: &mut Transaction<'_>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IncorrectParams` is never constructed [INFO] [stdout] --> src/utils/response.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub enum FuncError { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 86 | IncorrectParams, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FuncError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/utils/state.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Config { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 30 | pub secret_auth_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 31 | pub secret_refresh_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub server_id: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 35 | pub total_servers: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub vapid_secret: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 39 | pub vapid_pub: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 40 | pub brevo_api_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cache_redis`, `sessions_redis`, and `pubsub_redis` are never read [INFO] [stdout] --> src/utils/state.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct AppState { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 97 | pub cache_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 98 | pub sessions_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 99 | pub pubsub_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Operation` is never used [INFO] [stdout] --> src/utils/storage.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Operation { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SignedPayload` is never constructed [INFO] [stdout] --> src/utils/storage.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | struct SignedPayload<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_signed_token` is never used [INFO] [stdout] --> src/utils/storage.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn generate_signed_token( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `worker_id` is never read [INFO] [stdout] --> src/utils/thread_state.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | struct ThreadState { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 9 | worker_id: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/comments.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / return Ok(CommentsList { [INFO] [stdout] 229 | | comments, [INFO] [stdout] 230 | | next_cursor, [INFO] [stdout] 231 | | has_more, [INFO] [stdout] 232 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ Ok(CommentsList { [INFO] [stdout] 229 + comments, [INFO] [stdout] 230 + next_cursor, [INFO] [stdout] 231 + has_more, [INFO] [stdout] 232 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database/comments.rs:153:42 [INFO] [stdout] | [INFO] [stdout] 153 | let (i_u, ps, ci) = parse_cursor(&cursor).ok_or("INCORRECT_CURSOR")?; [INFO] [stdout] | ^^^^^^^ help: change this to: `cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/database/comments.rs:212:33 [INFO] [stdout] | [INFO] [stdout] 212 | let has_more = rows.len() > limit.clone() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/database/comments.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if rows.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/auth.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(response(tokens, StatusCode::OK)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(response(tokens, StatusCode::OK)); [INFO] [stdout] 63 + Ok(response(tokens, StatusCode::OK)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `delete_comment` is never used [INFO] [stdout] --> src/database/comments.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | pub async fn delete_comment(comment_id: &i64, tx: &mut Transaction<'_>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IncorrectParams` is never constructed [INFO] [stdout] --> src/utils/response.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub enum FuncError { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 86 | IncorrectParams, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FuncError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/utils/state.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Config { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 30 | pub secret_auth_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 31 | pub secret_refresh_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub server_id: u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 35 | pub total_servers: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub vapid_secret: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 39 | pub vapid_pub: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 40 | pub brevo_api_key: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cache_redis`, `sessions_redis`, and `pubsub_redis` are never read [INFO] [stdout] --> src/utils/state.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct AppState { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 97 | pub cache_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 98 | pub sessions_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 99 | pub pubsub_redis: Arc, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Operation` is never used [INFO] [stdout] --> src/utils/storage.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Operation { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SignedPayload` is never constructed [INFO] [stdout] --> src/utils/storage.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | struct SignedPayload<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generate_signed_token` is never used [INFO] [stdout] --> src/utils/storage.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn generate_signed_token( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `worker_id` is never read [INFO] [stdout] --> src/utils/thread_state.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | struct ThreadState { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 9 | worker_id: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/auth.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 137 | if !validate_username(¶ms.value).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `validate_username(¶ms.value).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/endpoints/auth.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | .map_err(|e| AppError::Unauthorized(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AppError::Unauthorized` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/database/comments.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / return Ok(CommentsList { [INFO] [stdout] 229 | | comments, [INFO] [stdout] 230 | | next_cursor, [INFO] [stdout] 231 | | has_more, [INFO] [stdout] 232 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ Ok(CommentsList { [INFO] [stdout] 229 + comments, [INFO] [stdout] 230 + next_cursor, [INFO] [stdout] 231 + has_more, [INFO] [stdout] 232 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database/comments.rs:153:42 [INFO] [stdout] | [INFO] [stdout] 153 | let (i_u, ps, ci) = parse_cursor(&cursor).ok_or("INCORRECT_CURSOR")?; [INFO] [stdout] | ^^^^^^^ help: change this to: `cursor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/database/comments.rs:212:33 [INFO] [stdout] | [INFO] [stdout] 212 | let has_more = rows.len() > limit.clone() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/database/comments.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if rows.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/comments.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(response(comment, StatusCode::CREATED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(response(comment, StatusCode::CREATED)); [INFO] [stdout] 91 + Ok(response(comment, StatusCode::CREATED)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/endpoints/comments.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / async fn load_comments_with_replies( [INFO] [stdout] 128 | | post_id: &i64, [INFO] [stdout] 129 | | parent_id: &Option, [INFO] [stdout] 130 | | user_id: &i64, [INFO] [stdout] ... | [INFO] [stdout] 135 | | r#type: &Option, [INFO] [stdout] 136 | | ) -> Result, &'static str> { [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/endpoints/comments.rs:189:40 [INFO] [stdout] | [INFO] [stdout] 189 | get_full_comment_by_id(&comment, &session.user_id, &mut conn).await [INFO] [stdout] | ^^^^^^^^ help: change this to: `comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/auth.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(response(tokens, StatusCode::OK)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(response(tokens, StatusCode::OK)); [INFO] [stdout] 63 + Ok(response(tokens, StatusCode::OK)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/endpoints/posts.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | } else if lang.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lang.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/posts.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(response(post, StatusCode::CREATED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(response(post, StatusCode::CREATED)); [INFO] [stdout] 176 + Ok(response(post, StatusCode::CREATED)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/posts.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return Ok(StatusCode::NO_CONTENT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ok(StatusCode::NO_CONTENT); [INFO] [stdout] 204 + Ok(StatusCode::NO_CONTENT) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/auth.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 137 | if !validate_username(¶ms.value).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `validate_username(¶ms.value).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/endpoints/auth.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | .map_err(|e| AppError::Unauthorized(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AppError::Unauthorized` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/comments.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(response(comment, StatusCode::CREATED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(response(comment, StatusCode::CREATED)); [INFO] [stdout] 91 + Ok(response(comment, StatusCode::CREATED)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/endpoints/comments.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / async fn load_comments_with_replies( [INFO] [stdout] 128 | | post_id: &i64, [INFO] [stdout] 129 | | parent_id: &Option, [INFO] [stdout] 130 | | user_id: &i64, [INFO] [stdout] ... | [INFO] [stdout] 135 | | r#type: &Option, [INFO] [stdout] 136 | | ) -> Result, &'static str> { [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/endpoints/comments.rs:189:40 [INFO] [stdout] | [INFO] [stdout] 189 | get_full_comment_by_id(&comment, &session.user_id, &mut conn).await [INFO] [stdout] | ^^^^^^^^ help: change this to: `comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/endpoints/posts.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | } else if lang.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lang.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/posts.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(response(post, StatusCode::CREATED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(response(post, StatusCode::CREATED)); [INFO] [stdout] 176 + Ok(response(post, StatusCode::CREATED)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/endpoints/posts.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return Ok(StatusCode::NO_CONTENT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ok(StatusCode::NO_CONTENT); [INFO] [stdout] 204 + Ok(StatusCode::NO_CONTENT) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/extractors/auth.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | let decoded = decode_token(token, Some("access")).map_err(|e| AppError::Unauthorized(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AppError::Unauthorized` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/security.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | let payload = b64_encode(&combined.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `combined.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/security.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | if !verify_hmac_b64(&payload, signature, &CONFIG.signature_key) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/utils/snowflake.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | (worker_id as u64) <= max_pid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `worker_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/state.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | pub static CONFIG: Lazy = Lazy::new(|| Config::from_env()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Config::from_env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | DELETE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | GET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAD` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | HEAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/utils/storage.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl ToString for Operation { [INFO] [stdout] 22 | | fn to_string(&self) -> String { [INFO] [stdout] 23 | | match self { [INFO] [stdout] 24 | | Operation::PUT => "PUT".into(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/storage.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | &config.cdn_secret_key.as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.cdn_secret_key.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/utils/thread_state.rs:14:50 [INFO] [stdout] | [INFO] [stdout] 14 | static STATE: RefCell> = RefCell::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/extractors/auth.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | let decoded = decode_token(token, Some("access")).map_err(|e| AppError::Unauthorized(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `AppError::Unauthorized` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/security.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | let payload = b64_encode(&combined.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `combined.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/security.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | if !verify_hmac_b64(&payload, signature, &CONFIG.signature_key) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/utils/snowflake.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | (worker_id as u64) <= max_pid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `worker_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/state.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | pub static CONFIG: Lazy = Lazy::new(|| Config::from_env()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Config::from_env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | DELETE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | GET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAD` contains a capitalized acronym [INFO] [stdout] --> src/utils/storage.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | HEAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/utils/storage.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl ToString for Operation { [INFO] [stdout] 22 | | fn to_string(&self) -> String { [INFO] [stdout] 23 | | match self { [INFO] [stdout] 24 | | Operation::PUT => "PUT".into(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/storage.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | &config.cdn_secret_key.as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.cdn_secret_key.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/utils/thread_state.rs:14:50 [INFO] [stdout] | [INFO] [stdout] 14 | static STATE: RefCell> = RefCell::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.43s [INFO] running `Command { std: "docker" "inspect" "f3a906864a2ec4a73e66cb0589e93656eb178b79a6c467295f7e00c119d06eaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3a906864a2ec4a73e66cb0589e93656eb178b79a6c467295f7e00c119d06eaa", kill_on_drop: false }` [INFO] [stdout] f3a906864a2ec4a73e66cb0589e93656eb178b79a6c467295f7e00c119d06eaa