[INFO] cloning repository https://github.com/kmark43/rgit
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kmark43/rgit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmark43%2Frgit", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmark43%2Frgit'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0b00c7eca415ce8d733a84f0ebf5ca7ec8d19170
[INFO] linting kmark43/rgit against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmark43%2Frgit" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/kmark43/rgit
[INFO] finished tweaking git repo https://github.com/kmark43/rgit
[INFO] tweaked toml for git repo https://github.com/kmark43/rgit written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/kmark43/rgit on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/kmark43/rgit already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded is_executable v1.0.5
[INFO] [stderr]   Downloaded wasm-bindgen-shared v0.2.101
[INFO] [stderr]   Downloaded wasm-bindgen-macro-support v0.2.101
[INFO] [stderr]   Downloaded wasm-bindgen-macro v0.2.101
[INFO] [stderr]   Downloaded wasm-bindgen v0.2.101
[INFO] [stderr]   Downloaded find-msvc-tools v0.1.1
[INFO] [stderr]   Downloaded wasm-bindgen-backend v0.2.101
[INFO] [stderr]   Downloaded js-sys v0.3.78
[INFO] [stderr]   Downloaded cc v1.2.36
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b2c431bd093c971887b9d4c1449197232adeb833231fd382f74d8ba067628562
[INFO] running `Command { std: "docker" "start" "-a" "b2c431bd093c971887b9d4c1449197232adeb833231fd382f74d8ba067628562", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b2c431bd093c971887b9d4c1449197232adeb833231fd382f74d8ba067628562", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b2c431bd093c971887b9d4c1449197232adeb833231fd382f74d8ba067628562", kill_on_drop: false }`
[INFO] [stdout] b2c431bd093c971887b9d4c1449197232adeb833231fd382f74d8ba067628562
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c7b9124273004e4e5470199838e726c6df7c18c5a7ba34801c4ae5e7b0eb5947
[INFO] running `Command { std: "docker" "start" "-a" "c7b9124273004e4e5470199838e726c6df7c18c5a7ba34801c4ae5e7b0eb5947", kill_on_drop: false }`
[INFO] [stderr]     Checking cfg-if v1.0.3
[INFO] [stderr]    Compiling crc32fast v1.5.0
[INFO] [stderr]     Checking memchr v2.7.5
[INFO] [stderr]     Checking regex-automata v0.4.10
[INFO] [stderr]     Checking iana-time-zone v0.1.63
[INFO] [stderr]     Checking glob v0.3.3
[INFO] [stderr]     Checking colored v3.0.0
[INFO] [stderr]     Checking is_executable v1.0.5
[INFO] [stderr]     Checking hex v0.4.3
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]     Checking miniz_oxide v0.8.9
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking sha1 v0.10.6
[INFO] [stderr]     Checking flate2 v1.1.2
[INFO] [stderr]     Checking bstr v1.12.0
[INFO] [stderr]     Checking chrono v0.4.42
[INFO] [stderr]     Checking rgit v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `colored::*`
[INFO] [stdout]  --> src/command/diff.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use colored::*;
[INFO] [stdout]   |     ^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `colored::*`
[INFO] [stdout]  --> src/command/diff.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use colored::*;
[INFO] [stdout]   |     ^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/git/index.rs:41:13
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let mut entries: Vec<IndexEntry> = Vec::new();
[INFO] [stdout]    |             ----^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/git/index.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let mut bytes = reader.read_to_end(&mut array).unwrap();
[INFO] [stdout]    |             ----^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `entries`
[INFO] [stdout]   --> src/git/index.rs:41:13
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let mut entries: Vec<IndexEntry> = Vec::new();
[INFO] [stdout]    |             ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_entries`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `bytes`
[INFO] [stdout]   --> src/git/index.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let mut bytes = reader.read_to_end(&mut array).unwrap();
[INFO] [stdout]    |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `committer` and `timezone` are never read
[INFO] [stdout]   --> src/git/object/commit.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct Commit {
[INFO] [stdout]    |            ------ fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     pub committer: String,
[INFO] [stdout]    |         ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 19 |     pub timezone: String,
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]   --> src/git/object/commit.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 28 | impl Commit {
[INFO] [stdout]    | ----------- associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 36 |     pub fn new(hash: String, tree: String, parent: Option<String>, author: String, committer: String, message: String, timestamp: St...
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `hash` is never read
[INFO] [stdout]   --> src/git/object/tree.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 28 | pub struct Tree {
[INFO] [stdout]    |            ---- field in this struct
[INFO] [stdout] 29 |     pub hash: String,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Tree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `hash` is never read
[INFO] [stdout]  --> src/git/object/blob.rs:9:9
[INFO] [stdout]   |
[INFO] [stdout] 8 | pub struct Blob {
[INFO] [stdout]   |            ---- field in this struct
[INFO] [stdout] 9 |     pub hash: String,
[INFO] [stdout]   |         ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: multiple fields are never read
[INFO] [stdout]   --> src/git/index.rs:5:9
[INFO] [stdout]    |
[INFO] [stdout]  4 | pub struct IndexEntry {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout]  5 |     pub ctime: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]  6 |     pub ctime_nsec: u32,
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]  7 |     pub mtime: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]  8 |     pub mtime_nsec: u32,
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]  9 |     pub device: u32,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 10 |     pub inode: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout] 11 |     pub mode: u32,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout] 12 |     pub uid: u32,
[INFO] [stdout]    |         ^^^
[INFO] [stdout] 13 |     pub gid: u32,
[INFO] [stdout]    |         ^^^
[INFO] [stdout] 14 |     pub size: u32,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout] 15 |     pub sha1: String,
[INFO] [stdout] 16 |     pub flags: u16,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `version` and `num_entries` are never read
[INFO] [stdout]   --> src/git/index.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 27 | pub struct Index {
[INFO] [stdout]    |            ----- fields in this struct
[INFO] [stdout] 28 |     pub version: u32,
[INFO] [stdout]    |         ^^^^^^^
[INFO] [stdout] 29 |     pub num_entries: u32,
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Index` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `Created` is never constructed
[INFO] [stdout]   --> src/command/diff.rs:67:5
[INFO] [stdout]    |
[INFO] [stdout] 66 | enum FileStatus {
[INFO] [stdout]    |      ---------- variant in this enum
[INFO] [stdout] 67 |     Created,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `FileStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `status` and `new_hash` are never read
[INFO] [stdout]   --> src/command/diff.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 73 | struct ChangedFile {
[INFO] [stdout]    |        ----------- fields in this struct
[INFO] [stdout] 74 |     pub path: String,
[INFO] [stdout] 75 |     pub status: FileStatus,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 76 |     pub old_hash: Option<String>,
[INFO] [stdout] 77 |     pub new_hash: Option<String>,
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `ChangedFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/git/object/commit.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 |     pub fn new(hash: String, tree: String, parent: Option<String>, author: String, committer: String, message: String, timestamp: String, timezone: String) -> Self {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:61:35
[INFO] [stdout]    |
[INFO] [stdout] 61 |                 let commit_line = &line[7..]; // Remove "commit " prefix
[INFO] [stdout]    |                                   ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:58:20
[INFO] [stdout]    |
[INFO] [stdout] 58 |             } else if line.starts_with("commit ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]    = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 58 ~             } else if let Some(commit_line) = line.strip_prefix("commit ") {
[INFO] [stdout] 59 |                 // Handle case where commit and tree are on the same line
[INFO] [stdout] 60 |                 // Format: "commit 256tree ff63d4cfd34fa7fa36d42aa90e55ae7cefad0f17"
[INFO] [stdout] 61 ~                 // Remove "commit " prefix
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:63:28
[INFO] [stdout]    |
[INFO] [stdout] 63 |                     tree = commit_line[5..].to_string(); // Remove "tree " prefix
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:62:17
[INFO] [stdout]    |
[INFO] [stdout] 62 |                 if commit_line.starts_with("tree ") {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 62 ~                 if let Some(<stripped>) = commit_line.strip_prefix("tree ") {
[INFO] [stdout] 63 ~                     tree = <stripped>.to_string(); // Remove "tree " prefix
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:75:24
[INFO] [stdout]    |
[INFO] [stdout] 75 |                 tree = line[5..].to_string();
[INFO] [stdout]    |                        ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:74:20
[INFO] [stdout]    |
[INFO] [stdout] 74 |             } else if line.starts_with("tree ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 74 ~             } else if let Some(<stripped>) = line.strip_prefix("tree ") {
[INFO] [stdout] 75 ~                 tree = <stripped>.to_string();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:77:31
[INFO] [stdout]    |
[INFO] [stdout] 77 |                 parent = Some(line[7..].to_string());
[INFO] [stdout]    |                               ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:76:20
[INFO] [stdout]    |
[INFO] [stdout] 76 |             } else if line.starts_with("parent ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 76 ~             } else if let Some(<stripped>) = line.strip_prefix("parent ") {
[INFO] [stdout] 77 ~                 parent = Some(<stripped>.to_string());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:79:35
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 let author_line = &line[7..];
[INFO] [stdout]    |                                   ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:78:20
[INFO] [stdout]    |
[INFO] [stdout] 78 |             } else if line.starts_with("author ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 78 ~             } else if let Some(author_line) = line.strip_prefix("author ") {
[INFO] [stdout] 79 ~                 if let Some(space_pos) = author_line.rfind(' ') {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:88:38
[INFO] [stdout]    |
[INFO] [stdout] 88 |                 let committer_line = &line[10..];
[INFO] [stdout]    |                                      ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:87:20
[INFO] [stdout]    |
[INFO] [stdout] 87 |             } else if line.starts_with("committer ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 87 ~             } else if let Some(committer_line) = line.strip_prefix("committer ") {
[INFO] [stdout] 88 ~                 if let Some(space_pos) = committer_line.rfind(' ') {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/git/index.rs:41:13
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let mut entries: Vec<IndexEntry> = Vec::new();
[INFO] [stdout]    |             ----^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/git/index.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let mut bytes = reader.read_to_end(&mut array).unwrap();
[INFO] [stdout]    |             ----^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `entries`
[INFO] [stdout]   --> src/git/index.rs:41:13
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let mut entries: Vec<IndexEntry> = Vec::new();
[INFO] [stdout]    |             ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_entries`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `bytes`
[INFO] [stdout]   --> src/git/index.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |         let mut bytes = reader.read_to_end(&mut array).unwrap();
[INFO] [stdout]    |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/git/object/tree.rs:116:21
[INFO] [stdout]     |
[INFO] [stdout] 116 |         hex::encode(&hash)
[INFO] [stdout]     |                     ^^^^^ help: change this to: `hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/git/object/tree.rs:134:65
[INFO] [stdout]     |
[INFO] [stdout] 134 |             tree_bytes.extend_from_slice(&Tree::write_dir_entry(&entry));
[INFO] [stdout]     |                                                                 ^^^^^^ help: change this to: `entry`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/git/object/tree.rs:140:32
[INFO] [stdout]     |
[INFO] [stdout] 140 |         let hash = hex::encode(&hash);
[INFO] [stdout]     |                                ^^^^^ help: change this to: `hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/git/object/tree.rs:154:31
[INFO] [stdout]     |
[INFO] [stdout] 154 |               if path.is_file() {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 155 | |                 dir_files.insert(entry.file_name().to_string_lossy().to_string());
[INFO] [stdout] 156 | |             } else {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/git/object/tree.rs:156:20
[INFO] [stdout]     |
[INFO] [stdout] 156 |               } else {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 157 | |                 dir_files.insert(entry.file_name().to_string_lossy().to_string());
[INFO] [stdout] 158 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/git/object/tree.rs:165:47
[INFO] [stdout]     |
[INFO] [stdout] 165 |         let dir_files = Tree::read_dir_to_set(&path);
[INFO] [stdout]     |                                               ^^^^^ help: change this to: `path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:41:31
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let file = File::open(&path).unwrap();
[INFO] [stdout]    |                               ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:59:32
[INFO] [stdout]    |
[INFO] [stdout] 59 |         let hash = hex::encode(&hash);
[INFO] [stdout]    |                                ^^^^^ help: change this to: `hash`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:67:27
[INFO] [stdout]    |
[INFO] [stdout] 67 |     let file = File::open(&path).unwrap();
[INFO] [stdout]    |                           ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:83:17
[INFO] [stdout]    |
[INFO] [stdout] 83 |     hex::encode(&hash)
[INFO] [stdout]    |                 ^^^^^ help: change this to: `hash`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/git/object/objectreader.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         return "commit";
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         return "commit";
[INFO] [stdout] 30 +         "commit"
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/head.rs:16:31
[INFO] [stdout]    |
[INFO] [stdout] 16 |         let file = File::open(&path).unwrap();
[INFO] [stdout]    |                               ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/git/head.rs:54:67
[INFO] [stdout]    |
[INFO] [stdout] 54 |         Self::from_file(&PathBuf::from(format!(".git/{}", ref_path.to_string())))
[INFO] [stdout]    |                                                                   ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (13/7)
[INFO] [stdout]   --> src/git/index.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     pub fn new(ctime: u32, ctime_nsec: u32, mtime: u32, mtime_nsec: u32, device: u32, inode: u32, mode: u32, uid: u32, gid: u32, size: u32, sha1: String, flags: u16, name: String) -> Self {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:50:12
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if version.unwrap() != 2 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:51:55
[INFO] [stdout]    |
[INFO] [stdout] 51 |             println!("Unsupported index version: {}", version.unwrap());
[INFO] [stdout]    |                                                       ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |         for _ in 0..num_entries.unwrap() {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:54:27
[INFO] [stdout]    |
[INFO] [stdout] 54 |         let num_entries = Some(u32::from_be_bytes(array[8..12].try_into().unwrap()));
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `committer` and `timezone` are never read
[INFO] [stdout]   --> src/git/object/commit.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct Commit {
[INFO] [stdout]    |            ------ fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     pub committer: String,
[INFO] [stdout]    |         ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 19 |     pub timezone: String,
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]   --> src/git/object/commit.rs:36:12
[INFO] [stdout]    |
[INFO] [stdout] 28 | impl Commit {
[INFO] [stdout]    | ----------- associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 36 |     pub fn new(hash: String, tree: String, parent: Option<String>, author: String, committer: String, message: String, timestamp: St...
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `hash` is never read
[INFO] [stdout]   --> src/git/object/tree.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 28 | pub struct Tree {
[INFO] [stdout]    |            ---- field in this struct
[INFO] [stdout] 29 |     pub hash: String,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Tree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `hash` is never read
[INFO] [stdout]  --> src/git/object/blob.rs:9:9
[INFO] [stdout]   |
[INFO] [stdout] 8 | pub struct Blob {
[INFO] [stdout]   |            ---- field in this struct
[INFO] [stdout] 9 |     pub hash: String,
[INFO] [stdout]   |         ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: multiple fields are never read
[INFO] [stdout]   --> src/git/index.rs:5:9
[INFO] [stdout]    |
[INFO] [stdout]  4 | pub struct IndexEntry {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout]  5 |     pub ctime: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]  6 |     pub ctime_nsec: u32,
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]  7 |     pub mtime: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]  8 |     pub mtime_nsec: u32,
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]  9 |     pub device: u32,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 10 |     pub inode: u32,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout] 11 |     pub mode: u32,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout] 12 |     pub uid: u32,
[INFO] [stdout]    |         ^^^
[INFO] [stdout] 13 |     pub gid: u32,
[INFO] [stdout]    |         ^^^
[INFO] [stdout] 14 |     pub size: u32,
[INFO] [stdout]    |         ^^^^
[INFO] [stdout] 15 |     pub sha1: String,
[INFO] [stdout] 16 |     pub flags: u16,
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `IndexEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `version` and `num_entries` are never read
[INFO] [stdout]   --> src/git/index.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 27 | pub struct Index {
[INFO] [stdout]    |            ----- fields in this struct
[INFO] [stdout] 28 |     pub version: u32,
[INFO] [stdout]    |         ^^^^^^^
[INFO] [stdout] 29 |     pub num_entries: u32,
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Index` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `Created` is never constructed
[INFO] [stdout]   --> src/command/diff.rs:67:5
[INFO] [stdout]    |
[INFO] [stdout] 66 | enum FileStatus {
[INFO] [stdout]    |      ---------- variant in this enum
[INFO] [stdout] 67 |     Created,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `FileStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `status` and `new_hash` are never read
[INFO] [stdout]   --> src/command/diff.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 73 | struct ChangedFile {
[INFO] [stdout]    |        ----------- fields in this struct
[INFO] [stdout] 74 |     pub path: String,
[INFO] [stdout] 75 |     pub status: FileStatus,
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout] 76 |     pub old_hash: Option<String>,
[INFO] [stdout] 77 |     pub new_hash: Option<String>,
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `ChangedFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/git/index.rs:74:13
[INFO] [stdout]    |
[INFO] [stdout] 74 |             offset = offset + offset_rem;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += offset_rem`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/git/index.rs:75:13
[INFO] [stdout]    |
[INFO] [stdout] 75 |             index = index + offset;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += offset`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:78:19
[INFO] [stdout]    |
[INFO] [stdout] 78 |         Self::new(version.unwrap(), entries)
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> src/git/object/commit.rs:36:5
[INFO] [stdout]    |
[INFO] [stdout] 36 |     pub fn new(hash: String, tree: String, parent: Option<String>, author: String, committer: String, message: String, timestamp: String, timezone: String) -> Self {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:61:35
[INFO] [stdout]    |
[INFO] [stdout] 61 |                 let commit_line = &line[7..]; // Remove "commit " prefix
[INFO] [stdout]    |                                   ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:58:20
[INFO] [stdout]    |
[INFO] [stdout] 58 |             } else if line.starts_with("commit ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout]    = note: `#[warn(clippy::manual_strip)]` on by default
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 58 ~             } else if let Some(commit_line) = line.strip_prefix("commit ") {
[INFO] [stdout] 59 |                 // Handle case where commit and tree are on the same line
[INFO] [stdout] 60 |                 // Format: "commit 256tree ff63d4cfd34fa7fa36d42aa90e55ae7cefad0f17"
[INFO] [stdout] 61 ~                 // Remove "commit " prefix
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:63:28
[INFO] [stdout]    |
[INFO] [stdout] 63 |                     tree = commit_line[5..].to_string(); // Remove "tree " prefix
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:62:17
[INFO] [stdout]    |
[INFO] [stdout] 62 |                 if commit_line.starts_with("tree ") {
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 62 ~                 if let Some(<stripped>) = commit_line.strip_prefix("tree ") {
[INFO] [stdout] 63 ~                     tree = <stripped>.to_string(); // Remove "tree " prefix
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:75:24
[INFO] [stdout]    |
[INFO] [stdout] 75 |                 tree = line[5..].to_string();
[INFO] [stdout]    |                        ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:74:20
[INFO] [stdout]    |
[INFO] [stdout] 74 |             } else if line.starts_with("tree ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 74 ~             } else if let Some(<stripped>) = line.strip_prefix("tree ") {
[INFO] [stdout] 75 ~                 tree = <stripped>.to_string();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:77:31
[INFO] [stdout]    |
[INFO] [stdout] 77 |                 parent = Some(line[7..].to_string());
[INFO] [stdout]    |                               ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:76:20
[INFO] [stdout]    |
[INFO] [stdout] 76 |             } else if line.starts_with("parent ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 76 ~             } else if let Some(<stripped>) = line.strip_prefix("parent ") {
[INFO] [stdout] 77 ~                 parent = Some(<stripped>.to_string());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:79:35
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 let author_line = &line[7..];
[INFO] [stdout]    |                                   ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:78:20
[INFO] [stdout]    |
[INFO] [stdout] 78 |             } else if line.starts_with("author ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 78 ~             } else if let Some(author_line) = line.strip_prefix("author ") {
[INFO] [stdout] 79 ~                 if let Some(space_pos) = author_line.rfind(' ') {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: stripping a prefix manually
[INFO] [stdout]   --> src/git/object/commit.rs:88:38
[INFO] [stdout]    |
[INFO] [stdout] 88 |                 let committer_line = &line[10..];
[INFO] [stdout]    |                                      ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] note: the prefix was tested here
[INFO] [stdout]   --> src/git/object/commit.rs:87:20
[INFO] [stdout]    |
[INFO] [stdout] 87 |             } else if line.starts_with("committer ") {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
[INFO] [stdout] help: try using the `strip_prefix` method
[INFO] [stdout]    |
[INFO] [stdout] 87 ~             } else if let Some(committer_line) = line.strip_prefix("committer ") {
[INFO] [stdout] 88 ~                 if let Some(space_pos) = committer_line.rfind(' ') {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/git/object/tree.rs:116:21
[INFO] [stdout]     |
[INFO] [stdout] 116 |         hex::encode(&hash)
[INFO] [stdout]     |                     ^^^^^ help: change this to: `hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/git/object/tree.rs:134:65
[INFO] [stdout]     |
[INFO] [stdout] 134 |             tree_bytes.extend_from_slice(&Tree::write_dir_entry(&entry));
[INFO] [stdout]     |                                                                 ^^^^^^ help: change this to: `entry`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/git/object/tree.rs:140:32
[INFO] [stdout]     |
[INFO] [stdout] 140 |         let hash = hex::encode(&hash);
[INFO] [stdout]     |                                ^^^^^ help: change this to: `hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/git/object/tree.rs:154:31
[INFO] [stdout]     |
[INFO] [stdout] 154 |               if path.is_file() {
[INFO] [stdout]     |  _______________________________^
[INFO] [stdout] 155 | |                 dir_files.insert(entry.file_name().to_string_lossy().to_string());
[INFO] [stdout] 156 | |             } else {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/git/object/tree.rs:156:20
[INFO] [stdout]     |
[INFO] [stdout] 156 |               } else {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 157 | |                 dir_files.insert(entry.file_name().to_string_lossy().to_string());
[INFO] [stdout] 158 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/checkout.rs:7:23
[INFO] [stdout]   |
[INFO] [stdout] 7 | pub fn checkout(args: &Vec<String>) {
[INFO] [stdout]   |                       ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 7 - pub fn checkout(args: &Vec<String>) {
[INFO] [stdout] 7 + pub fn checkout(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/checkout.rs:13:40
[INFO] [stdout]    |
[INFO] [stdout] 13 |     let head = head::Head::from_branch(&branch);
[INFO] [stdout]    |                                        ^^^^^^^ help: change this to: `branch`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/checkout.rs:17:39
[INFO] [stdout]    |
[INFO] [stdout] 17 |     head::Head::update_head_to_branch(&branch);
[INFO] [stdout]    |                                       ^^^^^^^ help: change this to: `branch`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/log.rs:5:18
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn log(args: &Vec<String>) {
[INFO] [stdout]   |                  ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - pub fn log(args: &Vec<String>) {
[INFO] [stdout] 5 + pub fn log(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/git/object/tree.rs:165:47
[INFO] [stdout]     |
[INFO] [stdout] 165 |         let dir_files = Tree::read_dir_to_set(&path);
[INFO] [stdout]     |                                               ^^^^^ help: change this to: `path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/status.rs:27:31
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 path.push_str(&dir);
[INFO] [stdout]    |                               ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/status.rs:29:17
[INFO] [stdout]    |
[INFO] [stdout] 29 |                 path.push_str("/");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `path.push('/')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]    = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:41:31
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let file = File::open(&path).unwrap();
[INFO] [stdout]    |                               ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:59:32
[INFO] [stdout]    |
[INFO] [stdout] 59 |         let hash = hex::encode(&hash);
[INFO] [stdout]    |                                ^^^^^ help: change this to: `hash`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:67:27
[INFO] [stdout]    |
[INFO] [stdout] 67 |     let file = File::open(&path).unwrap();
[INFO] [stdout]    |                           ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/object/blob.rs:83:17
[INFO] [stdout]    |
[INFO] [stdout] 83 |     hex::encode(&hash)
[INFO] [stdout]    |                 ^^^^^ help: change this to: `hash`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/git/object/objectreader.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         return "commit";
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         return "commit";
[INFO] [stdout] 30 +         "commit"
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/git/head.rs:16:31
[INFO] [stdout]    |
[INFO] [stdout] 16 |         let file = File::open(&path).unwrap();
[INFO] [stdout]    |                               ^^^^^ help: change this to: `path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/command/status.rs:147:12
[INFO] [stdout]     |
[INFO] [stdout] 147 |         if !tree_file.is_none() && file.hash != tree_file.unwrap().hash {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `tree_file.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/command/status.rs:137:28
[INFO] [stdout]     |
[INFO] [stdout] 137 |     create_tree_files(".", &tree, &mut tree_files, gitignore);
[INFO] [stdout]     |                            ^^^^^ help: change this to: `tree`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/git/head.rs:54:67
[INFO] [stdout]    |
[INFO] [stdout] 54 |         Self::from_file(&PathBuf::from(format!(".git/{}", ref_path.to_string())))
[INFO] [stdout]    |                                                                   ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/status.rs:158:23
[INFO] [stdout]     |
[INFO] [stdout] 158 | fn print_files(files: &Vec<ChangedFile>) {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 158 - fn print_files(files: &Vec<ChangedFile>) {
[INFO] [stdout] 158 + fn print_files(files: &[ChangedFile]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (13/7)
[INFO] [stdout]   --> src/git/index.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     pub fn new(ctime: u32, ctime_nsec: u32, mtime: u32, mtime_nsec: u32, device: u32, inode: u32, mode: u32, uid: u32, gid: u32, size: u32, sha1: String, flags: u16, name: String) -> Self {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/status.rs:174:21
[INFO] [stdout]     |
[INFO] [stdout] 174 | pub fn status(args: &Vec<String>) {
[INFO] [stdout]     |                     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 174 - pub fn status(args: &Vec<String>) {
[INFO] [stdout] 174 + pub fn status(args: &[String]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:50:12
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if version.unwrap() != 2 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:51:55
[INFO] [stdout]    |
[INFO] [stdout] 51 |             println!("Unsupported index version: {}", version.unwrap());
[INFO] [stdout]    |                                                       ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |         for _ in 0..num_entries.unwrap() {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:54:27
[INFO] [stdout]    |
[INFO] [stdout] 54 |         let num_entries = Some(u32::from_be_bytes(array[8..12].try_into().unwrap()));
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/read_index.rs:3:25
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn read_index(args: &Vec<String>) {
[INFO] [stdout]   |                         ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 3 - pub fn read_index(args: &Vec<String>) {
[INFO] [stdout] 3 + pub fn read_index(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/read_tree.rs:5:24
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn read_tree(args: &Vec<String>) {
[INFO] [stdout]   |                        ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - pub fn read_tree(args: &Vec<String>) {
[INFO] [stdout] 5 + pub fn read_tree(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/git/index.rs:74:13
[INFO] [stdout]    |
[INFO] [stdout] 74 |             offset = offset + offset_rem;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += offset_rem`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/git/index.rs:75:13
[INFO] [stdout]    |
[INFO] [stdout] 75 |             index = index + offset;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += offset`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `unwrap()` on `Some` value
[INFO] [stdout]   --> src/git/index.rs:78:19
[INFO] [stdout]    |
[INFO] [stdout] 78 |         Self::new(version.unwrap(), entries)
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: remove the `Some` and `unwrap()`
[INFO] [stdout]   --> src/git/index.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let version = Some(u32::from_be_bytes(array[4..8].try_into().unwrap()));
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/command/diff.rs:62:5
[INFO] [stdout]    |
[INFO] [stdout] 62 |     return diff;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 62 -     return diff;
[INFO] [stdout] 62 +     diff
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:15:13
[INFO] [stdout]    |
[INFO] [stdout] 15 |             diff.push_str("\n");
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/checkout.rs:7:23
[INFO] [stdout]   |
[INFO] [stdout] 7 | pub fn checkout(args: &Vec<String>) {
[INFO] [stdout]   |                       ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 7 - pub fn checkout(args: &Vec<String>) {
[INFO] [stdout] 7 + pub fn checkout(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:40:17
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 diff.push_str("\n");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/checkout.rs:13:40
[INFO] [stdout]    |
[INFO] [stdout] 13 |     let head = head::Head::from_branch(&branch);
[INFO] [stdout]    |                                        ^^^^^^^ help: change this to: `branch`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:45:17
[INFO] [stdout]    |
[INFO] [stdout] 45 |                 diff.push_str("\n");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/checkout.rs:17:39
[INFO] [stdout]    |
[INFO] [stdout] 17 |     head::Head::update_head_to_branch(&branch);
[INFO] [stdout]    |                                       ^^^^^^^ help: change this to: `branch`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `old_lines`
[INFO] [stdout]   --> src/command/diff.rs:52:14
[INFO] [stdout]    |
[INFO] [stdout] 52 |     for i in old_index..old_lines.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 52 -     for i in old_index..old_lines.len() {
[INFO] [stdout] 52 +     for <item> in old_lines.iter().skip(old_index) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/log.rs:5:18
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn log(args: &Vec<String>) {
[INFO] [stdout]   |                  ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - pub fn log(args: &Vec<String>) {
[INFO] [stdout] 5 + pub fn log(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         diff.push_str("\n");
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `new_lines`
[INFO] [stdout]   --> src/command/diff.rs:57:14
[INFO] [stdout]    |
[INFO] [stdout] 57 |     for i in new_index..new_lines.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 57 -     for i in new_index..new_lines.len() {
[INFO] [stdout] 57 +     for <item> in new_lines.iter().skip(new_index) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 |         diff.push_str("\n");
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/command/status.rs:27:31
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 path.push_str(&dir);
[INFO] [stdout]    |                               ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/status.rs:29:17
[INFO] [stdout]    |
[INFO] [stdout] 29 |                 path.push_str("/");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `path.push('/')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout]    = note: `#[warn(clippy::single_char_add_str)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/diff.rs:106:19
[INFO] [stdout]     |
[INFO] [stdout] 106 | pub fn diff(args: &Vec<String>) {
[INFO] [stdout]     |                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 106 - pub fn diff(args: &Vec<String>) {
[INFO] [stdout] 106 + pub fn diff(args: &[String]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/command/diff.rs:119:52
[INFO] [stdout]     |
[INFO] [stdout] 119 |         println!("{}", diff_blobs(&Blob::from_hash(&file.old_hash.as_ref().unwrap()), &Blob::from_file(&file.path)));
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file.old_hash.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:102:16
[INFO] [stdout]     |
[INFO] [stdout] 102 | ...   if vec![".git"].contains(&entry.file_name().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_string_lossy...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]     = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:126:16
[INFO] [stdout]     |
[INFO] [stdout] 126 | ...   if vec![".git"].contains(&entry.file_name().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_string_lossy...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:151:16
[INFO] [stdout]     |
[INFO] [stdout] 151 | ...   if vec![".git"].contains(&path.file_name().unwrap().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_stri...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/command/status.rs:147:12
[INFO] [stdout]     |
[INFO] [stdout] 147 |         if !tree_file.is_none() && file.hash != tree_file.unwrap().hash {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `tree_file.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/command/status.rs:137:28
[INFO] [stdout]     |
[INFO] [stdout] 137 |     create_tree_files(".", &tree, &mut tree_files, gitignore);
[INFO] [stdout]     |                            ^^^^^ help: change this to: `tree`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/status.rs:158:23
[INFO] [stdout]     |
[INFO] [stdout] 158 | fn print_files(files: &Vec<ChangedFile>) {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 158 - fn print_files(files: &Vec<ChangedFile>) {
[INFO] [stdout] 158 + fn print_files(files: &[ChangedFile]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/status.rs:174:21
[INFO] [stdout]     |
[INFO] [stdout] 174 | pub fn status(args: &Vec<String>) {
[INFO] [stdout]     |                     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 174 - pub fn status(args: &Vec<String>) {
[INFO] [stdout] 174 + pub fn status(args: &[String]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/read_index.rs:3:25
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn read_index(args: &Vec<String>) {
[INFO] [stdout]   |                         ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 3 - pub fn read_index(args: &Vec<String>) {
[INFO] [stdout] 3 + pub fn read_index(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/command/read_tree.rs:5:24
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn read_tree(args: &Vec<String>) {
[INFO] [stdout]   |                        ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - pub fn read_tree(args: &Vec<String>) {
[INFO] [stdout] 5 + pub fn read_tree(args: &[String]) {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/command/diff.rs:62:5
[INFO] [stdout]    |
[INFO] [stdout] 62 |     return diff;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 62 -     return diff;
[INFO] [stdout] 62 +     diff
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:15:13
[INFO] [stdout]    |
[INFO] [stdout] 15 |             diff.push_str("\n");
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:40:17
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 diff.push_str("\n");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:45:17
[INFO] [stdout]    |
[INFO] [stdout] 45 |                 diff.push_str("\n");
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `old_lines`
[INFO] [stdout]   --> src/command/diff.rs:52:14
[INFO] [stdout]    |
[INFO] [stdout] 52 |     for i in old_index..old_lines.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 52 -     for i in old_index..old_lines.len() {
[INFO] [stdout] 52 +     for <item> in old_lines.iter().skip(old_index) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         diff.push_str("\n");
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `new_lines`
[INFO] [stdout]   --> src/command/diff.rs:57:14
[INFO] [stdout]    |
[INFO] [stdout] 57 |     for i in new_index..new_lines.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 57 -     for i in new_index..new_lines.len() {
[INFO] [stdout] 57 +     for <item> in new_lines.iter().skip(new_index) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calling `push_str()` using a single-character string literal
[INFO] [stdout]   --> src/command/diff.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 |         diff.push_str("\n");
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `diff.push('\n')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/command/diff.rs:106:19
[INFO] [stdout]     |
[INFO] [stdout] 106 | pub fn diff(args: &Vec<String>) {
[INFO] [stdout]     |                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 106 - pub fn diff(args: &Vec<String>) {
[INFO] [stdout] 106 + pub fn diff(args: &[String]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/command/diff.rs:119:52
[INFO] [stdout]     |
[INFO] [stdout] 119 |         println!("{}", diff_blobs(&Blob::from_hash(&file.old_hash.as_ref().unwrap()), &Blob::from_file(&file.path)));
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file.old_hash.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:102:16
[INFO] [stdout]     |
[INFO] [stdout] 102 | ...   if vec![".git"].contains(&entry.file_name().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_string_lossy...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]     = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:126:16
[INFO] [stdout]     |
[INFO] [stdout] 126 | ...   if vec![".git"].contains(&entry.file_name().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_string_lossy...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]    --> src/git/object/tree.rs:151:16
[INFO] [stdout]     |
[INFO] [stdout] 151 | ...   if vec![".git"].contains(&path.file_name().unwrap().to_string_lossy().as_ref()) || gitignore.is_ignored(&entry.path().to_stri...
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: you can use an array directly: `[".git"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.83s
[INFO] running `Command { std: "docker" "inspect" "c7b9124273004e4e5470199838e726c6df7c18c5a7ba34801c4ae5e7b0eb5947", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c7b9124273004e4e5470199838e726c6df7c18c5a7ba34801c4ae5e7b0eb5947", kill_on_drop: false }`
[INFO] [stdout] c7b9124273004e4e5470199838e726c6df7c18c5a7ba34801c4ae5e7b0eb5947