[INFO] cloning repository https://github.com/kmakeev/puzzle15rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kmakeev/puzzle15rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmakeev%2Fpuzzle15rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmakeev%2Fpuzzle15rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2a0a1577f752888a68360bf2d818b46b2513cdd5 [INFO] linting kmakeev/puzzle15rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkmakeev%2Fpuzzle15rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kmakeev/puzzle15rust [INFO] finished tweaking git repo https://github.com/kmakeev/puzzle15rust [INFO] tweaked toml for git repo https://github.com/kmakeev/puzzle15rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kmakeev/puzzle15rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kmakeev/puzzle15rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded csv-core v0.1.6 [INFO] [stderr] Downloaded proc-macro2 v1.0.4 [INFO] [stderr] Downloaded regex-automata v0.1.8 [INFO] [stderr] Downloaded bstr v0.2.8 [INFO] [stderr] Downloaded csv v1.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6313623e3000ceed78b632fe045bbfe6b2c36b8c8fa7c3dbc4f9c5f3861d139a [INFO] running `Command { std: "docker" "start" "-a" "6313623e3000ceed78b632fe045bbfe6b2c36b8c8fa7c3dbc4f9c5f3861d139a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6313623e3000ceed78b632fe045bbfe6b2c36b8c8fa7c3dbc4f9c5f3861d139a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6313623e3000ceed78b632fe045bbfe6b2c36b8c8fa7c3dbc4f9c5f3861d139a", kill_on_drop: false }` [INFO] [stdout] 6313623e3000ceed78b632fe045bbfe6b2c36b8c8fa7c3dbc4f9c5f3861d139a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] afe43725cc512a16e453656d3d7bfe34dbd644ca09fc4796eea8c63e2143dfa4 [INFO] running `Command { std: "docker" "start" "-a" "afe43725cc512a16e453656d3d7bfe34dbd644ca09fc4796eea8c63e2143dfa4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling proc-macro2 v1.0.4 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking puzzle v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/puzzle.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/puzzle.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/puzzle.rs:195:61 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 195 - let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] 195 + let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| s1.set.f.cmp(&s2.set.f) ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/puzzle.rs:203:59 [INFO] [stdout] | [INFO] [stdout] 203 | let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] 203 + let result = map.par_iter().find_first(|(k1, s1)| s1.hash_current == hash ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:75 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:80 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:85 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:52 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:57 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:270:43 [INFO] [stdout] | [INFO] [stdout] 270 | let set:Set = Set{g:g, h:h_, f:f, position:new}; [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | let set:Set = Set{g:g, h:h_, f:f, position:new}; [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:272:107 [INFO] [stdout] | [INFO] [stdout] 272 | ... h_open_sets.insert(set.position.clone(),Step{hash_prev:prev.clone().hash_current, set:set, hash_current:hash}); [INFO] [stdout] | ^^^^^^^ help: replace it with: `set` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:355:25 [INFO] [stdout] | [INFO] [stdout] 355 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 355 - tmp[(pos as usize)] = -1; [INFO] [stdout] 355 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:366:25 [INFO] [stdout] | [INFO] [stdout] 366 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 366 - tmp[(pos as usize)] = -1; [INFO] [stdout] 366 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:377:25 [INFO] [stdout] | [INFO] [stdout] 377 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 377 - tmp[(pos as usize)] = -1; [INFO] [stdout] 377 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:388:25 [INFO] [stdout] | [INFO] [stdout] 388 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 388 - tmp[(pos as usize)] = -1; [INFO] [stdout] 388 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/puzzle.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/puzzle.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/puzzle.rs:195:61 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 195 - let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] 195 + let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| s1.set.f.cmp(&s2.set.f) ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/puzzle.rs:203:59 [INFO] [stdout] | [INFO] [stdout] 203 | let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] 203 + let result = map.par_iter().find_first(|(k1, s1)| s1.hash_current == hash ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:75 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:80 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:220:85 [INFO] [stdout] | [INFO] [stdout] 220 | h_open_sets.insert(self.start.clone(), Step{hash_prev: 0, set:Set{g:g, h:h, f:f, position:self.start.clone()}, [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:52 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:221:57 [INFO] [stdout] | [INFO] [stdout] 221 | hash_current: calculate_hash(&Set{g:g, h:h, f:f, position:self.start.clone()})}); [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:270:43 [INFO] [stdout] | [INFO] [stdout] 270 | let set:Set = Set{g:g, h:h_, f:f, position:new}; [INFO] [stdout] | ^^^ help: replace it with: `g` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | let set:Set = Set{g:g, h:h_, f:f, position:new}; [INFO] [stdout] | ^^^ help: replace it with: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/puzzle.rs:272:107 [INFO] [stdout] | [INFO] [stdout] 272 | ... h_open_sets.insert(set.position.clone(),Step{hash_prev:prev.clone().hash_current, set:set, hash_current:hash}); [INFO] [stdout] | ^^^^^^^ help: replace it with: `set` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:355:25 [INFO] [stdout] | [INFO] [stdout] 355 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 355 - tmp[(pos as usize)] = -1; [INFO] [stdout] 355 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:366:25 [INFO] [stdout] | [INFO] [stdout] 366 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 366 - tmp[(pos as usize)] = -1; [INFO] [stdout] 366 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:377:25 [INFO] [stdout] | [INFO] [stdout] 377 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 377 - tmp[(pos as usize)] = -1; [INFO] [stdout] 377 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/puzzle.rs:388:25 [INFO] [stdout] | [INFO] [stdout] 388 | tmp[(pos as usize)] = -1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 388 - tmp[(pos as usize)] = -1; [INFO] [stdout] 388 + tmp[pos as usize ] = -1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | let mut pos = pos_opt.unwrap() as i8; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k1` [INFO] [stdout] --> src/puzzle.rs:195:44 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k2` [INFO] [stdout] --> src/puzzle.rs:195:53 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/puzzle.rs:193:61 [INFO] [stdout] | [INFO] [stdout] 193 | fn get_best_step(& self, map: & HashMap, Step>, f: u32) -> Vec { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/puzzle.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | let (key, value) = best.unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k1` [INFO] [stdout] --> src/puzzle.rs:203:50 [INFO] [stdout] | [INFO] [stdout] 203 | let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/puzzle.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let (key, value) = result.unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | let mut now = SystemTime::now(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 229 | let mut val = self.get_best_step(&h_open_sets, f); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:236:25 [INFO] [stdout] | [INFO] [stdout] 236 | let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/puzzle.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | let h:i8 = self.size_h; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/puzzle.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let v:i8 = self.size_v; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cost` [INFO] [stdout] --> src/puzzle.rs:218:14 [INFO] [stdout] | [INFO] [stdout] 218 | let (cost, h) = self.cost(self.start.clone()); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cost` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/puzzle.rs:245:26 [INFO] [stdout] | [INFO] [stdout] 245 | Some(result) => {continue}, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:448:25 [INFO] [stdout] | [INFO] [stdout] 448 | let mut v: i8 = (((*j-1) / self.size_v) - (c as i8 / self.size_v)).abs(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:449:25 [INFO] [stdout] | [INFO] [stdout] 449 | let mut h: i8 = (((*j-1) % self.size_h) - (c as i8 % self.size_h)).abs(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | let mut position1: i8; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:471:21 [INFO] [stdout] | [INFO] [stdout] 471 | let mut position2: i8; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if self.puzzle.iter().position(|&r| r == x) == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.puzzle.iter().position(|&r| r == x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 113 | summ = summ + _b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `summ += _b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | let pos_opt: Option < usize >; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 145 | pos_opt = puz.iter().position( | &r | r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 144 ~ [INFO] [stdout] 145 ~ let pos_opt: Option < usize > = puz.iter().position( | &r | r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:146:16 [INFO] [stdout] | [INFO] [stdout] 146 | if pos_opt != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `pos_opt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 183 | summ = summ + _b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `summ += _b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/puzzle.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | return path_map; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 279 - return path_map; [INFO] [stdout] 279 + path_map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/puzzle.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 223 | while h_open_sets.len() !=0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!h_open_sets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_by_hash` doesn't need a mutable reference [INFO] [stdout] --> src/puzzle.rs:236:52 [INFO] [stdout] | [INFO] [stdout] 236 | let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 236 - let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] 236 + let mut val = self.get_by_hash(&h_close_sets, prev.hash_prev); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/puzzle.rs:244:17 [INFO] [stdout] | [INFO] [stdout] 244 | / match h_close_sets.get(&new) { [INFO] [stdout] 245 | | Some(result) => {continue}, [INFO] [stdout] 246 | | None => {} [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________________^ help: try: `if let Some(result) = h_close_sets.get(&new) {continue}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | let pos_opt:Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 291 | [INFO] [stdout] 292 | pos_opt = prev.iter().position(|&r| r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 290 ~ [INFO] [stdout] 291 | [INFO] [stdout] 292 ~ let pos_opt:Option = prev.iter().position(|&r| r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | if pos_opt == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `pos_opt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | let pos_opt:Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 340 | [INFO] [stdout] 341 | pos_opt = prev.iter().position(|&r| r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 | [INFO] [stdout] 341 ~ let pos_opt:Option = prev.iter().position(|&r| r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | if pos_opt == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `pos_opt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/puzzle.rs:402:25 [INFO] [stdout] | [INFO] [stdout] 402 | if *j > (0 + idx*self.size_h) && (*j <= self.size_h*(idx+1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(idx*self.size_h)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/puzzle.rs:403:30 [INFO] [stdout] | [INFO] [stdout] 403 | for i in line[c + 1..line.len()].to_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line[c + 1..line.len()].iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/puzzle.rs:404:32 [INFO] [stdout] | [INFO] [stdout] 404 | if i > (0 + idx*self.size_h) && (i <= self.size_h*(idx+1)) && *j>i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(idx*self.size_h)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/puzzle.rs:425:30 [INFO] [stdout] | [INFO] [stdout] 425 | for i in line[c + 1..line.len()].to_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line[c + 1..line.len()].iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:457:25 [INFO] [stdout] | [INFO] [stdout] 457 | / ... cost = cost + self.check_linear_conflict(i, [INFO] [stdout] 458 | | ... line[(self.size_h*i) as usize..((self.size_h)*(i+1)) as usize].to_vec()); [INFO] [stdout] | |_______________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 457 ~ cost += self.check_linear_conflict(i, [INFO] [stdout] 458 ~ line[(self.size_h*i) as usize..((self.size_h)*(i+1)) as usize].to_vec()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:466:21 [INFO] [stdout] | [INFO] [stdout] 466 | cost = cost + self.check_column_conflict(i, col); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cost += self.check_column_conflict(i, col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | let mut pos = pos_opt.unwrap() as i8; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k1` [INFO] [stdout] --> src/puzzle.rs:195:44 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k2` [INFO] [stdout] --> src/puzzle.rs:195:53 [INFO] [stdout] | [INFO] [stdout] 195 | let best = map.par_iter().min_by(|(k1, s1),(k2,s2)| (s1.set.f.cmp(&s2.set.f))); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/puzzle.rs:193:61 [INFO] [stdout] | [INFO] [stdout] 193 | fn get_best_step(& self, map: & HashMap, Step>, f: u32) -> Vec { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/puzzle.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | let (key, value) = best.unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k1` [INFO] [stdout] --> src/puzzle.rs:203:50 [INFO] [stdout] | [INFO] [stdout] 203 | let result = map.par_iter().find_first(|(k1, s1)| (s1.hash_current == hash)); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_k1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/puzzle.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let (key, value) = result.unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | let mut now = SystemTime::now(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 229 | let mut val = self.get_best_step(&h_open_sets, f); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:236:25 [INFO] [stdout] | [INFO] [stdout] 236 | let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/puzzle.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | let h:i8 = self.size_h; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/puzzle.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let v:i8 = self.size_v; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cost` [INFO] [stdout] --> src/puzzle.rs:218:14 [INFO] [stdout] | [INFO] [stdout] 218 | let (cost, h) = self.cost(self.start.clone()); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cost` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/puzzle.rs:245:26 [INFO] [stdout] | [INFO] [stdout] 245 | Some(result) => {continue}, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:448:25 [INFO] [stdout] | [INFO] [stdout] 448 | let mut v: i8 = (((*j-1) / self.size_v) - (c as i8 / self.size_v)).abs(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:449:25 [INFO] [stdout] | [INFO] [stdout] 449 | let mut h: i8 = (((*j-1) % self.size_h) - (c as i8 % self.size_h)).abs(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | let mut position1: i8; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/puzzle.rs:471:21 [INFO] [stdout] | [INFO] [stdout] 471 | let mut position2: i8; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if self.puzzle.iter().position(|&r| r == x) == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.puzzle.iter().position(|&r| r == x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 113 | summ = summ + _b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `summ += _b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | let pos_opt: Option < usize >; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 145 | pos_opt = puz.iter().position( | &r | r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 144 ~ [INFO] [stdout] 145 ~ let pos_opt: Option < usize > = puz.iter().position( | &r | r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:146:16 [INFO] [stdout] | [INFO] [stdout] 146 | if pos_opt != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `pos_opt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:183:21 [INFO] [stdout] | [INFO] [stdout] 183 | summ = summ + _b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `summ += _b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/puzzle.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | return path_map; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 279 - return path_map; [INFO] [stdout] 279 + path_map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/puzzle.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 223 | while h_open_sets.len() !=0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!h_open_sets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_by_hash` doesn't need a mutable reference [INFO] [stdout] --> src/puzzle.rs:236:52 [INFO] [stdout] | [INFO] [stdout] 236 | let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 236 - let mut val = self.get_by_hash(&mut h_close_sets, prev.hash_prev); [INFO] [stdout] 236 + let mut val = self.get_by_hash(&h_close_sets, prev.hash_prev); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/puzzle.rs:244:17 [INFO] [stdout] | [INFO] [stdout] 244 | / match h_close_sets.get(&new) { [INFO] [stdout] 245 | | Some(result) => {continue}, [INFO] [stdout] 246 | | None => {} [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________________^ help: try: `if let Some(result) = h_close_sets.get(&new) {continue}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | let pos_opt:Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 291 | [INFO] [stdout] 292 | pos_opt = prev.iter().position(|&r| r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 290 ~ [INFO] [stdout] 291 | [INFO] [stdout] 292 ~ let pos_opt:Option = prev.iter().position(|&r| r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | if pos_opt == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `pos_opt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/puzzle.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | let pos_opt:Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 340 | [INFO] [stdout] 341 | pos_opt = prev.iter().position(|&r| r == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos_opt` here [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 | [INFO] [stdout] 341 ~ let pos_opt:Option = prev.iter().position(|&r| r == 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/puzzle.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | if pos_opt == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `pos_opt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/puzzle.rs:402:25 [INFO] [stdout] | [INFO] [stdout] 402 | if *j > (0 + idx*self.size_h) && (*j <= self.size_h*(idx+1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(idx*self.size_h)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/puzzle.rs:403:30 [INFO] [stdout] | [INFO] [stdout] 403 | for i in line[c + 1..line.len()].to_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line[c + 1..line.len()].iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/puzzle.rs:404:32 [INFO] [stdout] | [INFO] [stdout] 404 | if i > (0 + idx*self.size_h) && (i <= self.size_h*(idx+1)) && *j>i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(idx*self.size_h)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/puzzle.rs:425:30 [INFO] [stdout] | [INFO] [stdout] 425 | for i in line[c + 1..line.len()].to_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line[c + 1..line.len()].iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:457:25 [INFO] [stdout] | [INFO] [stdout] 457 | / ... cost = cost + self.check_linear_conflict(i, [INFO] [stdout] 458 | | ... line[(self.size_h*i) as usize..((self.size_h)*(i+1)) as usize].to_vec()); [INFO] [stdout] | |_______________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 457 ~ cost += self.check_linear_conflict(i, [INFO] [stdout] 458 ~ line[(self.size_h*i) as usize..((self.size_h)*(i+1)) as usize].to_vec()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/puzzle.rs:466:21 [INFO] [stdout] | [INFO] [stdout] 466 | cost = cost + self.check_column_conflict(i, col); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cost += self.check_column_conflict(i, col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Serialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | ... size_h: size_h, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `size_h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:140:45 [INFO] [stdout] | [INFO] [stdout] 140 | ... size_v: size_v, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `size_v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:143:45 [INFO] [stdout] | [INFO] [stdout] 143 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut size_h:i8; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut size_v:i8; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:131:29 [INFO] [stdout] | [INFO] [stdout] 131 | let mut result:i8 = match set { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:146:32 [INFO] [stdout] | [INFO] [stdout] 146 | ... Ok(t) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | Ok(t) => {println!(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `count_solutions` is never read [INFO] [stdout] --> src/main.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let mut count_solutions:i32 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:130:42 [INFO] [stdout] | [INFO] [stdout] 130 | let set = result[(j+1) as usize].set.position.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `((j+1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Row` [INFO] [stdout] 24 | struct Row { [INFO] [stdout] | --- `Row` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Serialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | ... size_h: size_h, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `size_h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:140:45 [INFO] [stdout] | [INFO] [stdout] 140 | ... size_v: size_v, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `size_v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:143:45 [INFO] [stdout] | [INFO] [stdout] 143 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut size_h:i8; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut size_v:i8; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:131:29 [INFO] [stdout] | [INFO] [stdout] 131 | let mut result:i8 = match set { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/main.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | Err(n) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:146:32 [INFO] [stdout] | [INFO] [stdout] 146 | ... Ok(t) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/main.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | Ok(t) => {println!(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `count_solutions` is never read [INFO] [stdout] --> src/main.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let mut count_solutions:i32 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:130:42 [INFO] [stdout] | [INFO] [stdout] 130 | let set = result[(j+1) as usize].set.position.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `((j+1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Row` [INFO] [stdout] 24 | struct Row { [INFO] [stdout] | --- `Row` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/lib.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | assert!(!Puzzle::new(3,3).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Puzzle::new(3,3).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.66s [INFO] running `Command { std: "docker" "inspect" "afe43725cc512a16e453656d3d7bfe34dbd644ca09fc4796eea8c63e2143dfa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afe43725cc512a16e453656d3d7bfe34dbd644ca09fc4796eea8c63e2143dfa4", kill_on_drop: false }` [INFO] [stdout] afe43725cc512a16e453656d3d7bfe34dbd644ca09fc4796eea8c63e2143dfa4