[INFO] cloning repository https://github.com/km-clay/shed [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/km-clay/shed" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkm-clay%2Fshed", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkm-clay%2Fshed'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 782a3820dafcb147585438fc70e821300f2a1e74 [INFO] linting km-clay/shed against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkm-clay%2Fshed" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-6-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/km-clay/shed [INFO] finished tweaking git repo https://github.com/km-clay/shed [INFO] tweaked toml for git repo https://github.com/km-clay/shed written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/km-clay/shed on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/km-clay/shed already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded vte v0.15.0 [INFO] [stderr] Downloaded ariadne v0.6.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da49979c4e93dcb2ac927c29c14c118f0ac4c55527d1091570e552f33f28d3b5 [INFO] running `Command { std: "docker" "start" "-a" "da49979c4e93dcb2ac927c29c14c118f0ac4c55527d1091570e552f33f28d3b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da49979c4e93dcb2ac927c29c14c118f0ac4c55527d1091570e552f33f28d3b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da49979c4e93dcb2ac927c29c14c118f0ac4c55527d1091570e552f33f28d3b5", kill_on_drop: false }` [INFO] [stdout] da49979c4e93dcb2ac927c29c14c118f0ac4c55527d1091570e552f33f28d3b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] faa30695271120d53a3355ee223d5f842b7c6c83de32fa5314d847689c2cba02 [INFO] running `Command { std: "docker" "start" "-a" "faa30695271120d53a3355ee223d5f842b7c6c83de32fa5314d847689c2cba02", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking vte v0.15.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking ariadne v0.6.0 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking shed v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `nix::libc::STDIN_FILENO` [INFO] [stdout] --> src/builtin/help.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nix::libc::STDIN_FILENO; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IoFrame`, `IoMode`, `RedirType`, and `Redir` [INFO] [stdout] --> src/builtin/help.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | NdRule, Node, Redir, RedirType, [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | procio::{IoFrame, IoMode}, [INFO] [stdout] | ^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/builtin/help.rs:109:11 [INFO] [stdout] | [INFO] [stdout] 109 | } else { [INFO] [stdout] | ___________^ [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Var` [INFO] [stdout] --> src/jobs.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | state::{self, ShellParam, Var, VarFlags, VarKind, set_status, write_jobs, write_vars}, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_win_size` [INFO] [stdout] --> src/readline/linebuf.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | term::{RawModeGuard, get_win_size}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `expand_raw` [INFO] [stdout] --> src/readline/vimode/ex.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::expand::{Expander, expand_raw}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::readline::complete::SimpleCompleter` [INFO] [stdout] --> src/readline/vimode/ex.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::readline::complete::SimpleCompleter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_home` [INFO] [stdout] --> src/readline/vimode/ex.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | use crate::state::{get_home, write_meta}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nix::libc::STDIN_FILENO` [INFO] [stdout] --> src/builtin/help.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use nix::libc::STDIN_FILENO; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IoFrame`, `IoMode`, `RedirType`, and `Redir` [INFO] [stdout] --> src/builtin/help.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | NdRule, Node, Redir, RedirType, [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | procio::{IoFrame, IoMode}, [INFO] [stdout] | ^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/builtin/help.rs:109:11 [INFO] [stdout] | [INFO] [stdout] 109 | } else { [INFO] [stdout] | ___________^ [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Var` [INFO] [stdout] --> src/jobs.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | state::{self, ShellParam, Var, VarFlags, VarKind, set_status, write_jobs, write_vars}, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_win_size` [INFO] [stdout] --> src/readline/linebuf.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | term::{RawModeGuard, get_win_size}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `expand_raw` [INFO] [stdout] --> src/readline/vimode/ex.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::expand::{Expander, expand_raw}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::readline::complete::SimpleCompleter` [INFO] [stdout] --> src/readline/vimode/ex.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::readline::complete::SimpleCompleter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_home` [INFO] [stdout] --> src/readline/vimode/ex.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | use crate::state::{get_home, write_meta}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tag` [INFO] [stdout] --> src/builtin/help.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 103 | for (tag, line) in &tags {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_tag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/builtin/help.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | for (tag, line) in &tags {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matched_tag` [INFO] [stdout] --> src/builtin/help.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some((matched_tag, line)) = get_best_match(&topic, &tags) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matched_tag` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ch` [INFO] [stdout] --> src/readline/mod.rs:1802:7 [INFO] [stdout] | [INFO] [stdout] 1802 | ch if cmd_sub_depth > 0 || proc_sub_depth > 0 => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/expand.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / if chars.peek() == Some(&'.') { [INFO] [stdout] 181 | | chars.next(); [INFO] [stdout] 182 | | has_range = true; [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ '.' if qt_state.outside() && depth == 1 [INFO] [stdout] 180 ~ && chars.peek() == Some(&'.') => { [INFO] [stdout] 181 | chars.next(); [INFO] [stdout] 182 | has_range = true; [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/jobs.rs:836:13 [INFO] [stdout] | [INFO] [stdout] 836 | / if sig == Signal::SIGTSTP { [INFO] [stdout] 837 | | was_stopped = true; [INFO] [stdout] 838 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ WtStat::Signaled(_, sig, _) [INFO] [stdout] 836 ~ if sig == Signal::SIGTSTP => { [INFO] [stdout] 837 | was_stopped = true; [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tag` [INFO] [stdout] --> src/builtin/help.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 103 | for (tag, line) in &tags {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_tag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/builtin/help.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | for (tag, line) in &tags {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matched_tag` [INFO] [stdout] --> src/builtin/help.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some((matched_tag, line)) = get_best_match(&topic, &tags) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matched_tag` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1482:13 [INFO] [stdout] | [INFO] [stdout] 1482 | / if last_priority < 2 { [INFO] [stdout] 1483 | | if last_priority > 0 { [INFO] [stdout] 1484 | | ctx.pop(); [INFO] [stdout] ... | [INFO] [stdout] 1488 | | ctx.push(markers::COMMAND); [INFO] [stdout] 1489 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1481 ~ markers::COMMAND | markers::BUILTIN [INFO] [stdout] 1482 ~ if last_priority < 2 => { [INFO] [stdout] 1483 | if last_priority > 0 { [INFO] [stdout] ... [INFO] [stdout] 1488 | ctx.push(markers::COMMAND); [INFO] [stdout] 1489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1492:13 [INFO] [stdout] | [INFO] [stdout] 1492 | / if last_priority < 3 { [INFO] [stdout] 1493 | | if last_priority > 0 { [INFO] [stdout] 1494 | | ctx.pop(); [INFO] [stdout] ... | [INFO] [stdout] 1498 | | ctx.push(markers::VAR_SUB); [INFO] [stdout] 1499 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1491 ~ markers::VAR_SUB [INFO] [stdout] 1492 ~ if last_priority < 3 => { [INFO] [stdout] 1493 | if last_priority > 0 { [INFO] [stdout] ... [INFO] [stdout] 1498 | ctx.push(markers::VAR_SUB); [INFO] [stdout] 1499 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1502:13 [INFO] [stdout] | [INFO] [stdout] 1502 | / if last_priority < 1 { [INFO] [stdout] 1503 | | ctx_start = pos; [INFO] [stdout] 1504 | | ctx.push(markers::ARG); [INFO] [stdout] 1505 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1501 ~ markers::ARG | markers::ASSIGNMENT [INFO] [stdout] 1502 ~ if last_priority < 1 => { [INFO] [stdout] 1503 | ctx_start = pos; [INFO] [stdout] 1504 | ctx.push(markers::ARG); [INFO] [stdout] 1505 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1508:13 [INFO] [stdout] | [INFO] [stdout] 1508 | / if ctx.len() > 1 { [INFO] [stdout] 1509 | | ctx.pop(); [INFO] [stdout] 1510 | | last_priority = 0; [INFO] [stdout] 1511 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1507 ~ markers::RESET [INFO] [stdout] 1508 ~ if ctx.len() > 1 => { [INFO] [stdout] 1509 | ctx.pop(); [INFO] [stdout] 1510 | last_priority = 0; [INFO] [stdout] 1511 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `range.start` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/readline/linebuf.rs:740:17 [INFO] [stdout] | [INFO] [stdout] 740 | let start = range.start.max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `range.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/readline/linebuf.rs:3034:10 [INFO] [stdout] | [INFO] [stdout] 3034 | if after < before && !(before_escaped && !self.indent_ctx.in_escaped_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.indent_ctx.in_escaped_line || !before_escaped) && after < before` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/readline/linebuf.rs:3034:28 [INFO] [stdout] | [INFO] [stdout] 3034 | if after < before && !(before_escaped && !self.indent_ctx.in_escaped_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!before_escaped || self.indent_ctx.in_escaped_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/readline/term.rs:542:7 [INFO] [stdout] | [INFO] [stdout] 542 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 - self.ss3_pending = true; [INFO] [stdout] 542 - return; [INFO] [stdout] 541 + self.ss3_pending = true; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `pos` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/readline/mod.rs:1483:17 [INFO] [stdout] | [INFO] [stdout] 1483 | let pos = pos.max(0).min(annotated.len()); [INFO] [stdout] | ^^^^^^^^^^ help: try: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ch` [INFO] [stdout] --> src/readline/mod.rs:1802:7 [INFO] [stdout] | [INFO] [stdout] 1802 | ch if cmd_sub_depth > 0 || proc_sub_depth > 0 => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_ch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/expand.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / if chars.peek() == Some(&'.') { [INFO] [stdout] 181 | | chars.next(); [INFO] [stdout] 182 | | has_range = true; [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ '.' if qt_state.outside() && depth == 1 [INFO] [stdout] 180 ~ && chars.peek() == Some(&'.') => { [INFO] [stdout] 181 | chars.next(); [INFO] [stdout] 182 | has_range = true; [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/jobs.rs:836:13 [INFO] [stdout] | [INFO] [stdout] 836 | / if sig == Signal::SIGTSTP { [INFO] [stdout] 837 | | was_stopped = true; [INFO] [stdout] 838 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ WtStat::Signaled(_, sig, _) [INFO] [stdout] 836 ~ if sig == Signal::SIGTSTP => { [INFO] [stdout] 837 | was_stopped = true; [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1482:13 [INFO] [stdout] | [INFO] [stdout] 1482 | / if last_priority < 2 { [INFO] [stdout] 1483 | | if last_priority > 0 { [INFO] [stdout] 1484 | | ctx.pop(); [INFO] [stdout] ... | [INFO] [stdout] 1488 | | ctx.push(markers::COMMAND); [INFO] [stdout] 1489 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1481 ~ markers::COMMAND | markers::BUILTIN [INFO] [stdout] 1482 ~ if last_priority < 2 => { [INFO] [stdout] 1483 | if last_priority > 0 { [INFO] [stdout] ... [INFO] [stdout] 1488 | ctx.push(markers::COMMAND); [INFO] [stdout] 1489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1492:13 [INFO] [stdout] | [INFO] [stdout] 1492 | / if last_priority < 3 { [INFO] [stdout] 1493 | | if last_priority > 0 { [INFO] [stdout] 1494 | | ctx.pop(); [INFO] [stdout] ... | [INFO] [stdout] 1498 | | ctx.push(markers::VAR_SUB); [INFO] [stdout] 1499 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1491 ~ markers::VAR_SUB [INFO] [stdout] 1492 ~ if last_priority < 3 => { [INFO] [stdout] 1493 | if last_priority > 0 { [INFO] [stdout] ... [INFO] [stdout] 1498 | ctx.push(markers::VAR_SUB); [INFO] [stdout] 1499 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1502:13 [INFO] [stdout] | [INFO] [stdout] 1502 | / if last_priority < 1 { [INFO] [stdout] 1503 | | ctx_start = pos; [INFO] [stdout] 1504 | | ctx.push(markers::ARG); [INFO] [stdout] 1505 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1501 ~ markers::ARG | markers::ASSIGNMENT [INFO] [stdout] 1502 ~ if last_priority < 1 => { [INFO] [stdout] 1503 | ctx_start = pos; [INFO] [stdout] 1504 | ctx.push(markers::ARG); [INFO] [stdout] 1505 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/readline/complete.rs:1508:13 [INFO] [stdout] | [INFO] [stdout] 1508 | / if ctx.len() > 1 { [INFO] [stdout] 1509 | | ctx.pop(); [INFO] [stdout] 1510 | | last_priority = 0; [INFO] [stdout] 1511 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1507 ~ markers::RESET [INFO] [stdout] 1508 ~ if ctx.len() > 1 => { [INFO] [stdout] 1509 | ctx.pop(); [INFO] [stdout] 1510 | last_priority = 0; [INFO] [stdout] 1511 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `range.start` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/readline/linebuf.rs:740:17 [INFO] [stdout] | [INFO] [stdout] 740 | let start = range.start.max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `range.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/readline/linebuf.rs:3034:10 [INFO] [stdout] | [INFO] [stdout] 3034 | if after < before && !(before_escaped && !self.indent_ctx.in_escaped_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.indent_ctx.in_escaped_line || !before_escaped) && after < before` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/readline/linebuf.rs:3034:28 [INFO] [stdout] | [INFO] [stdout] 3034 | if after < before && !(before_escaped && !self.indent_ctx.in_escaped_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!before_escaped || self.indent_ctx.in_escaped_line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/readline/term.rs:542:7 [INFO] [stdout] | [INFO] [stdout] 542 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 541 - self.ss3_pending = true; [INFO] [stdout] 542 - return; [INFO] [stdout] 541 + self.ss3_pending = true; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `pos` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/readline/mod.rs:1483:17 [INFO] [stdout] | [INFO] [stdout] 1483 | let pos = pos.max(0).min(annotated.len()); [INFO] [stdout] | ^^^^^^^^^^ help: try: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.15s [INFO] running `Command { std: "docker" "inspect" "faa30695271120d53a3355ee223d5f842b7c6c83de32fa5314d847689c2cba02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "faa30695271120d53a3355ee223d5f842b7c6c83de32fa5314d847689c2cba02", kill_on_drop: false }` [INFO] [stdout] faa30695271120d53a3355ee223d5f842b7c6c83de32fa5314d847689c2cba02