[INFO] cloning repository https://github.com/kjagiello/diagwiz [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kjagiello/diagwiz" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjagiello%2Fdiagwiz", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjagiello%2Fdiagwiz'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 20a076b7c50147be86f5bc11b3d260845132233b [INFO] linting kjagiello/diagwiz against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkjagiello%2Fdiagwiz" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kjagiello/diagwiz [INFO] finished tweaking git repo https://github.com/kjagiello/diagwiz [INFO] tweaked toml for git repo https://github.com/kjagiello/diagwiz written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kjagiello/diagwiz on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kjagiello/diagwiz already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded diff v0.1.12 [INFO] [stderr] Downloaded output_vt100 v0.1.2 [INFO] [stderr] Downloaded ctor v0.1.20 [INFO] [stderr] Downloaded pest_generator v2.1.3 [INFO] [stderr] Downloaded sha-1 v0.8.2 [INFO] [stderr] Downloaded vec_map v0.8.2 [INFO] [stderr] Downloaded hermit-abi v0.1.18 [INFO] [stderr] Downloaded strsim v0.8.0 [INFO] [stderr] Downloaded pretty_assertions v0.7.2 [INFO] [stderr] Downloaded unicode-width v0.1.8 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded typenum v1.13.0 [INFO] [stderr] Downloaded ucd-trie v0.1.3 [INFO] [stderr] Downloaded pest v2.1.3 [INFO] [stderr] Downloaded unicode-segmentation v1.7.1 [INFO] [stderr] Downloaded textwrap v0.11.0 [INFO] [stderr] Downloaded syn v1.0.64 [INFO] [stderr] Downloaded cassowary v0.3.0 [INFO] [stderr] Downloaded pest_meta v2.1.3 [INFO] [stderr] Downloaded quote v1.0.9 [INFO] [stderr] Downloaded pest_derive v2.1.0 [INFO] [stderr] Downloaded clap v2.33.3 [INFO] [stderr] Downloaded libc v0.2.90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c3e04e5b38572b6a04eba314305d2cc71eefd78520a6b2ac98871fa868fe563 [INFO] running `Command { std: "docker" "start" "-a" "1c3e04e5b38572b6a04eba314305d2cc71eefd78520a6b2ac98871fa868fe563", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c3e04e5b38572b6a04eba314305d2cc71eefd78520a6b2ac98871fa868fe563", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c3e04e5b38572b6a04eba314305d2cc71eefd78520a6b2ac98871fa868fe563", kill_on_drop: false }` [INFO] [stdout] 1c3e04e5b38572b6a04eba314305d2cc71eefd78520a6b2ac98871fa868fe563 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2bc7a7c75be17382e1e6c5881dfd9653bf794a56fc543179a27c47165acf29ce [INFO] running `Command { std: "docker" "start" "-a" "2bc7a7c75be17382e1e6c5881dfd9653bf794a56fc543179a27c47165acf29ce", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling syn v1.0.64 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling libc v0.2.90 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking diagram_base v0.1.0 (/opt/rustwide/workdir/src/diagrams/base) [INFO] [stderr] Checking ascii_canvas v0.1.0 (/opt/rustwide/workdir/src/ascii_canvas) [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | &mut self.buffer [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &mut self, [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 114 | ) -> TextCanvasRegion { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 114 | ) -> TextCanvasRegion<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking pest v2.1.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking pretty_assertions v0.7.2 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | &mut self.buffer [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &mut self, [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 114 | ) -> TextCanvasRegion { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 114 | ) -> TextCanvasRegion<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | &mut self.buffer [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:153:24 [INFO] [stdout] | [INFO] [stdout] 153 | let expected = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 154 | | "123 ", [INFO] [stdout] 155 | | "456 ", [INFO] [stdout] 156 | | "78123", [INFO] [stdout] 157 | | " 456", [INFO] [stdout] 158 | | " 789", [INFO] [stdout] 159 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 153 ~ let expected = ["123 ", [INFO] [stdout] 154 + "456 ", [INFO] [stdout] 155 + "78123", [INFO] [stdout] 156 + " 456", [INFO] [stdout] 157 ~ " 789"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ascii_canvas/src/lib.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &mut self, [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 114 | ) -> TextCanvasRegion { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 114 | ) -> TextCanvasRegion<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking diagram_seq v0.1.0 (/opt/rustwide/workdir/src/diagrams/seq) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:82:34 [INFO] [stdout] | [INFO] [stdout] 82 | self.data.render(canvas, &ctx) [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `repeat(1)` on str [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | &" ".repeat(1), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()` instead: `" ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repeat_once [INFO] [stdout] = note: `#[warn(clippy::repeat_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:205:36 [INFO] [stdout] | [INFO] [stdout] 205 | let left_padding = ((width - len) / 2) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((width - len) / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:476:17 [INFO] [stdout] | [INFO] [stdout] 476 | assert!(output.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!output.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diagrams/seq/src/parser.rs:207:17 [INFO] [stdout] | [INFO] [stdout] 207 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diagrams/seq/src/parser.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/diagrams/seq/src/lib.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | assert_eq!(result.contains("Foo"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 35 - assert_eq!(result.contains("Foo"), true); [INFO] [stdout] 35 + assert!(result.contains("Foo")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/diagrams/seq/src/lib.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(result.contains("Bar"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(result.contains("Bar"), true); [INFO] [stdout] 36 + assert!(result.contains("Bar")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:82:34 [INFO] [stdout] | [INFO] [stdout] 82 | self.data.render(canvas, &ctx) [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `repeat(1)` on str [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | &" ".repeat(1), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()` instead: `" ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repeat_once [INFO] [stdout] = note: `#[warn(clippy::repeat_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:205:36 [INFO] [stdout] | [INFO] [stdout] 205 | let left_padding = ((width - len) / 2) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((width - len) / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:82:34 [INFO] [stdout] | [INFO] [stdout] 82 | self.data.render(canvas, &ctx) [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `repeat(1)` on str [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | &" ".repeat(1), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()` instead: `" ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repeat_once [INFO] [stdout] = note: `#[warn(clippy::repeat_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/diagrams/seq/src/layout.rs:205:36 [INFO] [stdout] | [INFO] [stdout] 205 | let left_padding = ((width - len) / 2) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((width - len) / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking diagwiz v0.1.0 (/opt/rustwide/workdir/src/cli) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/src/main.rs:24:33 [INFO] [stdout] | [INFO] [stdout] 24 | let mut handle = File::open(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cli/src/main.rs:24:33 [INFO] [stdout] | [INFO] [stdout] 24 | let mut handle = File::open(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/diagrams/seq/tests/snapshot.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | / r#" [INFO] [stdout] 83 | | a->b: "hello world" [INFO] [stdout] 84 | | "# [INFO] [stdout] 85 | | .into() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 82 ~ r#" [INFO] [stdout] 83 + a->b: "hello world" [INFO] [stdout] 84 + "# [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/diagrams/seq/tests/snapshot.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / r#" [INFO] [stdout] 106 | | alias a = "Alice" [INFO] [stdout] 107 | | alias b = "Bob" [INFO] [stdout] 108 | | alias c = "Charlie" [INFO] [stdout] ... | [INFO] [stdout] 115 | | "# [INFO] [stdout] 116 | | .into() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 105 ~ r#" [INFO] [stdout] 106 + alias a = "Alice" [INFO] [stdout] 107 + alias b = "Bob" [INFO] [stdout] 108 + alias c = "Charlie" [INFO] [stdout] 109 + [INFO] [stdout] 110 + a->c: "hello world" [INFO] [stdout] 111 + b->a: "hello there" [INFO] [stdout] 112 + c-->a: "hello back" [INFO] [stdout] 113 + c->b: "hello back too" [INFO] [stdout] 114 + b->b: "hello?" [INFO] [stdout] 115 + "# [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.57s [INFO] running `Command { std: "docker" "inspect" "2bc7a7c75be17382e1e6c5881dfd9653bf794a56fc543179a27c47165acf29ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bc7a7c75be17382e1e6c5881dfd9653bf794a56fc543179a27c47165acf29ce", kill_on_drop: false }` [INFO] [stdout] 2bc7a7c75be17382e1e6c5881dfd9653bf794a56fc543179a27c47165acf29ce