[INFO] cloning repository https://github.com/kj800x/jobfather [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kj800x/jobfather" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkj800x%2Fjobfather", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkj800x%2Fjobfather'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 62015c460840129ff08e689767165603e1800ae0 [INFO] linting kj800x/jobfather against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkj800x%2Fjobfather" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kj800x/jobfather [INFO] finished tweaking git repo https://github.com/kj800x/jobfather [INFO] tweaked toml for git repo https://github.com/kj800x/jobfather written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kj800x/jobfather on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kj800x/jobfather already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded opentelemetry-prometheus v0.14.1 [INFO] [stderr] Downloaded maud v0.26.0 [INFO] [stderr] Downloaded maud_macros v0.26.0 [INFO] [stderr] Downloaded phf_shared v0.12.1 [INFO] [stderr] Downloaded phf v0.12.1 [INFO] [stderr] Downloaded kube-derive v0.99.0 [INFO] [stderr] Downloaded opentelemetry-semantic-conventions v0.13.0 [INFO] [stderr] Downloaded croner v2.2.0 [INFO] [stderr] Downloaded kube-runtime v0.99.0 [INFO] [stderr] Downloaded headers v0.4.1 [INFO] [stderr] Downloaded kube-client v0.99.0 [INFO] [stderr] Downloaded kube v0.99.0 [INFO] [stderr] Downloaded rusqlite_migration v1.3.1 [INFO] [stderr] Downloaded hyper-http-proxy v1.1.0 [INFO] [stderr] Downloaded actix-web-opentelemetry v0.16.0 [INFO] [stderr] Downloaded kube-core v0.99.0 [INFO] [stderr] Downloaded chrono-tz v0.10.4 [INFO] [stderr] Downloaded k8s-openapi v0.24.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74d6eee18f0269e21d8a3f17286702da1dad835006b398683814504e49455921 [INFO] running `Command { std: "docker" "start" "-a" "74d6eee18f0269e21d8a3f17286702da1dad835006b398683814504e49455921", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74d6eee18f0269e21d8a3f17286702da1dad835006b398683814504e49455921", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74d6eee18f0269e21d8a3f17286702da1dad835006b398683814504e49455921", kill_on_drop: false }` [INFO] [stdout] 74d6eee18f0269e21d8a3f17286702da1dad835006b398683814504e49455921 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbd344de3b7e72f526376ae4ee99f22a563c1d3a8b9b53d9504740e3f96a918a [INFO] running `Command { std: "docker" "start" "-a" "bbd344de3b7e72f526376ae4ee99f22a563c1d3a8b9b53d9504740e3f96a918a", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling pest v2.8.6 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Compiling k8s-openapi v0.24.0 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling regex-lite v0.1.9 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking siphasher v1.0.2 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking phf_shared v0.12.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Compiling chrono-tz v0.10.4 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling rusqlite_migration v1.3.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking phf v0.12.1 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.2 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking opentelemetry v0.21.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking jsonpath-rust v0.7.5 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling enum-ordinalize v4.3.2 [INFO] [stderr] Compiling educe v0.6.0 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.13.0 [INFO] [stderr] Compiling maud_macros v0.26.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking maud v0.26.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking jsonptr v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-router v0.5.4 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking opentelemetry_sdk v0.21.2 [INFO] [stderr] Compiling kube-derive v0.99.0 [INFO] [stderr] Checking json-patch v4.1.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking opentelemetry-prometheus v0.14.1 [INFO] [stderr] Checking croner v2.2.0 [INFO] [stderr] Checking r2d2_sqlite v0.25.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking backon v1.6.0 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking actix-http v3.12.0 [INFO] [stderr] Checking kube-core v0.99.0 [INFO] [stderr] Checking actix-web v4.13.0 [INFO] [stderr] Checking kube-client v0.99.0 [INFO] [stderr] Checking kube-runtime v0.99.0 [INFO] [stderr] Checking actix-web-opentelemetry v0.16.0 [INFO] [stderr] Checking kube v0.99.0 [INFO] [stderr] Checking jobfather v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:285:21 [INFO] [stdout] | [INFO] [stdout] 285 | / if is_terminal(job) { [INFO] [stdout] 286 | | if let Ok(conn) = pool.get() { [INFO] [stdout] 287 | | api_job.snapshot_status = crate::db::job_output::get_string( [INFO] [stdout] 288 | | &api_job.name, [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 285 ~ if is_terminal(job) [INFO] [stdout] 286 ~ && let Ok(conn) = pool.get() { [INFO] [stdout] 287 | api_job.snapshot_status = crate::db::job_output::get_string( [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:301:5 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 302 | | if let Ok(archived) = ArchivedJob::get_by_job_template(name, namespace, &conn) { [INFO] [stdout] 303 | | for job in &archived { [INFO] [stdout] 304 | | jobs.push(archived_job_to_api(job)); [INFO] [stdout] ... | [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 302 ~ && let Ok(archived) = ArchivedJob::get_by_job_template(name, namespace, &conn) { [INFO] [stdout] 303 | for job in &archived { [INFO] [stdout] 304 | jobs.push(archived_job_to_api(job)); [INFO] [stdout] 305 | } [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | / if is_terminal(&job) { [INFO] [stdout] 323 | | if let Ok(conn) = pool.get() { [INFO] [stdout] 324 | | api_job.snapshot_status = [INFO] [stdout] 325 | | crate::db::job_output::get_string(name, namespace, "_snapshot_status", &conn); [INFO] [stdout] 326 | | } [INFO] [stdout] 327 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 322 ~ if is_terminal(&job) [INFO] [stdout] 323 ~ && let Ok(conn) = pool.get() { [INFO] [stdout] 324 | api_job.snapshot_status = [INFO] [stdout] 325 | crate::db::job_output::get_string(name, namespace, "_snapshot_status", &conn); [INFO] [stdout] 326 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 332 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 333 | | return Some(archived_job_to_api(&job)); [INFO] [stdout] 334 | | } [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 332 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 333 | return Some(archived_job_to_api(&job)); [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 355 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 356 | | let text = job.logs.unwrap_or_default(); [INFO] [stdout] 357 | | return Ok(match tail { [INFO] [stdout] ... | [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 354 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 355 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 356 | let text = job.logs.unwrap_or_default(); [INFO] [stdout] ... [INFO] [stdout] 364 | }); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:382:5 [INFO] [stdout] | [INFO] [stdout] 382 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 383 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 384 | | return job [INFO] [stdout] 385 | | .events_json [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 382 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 383 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 384 | return job [INFO] [stdout] ... [INFO] [stdout] 388 | .unwrap_or_default(); [INFO] [stdout] 389 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | / if let Some(content) = crate::db::job_output::get(name, namespace, filename, &conn) [INFO] [stdout] 438 | | .ok() [INFO] [stdout] 439 | | .flatten() [INFO] [stdout] ... | [INFO] [stdout] 444 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 439 ~ .flatten() [INFO] [stdout] 440 ~ && let Ok(text) = String::from_utf8(content) { [INFO] [stdout] 441 | return Ok(text); [INFO] [stdout] 442 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | / if let Some(diff_json) = [INFO] [stdout] 468 | | crate::db::job_output::get_string(name, namespace, "_snapshot_diff_json", &conn) [INFO] [stdout] 469 | | { [INFO] [stdout] 470 | | if let Ok(diff) = serde_json::from_str::(&diff_json) { [INFO] [stdout] ... | [INFO] [stdout] 473 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ crate::db::job_output::get_string(name, namespace, "_snapshot_diff_json", &conn) [INFO] [stdout] 469 ~ && let Ok(diff) = serde_json::from_str::(&diff_json) { [INFO] [stdout] 470 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | / if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 476 | | if let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] ... | [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 475 ~ if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) [INFO] [stdout] 476 ~ && let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 | } [INFO] [stdout] 480 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | / if let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 | | } [INFO] [stdout] 480 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Some(diff_json) = &job.snapshot_diff_json [INFO] [stdout] 477 ~ && let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:547:5 [INFO] [stdout] | [INFO] [stdout] 547 | / if let Some(tarball) = tarball { [INFO] [stdout] 548 | | if let Ok(current) = crate::snapshot::extract_tarball(&tarball) { [INFO] [stdout] 549 | | let jt_ref = ArchivedJob::get_by_name_and_namespace(job_name, namespace, &conn) [INFO] [stdout] 550 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 594 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 547 ~ if let Some(tarball) = tarball [INFO] [stdout] 548 ~ && let Ok(current) = crate::snapshot::extract_tarball(&tarball) { [INFO] [stdout] 549 | let jt_ref = ArchivedJob::get_by_name_and_namespace(job_name, namespace, &conn) [INFO] [stdout] ... [INFO] [stdout] 592 | } [INFO] [stdout] 593 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:583:17 [INFO] [stdout] | [INFO] [stdout] 583 | / if f.path.ends_with(".json") [INFO] [stdout] 584 | | && f.status == crate::snapshot::FileDiffStatus::Changed [INFO] [stdout] 585 | | { [INFO] [stdout] 586 | | if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] ... | [INFO] [stdout] 591 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 584 ~ && f.status == crate::snapshot::FileDiffStatus::Changed [INFO] [stdout] 585 ~ && let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] 586 | if let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 587 | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 588 | } [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:586:21 [INFO] [stdout] | [INFO] [stdout] 586 | / if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] 587 | | if let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 588 | | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 589 | | } [INFO] [stdout] 590 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) [INFO] [stdout] 587 ~ && let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 588 | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | / if let Some(n) = tail { [INFO] [stdout] 623 | | if n > 0 { [INFO] [stdout] 624 | | params.tail_lines = Some(n); [INFO] [stdout] 625 | | } [INFO] [stdout] 626 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 622 ~ if let Some(n) = tail [INFO] [stdout] 623 ~ && n > 0 { [INFO] [stdout] 624 | params.tail_lines = Some(n); [INFO] [stdout] 625 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:285:21 [INFO] [stdout] | [INFO] [stdout] 285 | / if is_terminal(job) { [INFO] [stdout] 286 | | if let Ok(conn) = pool.get() { [INFO] [stdout] 287 | | api_job.snapshot_status = crate::db::job_output::get_string( [INFO] [stdout] 288 | | &api_job.name, [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 285 ~ if is_terminal(job) [INFO] [stdout] 286 ~ && let Ok(conn) = pool.get() { [INFO] [stdout] 287 | api_job.snapshot_status = crate::db::job_output::get_string( [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:301:5 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 302 | | if let Ok(archived) = ArchivedJob::get_by_job_template(name, namespace, &conn) { [INFO] [stdout] 303 | | for job in &archived { [INFO] [stdout] 304 | | jobs.push(archived_job_to_api(job)); [INFO] [stdout] ... | [INFO] [stdout] 307 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 302 ~ && let Ok(archived) = ArchivedJob::get_by_job_template(name, namespace, &conn) { [INFO] [stdout] 303 | for job in &archived { [INFO] [stdout] 304 | jobs.push(archived_job_to_api(job)); [INFO] [stdout] 305 | } [INFO] [stdout] 306 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | / if is_terminal(&job) { [INFO] [stdout] 323 | | if let Ok(conn) = pool.get() { [INFO] [stdout] 324 | | api_job.snapshot_status = [INFO] [stdout] 325 | | crate::db::job_output::get_string(name, namespace, "_snapshot_status", &conn); [INFO] [stdout] 326 | | } [INFO] [stdout] 327 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 322 ~ if is_terminal(&job) [INFO] [stdout] 323 ~ && let Ok(conn) = pool.get() { [INFO] [stdout] 324 | api_job.snapshot_status = [INFO] [stdout] 325 | crate::db::job_output::get_string(name, namespace, "_snapshot_status", &conn); [INFO] [stdout] 326 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 332 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 333 | | return Some(archived_job_to_api(&job)); [INFO] [stdout] 334 | | } [INFO] [stdout] 335 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 332 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 333 | return Some(archived_job_to_api(&job)); [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 355 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 356 | | let text = job.logs.unwrap_or_default(); [INFO] [stdout] 357 | | return Ok(match tail { [INFO] [stdout] ... | [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 354 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 355 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 356 | let text = job.logs.unwrap_or_default(); [INFO] [stdout] ... [INFO] [stdout] 364 | }); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.diff_lines` after checking its variant with `is_some` [INFO] [stdout] --> src/web/job_detail.rs:586:62 [INFO] [stdout] | [INFO] [stdout] 562 | ... @if is_diff && file.diff_lines.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 586 | ... @for line in file.diff_lines.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:382:5 [INFO] [stdout] | [INFO] [stdout] 382 | / if let Ok(conn) = pool.get() { [INFO] [stdout] 383 | | if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 384 | | return job [INFO] [stdout] 385 | | .events_json [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 382 ~ if let Ok(conn) = pool.get() [INFO] [stdout] 383 ~ && let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 384 | return job [INFO] [stdout] ... [INFO] [stdout] 388 | .unwrap_or_default(); [INFO] [stdout] 389 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | / if let Some(content) = crate::db::job_output::get(name, namespace, filename, &conn) [INFO] [stdout] 438 | | .ok() [INFO] [stdout] 439 | | .flatten() [INFO] [stdout] ... | [INFO] [stdout] 444 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 439 ~ .flatten() [INFO] [stdout] 440 ~ && let Ok(text) = String::from_utf8(content) { [INFO] [stdout] 441 | return Ok(text); [INFO] [stdout] 442 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | / if let Some(diff_json) = [INFO] [stdout] 468 | | crate::db::job_output::get_string(name, namespace, "_snapshot_diff_json", &conn) [INFO] [stdout] 469 | | { [INFO] [stdout] 470 | | if let Ok(diff) = serde_json::from_str::(&diff_json) { [INFO] [stdout] ... | [INFO] [stdout] 473 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ crate::db::job_output::get_string(name, namespace, "_snapshot_diff_json", &conn) [INFO] [stdout] 469 ~ && let Ok(diff) = serde_json::from_str::(&diff_json) { [INFO] [stdout] 470 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | / if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) { [INFO] [stdout] 476 | | if let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] ... | [INFO] [stdout] 481 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 475 ~ if let Ok(Some(job)) = ArchivedJob::get_by_name_and_namespace(name, namespace, &conn) [INFO] [stdout] 476 ~ && let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 | } [INFO] [stdout] 480 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | / if let Some(diff_json) = &job.snapshot_diff_json { [INFO] [stdout] 477 | | if let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 | | } [INFO] [stdout] 480 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Some(diff_json) = &job.snapshot_diff_json [INFO] [stdout] 477 ~ && let Ok(diff) = serde_json::from_str::(diff_json) { [INFO] [stdout] 478 | return Some(build_snapshot_diff_response(&diff, name, namespace, pool)); [INFO] [stdout] 479 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:547:5 [INFO] [stdout] | [INFO] [stdout] 547 | / if let Some(tarball) = tarball { [INFO] [stdout] 548 | | if let Ok(current) = crate::snapshot::extract_tarball(&tarball) { [INFO] [stdout] 549 | | let jt_ref = ArchivedJob::get_by_name_and_namespace(job_name, namespace, &conn) [INFO] [stdout] 550 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 594 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 547 ~ if let Some(tarball) = tarball [INFO] [stdout] 548 ~ && let Ok(current) = crate::snapshot::extract_tarball(&tarball) { [INFO] [stdout] 549 | let jt_ref = ArchivedJob::get_by_name_and_namespace(job_name, namespace, &conn) [INFO] [stdout] ... [INFO] [stdout] 592 | } [INFO] [stdout] 593 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:583:17 [INFO] [stdout] | [INFO] [stdout] 583 | / if f.path.ends_with(".json") [INFO] [stdout] 584 | | && f.status == crate::snapshot::FileDiffStatus::Changed [INFO] [stdout] 585 | | { [INFO] [stdout] 586 | | if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] ... | [INFO] [stdout] 591 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 584 ~ && f.status == crate::snapshot::FileDiffStatus::Changed [INFO] [stdout] 585 ~ && let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] 586 | if let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 587 | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 588 | } [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:586:21 [INFO] [stdout] | [INFO] [stdout] 586 | / if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) { [INFO] [stdout] 587 | | if let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 588 | | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 589 | | } [INFO] [stdout] 590 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 586 ~ if let (Some(old), Some(new)) = (baseline.get(&f.path), current.get(&f.path)) [INFO] [stdout] 587 ~ && let Some(lines) = crate::snapshot::json_diff(old, new) { [INFO] [stdout] 588 | json_diffs.insert(f.path.clone(), lines); [INFO] [stdout] 589 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/web/api.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | / if let Some(n) = tail { [INFO] [stdout] 623 | | if n > 0 { [INFO] [stdout] 624 | | params.tail_lines = Some(n); [INFO] [stdout] 625 | | } [INFO] [stdout] 626 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 622 ~ if let Some(n) = tail [INFO] [stdout] 623 ~ && n > 0 { [INFO] [stdout] 624 | params.tail_lines = Some(n); [INFO] [stdout] 625 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file.diff_lines` after checking its variant with `is_some` [INFO] [stdout] --> src/web/job_detail.rs:586:62 [INFO] [stdout] | [INFO] [stdout] 562 | ... @if is_diff && file.diff_lines.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 586 | ... @for line in file.diff_lines.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/web/job_template_detail.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 233 | rows.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - rows.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] 233 + rows.sort_by_key(|b| std::cmp::Reverse(b.start_time)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/web/job_template_detail.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 233 | rows.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - rows.sort_by(|a, b| b.start_time.cmp(&a.start_time)); [INFO] [stdout] 233 + rows.sort_by_key(|b| std::cmp::Reverse(b.start_time)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.81s [INFO] running `Command { std: "docker" "inspect" "bbd344de3b7e72f526376ae4ee99f22a563c1d3a8b9b53d9504740e3f96a918a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbd344de3b7e72f526376ae4ee99f22a563c1d3a8b9b53d9504740e3f96a918a", kill_on_drop: false }` [INFO] [stdout] bbd344de3b7e72f526376ae4ee99f22a563c1d3a8b9b53d9504740e3f96a918a