[INFO] cloning repository https://github.com/kilianmandscharo/greg [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kilianmandscharo/greg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkilianmandscharo%2Fgreg", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkilianmandscharo%2Fgreg'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0773ee077e3c1deb4769fca5d13fa9791aeaf231 [INFO] linting kilianmandscharo/greg against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkilianmandscharo%2Fgreg" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kilianmandscharo/greg [INFO] finished tweaking git repo https://github.com/kilianmandscharo/greg [INFO] tweaked toml for git repo https://github.com/kilianmandscharo/greg written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kilianmandscharo/greg on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kilianmandscharo/greg already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-mio v0.2.3 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.90 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.90 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.90 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.90 [INFO] [stderr] Downloaded iana-time-zone v0.1.59 [INFO] [stderr] Downloaded js-sys v0.3.67 [INFO] [stderr] Downloaded wasm-bindgen v0.2.90 [INFO] [stderr] Downloaded chrono v0.4.33 [INFO] [stderr] Downloaded libc v0.2.152 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ddd34f29d830cbeadc8d2ae5be77a2502ede8dd26d691cf690fc1e7e3f69f6e [INFO] running `Command { std: "docker" "start" "-a" "0ddd34f29d830cbeadc8d2ae5be77a2502ede8dd26d691cf690fc1e7e3f69f6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ddd34f29d830cbeadc8d2ae5be77a2502ede8dd26d691cf690fc1e7e3f69f6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ddd34f29d830cbeadc8d2ae5be77a2502ede8dd26d691cf690fc1e7e3f69f6e", kill_on_drop: false }` [INFO] [stdout] 0ddd34f29d830cbeadc8d2ae5be77a2502ede8dd26d691cf690fc1e7e3f69f6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cec58e14dbda8d377686d1fa8e9af0e8ddff6fadd5293c16d640fb430e1973cc [INFO] running `Command { std: "docker" "start" "-a" "cec58e14dbda8d377686d1fa8e9af0e8ddff6fadd5293c16d640fb430e1973cc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking greg v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `end` and `description` are never read [INFO] [stdout] --> src/block.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Block { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 5 | pub start: TimeOfDay, [INFO] [stdout] 6 | pub end: TimeOfDay, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub title: String, [INFO] [stdout] 8 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Block` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start` is never read [INFO] [stdout] --> src/time_of_day.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub struct TimeOfDayRange { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 50 | start: TimeOfDay, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/block.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new( [INFO] [stdout] 17 | | start: TimeOfDay, [INFO] [stdout] 18 | | end: TimeOfDay, [INFO] [stdout] 19 | | title: String, [INFO] [stdout] ... | [INFO] [stdout] 24 | | height: u16, [INFO] [stdout] 25 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / !(self.y + self.height < other.y || self.y > other.y + other.height) [INFO] [stdout] 40 | | && !(self.x + self.width < other.x || self.x > other.x + other.width) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `!(self.y + self.height < other.y || self.y > other.y + other.height || self.x + self.width < other.x || self.x > other.x + other.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/time_of_day.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `time_of_day::TimeOfDay` [INFO] [stdout] --> src/time_of_day.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn to_string(&self) -> String { [INFO] [stdout] 29 | | let hours = if self.hour < 10 { [INFO] [stdout] 30 | | format!("0{}", self.hour) [INFO] [stdout] 31 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 39 | | format!("{hours}:{minutes}") [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `time_of_day::TimeOfDay` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `end` and `description` are never read [INFO] [stdout] --> src/block.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Block { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 5 | pub start: TimeOfDay, [INFO] [stdout] 6 | pub end: TimeOfDay, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub title: String, [INFO] [stdout] 8 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Block` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start` is never read [INFO] [stdout] --> src/time_of_day.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub struct TimeOfDayRange { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 50 | start: TimeOfDay, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/block.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new( [INFO] [stdout] 17 | | start: TimeOfDay, [INFO] [stdout] 18 | | end: TimeOfDay, [INFO] [stdout] 19 | | title: String, [INFO] [stdout] ... | [INFO] [stdout] 24 | | height: u16, [INFO] [stdout] 25 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / !(self.y + self.height < other.y || self.y > other.y + other.height) [INFO] [stdout] 40 | | && !(self.x + self.width < other.x || self.x > other.x + other.width) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `!(self.y + self.height < other.y || self.y > other.y + other.height || self.x + self.width < other.x || self.x > other.x + other.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/time_of_day.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn to_string(&self) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `time_of_day::TimeOfDay` [INFO] [stdout] --> src/time_of_day.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn to_string(&self) -> String { [INFO] [stdout] 29 | | let hours = if self.hour < 10 { [INFO] [stdout] 30 | | format!("0{}", self.hour) [INFO] [stdout] 31 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 39 | | format!("{hours}:{minutes}") [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `time_of_day::TimeOfDay` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.05s [INFO] running `Command { std: "docker" "inspect" "cec58e14dbda8d377686d1fa8e9af0e8ddff6fadd5293c16d640fb430e1973cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cec58e14dbda8d377686d1fa8e9af0e8ddff6fadd5293c16d640fb430e1973cc", kill_on_drop: false }` [INFO] [stdout] cec58e14dbda8d377686d1fa8e9af0e8ddff6fadd5293c16d640fb430e1973cc