[INFO] cloning repository https://github.com/kikokikok/otel-tail-sampler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kikokikok/otel-tail-sampler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkikokikok%2Fotel-tail-sampler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkikokikok%2Fotel-tail-sampler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] db958f39a40d1bbc2a360851f466e98fd56101c0 [INFO] linting kikokikok/otel-tail-sampler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkikokikok%2Fotel-tail-sampler" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kikokikok/otel-tail-sampler [INFO] finished tweaking git repo https://github.com/kikokikok/otel-tail-sampler [INFO] tweaked toml for git repo https://github.com/kikokikok/otel-tail-sampler written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kikokikok/otel-tail-sampler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kikokikok/otel-tail-sampler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-retry v0.3.0 [INFO] [stderr] Downloaded crc16 v0.4.0 [INFO] [stderr] Downloaded arcstr v1.2.0 [INFO] [stderr] Downloaded task-local-extensions v0.1.4 [INFO] [stderr] Downloaded polars-schema v0.52.0 [INFO] [stderr] Downloaded streaming-decompression v0.1.2 [INFO] [stderr] Downloaded strength_reduce v0.2.4 [INFO] [stderr] Downloaded polars-dtype v0.52.0 [INFO] [stderr] Downloaded recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Downloaded murmur3 v0.5.2 [INFO] [stderr] Downloaded expect-test v1.5.1 [INFO] [stderr] Downloaded iceberg-datafusion v0.7.0 [INFO] [stderr] Downloaded dissimilar v1.0.10 [INFO] [stderr] Downloaded array-init v2.1.0 [INFO] [stderr] Downloaded as-any v0.3.2 [INFO] [stderr] Downloaded rkyv v0.7.45 [INFO] [stderr] Downloaded opentelemetry-proto v0.5.0 [INFO] [stderr] Downloaded datafusion-doc v48.0.1 [INFO] [stderr] Downloaded bimap v0.6.3 [INFO] [stderr] Downloaded datafusion-macros v48.0.1 [INFO] [stderr] Downloaded rust-ini v0.20.0 [INFO] [stderr] Downloaded arrow-string v55.2.0 [INFO] [stderr] Downloaded pest_generator v2.8.4 [INFO] [stderr] Downloaded pest_meta v2.8.4 [INFO] [stderr] Downloaded datafusion-datasource-parquet v48.0.1 [INFO] [stderr] Downloaded arrow v55.2.0 [INFO] [stderr] Downloaded datafusion-functions-aggregate v48.0.1 [INFO] [stderr] Downloaded async-compression v0.4.19 [INFO] [stderr] Downloaded pest v2.8.4 [INFO] [stderr] Downloaded polars-plan v0.52.0 [INFO] [stderr] Downloaded lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Downloaded datafusion-functions v48.0.1 [INFO] [stderr] Downloaded datafusion-optimizer v48.0.1 [INFO] [stderr] Downloaded datafusion-expr v48.0.1 [INFO] [stderr] Downloaded iceberg v0.7.0 [INFO] [stderr] Downloaded datafusion v48.0.1 [INFO] [stderr] Downloaded datafusion-common v48.0.1 [INFO] [stderr] Downloaded datafusion-physical-expr v48.0.1 [INFO] [stderr] Downloaded sqlparser v0.55.0 [INFO] [stderr] Downloaded datafusion-sql v48.0.1 [INFO] [stderr] Downloaded apache-avro v0.20.0 [INFO] [stderr] Downloaded parquet v55.2.0 [INFO] [stderr] Downloaded polars-core v0.52.0 [INFO] [stderr] Downloaded yaml-rust2 v0.8.1 [INFO] [stderr] Downloaded datafusion-datasource v48.0.1 [INFO] [stderr] Downloaded datafusion-physical-plan v48.0.1 [INFO] [stderr] Downloaded roaring v0.11.3 [INFO] [stderr] Downloaded datafusion-physical-optimizer v48.0.1 [INFO] [stderr] Downloaded datafusion-expr-common v48.0.1 [INFO] [stderr] Downloaded bon-macros v3.8.1 [INFO] [stderr] Downloaded polars-arrow v0.52.0 [INFO] [stderr] Downloaded redis v1.0.2 [INFO] [stderr] Downloaded datafusion-functions-nested v48.0.1 [INFO] [stderr] Downloaded opendal v0.54.1 [INFO] [stderr] Downloaded datafusion-catalog v48.0.1 [INFO] [stderr] Downloaded arrow-json v55.2.0 [INFO] [stderr] Downloaded bon v3.8.1 [INFO] [stderr] Downloaded arrow-ord v55.2.0 [INFO] [stderr] Downloaded iceberg-catalog-rest v0.7.0 [INFO] [stderr] Downloaded datafusion-functions-window v48.0.1 [INFO] [stderr] Downloaded datafusion-execution v48.0.1 [INFO] [stderr] Downloaded datafusion-functions-aggregate-common v48.0.1 [INFO] [stderr] Downloaded arrow-csv v55.2.0 [INFO] [stderr] Downloaded lzma-sys v0.1.20 [INFO] [stderr] Downloaded arrow-row v55.2.0 [INFO] [stderr] Downloaded datafusion-physical-expr-common v48.0.1 [INFO] [stderr] Downloaded polars-stream v0.52.0 [INFO] [stderr] Downloaded sqlparser v0.53.0 [INFO] [stderr] Downloaded pest_derive v2.8.4 [INFO] [stderr] Downloaded config v0.14.1 [INFO] [stderr] Downloaded bzip2 v0.5.2 [INFO] [stderr] Downloaded moka v0.12.12 [INFO] [stderr] Downloaded arrow-array v55.2.0 [INFO] [stderr] Downloaded opentelemetry_sdk v0.31.0 [INFO] [stderr] Downloaded datafusion-catalog-listing v48.0.1 [INFO] [stderr] Downloaded datafusion-datasource-csv v48.0.1 [INFO] [stderr] Downloaded datafusion-datasource-json v48.0.1 [INFO] [stderr] Downloaded datafusion-functions-table v48.0.1 [INFO] [stderr] Downloaded datafusion-session v48.0.1 [INFO] [stderr] Downloaded xz2 v0.1.7 [INFO] [stderr] Downloaded arrow-arith v55.2.0 [INFO] [stderr] Downloaded polars-io v0.52.0 [INFO] [stderr] Downloaded webpki-roots v1.0.4 [INFO] [stderr] Downloaded datafusion-common-runtime v48.0.1 [INFO] [stderr] Downloaded datafusion-functions-window-common v48.0.1 [INFO] [stderr] Downloaded proptest v1.9.0 [INFO] [stderr] Downloaded simd-json v0.17.0 [INFO] [stderr] Downloaded polars-parquet v0.52.0 [INFO] [stderr] Downloaded polars-expr v0.52.0 [INFO] [stderr] Downloaded polars-ops v0.52.0 [INFO] [stderr] Downloaded opentelemetry_sdk v0.22.1 [INFO] [stderr] Downloaded polars-compute v0.52.0 [INFO] [stderr] Downloaded arrow-ipc v55.2.0 [INFO] [stderr] Downloaded polars v0.52.0 [INFO] [stderr] Downloaded reqsign v0.16.5 [INFO] [stderr] Downloaded arrow-cast v55.2.0 [INFO] [stderr] Downloaded polars-arrow-format v0.2.1 [INFO] [stderr] Downloaded rdkafka v0.38.0 [INFO] [stderr] Downloaded opentelemetry v0.31.0 [INFO] [stderr] Downloaded arrow-select v55.2.0 [INFO] [stderr] Downloaded polars-lazy v0.52.0 [INFO] [stderr] Downloaded polars-sql v0.52.0 [INFO] [stderr] Downloaded polars-time v0.52.0 [INFO] [stderr] Downloaded bincode v2.0.1 [INFO] [stderr] Downloaded metrics-util v0.16.3 [INFO] [stderr] Downloaded tonic v0.11.0 [INFO] [stderr] Downloaded opentelemetry-proto v0.31.0 [INFO] [stderr] Downloaded opentelemetry v0.22.0 [INFO] [stderr] Downloaded arrow-buffer v55.2.0 [INFO] [stderr] Downloaded arrow-schema v55.2.0 [INFO] [stderr] Downloaded lz4_flex v0.11.5 [INFO] [stderr] Downloaded polars-mem-engine v0.52.0 [INFO] [stderr] Downloaded argminmax v0.6.3 [INFO] [stderr] Downloaded comfy-table v7.2.1 [INFO] [stderr] Downloaded virtue v0.0.18 [INFO] [stderr] Downloaded polars-utils v0.52.0 [INFO] [stderr] Downloaded jsonwebtoken v9.3.1 [INFO] [stderr] Downloaded arrow-data v55.2.0 [INFO] [stderr] Downloaded halfbrown v0.4.0 [INFO] [stderr] Downloaded polars-json v0.52.0 [INFO] [stderr] Downloaded polars-parquet-format v0.1.0 [INFO] [stderr] Downloaded planus v1.1.1 [INFO] [stderr] Downloaded rmp v0.8.15 [INFO] [stderr] Downloaded rmp-serde v1.3.1 [INFO] [stderr] Downloaded psm v0.1.28 [INFO] [stderr] Downloaded rkyv_derive v0.7.45 [INFO] [stderr] Downloaded pem v3.0.6 [INFO] [stderr] Downloaded metrics v0.22.4 [INFO] [stderr] Downloaded metrics-exporter-prometheus v0.13.1 [INFO] [stderr] Downloaded opentelemetry-semantic-conventions v0.14.0 [INFO] [stderr] Downloaded fs4 v0.13.1 [INFO] [stderr] Downloaded crc32c v0.6.8 [INFO] [stderr] Downloaded typed-builder-macro v0.20.1 [INFO] [stderr] Downloaded typed-builder v0.20.1 [INFO] [stderr] Downloaded tokio-io-timeout v1.2.1 [INFO] [stderr] Downloaded opentelemetry-otlp v0.15.0 [INFO] [stderr] Downloaded const-hex v1.17.0 [INFO] [stderr] Downloaded value-trait v0.12.1 [INFO] [stderr] Downloaded fast-float2 v0.2.3 [INFO] [stderr] Downloaded boxcar v0.2.14 [INFO] [stderr] Downloaded atoi_simd v0.16.1 [INFO] [stderr] Downloaded unicode-reverse v1.0.9 [INFO] [stderr] Downloaded polars-error v0.52.0 [INFO] [stderr] Downloaded lz4 v1.28.1 [INFO] [stderr] Downloaded array-init-cursor v0.2.1 [INFO] [stderr] Downloaded arc-swap v1.8.0 [INFO] [stderr] Downloaded ethnum v1.5.2 [INFO] [stderr] Downloaded os_pipe v1.2.3 [INFO] [stderr] Downloaded shared_child v1.1.1 [INFO] [stderr] Downloaded recursive v0.1.1 [INFO] [stderr] Downloaded now v0.1.3 [INFO] [stderr] Downloaded debug_unsafe v0.1.3 [INFO] [stderr] Downloaded polars-row v0.52.0 [INFO] [stderr] Downloaded bincode_derive v2.0.1 [INFO] [stderr] Downloaded unty v0.0.4 [INFO] [stderr] Downloaded serde_stacker v0.1.14 [INFO] [stderr] Downloaded ar_archive_writer v0.2.0 [INFO] [stderr] Downloaded sigchld v0.2.4 [INFO] [stderr] Downloaded warp v0.3.7 [INFO] [stderr] Downloaded backon v1.6.0 [INFO] [stderr] Downloaded reqwest-middleware v0.2.5 [INFO] [stderr] Downloaded rdkafka-sys v4.9.0+2.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ae23a4141c4742a7705ddce4c269a2d42dc7caf7f70157a376ad033571e051d [INFO] running `Command { std: "docker" "start" "-a" "0ae23a4141c4742a7705ddce4c269a2d42dc7caf7f70157a376ad033571e051d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ae23a4141c4742a7705ddce4c269a2d42dc7caf7f70157a376ad033571e051d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ae23a4141c4742a7705ddce4c269a2d42dc7caf7f70157a376ad033571e051d", kill_on_drop: false }` [INFO] [stdout] 0ae23a4141c4742a7705ddce4c269a2d42dc7caf7f70157a376ad033571e051d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8658fad8ede6d37daca97f6de1c72b430699f868d8207fb75a164b9a0cf33c30 [INFO] running `Command { std: "docker" "start" "-a" "8658fad8ede6d37daca97f6de1c72b430699f868d8207fb75a164b9a0cf33c30", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling object v0.32.2 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking array-init-cursor v0.2.1 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Compiling virtue v0.0.18 [INFO] [stderr] Checking planus v1.1.1 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Compiling polars-utils v0.52.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Compiling bincode_derive v2.0.1 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking phf_shared v0.12.1 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Compiling polars-schema v0.52.0 [INFO] [stderr] Compiling chrono-tz v0.10.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking rmp v0.8.15 [INFO] [stderr] Checking phf v0.12.1 [INFO] [stderr] Compiling polars-arrow v0.52.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking ethnum v1.5.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Compiling polars-compute v0.52.0 [INFO] [stderr] Checking debug_unsafe v0.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking atoi_simd v0.16.1 [INFO] [stderr] Checking fast-float2 v0.2.3 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking boxcar v0.2.14 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling polars-core v0.52.0 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling polars-ops v0.52.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking argminmax v0.6.3 [INFO] [stderr] Compiling os_pipe v1.2.3 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Compiling sigchld v0.2.4 [INFO] [stderr] Compiling polars-plan v0.52.0 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling shared_child v1.1.1 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling duct v0.13.7 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling polars-expr v0.52.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Compiling pest v2.8.4 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Compiling sasl2-sys v0.1.22+2.1.28 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling ar_archive_writer v0.2.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling polars-stream v0.52.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking fs4 v0.13.1 [INFO] [stderr] Compiling pest_meta v2.8.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Compiling time-core v0.1.6 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling time-macros v0.2.24 [INFO] [stderr] Compiling psm v0.1.28 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking comfy-table v7.2.1 [INFO] [stderr] Compiling rdkafka-sys v4.9.0+2.10.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Compiling pest_generator v2.8.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking serde_stacker v0.1.14 [INFO] [stderr] Compiling polars-lazy v0.52.0 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking recursive v0.1.1 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling prost-derive v0.14.1 [INFO] [stderr] Checking opentelemetry v0.31.0 [INFO] [stderr] Compiling pest_derive v2.8.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling num_enum_derive v0.7.5 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking opentelemetry v0.22.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking quanta v0.12.6 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking metrics v0.22.4 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling polars v0.52.0 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking polars-parquet-format v0.1.0 [INFO] [stderr] Checking num_enum v0.7.5 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking metrics-util v0.16.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking backon v1.6.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking opentelemetry_sdk v0.31.0 [INFO] [stderr] Checking rust-ini v0.20.0 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking polars-arrow-format v0.2.1 [INFO] [stderr] Checking rmp-serde v1.3.1 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking prost v0.14.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking yaml-rust2 v0.8.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking const-hex v1.17.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking arc-swap v1.8.0 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking task-local-extensions v0.1.4 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking arcstr v1.2.0 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.14.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking config v0.14.1 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-io-timeout v1.2.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tokio-retry v0.3.0 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking opentelemetry_sdk v0.22.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking rdkafka v0.38.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking redis v1.0.2 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking tonic v0.14.2 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking lz4 v1.28.1 [INFO] [stderr] Checking object_store v0.12.4 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking warp v0.3.7 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking metrics-exporter-prometheus v0.13.1 [INFO] [stderr] Checking tonic-prost v0.14.2 [INFO] [stderr] Checking opentelemetry-proto v0.31.0 [INFO] [stderr] Checking reqwest-middleware v0.2.5 [INFO] [stderr] Checking polars-error v0.52.0 [INFO] [stderr] Checking tonic v0.11.0 [INFO] [stderr] Checking opentelemetry-proto v0.5.0 [INFO] [stderr] Checking opentelemetry-otlp v0.15.0 [INFO] [stderr] Checking polars-dtype v0.52.0 [INFO] [stderr] Checking polars-row v0.52.0 [INFO] [stderr] Checking polars-parquet v0.52.0 [INFO] [stderr] Checking polars-time v0.52.0 [INFO] [stderr] Checking polars-io v0.52.0 [INFO] [stderr] Checking polars-mem-engine v0.52.0 [INFO] [stderr] Checking tail-sampling-selector v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/state.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(metadata) = inner.trace_metadata.get(trace_id) { [INFO] [stdout] 358 | | if metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(metadata) = inner.trace_metadata.get(trace_id) [INFO] [stdout] 358 ~ && metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:537:21 [INFO] [stdout] | [INFO] [stdout] 537 | / if now.duration_since(metadata.last_activity) > stuck_timeout { [INFO] [stdout] 538 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 536 ~ TraceStatus::Processing [INFO] [stdout] 537 ~ if now.duration_since(metadata.last_activity) > stuck_timeout => { [INFO] [stdout] 538 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | / if now.duration_since(*since) > stuck_timeout { [INFO] [stdout] 543 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 541 ~ TraceStatus::Investigation { since, .. } [INFO] [stdout] 542 ~ if now.duration_since(*since) > stuck_timeout => { [INFO] [stdout] 543 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 547 | / if now.duration_since(metadata.last_activity) > max_age { [INFO] [stdout] 548 | | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ TraceStatus::Active [INFO] [stdout] 547 ~ if now.duration_since(metadata.last_activity) > max_age => { [INFO] [stdout] 548 | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/observability/oidc.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if let Some(last_fetch) = cache.last_fetch { [INFO] [stdout] 113 | | if last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | | return Ok(cache.keys.clone()); [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if let Some(last_fetch) = cache.last_fetch [INFO] [stdout] 113 ~ && last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | return Ok(cache.keys.clone()); [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:220:21 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 221 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 223 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 221 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 228 | continue; [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 246 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 247 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 249 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 247 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 254 | continue; [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? { [INFO] [stdout] 285 | | if let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] 287 | | exported_trace_ids.push(trace_id.clone()); [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 284 ~ if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? [INFO] [stdout] 285 ~ && let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/state.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(metadata) = inner.trace_metadata.get(trace_id) { [INFO] [stdout] 358 | | if metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(metadata) = inner.trace_metadata.get(trace_id) [INFO] [stdout] 358 ~ && metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:537:21 [INFO] [stdout] | [INFO] [stdout] 537 | / if now.duration_since(metadata.last_activity) > stuck_timeout { [INFO] [stdout] 538 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 536 ~ TraceStatus::Processing [INFO] [stdout] 537 ~ if now.duration_since(metadata.last_activity) > stuck_timeout => { [INFO] [stdout] 538 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | / if now.duration_since(*since) > stuck_timeout { [INFO] [stdout] 543 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 541 ~ TraceStatus::Investigation { since, .. } [INFO] [stdout] 542 ~ if now.duration_since(*since) > stuck_timeout => { [INFO] [stdout] 543 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 547 | / if now.duration_since(metadata.last_activity) > max_age { [INFO] [stdout] 548 | | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ TraceStatus::Active [INFO] [stdout] 547 ~ if now.duration_since(metadata.last_activity) > max_age => { [INFO] [stdout] 548 | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await { [INFO] [stdout] 511 | | if !trace_ids.is_empty() { [INFO] [stdout] 512 | | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await [INFO] [stdout] 511 ~ && !trace_ids.is_empty() { [INFO] [stdout] 512 | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 519 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 519 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | / if let Some(rule_json) = conn.get::(key).await? { [INFO] [stdout] 626 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | | rules.push(rule); [INFO] [stdout] 628 | | } [INFO] [stdout] 629 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 625 ~ if let Some(rule_json) = conn.get::(key).await? [INFO] [stdout] 626 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | rules.push(rule); [INFO] [stdout] 628 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 632 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 632 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:796:13 [INFO] [stdout] | [INFO] [stdout] 796 | / if let Some(rule_json) = conn.get::(key.clone()).await? { [INFO] [stdout] 797 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] ... | [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 796 ~ if let Some(rule_json) = conn.get::(key.clone()).await? [INFO] [stdout] 797 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | if rule.expires_at <= now { [INFO] [stdout] ... [INFO] [stdout] 804 | } [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:797:17 [INFO] [stdout] | [INFO] [stdout] 797 | / if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] 800 | | conn.srem(REDIS_FORCE_RULES_KEY.to_string(), rule_id.clone()) [INFO] [stdout] ... | [INFO] [stdout] 805 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 797 ~ if let Ok(rule) = serde_json::from_str::(&rule_json) [INFO] [stdout] 798 ~ && rule.expires_at <= now { [INFO] [stdout] 799 | conn.del(key).await?; [INFO] [stdout] ... [INFO] [stdout] 803 | debug!("Cleaned up expired force rule '{}'", rule_id); [INFO] [stdout] 804 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/observability/oidc.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if let Some(last_fetch) = cache.last_fetch { [INFO] [stdout] 113 | | if last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | | return Ok(cache.keys.clone()); [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if let Some(last_fetch) = cache.last_fetch [INFO] [stdout] 113 ~ && last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | return Ok(cache.keys.clone()); [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/span_compression.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / if matches { [INFO] [stdout] 273 | | if let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | | return group_name.clone(); [INFO] [stdout] 275 | | } [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ if matches [INFO] [stdout] 273 ~ && let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | return group_name.clone(); [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:220:21 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 221 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 223 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 221 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 228 | continue; [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 246 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 247 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 249 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 247 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 254 | continue; [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? { [INFO] [stdout] 285 | | if let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] 287 | | exported_trace_ids.push(trace_id.clone()); [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 284 ~ if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? [INFO] [stdout] 285 ~ && let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await { [INFO] [stdout] 511 | | if !trace_ids.is_empty() { [INFO] [stdout] 512 | | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await [INFO] [stdout] 511 ~ && !trace_ids.is_empty() { [INFO] [stdout] 512 | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 519 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 519 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | / if let Some(rule_json) = conn.get::(key).await? { [INFO] [stdout] 626 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | | rules.push(rule); [INFO] [stdout] 628 | | } [INFO] [stdout] 629 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 625 ~ if let Some(rule_json) = conn.get::(key).await? [INFO] [stdout] 626 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | rules.push(rule); [INFO] [stdout] 628 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 632 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 632 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:796:13 [INFO] [stdout] | [INFO] [stdout] 796 | / if let Some(rule_json) = conn.get::(key.clone()).await? { [INFO] [stdout] 797 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] ... | [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 796 ~ if let Some(rule_json) = conn.get::(key.clone()).await? [INFO] [stdout] 797 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | if rule.expires_at <= now { [INFO] [stdout] ... [INFO] [stdout] 804 | } [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:797:17 [INFO] [stdout] | [INFO] [stdout] 797 | / if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] 800 | | conn.srem(REDIS_FORCE_RULES_KEY.to_string(), rule_id.clone()) [INFO] [stdout] ... | [INFO] [stdout] 805 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 797 ~ if let Ok(rule) = serde_json::from_str::(&rule_json) [INFO] [stdout] 798 ~ && rule.expires_at <= now { [INFO] [stdout] 799 | conn.del(key).await?; [INFO] [stdout] ... [INFO] [stdout] 803 | debug!("Cleaned up expired force rule '{}'", rule_id); [INFO] [stdout] 804 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bin/simple_producer.rs:611:13 [INFO] [stdout] | [INFO] [stdout] 611 | / if let Ok(true) = handle.await { [INFO] [stdout] 612 | | if !quiet { [INFO] [stdout] 613 | | let status = if with_error { [INFO] [stdout] 614 | | "\x1b[31mERROR\x1b[0m" [INFO] [stdout] ... | [INFO] [stdout] 623 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 611 ~ if let Ok(true) = handle.await [INFO] [stdout] 612 ~ && !quiet { [INFO] [stdout] 613 | let status = if with_error { [INFO] [stdout] ... [INFO] [stdout] 621 | println!(" [{}] Trace {:>4} | {} | {} spans", status, i, service, spans_per_trace); [INFO] [stdout] 622 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/simple_producer.rs:626:21 [INFO] [stdout] | [INFO] [stdout] 626 | if quiet && batch_end % 100 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `batch_end.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/span_compression.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / if matches { [INFO] [stdout] 273 | | if let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | | return group_name.clone(); [INFO] [stdout] 275 | | } [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ if matches [INFO] [stdout] 273 ~ && let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | return group_name.clone(); [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bin/simple_producer.rs:611:13 [INFO] [stdout] | [INFO] [stdout] 611 | / if let Ok(true) = handle.await { [INFO] [stdout] 612 | | if !quiet { [INFO] [stdout] 613 | | let status = if with_error { [INFO] [stdout] 614 | | "\x1b[31mERROR\x1b[0m" [INFO] [stdout] ... | [INFO] [stdout] 623 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 611 ~ if let Ok(true) = handle.await [INFO] [stdout] 612 ~ && !quiet { [INFO] [stdout] 613 | let status = if with_error { [INFO] [stdout] ... [INFO] [stdout] 621 | println!(" [{}] Trace {:>4} | {} | {} spans", status, i, service, spans_per_trace); [INFO] [stdout] 622 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/simple_producer.rs:626:21 [INFO] [stdout] | [INFO] [stdout] 626 | if quiet && batch_end % 100 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `batch_end.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/observability/oidc.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if let Some(last_fetch) = cache.last_fetch { [INFO] [stdout] 113 | | if last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | | return Ok(cache.keys.clone()); [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if let Some(last_fetch) = cache.last_fetch [INFO] [stdout] 113 ~ && last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | return Ok(cache.keys.clone()); [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:220:21 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 221 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 223 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 221 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 228 | continue; [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 246 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 247 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 249 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 247 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 254 | continue; [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? { [INFO] [stdout] 285 | | if let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] 287 | | exported_trace_ids.push(trace_id.clone()); [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 284 ~ if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? [INFO] [stdout] 285 ~ && let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await { [INFO] [stdout] 511 | | if !trace_ids.is_empty() { [INFO] [stdout] 512 | | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await [INFO] [stdout] 511 ~ && !trace_ids.is_empty() { [INFO] [stdout] 512 | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 519 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 519 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | / if let Some(rule_json) = conn.get::(key).await? { [INFO] [stdout] 626 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | | rules.push(rule); [INFO] [stdout] 628 | | } [INFO] [stdout] 629 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 625 ~ if let Some(rule_json) = conn.get::(key).await? [INFO] [stdout] 626 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | rules.push(rule); [INFO] [stdout] 628 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 632 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 632 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/observability/oidc.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / if let Some(last_fetch) = cache.last_fetch { [INFO] [stdout] 113 | | if last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | | return Ok(cache.keys.clone()); [INFO] [stdout] 115 | | } [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 112 ~ if let Some(last_fetch) = cache.last_fetch [INFO] [stdout] 113 ~ && last_fetch.elapsed() < cache_ttl && !cache.keys.is_empty() { [INFO] [stdout] 114 | return Ok(cache.keys.clone()); [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:796:13 [INFO] [stdout] | [INFO] [stdout] 796 | / if let Some(rule_json) = conn.get::(key.clone()).await? { [INFO] [stdout] 797 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] ... | [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 796 ~ if let Some(rule_json) = conn.get::(key.clone()).await? [INFO] [stdout] 797 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | if rule.expires_at <= now { [INFO] [stdout] ... [INFO] [stdout] 804 | } [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:797:17 [INFO] [stdout] | [INFO] [stdout] 797 | / if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] 800 | | conn.srem(REDIS_FORCE_RULES_KEY.to_string(), rule_id.clone()) [INFO] [stdout] ... | [INFO] [stdout] 805 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 797 ~ if let Ok(rule) = serde_json::from_str::(&rule_json) [INFO] [stdout] 798 ~ && rule.expires_at <= now { [INFO] [stdout] 799 | conn.del(key).await?; [INFO] [stdout] ... [INFO] [stdout] 803 | debug!("Cleaned up expired force rule '{}'", rule_id); [INFO] [stdout] 804 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:220:21 [INFO] [stdout] | [INFO] [stdout] 220 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 221 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 223 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 221 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 222 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 228 | continue; [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/span_compression.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / if matches { [INFO] [stdout] 273 | | if let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | | return group_name.clone(); [INFO] [stdout] 275 | | } [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ if matches [INFO] [stdout] 273 ~ && let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | return group_name.clone(); [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:246:25 [INFO] [stdout] | [INFO] [stdout] 246 | / if let Some(engine) = &self.force_rule_engine { [INFO] [stdout] 247 | | if let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] 249 | | debug!( [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Some(engine) = &self.force_rule_engine [INFO] [stdout] 247 ~ && let Some(ForceAction::ForceDrop) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 248 | crate::observability::metrics::TraceMetrics::trace_force_dropped(); [INFO] [stdout] ... [INFO] [stdout] 254 | continue; [INFO] [stdout] 255 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? { [INFO] [stdout] 285 | | if let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] 287 | | exported_trace_ids.push(trace_id.clone()); [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 284 ~ if let Some(spans) = self.trace_store.get_trace_spans(&trace_id).await? [INFO] [stdout] 285 ~ && let Some(ForceAction::ForceKeep) = engine.evaluate_trace(&spans).await { [INFO] [stdout] 286 | crate::observability::metrics::TraceMetrics::trace_force_sampled(); [INFO] [stdout] ... [INFO] [stdout] 292 | ); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/evaluator.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await { [INFO] [stdout] 511 | | if !trace_ids.is_empty() { [INFO] [stdout] 512 | | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Ok(trace_ids) = self.trace_store.get_all_trace_ids().await [INFO] [stdout] 511 ~ && !trace_ids.is_empty() { [INFO] [stdout] 512 | let _ = self.work_tx.send(EvaluationMessage::Batch(trace_ids)).await; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/state.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(metadata) = inner.trace_metadata.get(trace_id) { [INFO] [stdout] 358 | | if metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(metadata) = inner.trace_metadata.get(trace_id) [INFO] [stdout] 358 ~ && metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:537:21 [INFO] [stdout] | [INFO] [stdout] 537 | / if now.duration_since(metadata.last_activity) > stuck_timeout { [INFO] [stdout] 538 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 536 ~ TraceStatus::Processing [INFO] [stdout] 537 ~ if now.duration_since(metadata.last_activity) > stuck_timeout => { [INFO] [stdout] 538 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | / if now.duration_since(*since) > stuck_timeout { [INFO] [stdout] 543 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 541 ~ TraceStatus::Investigation { since, .. } [INFO] [stdout] 542 ~ if now.duration_since(*since) > stuck_timeout => { [INFO] [stdout] 543 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 547 | / if now.duration_since(metadata.last_activity) > max_age { [INFO] [stdout] 548 | | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ TraceStatus::Active [INFO] [stdout] 547 ~ if now.duration_since(metadata.last_activity) > max_age => { [INFO] [stdout] 548 | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/main.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | "memory" | _ => { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | let _metrics_handle = initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 103 - let _metrics_handle = initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] 103 + initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 519 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 519 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | / if let Some(rule_json) = conn.get::(key).await? { [INFO] [stdout] 626 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | | rules.push(rule); [INFO] [stdout] 628 | | } [INFO] [stdout] 629 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 625 ~ if let Some(rule_json) = conn.get::(key).await? [INFO] [stdout] 626 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 627 | rules.push(rule); [INFO] [stdout] 628 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sampling/force_sampling.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 632 | rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 632 - rules.sort_by(|a, b| b.priority.cmp(&a.priority)); [INFO] [stdout] 632 + rules.sort_by_key(|b| std::cmp::Reverse(b.priority)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:796:13 [INFO] [stdout] | [INFO] [stdout] 796 | / if let Some(rule_json) = conn.get::(key.clone()).await? { [INFO] [stdout] 797 | | if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] ... | [INFO] [stdout] 806 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 796 ~ if let Some(rule_json) = conn.get::(key.clone()).await? [INFO] [stdout] 797 ~ && let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | if rule.expires_at <= now { [INFO] [stdout] ... [INFO] [stdout] 804 | } [INFO] [stdout] 805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/force_sampling.rs:797:17 [INFO] [stdout] | [INFO] [stdout] 797 | / if let Ok(rule) = serde_json::from_str::(&rule_json) { [INFO] [stdout] 798 | | if rule.expires_at <= now { [INFO] [stdout] 799 | | conn.del(key).await?; [INFO] [stdout] 800 | | conn.srem(REDIS_FORCE_RULES_KEY.to_string(), rule_id.clone()) [INFO] [stdout] ... | [INFO] [stdout] 805 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 797 ~ if let Ok(rule) = serde_json::from_str::(&rule_json) [INFO] [stdout] 798 ~ && rule.expires_at <= now { [INFO] [stdout] 799 | conn.del(key).await?; [INFO] [stdout] ... [INFO] [stdout] 803 | debug!("Cleaned up expired force rule '{}'", rule_id); [INFO] [stdout] 804 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sampling/span_compression.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / if matches { [INFO] [stdout] 273 | | if let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | | return group_name.clone(); [INFO] [stdout] 275 | | } [INFO] [stdout] 276 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 272 ~ if matches [INFO] [stdout] 273 ~ && let Some(ref group_name) = sql_pattern.group_name { [INFO] [stdout] 274 | return group_name.clone(); [INFO] [stdout] 275 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/state.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | / if let Some(metadata) = inner.trace_metadata.get(trace_id) { [INFO] [stdout] 358 | | if metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 357 ~ if let Some(metadata) = inner.trace_metadata.get(trace_id) [INFO] [stdout] 358 ~ && metadata.status == TraceStatus::Active { [INFO] [stdout] 359 | large_traces.push(trace_id.clone()); [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:537:21 [INFO] [stdout] | [INFO] [stdout] 537 | / if now.duration_since(metadata.last_activity) > stuck_timeout { [INFO] [stdout] 538 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 536 ~ TraceStatus::Processing [INFO] [stdout] 537 ~ if now.duration_since(metadata.last_activity) > stuck_timeout => { [INFO] [stdout] 538 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 539 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:542:21 [INFO] [stdout] | [INFO] [stdout] 542 | / if now.duration_since(*since) > stuck_timeout { [INFO] [stdout] 543 | | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 541 ~ TraceStatus::Investigation { since, .. } [INFO] [stdout] 542 ~ if now.duration_since(*since) > stuck_timeout => { [INFO] [stdout] 543 | stuck_traces.push(trace_id.clone()); [INFO] [stdout] 544 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/state.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 547 | / if now.duration_since(metadata.last_activity) > max_age { [INFO] [stdout] 548 | | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 546 ~ TraceStatus::Active [INFO] [stdout] 547 ~ if now.duration_since(metadata.last_activity) > max_age => { [INFO] [stdout] 548 | expired_traces.push(trace_id.clone()); [INFO] [stdout] 549 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/main.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | "memory" | _ => { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | let _metrics_handle = initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 103 - let _metrics_handle = initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] 103 + initialize_all_metrics(config.metrics_socket_addr()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 02s [INFO] running `Command { std: "docker" "inspect" "8658fad8ede6d37daca97f6de1c72b430699f868d8207fb75a164b9a0cf33c30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8658fad8ede6d37daca97f6de1c72b430699f868d8207fb75a164b9a0cf33c30", kill_on_drop: false }` [INFO] [stdout] 8658fad8ede6d37daca97f6de1c72b430699f868d8207fb75a164b9a0cf33c30