[INFO] cloning repository https://github.com/kiernfeeney/syslog-server
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kiernfeeney/syslog-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkiernfeeney%2Fsyslog-server", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkiernfeeney%2Fsyslog-server'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 2d3b08777d66fd2d209caeb0147523ae276142c5
[INFO] linting kiernfeeney/syslog-server against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkiernfeeney%2Fsyslog-server" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/kiernfeeney/syslog-server
[INFO] finished tweaking git repo https://github.com/kiernfeeney/syslog-server
[INFO] tweaked toml for git repo https://github.com/kiernfeeney/syslog-server written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/kiernfeeney/syslog-server on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/kiernfeeney/syslog-server already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 9e21d0d463a7495ec62b1c424726e18993dea5730baf6547582bf68656abcd4f
[INFO] running `Command { std: "docker" "start" "-a" "9e21d0d463a7495ec62b1c424726e18993dea5730baf6547582bf68656abcd4f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "9e21d0d463a7495ec62b1c424726e18993dea5730baf6547582bf68656abcd4f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "9e21d0d463a7495ec62b1c424726e18993dea5730baf6547582bf68656abcd4f", kill_on_drop: false }`
[INFO] [stdout] 9e21d0d463a7495ec62b1c424726e18993dea5730baf6547582bf68656abcd4f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] fff88e81fc4bb4ddaa17583b9523e2abbad0f88102febb5e9bd8ce332e0f621e
[INFO] running `Command { std: "docker" "start" "-a" "fff88e81fc4bb4ddaa17583b9523e2abbad0f88102febb5e9bd8ce332e0f621e", kill_on_drop: false }`
[INFO] [stderr]     Checking mio v1.1.1
[INFO] [stderr]     Checking socket2 v0.6.1
[INFO] [stderr]    Compiling tokio-macros v2.6.0
[INFO] [stderr]     Checking chrono v0.4.42
[INFO] [stderr]     Checking tokio v1.48.0
[INFO] [stderr]     Checking syslog-server v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/syslog/parser.rs:38:18
[INFO] [stdout]    |
[INFO] [stdout] 38 |         .map_err(|e| ParseErr::MalformedTimestamp(e))?;
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseErr::MalformedTimestamp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:49:8
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if hostname.len() == 0 || hostname.len() > 255 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hostname.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:65:8
[INFO] [stdout]    |
[INFO] [stdout] 65 |     if app_name.len() == 0 || app_name.len() > 48 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app_name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:81:8
[INFO] [stdout]    |
[INFO] [stdout] 81 |     if procid.len() == 0 || procid.len() > 128 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `procid.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:97:8
[INFO] [stdout]    |
[INFO] [stdout] 97 |     if msgid.len() == 0 || msgid.len() > 32 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msgid.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]    --> src/syslog/parser.rs:117:9
[INFO] [stdout]     |
[INFO] [stdout] 117 |         while let Some(i) = parts.next() {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in parts`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]     = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/syslog/parser.rs:124:16
[INFO] [stdout]     |
[INFO] [stdout] 124 |             if tmp.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tmp.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/syslog/parser.rs:235:8
[INFO] [stdout]     |
[INFO] [stdout] 235 |     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 235 -     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout] 235 +     if !(c == '"' && !is_escaped) {
[INFO] [stdout]     |
[INFO] [stdout] 235 -     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout] 235 +     if c != '"' || is_escaped {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/syslog/parser.rs:259:3
[INFO] [stdout]     |
[INFO] [stdout] 259 |   return Err(ParseErr::Unfinished);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 259 -   return Err(ParseErr::Unfinished);
[INFO] [stdout] 259 +   Err(ParseErr::Unfinished)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/syslog/parser.rs:38:18
[INFO] [stdout]    |
[INFO] [stdout] 38 |         .map_err(|e| ParseErr::MalformedTimestamp(e))?;
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ParseErr::MalformedTimestamp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:49:8
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if hostname.len() == 0 || hostname.len() > 255 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hostname.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:65:8
[INFO] [stdout]    |
[INFO] [stdout] 65 |     if app_name.len() == 0 || app_name.len() > 48 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app_name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:81:8
[INFO] [stdout]    |
[INFO] [stdout] 81 |     if procid.len() == 0 || procid.len() > 128 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `procid.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/syslog/parser.rs:97:8
[INFO] [stdout]    |
[INFO] [stdout] 97 |     if msgid.len() == 0 || msgid.len() > 32 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msgid.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]    --> src/syslog/parser.rs:117:9
[INFO] [stdout]     |
[INFO] [stdout] 117 |         while let Some(i) = parts.next() {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in parts`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]     = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/syslog/parser.rs:124:16
[INFO] [stdout]     |
[INFO] [stdout] 124 |             if tmp.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!tmp.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/syslog/parser.rs:235:8
[INFO] [stdout]     |
[INFO] [stdout] 235 |     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 235 -     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout] 235 +     if !(c == '"' && !is_escaped) {
[INFO] [stdout]     |
[INFO] [stdout] 235 -     if c != '"' || (c == '"' && is_escaped) {
[INFO] [stdout] 235 +     if c != '"' || is_escaped {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/syslog/parser.rs:259:3
[INFO] [stdout]     |
[INFO] [stdout] 259 |   return Err(ParseErr::Unfinished);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 259 -   return Err(ParseErr::Unfinished);
[INFO] [stdout] 259 +   Err(ParseErr::Unfinished)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.47s
[INFO] running `Command { std: "docker" "inspect" "fff88e81fc4bb4ddaa17583b9523e2abbad0f88102febb5e9bd8ce332e0f621e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "fff88e81fc4bb4ddaa17583b9523e2abbad0f88102febb5e9bd8ce332e0f621e", kill_on_drop: false }`
[INFO] [stdout] fff88e81fc4bb4ddaa17583b9523e2abbad0f88102febb5e9bd8ce332e0f621e