[INFO] cloning repository https://github.com/khoutz182/DearDiary [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/khoutz182/DearDiary" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhoutz182%2FDearDiary", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhoutz182%2FDearDiary'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] edd2256520f5d85ea6aaaa46e193a36e2dae3a72 [INFO] linting khoutz182/DearDiary against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhoutz182%2FDearDiary" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/khoutz182/DearDiary [INFO] finished tweaking git repo https://github.com/khoutz182/DearDiary [INFO] tweaked toml for git repo https://github.com/khoutz182/DearDiary written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/khoutz182/DearDiary on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/khoutz182/DearDiary already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uuid v0.4.0 [INFO] [stderr] Downloaded confy v0.3.1 [INFO] [stderr] Downloaded directories v0.10.0 [INFO] [stderr] Downloaded syn v1.0.58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 795418595c193b5659e06eb648acb13c0b168676f76456a24a096647928a2687 [INFO] running `Command { std: "docker" "start" "-a" "795418595c193b5659e06eb648acb13c0b168676f76456a24a096647928a2687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "795418595c193b5659e06eb648acb13c0b168676f76456a24a096647928a2687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "795418595c193b5659e06eb648acb13c0b168676f76456a24a096647928a2687", kill_on_drop: false }` [INFO] [stdout] 795418595c193b5659e06eb648acb13c0b168676f76456a24a096647928a2687 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d3511571cb05c0c55e2f85ff45d5114e90516d08dda761515bca92520479c7d [INFO] running `Command { std: "docker" "start" "-a" "1d3511571cb05c0c55e2f85ff45d5114e90516d08dda761515bca92520479c7d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking directories v0.10.0 [INFO] [stderr] Checking shellexpand v2.1.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking confy v0.3.1 [INFO] [stderr] Checking dear_diary v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return DiaryCommand::from_args() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return DiaryCommand::from_args() [INFO] [stdout] 34 + DiaryCommand::from_args() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return shellexpand::tilde(&self.diary_directory).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return shellexpand::tilde(&self.diary_directory).into(); [INFO] [stdout] 21 + shellexpand::tilde(&self.diary_directory).into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok(()); [INFO] [stdout] 40 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return input_val.replace(" ", "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return input_val.replace(" ", "_"); [INFO] [stdout] 59 + input_val.replace(" ", "_") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / match io::stdout().flush() { [INFO] [stdout] 48 | | Err(e) => eprintln!("Error flushing stdout: {}", e), [INFO] [stdout] 49 | | _ => {} [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(e) = io::stdout().flush() { eprintln!("Error flushing stdout: {}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if !config.editor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.editor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return Err(String::from( [INFO] [stdout] 77 | | "Editor not set in configuration or defined in environment variables", [INFO] [stdout] 78 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ Err(String::from( [INFO] [stdout] 77 + "Editor not set in configuration or defined in environment variables", [INFO] [stdout] 78 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / match env_editor { [INFO] [stdout] 72 | | Ok(editor) => return Ok(editor), [INFO] [stdout] 73 | | _ => {} [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(editor) = env_editor { return Ok(editor) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return String::from("interactive"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return String::from("interactive"); [INFO] [stdout] 123 + String::from("interactive") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return String::from("latest"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return String::from("latest"); [INFO] [stdout] 127 + String::from("latest") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return DiaryCommand::from_args() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return DiaryCommand::from_args() [INFO] [stdout] 34 + DiaryCommand::from_args() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return shellexpand::tilde(&self.diary_directory).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return shellexpand::tilde(&self.diary_directory).into(); [INFO] [stdout] 21 + shellexpand::tilde(&self.diary_directory).into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok(()); [INFO] [stdout] 40 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return input_val.replace(" ", "_"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return input_val.replace(" ", "_"); [INFO] [stdout] 59 + input_val.replace(" ", "_") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / match io::stdout().flush() { [INFO] [stdout] 48 | | Err(e) => eprintln!("Error flushing stdout: {}", e), [INFO] [stdout] 49 | | _ => {} [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(e) = io::stdout().flush() { eprintln!("Error flushing stdout: {}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if !config.editor.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.editor.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return Err(String::from( [INFO] [stdout] 77 | | "Editor not set in configuration or defined in environment variables", [INFO] [stdout] 78 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ Err(String::from( [INFO] [stdout] 77 + "Editor not set in configuration or defined in environment variables", [INFO] [stdout] 78 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / match env_editor { [INFO] [stdout] 72 | | Ok(editor) => return Ok(editor), [INFO] [stdout] 73 | | _ => {} [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(editor) = env_editor { return Ok(editor) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return String::from("interactive"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return String::from("interactive"); [INFO] [stdout] 123 + String::from("interactive") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return String::from("latest"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return String::from("latest"); [INFO] [stdout] 127 + String::from("latest") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.22s [INFO] running `Command { std: "docker" "inspect" "1d3511571cb05c0c55e2f85ff45d5114e90516d08dda761515bca92520479c7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d3511571cb05c0c55e2f85ff45d5114e90516d08dda761515bca92520479c7d", kill_on_drop: false }` [INFO] [stdout] 1d3511571cb05c0c55e2f85ff45d5114e90516d08dda761515bca92520479c7d