[INFO] cloning repository https://github.com/khamui/codex-importer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/khamui/codex-importer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamui%2Fcodex-importer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamui%2Fcodex-importer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d9db2b3f7a1d666d5cf86668173a842e01a2acc1 [INFO] linting khamui/codex-importer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamui%2Fcodex-importer" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/khamui/codex-importer [INFO] finished tweaking git repo https://github.com/khamui/codex-importer [INFO] tweaked toml for git repo https://github.com/khamui/codex-importer written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/khamui/codex-importer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/khamui/codex-importer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18c06ca4e314a725077a7266c8deae551cf60bf83f7faf17310975781925af04 [INFO] running `Command { std: "docker" "start" "-a" "18c06ca4e314a725077a7266c8deae551cf60bf83f7faf17310975781925af04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18c06ca4e314a725077a7266c8deae551cf60bf83f7faf17310975781925af04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18c06ca4e314a725077a7266c8deae551cf60bf83f7faf17310975781925af04", kill_on_drop: false }` [INFO] [stdout] 18c06ca4e314a725077a7266c8deae551cf60bf83f7faf17310975781925af04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bba167e7cb92f5be2c95eb1d5b431d16b2293516bacc917f18d83399349d302 [INFO] running `Command { std: "docker" "start" "-a" "9bba167e7cb92f5be2c95eb1d5b431d16b2293516bacc917f18d83399349d302", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking codex_importer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:86:32 [INFO] [stdout] | [INFO] [stdout] 86 | fn read_filenames(import_path: &PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - fn read_filenames(import_path: &PathBuf) -> Vec { [INFO] [stdout] 86 + fn read_filenames(import_path: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if !notebook.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `notebook.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `notebook` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:147:45 [INFO] [stdout] | [INFO] [stdout] 146 | if !notebook.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 147 | json.items.push(CodexItem::Notebook(notebook.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:194:61 [INFO] [stdout] | [INFO] [stdout] 194 | fn get_deltas(node_filenames: &Vec, tree_filenames: &Vec) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 ~ fn get_deltas(node_filenames: &Vec, tree_filenames: &[String]) -> (Vec, Vec) { [INFO] [stdout] 195 | let mut delta_tree: Vec = vec![]; [INFO] [stdout] 196 | [INFO] [stdout] 197 | // delta_tree collects all files, which are not in node_filenames yet [INFO] [stdout] 198 ~ for tree_fname in tree_filenames.to_owned() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | if !tree_filenames.contains(&node_fname) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `node_fname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:86:32 [INFO] [stdout] | [INFO] [stdout] 86 | fn read_filenames(import_path: &PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - fn read_filenames(import_path: &PathBuf) -> Vec { [INFO] [stdout] 86 + fn read_filenames(import_path: &Path) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if !notebook.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `notebook.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `notebook` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:147:45 [INFO] [stdout] | [INFO] [stdout] 146 | if !notebook.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 147 | json.items.push(CodexItem::Notebook(notebook.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:194:61 [INFO] [stdout] | [INFO] [stdout] 194 | fn get_deltas(node_filenames: &Vec, tree_filenames: &Vec) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 ~ fn get_deltas(node_filenames: &Vec, tree_filenames: &[String]) -> (Vec, Vec) { [INFO] [stdout] 195 | let mut delta_tree: Vec = vec![]; [INFO] [stdout] 196 | [INFO] [stdout] 197 | // delta_tree collects all files, which are not in node_filenames yet [INFO] [stdout] 198 ~ for tree_fname in tree_filenames.to_owned() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:207:37 [INFO] [stdout] | [INFO] [stdout] 207 | if !tree_filenames.contains(&node_fname) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `node_fname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.15s [INFO] running `Command { std: "docker" "inspect" "9bba167e7cb92f5be2c95eb1d5b431d16b2293516bacc917f18d83399349d302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bba167e7cb92f5be2c95eb1d5b431d16b2293516bacc917f18d83399349d302", kill_on_drop: false }` [INFO] [stdout] 9bba167e7cb92f5be2c95eb1d5b431d16b2293516bacc917f18d83399349d302