[INFO] cloning repository https://github.com/khamdany/Split-string
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/khamdany/Split-string" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamdany%2FSplit-string", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamdany%2FSplit-string'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] d5a550ed3eb73207b1a6ac064ec686161a69b380
[INFO] linting khamdany/Split-string against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkhamdany%2FSplit-string" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/khamdany/Split-string
[INFO] finished tweaking git repo https://github.com/khamdany/Split-string
[INFO] tweaked toml for git repo https://github.com/khamdany/Split-string written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/khamdany/Split-string on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/khamdany/Split-string already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] c8176a93830520070511235559f0ea6187662ac689e969e1c2a113bb533b4e46
[INFO] running `Command { std: "docker" "start" "-a" "c8176a93830520070511235559f0ea6187662ac689e969e1c2a113bb533b4e46", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "c8176a93830520070511235559f0ea6187662ac689e969e1c2a113bb533b4e46", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c8176a93830520070511235559f0ea6187662ac689e969e1c2a113bb533b4e46", kill_on_drop: false }`
[INFO] [stdout] c8176a93830520070511235559f0ea6187662ac689e969e1c2a113bb533b4e46
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8aedd57b462d6ab5bde68e9d8895f2a3a0422aee9d8a32450ddc9cc42dc760e7
[INFO] running `Command { std: "docker" "start" "-a" "8aedd57b462d6ab5bde68e9d8895f2a3a0422aee9d8a32450ddc9cc42dc760e7", kill_on_drop: false }`
[INFO] [stderr]     Checking split_string v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/logic.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let joined = (used_string, left_string);
[INFO] [stdout]    |         ---------------------------------------- unnecessary `let` binding
[INFO] [stdout] 41 |         joined
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 40 ~         
[INFO] [stdout] 41 ~         (used_string, left_string)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/logic.rs:50:15
[INFO] [stdout]    |
[INFO] [stdout] 50 |     } else if !args[1].parse::<i32>().is_ok() {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].parse::<i32>().is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/logic.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let joined = (used_string, left_string);
[INFO] [stdout]    |         ---------------------------------------- unnecessary `let` binding
[INFO] [stdout] 41 |         joined
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 40 ~         
[INFO] [stdout] 41 ~         (used_string, left_string)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/logic.rs:82:17
[INFO] [stdout]    |
[INFO] [stdout] 82 |     f.write_all(&first)?;
[INFO] [stdout]    |                 ^^^^^^ help: change this to: `first`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/logic.rs:85:17
[INFO] [stdout]    |
[INFO] [stdout] 85 |     c.write_all(&second)?;
[INFO] [stdout]    |                 ^^^^^^^ help: change this to: `second`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/logic.rs:50:15
[INFO] [stdout]    |
[INFO] [stdout] 50 |     } else if !args[1].parse::<i32>().is_ok() {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].parse::<i32>().is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/logic.rs:82:17
[INFO] [stdout]    |
[INFO] [stdout] 82 |     f.write_all(&first)?;
[INFO] [stdout]    |                 ^^^^^^ help: change this to: `first`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/logic.rs:85:17
[INFO] [stdout]    |
[INFO] [stdout] 85 |     c.write_all(&second)?;
[INFO] [stdout]    |                 ^^^^^^^ help: change this to: `second`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.11s
[INFO] running `Command { std: "docker" "inspect" "8aedd57b462d6ab5bde68e9d8895f2a3a0422aee9d8a32450ddc9cc42dc760e7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8aedd57b462d6ab5bde68e9d8895f2a3a0422aee9d8a32450ddc9cc42dc760e7", kill_on_drop: false }`
[INFO] [stdout] 8aedd57b462d6ab5bde68e9d8895f2a3a0422aee9d8a32450ddc9cc42dc760e7