[INFO] cloning repository https://github.com/kernelmachine/cargo-profiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kernelmachine/cargo-profiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkernelmachine%2Fcargo-profiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkernelmachine%2Fcargo-profiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0a8ab772fd5c0f1579e4847c5d05aa443ffa2bc8 [INFO] linting kernelmachine/cargo-profiler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkernelmachine%2Fcargo-profiler" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kernelmachine/cargo-profiler [INFO] finished tweaking git repo https://github.com/kernelmachine/cargo-profiler [INFO] tweaked toml for git repo https://github.com/kernelmachine/cargo-profiler written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kernelmachine/cargo-profiler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kernelmachine/cargo-profiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thread_local v1.0.1 [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded unicode-width v0.1.6 [INFO] [stderr] Downloaded serde_derive v1.0.131 [INFO] [stderr] Downloaded num-complex v0.2.3 [INFO] [stderr] Downloaded clap v2.33.0 [INFO] [stderr] Downloaded serde_json v1.0.75 [INFO] [stderr] Downloaded serde v1.0.131 [INFO] [stderr] Downloaded ndarray v0.13.1 [INFO] [stderr] Downloaded regex v1.4.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3086d7226b1747feee44a295b0e00e1dea5cddc7df3bbd8b3b4f07be0d176f47 [INFO] running `Command { std: "docker" "start" "-a" "3086d7226b1747feee44a295b0e00e1dea5cddc7df3bbd8b3b4f07be0d176f47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3086d7226b1747feee44a295b0e00e1dea5cddc7df3bbd8b3b4f07be0d176f47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3086d7226b1747feee44a295b0e00e1dea5cddc7df3bbd8b3b4f07be0d176f47", kill_on_drop: false }` [INFO] [stdout] 3086d7226b1747feee44a295b0e00e1dea5cddc7df3bbd8b3b4f07be0d176f47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5509e2eed2e34cb9d90eb11356d501373e55fe4950c5801f36351bc8af0ba6f [INFO] running `Command { std: "docker" "start" "-a" "c5509e2eed2e34cb9d90eb11356d501373e55fe4950c5801f36351bc8af0ba6f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling serde_derive v1.0.131 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling serde v1.0.131 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Compiling serde_json v1.0.75 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking cargo-profiler v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/display.rs:62:89 [INFO] [stdout] | [INFO] [stdout] 62 | \n\x1b[32mTotal LL D-Cache Misses\x1b[0m...{} ({}%)\t\x1b[0m\n\n\ [INFO] [stdout] | _________________________________________________________________________________________^ [INFO] [stdout] 63 | | [INFO] [stdout] 64 | | ", [INFO] [stdout] | |____________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/display.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | static DASHES: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/err.rs:128:48 [INFO] [stdout] | [INFO] [stdout] 128 | ProfError::IOError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / data.as_object() [INFO] [stdout] 52 | | .expect("Could not extract object from read manifest JSON. Please submit bug.") [INFO] [stdout] 53 | | .get("name") [INFO] [stdout] 54 | | .ok_or(ProfError::NoNameError) [INFO] [stdout] 55 | | .and_then(|x| Ok(x.to_string().replace("\"", ""))) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ data.as_object() [INFO] [stdout] 52 + .expect("Could not extract object from read manifest JSON. Please submit bug.") [INFO] [stdout] 53 + .get("name") [INFO] [stdout] 54 + .ok_or(ProfError::NoNameError).map(|x| x.to_string().replace("\"", "")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cargo.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | .args(&["build", "--release"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--release"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 91 | let target_dir = find_target() [INFO] [stdout] | ______________________^ [INFO] [stdout] 92 | | .ok_or(ProfError::NoTargetDirectory) [INFO] [stdout] 93 | | .and_then(|x| { [INFO] [stdout] 94 | | Ok(x.to_str() [INFO] [stdout] 95 | | .expect("target directory could not be converted to string.") [INFO] [stdout] 96 | | .to_string()) [INFO] [stdout] 97 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 ~ let target_dir = find_target() [INFO] [stdout] 92 + .ok_or(ProfError::NoTargetDirectory).map(|x| x.to_str() [INFO] [stdout] 93 + .expect("target directory could not be converted to string.") [INFO] [stdout] 94 ~ .to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | let path = target_dir [INFO] [stdout] | ________________^ [INFO] [stdout] 99 | | .and_then(|x| Ok(x + binary_dir + &package_name)) [INFO] [stdout] | |_________________________________________________________^ help: try: `target_dir.map(|x| x + binary_dir + &package_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 126 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/display.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 128 | ... t if (t >= 30.0) & (t < 50.0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(30.0..50.0).contains(&t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:136:33 [INFO] [stdout] | [INFO] [stdout] 136 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:146:33 [INFO] [stdout] | [INFO] [stdout] 146 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/parse/cachegrind.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | let errs = out_split [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | .to_owned() [INFO] [stdout] 89 | | .into_iter() [INFO] [stdout] | |________________________^ help: use: `out_split.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse/cachegrind.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / &data_vec [INFO] [stdout] 144 | | .iter() [INFO] [stdout] 145 | | .map(|x| x.view()) [INFO] [stdout] 146 | | .collect::>() [INFO] [stdout] 147 | | .as_slice(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 143 ~ data_vec [INFO] [stdout] 144 + .iter() [INFO] [stdout] 145 + .map(|x| x.view()) [INFO] [stdout] 146 + .collect::>() [INFO] [stdout] 147 ~ .as_slice(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/parse/cachegrind.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | .map(|&x| (&funcs[x]).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `funcs[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/parse/callgrind.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 50 | let errs = out_split [INFO] [stdout] | ____________________^ [INFO] [stdout] 51 | | .to_owned() [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] | |________________________^ help: use: `out_split.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/callgrind.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | assert!(is_err && true) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `is_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse/callgrind.rs:119:47 [INFO] [stdout] | [INFO] [stdout] 119 | let is_err = profiler.callgrind_parse(&output, num).is_err(); [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | try_or_exit!(get_binary(&m)).to_string() [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 139 | let num = try_or_exit!(get_num(&m)); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:140:52 [INFO] [stdout] | [INFO] [stdout] 140 | let sort_metric = try_or_exit!(get_sort_metric(&m)); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stdout] --> src/parse/cachegrind.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 136 | let _ = func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stdout] --> src/parse/callgrind.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/display.rs:62:89 [INFO] [stdout] | [INFO] [stdout] 62 | \n\x1b[32mTotal LL D-Cache Misses\x1b[0m...{} ({}%)\t\x1b[0m\n\n\ [INFO] [stdout] | _________________________________________________________________________________________^ [INFO] [stdout] 63 | | [INFO] [stdout] 64 | | ", [INFO] [stdout] | |____________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/display.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | static DASHES: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/err.rs:128:48 [INFO] [stdout] | [INFO] [stdout] 128 | ProfError::IOError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / data.as_object() [INFO] [stdout] 52 | | .expect("Could not extract object from read manifest JSON. Please submit bug.") [INFO] [stdout] 53 | | .get("name") [INFO] [stdout] 54 | | .ok_or(ProfError::NoNameError) [INFO] [stdout] 55 | | .and_then(|x| Ok(x.to_string().replace("\"", ""))) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ data.as_object() [INFO] [stdout] 52 + .expect("Could not extract object from read manifest JSON. Please submit bug.") [INFO] [stdout] 53 + .get("name") [INFO] [stdout] 54 + .ok_or(ProfError::NoNameError).map(|x| x.to_string().replace("\"", "")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/cargo.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 71 | .args(&["build", "--release"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--release"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 91 | let target_dir = find_target() [INFO] [stdout] | ______________________^ [INFO] [stdout] 92 | | .ok_or(ProfError::NoTargetDirectory) [INFO] [stdout] 93 | | .and_then(|x| { [INFO] [stdout] 94 | | Ok(x.to_str() [INFO] [stdout] 95 | | .expect("target directory could not be converted to string.") [INFO] [stdout] 96 | | .to_string()) [INFO] [stdout] 97 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 ~ let target_dir = find_target() [INFO] [stdout] 92 + .ok_or(ProfError::NoTargetDirectory).map(|x| x.to_str() [INFO] [stdout] 93 + .expect("target directory could not be converted to string.") [INFO] [stdout] 94 ~ .to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cargo.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | let path = target_dir [INFO] [stdout] | ________________^ [INFO] [stdout] 99 | | .and_then(|x| Ok(x + binary_dir + &package_name)) [INFO] [stdout] | |_________________________________________________________^ help: try: `target_dir.map(|x| x + binary_dir + &package_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 98 | println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 126 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/display.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 128 | ... t if (t >= 30.0) & (t < 50.0) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(30.0..50.0).contains(&t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:136:33 [INFO] [stdout] | [INFO] [stdout] 136 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/display.rs:146:33 [INFO] [stdout] | [INFO] [stdout] 146 | ... println!("{}", DASHES); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/parse/cachegrind.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | let errs = out_split [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | .to_owned() [INFO] [stdout] 89 | | .into_iter() [INFO] [stdout] | |________________________^ help: use: `out_split.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse/cachegrind.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / &data_vec [INFO] [stdout] 144 | | .iter() [INFO] [stdout] 145 | | .map(|x| x.view()) [INFO] [stdout] 146 | | .collect::>() [INFO] [stdout] 147 | | .as_slice(), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 143 ~ data_vec [INFO] [stdout] 144 + .iter() [INFO] [stdout] 145 + .map(|x| x.view()) [INFO] [stdout] 146 + .collect::>() [INFO] [stdout] 147 ~ .as_slice(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/parse/cachegrind.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | .map(|&x| (&funcs[x]).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `funcs[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/parse/callgrind.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 50 | let errs = out_split [INFO] [stdout] | ____________________^ [INFO] [stdout] 51 | | .to_owned() [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] | |________________________^ help: use: `out_split.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | try_or_exit!(get_binary(&m)).to_string() [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 139 | let num = try_or_exit!(get_num(&m)); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:140:52 [INFO] [stdout] | [INFO] [stdout] 140 | let sort_metric = try_or_exit!(get_sort_metric(&m)); [INFO] [stdout] | ^^ help: change this to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stdout] --> src/parse/cachegrind.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 136 | let _ = func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stdout] --> src/parse/callgrind.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = func.to_mut().drain(idx..).collect::(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.48s [INFO] running `Command { std: "docker" "inspect" "c5509e2eed2e34cb9d90eb11356d501373e55fe4950c5801f36351bc8af0ba6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5509e2eed2e34cb9d90eb11356d501373e55fe4950c5801f36351bc8af0ba6f", kill_on_drop: false }` [INFO] [stdout] c5509e2eed2e34cb9d90eb11356d501373e55fe4950c5801f36351bc8af0ba6f