[INFO] cloning repository https://github.com/kenleung5e28/grepr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kenleung5e28/grepr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenleung5e28%2Fgrepr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenleung5e28%2Fgrepr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 76c743a9b704f929efc7c095ccb80477c6d4693c [INFO] linting kenleung5e28/grepr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenleung5e28%2Fgrepr" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kenleung5e28/grepr [INFO] finished tweaking git repo https://github.com/kenleung5e28/grepr [INFO] tweaked toml for git repo https://github.com/kenleung5e28/grepr written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kenleung5e28/grepr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kenleung5e28/grepr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.120 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 352c775fad9d194747bde29c7c2baaf4e2163b527dcdfc63cecc85314458bc01 [INFO] running `Command { std: "docker" "start" "-a" "352c775fad9d194747bde29c7c2baaf4e2163b527dcdfc63cecc85314458bc01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "352c775fad9d194747bde29c7c2baaf4e2163b527dcdfc63cecc85314458bc01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "352c775fad9d194747bde29c7c2baaf4e2163b527dcdfc63cecc85314458bc01", kill_on_drop: false }` [INFO] [stdout] 352c775fad9d194747bde29c7c2baaf4e2163b527dcdfc63cecc85314458bc01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b0b0da4e931a4533e41795d2c56b7fa6bdc1a50de837ff63d1bcc368010ad26 [INFO] running `Command { std: "docker" "start" "-a" "0b0b0da4e931a4533e41795d2c56b7fa6bdc1a50de837ff63d1bcc368010ad26", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.120 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking predicates-core v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling sys-info v0.9.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking termtree v0.2.4 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking predicates-tree v1.0.5 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking predicates v2.1.1 [INFO] [stderr] Checking grepr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap_err` on `matches` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 107 | if matches.is_err() { [INFO] [stdout] | ------------------- help: try: `if let Err() = matches` [INFO] [stdout] 108 | eprintln!("{}: {}", filename, matches.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if pattern.is_match(&buf) == !invert_match { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pattern.is_match(&buf) != invert_match` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking assert_cmd v2.0.4 [INFO] [stdout] warning: called `unwrap_err` on `matches` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 107 | if matches.is_err() { [INFO] [stdout] | ------------------- help: try: `if let Err() = matches` [INFO] [stdout] 108 | eprintln!("{}: {}", filename, matches.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if pattern.is_match(&buf) == !invert_match { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pattern.is_match(&buf) != invert_match` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli.rs:45:15 [INFO] [stdout] | [INFO] [stdout] 45 | .args(&["*foo", FOX]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `["*foo", FOX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 58 | .args(&["foo", &bad]) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `["foo", &bad]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli.rs:75:39 [INFO] [stdout] | [INFO] [stdout] 75 | let expected = fs::read_to_string(&expected_file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `expected_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli.rs:237:15 [INFO] [stdout] | [INFO] [stdout] 237 | .args(&["fox", INPUTS_DIR, FOX]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["fox", INPUTS_DIR, FOX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/cli.rs:274:15 [INFO] [stdout] | [INFO] [stdout] 274 | .args(&["-ci", "the", "-"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-ci", "the", "-"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.33s [INFO] running `Command { std: "docker" "inspect" "0b0b0da4e931a4533e41795d2c56b7fa6bdc1a50de837ff63d1bcc368010ad26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b0b0da4e931a4533e41795d2c56b7fa6bdc1a50de837ff63d1bcc368010ad26", kill_on_drop: false }` [INFO] [stdout] 0b0b0da4e931a4533e41795d2c56b7fa6bdc1a50de837ff63d1bcc368010ad26