[INFO] cloning repository https://github.com/kenkoooo/simple-nes-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kenkoooo/simple-nes-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenkoooo%2Fsimple-nes-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenkoooo%2Fsimple-nes-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0ef099baf4de430804a462b46cf81bd1b204f40a
[INFO] linting kenkoooo/simple-nes-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenkoooo%2Fsimple-nes-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/kenkoooo/simple-nes-rs
[INFO] finished tweaking git repo https://github.com/kenkoooo/simple-nes-rs
[INFO] tweaked toml for git repo https://github.com/kenkoooo/simple-nes-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/kenkoooo/simple-nes-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/kenkoooo/simple-nes-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] f2af672cf9c52d7285264ea145700e49523166fc9a25179c2a0e7bae978e9870
[INFO] running `Command { std: "docker" "start" "-a" "f2af672cf9c52d7285264ea145700e49523166fc9a25179c2a0e7bae978e9870", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f2af672cf9c52d7285264ea145700e49523166fc9a25179c2a0e7bae978e9870", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f2af672cf9c52d7285264ea145700e49523166fc9a25179c2a0e7bae978e9870", kill_on_drop: false }`
[INFO] [stdout] f2af672cf9c52d7285264ea145700e49523166fc9a25179c2a0e7bae978e9870
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] b5e90220e24510372012f08e1e5744fc76f53447681a4179b9d6bdd52dfe1565
[INFO] running `Command { std: "docker" "start" "-a" "b5e90220e24510372012f08e1e5744fc76f53447681a4179b9d6bdd52dfe1565", kill_on_drop: false }`
[INFO] [stderr]     Checking simple-nes-rs v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:35:19
[INFO] [stdout]    |
[INFO] [stdout] 35 |             0x0000...0x1FFF => self.work_ram.read(addr & 0x07FF),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:40:19
[INFO] [stdout]    |
[INFO] [stdout] 40 |             0x6000...0x7FFF => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:47:19
[INFO] [stdout]    |
[INFO] [stdout] 47 |             0x8000...0xBFFF => self.program_rom.read(addr - 0x8000),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:48:19
[INFO] [stdout]    |
[INFO] [stdout] 48 |             0xC000...0xFFFF if self.program_rom.size() <= 0x4000 => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:51:19
[INFO] [stdout]    |
[INFO] [stdout] 51 |             0xC000...0xFFFF => self.program_rom.read(addr - 0x8000),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:58:19
[INFO] [stdout]    |
[INFO] [stdout] 58 |             0x0000...0x1FFF => self.work_ram.write(addr & 0x07FF, data),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:63:19
[INFO] [stdout]    |
[INFO] [stdout] 63 |             0x6000...0x7FFF => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around method argument
[INFO] [stdout]    --> src/cpu/instructions.rs:545:15
[INFO] [stdout]     |
[INFO] [stdout] 545 |     bus.write((addr | 0x0100), data);
[INFO] [stdout]     |               ^             ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 545 -     bus.write((addr | 0x0100), data);
[INFO] [stdout] 545 +     bus.write(addr | 0x0100 , data);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:35:19
[INFO] [stdout]    |
[INFO] [stdout] 35 |             0x0000...0x1FFF => self.work_ram.read(addr & 0x07FF),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout]    = note: `#[warn(ellipsis_inclusive_range_patterns)]` (part of `#[warn(rust_2021_compatibility)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:40:19
[INFO] [stdout]    |
[INFO] [stdout] 40 |             0x6000...0x7FFF => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:47:19
[INFO] [stdout]    |
[INFO] [stdout] 47 |             0x8000...0xBFFF => self.program_rom.read(addr - 0x8000),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:48:19
[INFO] [stdout]    |
[INFO] [stdout] 48 |             0xC000...0xFFFF if self.program_rom.size() <= 0x4000 => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:51:19
[INFO] [stdout]    |
[INFO] [stdout] 51 |             0xC000...0xFFFF => self.program_rom.read(addr - 0x8000),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:58:19
[INFO] [stdout]    |
[INFO] [stdout] 58 |             0x0000...0x1FFF => self.work_ram.write(addr & 0x07FF, data),
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `...` range patterns are deprecated
[INFO] [stdout]   --> src/bus.rs:63:19
[INFO] [stdout]    |
[INFO] [stdout] 63 |             0x6000...0x7FFF => {
[INFO] [stdout]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stdout]    |
[INFO] [stdout]    = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021!
[INFO] [stdout]    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2021/warnings-promoted-to-error.html>
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around method argument
[INFO] [stdout]    --> src/cpu/instructions.rs:545:15
[INFO] [stdout]     |
[INFO] [stdout] 545 |     bus.write((addr | 0x0100), data);
[INFO] [stdout]     |               ^             ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 545 -     bus.write((addr | 0x0100), data);
[INFO] [stdout] 545 +     bus.write(addr | 0x0100 , data);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/bus.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         (upper << 8 | lower) as u16
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(upper << 8 | lower)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 |     (addr + registers.get_X() as Word) & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(addr + registers.get_X() as Word)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout]    = note: `#[warn(clippy::identity_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:68:5
[INFO] [stdout]    |
[INFO] [stdout] 68 |     (addr + registers.get_Y() as Word) & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(addr + registers.get_Y() as Word)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:75:16
[INFO] [stdout]    |
[INFO] [stdout] 75 |     let addr = ((fetch(registers, bus) + registers.get_X()) & 0xFF) as Address;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((fetch(registers, bus) + registers.get_X()))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     addr & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^ help: consider reducing it to: `addr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:94:5
[INFO] [stdout]    |
[INFO] [stdout] 94 |     addr & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^ help: consider reducing it to: `addr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cpu/instructions.rs:139:13
[INFO] [stdout]     |
[INFO] [stdout] 139 |             !(((acc ^ (operand as Byte)) & 0x80) != 0) && ((acc ^ computed as Byte) & 0x80) != 0,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((acc ^ (operand as Byte)) & 0x80) == 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]    --> src/cpu/instructions.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         (operand as u16) + registers.get_A() as u16 + bool_to_u8(registers.get_carry()) as u16;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^ help: try: `operand`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cpu/instructions.rs:154:13
[INFO] [stdout]     |
[INFO] [stdout] 154 |             !(((acc ^ (fetched as Byte)) & 0x80) != 0) && ((acc ^ computed as Byte) & 0x80) != 0,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((acc ^ (fetched as Byte)) & 0x80) == 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:172:32
[INFO] [stdout]     |
[INFO] [stdout] 172 |         .set_carry(computed >= 0 as i16)
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:187:32
[INFO] [stdout]     |
[INFO] [stdout] 187 |         .set_carry(computed >= 0 as i16)
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:196:32
[INFO] [stdout]     |
[INFO] [stdout] 196 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:205:32
[INFO] [stdout]     |
[INFO] [stdout] 205 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:213:32
[INFO] [stdout]     |
[INFO] [stdout] 213 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:222:32
[INFO] [stdout]     |
[INFO] [stdout] 222 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:230:32
[INFO] [stdout]     |
[INFO] [stdout] 230 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:239:32
[INFO] [stdout]     |
[INFO] [stdout] 239 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:304:19
[INFO] [stdout]     |
[INFO] [stdout] 304 |     let shifted = (acc << 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^ help: try: `(acc << 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:314:19
[INFO] [stdout]     |
[INFO] [stdout] 314 |     let shifted = (fetched << 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `(fetched << 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:324:19
[INFO] [stdout]     |
[INFO] [stdout] 324 |     let shifted = (acc >> 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^ help: try: `(acc >> 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:334:19
[INFO] [stdout]     |
[INFO] [stdout] 334 |     let shifted = (fetched >> 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `(fetched >> 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `u8` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:393:36
[INFO] [stdout]     |
[INFO] [stdout] 393 |     let data = bus.read(operand) + 1 as u8;
[INFO] [stdout]     |                                    ^^^^^^^ help: try: `1_u8`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:104:44
[INFO] [stdout]     |
[INFO] [stdout] 104 |         Instruction::LAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]     = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 104 -         Instruction::LAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 104 +         Instruction::LAX => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:105:44
[INFO] [stdout]     |
[INFO] [stdout] 105 |         Instruction::SAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 105 -         Instruction::SAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 105 +         Instruction::SAX => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:106:44
[INFO] [stdout]     |
[INFO] [stdout] 106 |         Instruction::DCP => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 106 -         Instruction::DCP => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 106 +         Instruction::DCP => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:107:44
[INFO] [stdout]     |
[INFO] [stdout] 107 |         Instruction::ISB => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 107 -         Instruction::ISB => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 107 +         Instruction::ISB => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:108:44
[INFO] [stdout]     |
[INFO] [stdout] 108 |         Instruction::SLO => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 108 -         Instruction::SLO => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 108 +         Instruction::SLO => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:109:44
[INFO] [stdout]     |
[INFO] [stdout] 109 |         Instruction::RLA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 109 -         Instruction::RLA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 109 +         Instruction::RLA => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:110:44
[INFO] [stdout]     |
[INFO] [stdout] 110 |         Instruction::SRE => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 110 -         Instruction::SRE => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 110 +         Instruction::SRE => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:111:44
[INFO] [stdout]     |
[INFO] [stdout] 111 |         Instruction::RRA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 111 -         Instruction::RRA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 111 +         Instruction::RRA => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers`
[INFO] [stdout]    --> src/cpu_registers.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     pub fn new() -> Self {
[INFO] [stdout]  99 | |         Registers {
[INFO] [stdout] 100 | |             A: 0,
[INFO] [stdout] 101 | |             X: 0,
[INFO] [stdout] ...   |
[INFO] [stdout] 116 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout]  97 + impl Default for Registers {
[INFO] [stdout]  98 +     fn default() -> Self {
[INFO] [stdout]  99 +         Self::new()
[INFO] [stdout] 100 +     }
[INFO] [stdout] 101 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu_registers.rs:149:15
[INFO] [stdout]     |
[INFO] [stdout] 149 |             | bool_to_u8(self.P.carry) as u8
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bool_to_u8(self.P.carry)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]   --> src/bus.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         (upper << 8 | lower) as u16
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(upper << 8 | lower)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 |     (addr + registers.get_X() as Word) & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(addr + registers.get_X() as Word)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout]    = note: `#[warn(clippy::identity_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:68:5
[INFO] [stdout]    |
[INFO] [stdout] 68 |     (addr + registers.get_Y() as Word) & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(addr + registers.get_Y() as Word)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:75:16
[INFO] [stdout]    |
[INFO] [stdout] 75 |     let addr = ((fetch(registers, bus) + registers.get_X()) & 0xFF) as Address;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((fetch(registers, bus) + registers.get_X()))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     addr & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^ help: consider reducing it to: `addr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/cpu/fetch.rs:94:5
[INFO] [stdout]    |
[INFO] [stdout] 94 |     addr & 0xFFFF
[INFO] [stdout]    |     ^^^^^^^^^^^^^ help: consider reducing it to: `addr`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cpu/instructions.rs:139:13
[INFO] [stdout]     |
[INFO] [stdout] 139 |             !(((acc ^ (operand as Byte)) & 0x80) != 0) && ((acc ^ computed as Byte) & 0x80) != 0,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((acc ^ (operand as Byte)) & 0x80) == 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]    --> src/cpu/instructions.rs:135:9
[INFO] [stdout]     |
[INFO] [stdout] 135 |         (operand as u16) + registers.get_A() as u16 + bool_to_u8(registers.get_carry()) as u16;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^ help: try: `operand`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/cpu/instructions.rs:154:13
[INFO] [stdout]     |
[INFO] [stdout] 154 |             !(((acc ^ (fetched as Byte)) & 0x80) != 0) && ((acc ^ computed as Byte) & 0x80) != 0,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((acc ^ (fetched as Byte)) & 0x80) == 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:172:32
[INFO] [stdout]     |
[INFO] [stdout] 172 |         .set_carry(computed >= 0 as i16)
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:187:32
[INFO] [stdout]     |
[INFO] [stdout] 187 |         .set_carry(computed >= 0 as i16)
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:196:32
[INFO] [stdout]     |
[INFO] [stdout] 196 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:205:32
[INFO] [stdout]     |
[INFO] [stdout] 205 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:213:32
[INFO] [stdout]     |
[INFO] [stdout] 213 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:222:32
[INFO] [stdout]     |
[INFO] [stdout] 222 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:230:32
[INFO] [stdout]     |
[INFO] [stdout] 230 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i16` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:239:32
[INFO] [stdout]     |
[INFO] [stdout] 239 |         .set_carry(computed >= 0 as i16);
[INFO] [stdout]     |                                ^^^^^^^^ help: try: `0_i16`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:304:19
[INFO] [stdout]     |
[INFO] [stdout] 304 |     let shifted = (acc << 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^ help: try: `(acc << 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:314:19
[INFO] [stdout]     |
[INFO] [stdout] 314 |     let shifted = (fetched << 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `(fetched << 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:324:19
[INFO] [stdout]     |
[INFO] [stdout] 324 |     let shifted = (acc >> 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^ help: try: `(acc >> 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu/instructions.rs:334:19
[INFO] [stdout]     |
[INFO] [stdout] 334 |     let shifted = (fetched >> 1) as u8;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `(fetched >> 1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `u8` is unnecessary
[INFO] [stdout]    --> src/cpu/instructions.rs:393:36
[INFO] [stdout]     |
[INFO] [stdout] 393 |     let data = bus.read(operand) + 1 as u8;
[INFO] [stdout]     |                                    ^^^^^^^ help: try: `1_u8`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`)
[INFO] [stdout]    --> src/cpu/instructions.rs:603:13
[INFO] [stdout]     |
[INFO] [stdout] 603 |             (upper << 8 | lower) as u16
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(upper << 8 | lower)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/main.rs:5:15
[INFO] [stdout]   |
[INFO] [stdout] 5 | use std::io::{self, BufReader};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:812:9
[INFO] [stdout]     |
[INFO] [stdout] 812 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 812 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 812 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:822:9
[INFO] [stdout]     |
[INFO] [stdout] 822 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 822 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 822 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:830:9
[INFO] [stdout]     |
[INFO] [stdout] 830 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 830 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 830 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:840:9
[INFO] [stdout]     |
[INFO] [stdout] 840 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 840 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 840 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:848:9
[INFO] [stdout]     |
[INFO] [stdout] 848 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 848 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 848 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/main.rs:5:15
[INFO] [stdout]   |
[INFO] [stdout] 5 | use std::io::{self, BufReader};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/cpu/instructions.rs:858:9
[INFO] [stdout]     |
[INFO] [stdout] 858 |         assert_eq!(reg.get_carry(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 858 -         assert_eq!(reg.get_carry(), true);
[INFO] [stdout] 858 +         assert!(reg.get_carry());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:104:44
[INFO] [stdout]     |
[INFO] [stdout] 104 |         Instruction::LAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]     = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 104 -         Instruction::LAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 104 +         Instruction::LAX => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:105:44
[INFO] [stdout]     |
[INFO] [stdout] 105 |         Instruction::SAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 105 -         Instruction::SAX => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 105 +         Instruction::SAX => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:106:44
[INFO] [stdout]     |
[INFO] [stdout] 106 |         Instruction::DCP => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 106 -         Instruction::DCP => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 106 +         Instruction::DCP => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:107:44
[INFO] [stdout]     |
[INFO] [stdout] 107 |         Instruction::ISB => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 107 -         Instruction::ISB => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 107 +         Instruction::ISB => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:108:44
[INFO] [stdout]     |
[INFO] [stdout] 108 |         Instruction::SLO => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 108 -         Instruction::SLO => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 108 +         Instruction::SLO => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:109:44
[INFO] [stdout]     |
[INFO] [stdout] 109 |         Instruction::RLA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 109 -         Instruction::RLA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 109 +         Instruction::RLA => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:110:44
[INFO] [stdout]     |
[INFO] [stdout] 110 |         Instruction::SRE => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 110 -         Instruction::SRE => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 110 +         Instruction::SRE => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]    --> src/cpu.rs:111:44
[INFO] [stdout]     |
[INFO] [stdout] 111 |         Instruction::RRA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 111 -         Instruction::RRA => println!("{}", "TODO:Undocumented instruction"),
[INFO] [stdout] 111 +         Instruction::RRA => println!("TODO:Undocumented instruction"),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers`
[INFO] [stdout]    --> src/cpu_registers.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     pub fn new() -> Self {
[INFO] [stdout]  99 | |         Registers {
[INFO] [stdout] 100 | |             A: 0,
[INFO] [stdout] 101 | |             X: 0,
[INFO] [stdout] ...   |
[INFO] [stdout] 116 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout]  97 + impl Default for Registers {
[INFO] [stdout]  98 +     fn default() -> Self {
[INFO] [stdout]  99 +         Self::new()
[INFO] [stdout] 100 +     }
[INFO] [stdout] 101 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]    --> src/cpu_registers.rs:149:15
[INFO] [stdout]     |
[INFO] [stdout] 149 |             | bool_to_u8(self.P.carry) as u8
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bool_to_u8(self.P.carry)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.56s
[INFO] running `Command { std: "docker" "inspect" "b5e90220e24510372012f08e1e5744fc76f53447681a4179b9d6bdd52dfe1565", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b5e90220e24510372012f08e1e5744fc76f53447681a4179b9d6bdd52dfe1565", kill_on_drop: false }`
[INFO] [stdout] b5e90220e24510372012f08e1e5744fc76f53447681a4179b9d6bdd52dfe1565