[INFO] cloning repository https://github.com/kenballus/libafl-diff [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kenballus/libafl-diff" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenballus%2Flibafl-diff", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenballus%2Flibafl-diff'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 959641ac1cd3e76706f4a1298bc8843bd1b91f68 [INFO] linting kenballus/libafl-diff against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkenballus%2Flibafl-diff" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kenballus/libafl-diff [INFO] finished tweaking git repo https://github.com/kenballus/libafl-diff [INFO] tweaked toml for git repo https://github.com/kenballus/libafl-diff written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kenballus/libafl-diff on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kenballus/libafl-diff already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_spanned v1.0.4 [INFO] [stderr] Downloaded xxhash-rust v0.8.15 [INFO] [stderr] Downloaded toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Downloaded toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Downloaded toml v0.9.10+spec-1.1.0 [INFO] [stderr] Downloaded ctor-proc-macro v0.0.7 [INFO] [stderr] Downloaded toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Downloaded ctor v0.6.3 [INFO] [stderr] Downloaded dtor-proc-macro v0.0.6 [INFO] [stderr] Downloaded serial_test_derive v3.3.1 [INFO] [stderr] Downloaded meminterval v0.4.2 [INFO] [stderr] Downloaded bincode_derive v2.0.1 [INFO] [stderr] Downloaded unty v0.0.4 [INFO] [stderr] Downloaded windows-threading v0.2.1 [INFO] [stderr] Downloaded rustc-demangle v0.1.26 [INFO] [stderr] Downloaded windows-collections v0.3.2 [INFO] [stderr] Downloaded bitbybit v1.4.0 [INFO] [stderr] Downloaded virtue v0.0.18 [INFO] [stderr] Downloaded arbitrary-int v2.0.0 [INFO] [stderr] Downloaded bincode v2.0.1 [INFO] [stderr] Downloaded zerocopy-derive v0.8.31 [INFO] [stderr] Downloaded wide v0.7.33 [INFO] [stderr] Downloaded libafl_bolts v0.15.4 [INFO] [stderr] Downloaded const_format v0.2.35 [INFO] [stderr] Downloaded libm v0.2.15 [INFO] [stderr] Downloaded uds v0.4.2 [INFO] [stderr] Downloaded js-sys v0.3.83 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Downloaded bytemuck v1.24.0 [INFO] [stderr] Downloaded zerocopy v0.8.31 [INFO] [stderr] Downloaded syn v2.0.113 [INFO] [stderr] Downloaded const_format_proc_macros v0.2.34 [INFO] [stderr] Downloaded typewit v1.14.2 [INFO] [stderr] Downloaded const_panic v0.2.15 [INFO] [stderr] Downloaded wasm-bindgen v0.2.106 [INFO] [stderr] Downloaded nix v0.30.1 [INFO] [stderr] Downloaded uuid v1.19.0 [INFO] [stderr] Downloaded arbitrary-int v1.3.0 [INFO] [stderr] Downloaded postcard v1.1.3 [INFO] [stderr] Downloaded libafl v0.15.4 [INFO] [stderr] Downloaded windows-future v0.3.2 [INFO] [stderr] Downloaded fastbloom v0.14.0 [INFO] [stderr] Downloaded zmij v1.0.12 [INFO] [stderr] Downloaded typed-builder-macro v0.22.0 [INFO] [stderr] Downloaded typed-builder v0.22.0 [INFO] [stderr] Downloaded erased-serde v0.4.9 [INFO] [stderr] Downloaded dtor v0.1.1 [INFO] [stderr] Downloaded libafl_derive v0.15.4 [INFO] [stderr] Downloaded windows-numerics v0.3.1 [INFO] [stderr] Downloaded cobs v0.3.0 [INFO] [stderr] Downloaded embedded-io v0.4.0 [INFO] [stderr] Downloaded serial_test v3.3.1 [INFO] [stderr] Downloaded typeid v1.0.3 [INFO] [stderr] Downloaded tuple_list v0.1.3 [INFO] [stderr] Downloaded embedded-io v0.6.1 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.106 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.106 [INFO] [stderr] Downloaded libc v0.2.179 [INFO] [stderr] Downloaded windows v0.62.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13b6f18c06c56e633bb4d55de1aa1375e440003648b944af8b0f478a23fdc2ed [INFO] running `Command { std: "docker" "start" "-a" "13b6f18c06c56e633bb4d55de1aa1375e440003648b944af8b0f478a23fdc2ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13b6f18c06c56e633bb4d55de1aa1375e440003648b944af8b0f478a23fdc2ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13b6f18c06c56e633bb4d55de1aa1375e440003648b944af8b0f478a23fdc2ed", kill_on_drop: false }` [INFO] [stdout] 13b6f18c06c56e633bb4d55de1aa1375e440003648b944af8b0f478a23fdc2ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db29c652b3f777989ca202aa61056c644e0f1908b77d36679677dc227d353f1d [INFO] running `Command { std: "docker" "start" "-a" "db29c652b3f777989ca202aa61056c644e0f1908b77d36679677dc227d353f1d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling typeid v1.0.3 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling erased-serde v0.4.9 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling dtor-proc-macro v0.0.6 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling ctor-proc-macro v0.0.7 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking dtor v0.1.1 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Compiling virtue v0.0.18 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking ctor v0.6.3 [INFO] [stderr] Compiling const_format_proc_macros v0.2.34 [INFO] [stderr] Compiling libafl_bolts v0.15.4 [INFO] [stderr] Compiling libafl v0.15.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Checking typewit v1.14.2 [INFO] [stderr] Compiling bincode_derive v2.0.1 [INFO] [stderr] Checking tuple_list v0.1.3 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Compiling arbitrary-int v1.3.0 [INFO] [stderr] Checking toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Checking const_panic v0.2.15 [INFO] [stderr] Checking arbitrary-int v2.0.0 [INFO] [stderr] Checking const_format v0.2.35 [INFO] [stderr] Checking toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking uds v0.4.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking fastbloom v0.14.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking toml v0.9.10+spec-1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling num_enum_derive v0.7.5 [INFO] [stderr] Compiling serial_test_derive v3.3.1 [INFO] [stderr] Compiling typed-builder-macro v0.22.0 [INFO] [stderr] Compiling libafl_derive v0.15.4 [INFO] [stderr] Compiling bitbybit v1.4.0 [INFO] [stderr] Checking serial_test v3.3.1 [INFO] [stderr] Checking num_enum v0.7.5 [INFO] [stderr] Checking cobs v0.3.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking typed-builder v0.22.0 [INFO] [stderr] Checking postcard v1.1.3 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking meminterval v0.4.2 [INFO] [stderr] Checking davey_and_daleys_fuzzer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | fn new(stdout_observers: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn new(stdout_observers: &Vec) -> Self { [INFO] [stdout] 59 + fn new(stdout_observers: &[StdOutObserver]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/main.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|(o1_handle, o2_handle)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 86 | | match ( [INFO] [stdout] 87 | | &observers [INFO] [stdout] 88 | | .get(&o1_handle) [INFO] [stdout] ... | [INFO] [stdout] 100 | | }) [INFO] [stdout] 101 | | .any(|x| x)) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 85 ~ .any(|(o1_handle, o2_handle)| { [INFO] [stdout] 86 + match ( [INFO] [stdout] 87 + &observers [INFO] [stdout] 88 + .get(&o1_handle) [INFO] [stdout] 89 + .expect("couldn't find stdout observer 1") [INFO] [stdout] 90 + .output, [INFO] [stdout] 91 + &observers [INFO] [stdout] 92 + .get(&o2_handle) [INFO] [stdout] 93 + .expect("couldn't find stdout observer 2") [INFO] [stdout] 94 + .output, [INFO] [stdout] 95 + ) { [INFO] [stdout] 96 + (None, None) => false, [INFO] [stdout] 97 + (Some(_), None) | (None, Some(_)) => true, [INFO] [stdout] 98 + (Some(output1), Some(output2)) => output1 != output2, [INFO] [stdout] 99 + } [INFO] [stdout] 100 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 88 | .get(&o1_handle) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `o1_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 92 | .get(&o2_handle) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `o2_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 142 | .get(&map_observer_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `map_observer_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | if !executor.observers_mut().pre_exec_all(state, input).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `executor.observers_mut().pre_exec_all(state, input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if !executor [INFO] [stdout] | ________________^ [INFO] [stdout] 209 | | .observers_mut() [INFO] [stdout] 210 | | .post_exec_all(state, input, exit_kind) [INFO] [stdout] 211 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 208 ~ if executor [INFO] [stdout] 209 + .observers_mut() [INFO] [stdout] 210 + .post_exec_all(state, input, exit_kind).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | .zip(map_observers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 415 - .zip(map_observers.into_iter()) [INFO] [stdout] 415 + .zip(map_observers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:416:18 [INFO] [stdout] | [INFO] [stdout] 416 | .zip(stdout_observers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 416 - .zip(stdout_observers.into_iter()) [INFO] [stdout] 416 + .zip(stdout_observers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:417:18 [INFO] [stdout] | [INFO] [stdout] 417 | .zip(map_sizes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 417 - .zip(map_sizes.into_iter()) [INFO] [stdout] 417 + .zip(map_sizes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | fn new(stdout_observers: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn new(stdout_observers: &Vec) -> Self { [INFO] [stdout] 59 + fn new(stdout_observers: &[StdOutObserver]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/main.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|(o1_handle, o2_handle)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 86 | | match ( [INFO] [stdout] 87 | | &observers [INFO] [stdout] 88 | | .get(&o1_handle) [INFO] [stdout] ... | [INFO] [stdout] 100 | | }) [INFO] [stdout] 101 | | .any(|x| x)) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 85 ~ .any(|(o1_handle, o2_handle)| { [INFO] [stdout] 86 + match ( [INFO] [stdout] 87 + &observers [INFO] [stdout] 88 + .get(&o1_handle) [INFO] [stdout] 89 + .expect("couldn't find stdout observer 1") [INFO] [stdout] 90 + .output, [INFO] [stdout] 91 + &observers [INFO] [stdout] 92 + .get(&o2_handle) [INFO] [stdout] 93 + .expect("couldn't find stdout observer 2") [INFO] [stdout] 94 + .output, [INFO] [stdout] 95 + ) { [INFO] [stdout] 96 + (None, None) => false, [INFO] [stdout] 97 + (Some(_), None) | (None, Some(_)) => true, [INFO] [stdout] 98 + (Some(output1), Some(output2)) => output1 != output2, [INFO] [stdout] 99 + } [INFO] [stdout] 100 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 88 | .get(&o1_handle) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `o1_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 92 | .get(&o2_handle) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `o2_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 142 | .get(&map_observer_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `map_observer_handle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | if !executor.observers_mut().pre_exec_all(state, input).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `executor.observers_mut().pre_exec_all(state, input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | if !executor [INFO] [stdout] | ________________^ [INFO] [stdout] 209 | | .observers_mut() [INFO] [stdout] 210 | | .post_exec_all(state, input, exit_kind) [INFO] [stdout] 211 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 208 ~ if executor [INFO] [stdout] 209 + .observers_mut() [INFO] [stdout] 210 + .post_exec_all(state, input, exit_kind).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 415 | .zip(map_observers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 415 - .zip(map_observers.into_iter()) [INFO] [stdout] 415 + .zip(map_observers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:416:18 [INFO] [stdout] | [INFO] [stdout] 416 | .zip(stdout_observers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 416 - .zip(stdout_observers.into_iter()) [INFO] [stdout] 416 + .zip(stdout_observers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:417:18 [INFO] [stdout] | [INFO] [stdout] 417 | .zip(map_sizes.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 417 - .zip(map_sizes.into_iter()) [INFO] [stdout] 417 + .zip(map_sizes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.02s [INFO] running `Command { std: "docker" "inspect" "db29c652b3f777989ca202aa61056c644e0f1908b77d36679677dc227d353f1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db29c652b3f777989ca202aa61056c644e0f1908b77d36679677dc227d353f1d", kill_on_drop: false }` [INFO] [stdout] db29c652b3f777989ca202aa61056c644e0f1908b77d36679677dc227d353f1d