[INFO] cloning repository https://github.com/kea/dungeon-crawler-hor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kea/dungeon-crawler-hor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkea%2Fdungeon-crawler-hor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkea%2Fdungeon-crawler-hor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30a62bfce5c833ec29815d4ef8ba6fc4b839c6ed [INFO] linting kea/dungeon-crawler-hor against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkea%2Fdungeon-crawler-hor" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kea/dungeon-crawler-hor [INFO] finished tweaking git repo https://github.com/kea/dungeon-crawler-hor [INFO] tweaked toml for git repo https://github.com/kea/dungeon-crawler-hor written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kea/dungeon-crawler-hor on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kea/dungeon-crawler-hor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ron v0.6.1 [INFO] [stderr] Downloaded erased-serde v0.3.26 [INFO] [stderr] Downloaded fdeflate v0.3.3 [INFO] [stderr] Downloaded thiserror-impl v1.0.52 [INFO] [stderr] Downloaded anyhow v1.0.77 [INFO] [stderr] Downloaded thiserror v1.0.52 [INFO] [stderr] Downloaded winnow v0.5.31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a9e72bc237bd604496aa0a4589a9c413d8d5dc37cac9afa57ed2df43d98a82e [INFO] running `Command { std: "docker" "start" "-a" "9a9e72bc237bd604496aa0a4589a9c413d8d5dc37cac9afa57ed2df43d98a82e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a9e72bc237bd604496aa0a4589a9c413d8d5dc37cac9afa57ed2df43d98a82e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a9e72bc237bd604496aa0a4589a9c413d8d5dc37cac9afa57ed2df43d98a82e", kill_on_drop: false }` [INFO] [stdout] 9a9e72bc237bd604496aa0a4589a9c413d8d5dc37cac9afa57ed2df43d98a82e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1140fbd978059da8817712b920c7b52def3e4467ad1edaffe4e462e38d65e78 [INFO] running `Command { std: "docker" "start" "-a" "c1140fbd978059da8817712b920c7b52def3e4467ad1edaffe4e462e38d65e78", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.52 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking fdeflate v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling anyhow v1.0.77 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Compiling erased-serde v0.3.26 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling crossfont v0.5.2 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking ultraviolet v0.9.2 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking bracket-embedding v0.8.7 [INFO] [stderr] Checking bracket-color v0.8.7 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking freetype-rs v0.26.0 [INFO] [stderr] Checking object-pool v0.5.4 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Checking bracket-rex v0.8.7 [INFO] [stderr] Checking bracket-geometry v0.8.7 [INFO] [stderr] Checking bracket-random v0.8.7 [INFO] [stderr] Checking bracket-algorithm-traits v0.8.7 [INFO] [stderr] Checking bracket-noise v0.8.7 [INFO] [stderr] Checking bracket-pathfinding v0.8.7 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Compiling thiserror-impl v1.0.52 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Compiling legion_codegen v0.3.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking wayland-egl v0.29.5 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking ron v0.6.1 [INFO] [stderr] Checking legion v0.3.1 [INFO] [stderr] Checking sctk-adwaita v0.4.3 [INFO] [stderr] Checking winit v0.27.5 [INFO] [stderr] Checking glutin v0.29.1 [INFO] [stderr] Checking bracket-terminal v0.8.7 [INFO] [stderr] Checking bracket-lib v0.8.7 [INFO] [stderr] Checking dungeon-crawler v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `EmptyArchitect` is never constructed [INFO] [stdout] --> src/map_builder/empty.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct EmptyArchitect {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EmptyArchitect` is never constructed [INFO] [stdout] --> src/map_builder/empty.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct EmptyArchitect {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/map_builder/drunkard.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | let mut drunkard_pos = start.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/map_builder/drunkard.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | let mut drunkard_pos = start.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/themes.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new() -> Box { [INFO] [stdout] 7 | | Box::new(Self {}) [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/themes.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Box { [INFO] [stdout] 35 | | Box::new(Self {}) [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually take no `self` [INFO] [stdout] --> src/map_builder/mod.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(&mut self, rng: &mut RandomNumberGenerator) -> MapBuilder; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(&mut self, rng: &mut RandomNumberGenerator) -> MapBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/map_builder/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | rooms.sort_by(|a, b| a.center().x.cmp(&b.center().x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - rooms.sort_by(|a, b| a.center().x.cmp(&b.center().x)); [INFO] [stdout] 107 + rooms.sort_by_key(|a| a.center().x); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/themes.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new() -> Box { [INFO] [stdout] 7 | | Box::new(Self {}) [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/themes.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Box { [INFO] [stdout] 35 | | Box::new(Self {}) [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually take no `self` [INFO] [stdout] --> src/map_builder/mod.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(&mut self, rng: &mut RandomNumberGenerator) -> MapBuilder; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/map_builder/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(&mut self, rng: &mut RandomNumberGenerator) -> MapBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/map_builder/mod.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 158 | spawns.push(spawnable_tiles[target_index].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spawnable_tiles[target_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/map_builder/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | rooms.sort_by(|a, b| a.center().x.cmp(&b.center().x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - rooms.sort_by(|a, b| a.center().x.cmp(&b.center().x)); [INFO] [stdout] 107 + rooms.sort_by_key(|a| a.center().x); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Point` which implements the `Copy` trait [INFO] [stdout] --> src/map_builder/mod.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 158 | spawns.push(spawnable_tiles[target_index].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `spawnable_tiles[target_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TurnState` which implements the `Copy` trait [INFO] [stdout] --> src/systems/end_turn.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | let current_state = turn_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*turn_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/hud.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | .find_map(|(entity, player)| Some((*entity, player.map_level))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/systems/map_render.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | #[resource] theme: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `&dyn MapTheme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TurnState` which implements the `Copy` trait [INFO] [stdout] --> src/systems/end_turn.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | let current_state = turn_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*turn_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/systems/movement.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if !entry.get_component::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `entry.get_component::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/player_input.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | .find_map(|(entity, pos)| Some((*entity, *pos))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/hud.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | .find_map(|(entity, player)| Some((*entity, player.map_level))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/player_input.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | .find_map(|(entity, pos)| Some((*entity, *pos + delta))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/systems/map_render.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | #[resource] theme: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `&dyn MapTheme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/systems/movement.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if !entry.get_component::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `entry.get_component::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/systems/tooltips.rs:19:85 [INFO] [stdout] | [INFO] [stdout] 19 | .filter(|(_, pos, _)| **pos == map_pos && player_fov.visible_tiles.contains(&pos)) [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/player_input.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | .find_map(|(entity, pos)| Some((*entity, *pos))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.map(..).next()` [INFO] [stdout] --> src/systems/player_input.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | .find_map(|(entity, pos)| Some((*entity, *pos + delta))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `iter` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | .iter(&mut self.ecs) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 125 - .iter(&mut self.ecs) [INFO] [stdout] 125 + .iter(&self.ecs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `CommandBuffer::new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:140:41 [INFO] [stdout] | [INFO] [stdout] 140 | let mut cb = CommandBuffer::new(&mut self.ecs); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 140 - let mut cb = CommandBuffer::new(&mut self.ecs); [INFO] [stdout] 140 + let mut cb = CommandBuffer::new(&self.ecs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/systems/tooltips.rs:19:85 [INFO] [stdout] | [INFO] [stdout] 19 | .filter(|(_, pos, _)| **pos == map_pos && player_fov.visible_tiles.contains(&pos)) [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TurnState` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:193:29 [INFO] [stdout] | [INFO] [stdout] 193 | let current_state = self.resources.get::().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.resources.get::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/map_builder/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | &vec![self.map.point2d_to_index(self.player_start)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[self.map.point2d_to_index(self.player_start)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/map_builder/prefab.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | &vec![mb.map.point2d_to_index(mb.player_start)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[mb.map.point2d_to_index(mb.player_start)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `iter` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | .iter(&mut self.ecs) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 125 - .iter(&mut self.ecs) [INFO] [stdout] 125 + .iter(&self.ecs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `CommandBuffer::new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:140:41 [INFO] [stdout] | [INFO] [stdout] 140 | let mut cb = CommandBuffer::new(&mut self.ecs); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 140 - let mut cb = CommandBuffer::new(&mut self.ecs); [INFO] [stdout] 140 + let mut cb = CommandBuffer::new(&self.ecs); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TurnState` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:193:29 [INFO] [stdout] | [INFO] [stdout] 193 | let current_state = self.resources.get::().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.resources.get::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/map_builder/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | &vec![self.map.point2d_to_index(self.player_start)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[self.map.point2d_to_index(self.player_start)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/map_builder/prefab.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | &vec![mb.map.point2d_to_index(mb.player_start)], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[mb.map.point2d_to_index(mb.player_start)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 51.16s [INFO] running `Command { std: "docker" "inspect" "c1140fbd978059da8817712b920c7b52def3e4467ad1edaffe4e462e38d65e78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1140fbd978059da8817712b920c7b52def3e4467ad1edaffe4e462e38d65e78", kill_on_drop: false }` [INFO] [stdout] c1140fbd978059da8817712b920c7b52def3e4467ad1edaffe4e462e38d65e78