[INFO] cloning repository https://github.com/kazsaj/command-queue [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kazsaj/command-queue" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkazsaj%2Fcommand-queue", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkazsaj%2Fcommand-queue'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d37c090251f79a543a02d8a7043c1512a6f8fc9d [INFO] linting kazsaj/command-queue against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkazsaj%2Fcommand-queue" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kazsaj/command-queue [INFO] finished tweaking git repo https://github.com/kazsaj/command-queue [INFO] tweaked toml for git repo https://github.com/kazsaj/command-queue written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kazsaj/command-queue on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kazsaj/command-queue already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sha1_smol v1.0.1 [INFO] [stderr] Downloaded semver v0.1.20 [INFO] [stderr] Downloaded graceful v0.1.1 [INFO] [stderr] Downloaded bitflags v0.4.0 [INFO] [stderr] Downloaded rustc_version v0.1.7 [INFO] [stderr] Downloaded nix v0.7.0 [INFO] [stderr] Downloaded redis v0.29.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3466cdcfb9d0473232152ba1fd073d8d17632666479d307d9a68116378c46d7f [INFO] running `Command { std: "docker" "start" "-a" "3466cdcfb9d0473232152ba1fd073d8d17632666479d307d9a68116378c46d7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3466cdcfb9d0473232152ba1fd073d8d17632666479d307d9a68116378c46d7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3466cdcfb9d0473232152ba1fd073d8d17632666479d307d9a68116378c46d7f", kill_on_drop: false }` [INFO] [stdout] 3466cdcfb9d0473232152ba1fd073d8d17632666479d307d9a68116378c46d7f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9efb51007d97bd82362254a20209b5c6fb8b0315cd6d8c04bb7487cf3a0d5444 [INFO] running `Command { std: "docker" "start" "-a" "9efb51007d97bd82362254a20209b5c6fb8b0315cd6d8c04bb7487cf3a0d5444", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling nix v0.7.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking graceful v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking redis v0.29.5 [INFO] [stderr] Checking command-queue v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/args.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | logger.error(format!("{}", "No queue names specified, see --help")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No queue names specified, see --help".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `args` [INFO] [stdout] --> src/args.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 1..args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 1..args.len() { [INFO] [stdout] 29 + for in args.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/args.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 79 | / let env_config = EnvConfig { [INFO] [stdout] 80 | | instance_name, [INFO] [stdout] 81 | | redis_hostname, [INFO] [stdout] 82 | | redis_port, [INFO] [stdout] ... | [INFO] [stdout] 86 | | last_command_expire, [INFO] [stdout] 87 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 88 | env_config [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 79 ~ [INFO] [stdout] 80 ~ EnvConfig { [INFO] [stdout] 81 + instance_name, [INFO] [stdout] 82 + redis_hostname, [INFO] [stdout] 83 + redis_port, [INFO] [stdout] 84 + redis_pop_timeout, [INFO] [stdout] 85 + retry_sleep, [INFO] [stdout] 86 + retry_limit, [INFO] [stdout] 87 + last_command_expire, [INFO] [stdout] 88 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/output.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return match self { [INFO] [stdout] 16 | | LogLevel::Error => 3, [INFO] [stdout] 17 | | LogLevel::Warning => 2, [INFO] [stdout] 18 | | LogLevel::Info => 1, [INFO] [stdout] 19 | | LogLevel::Debug => 0, [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ match self { [INFO] [stdout] 16 + LogLevel::Error => 3, [INFO] [stdout] 17 + LogLevel::Warning => 2, [INFO] [stdout] 18 + LogLevel::Info => 1, [INFO] [stdout] 19 + LogLevel::Debug => 0, [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/output.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if &self.log_level.to_number() > &message_level.to_number() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 85 - if &self.log_level.to_number() > &message_level.to_number() { [INFO] [stdout] 85 + if self.log_level.to_number() > message_level.to_number() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `process_configs` [INFO] [stdout] --> src/worker.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..process_configs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..process_configs.len() { [INFO] [stdout] 41 + for in &process_configs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | if !pulled_value.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `pulled_value.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:46 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:55 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | &thread_number, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &thread_number, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &process_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `process_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:198:23 [INFO] [stdout] | [INFO] [stdout] 198 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 198 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | logger.info(format!("All threads finished")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"All threads finished".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `other_queues` [INFO] [stdout] --> src/main.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | for i in 0..other_queues.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 70 - for i in 0..other_queues.len() { [INFO] [stdout] 70 + for in &other_queues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:80:33 [INFO] [stdout] | [INFO] [stdout] 80 | fn get_remaining_queues(queues: &Vec, exclude: &QueueConfig) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn get_remaining_queues(queues: &Vec, exclude: &QueueConfig) -> Vec { [INFO] [stdout] 80 + fn get_remaining_queues(queues: &[QueueConfig], exclude: &QueueConfig) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `queues` [INFO] [stdout] --> src/main.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | for k in 0..queues.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 83 - for k in 0..queues.len() { [INFO] [stdout] 83 + for in &queues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/args.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | logger.error(format!("{}", "No queue names specified, see --help")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No queue names specified, see --help".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `args` [INFO] [stdout] --> src/args.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 1..args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 1..args.len() { [INFO] [stdout] 29 + for in args.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/args.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 79 | / let env_config = EnvConfig { [INFO] [stdout] 80 | | instance_name, [INFO] [stdout] 81 | | redis_hostname, [INFO] [stdout] 82 | | redis_port, [INFO] [stdout] ... | [INFO] [stdout] 86 | | last_command_expire, [INFO] [stdout] 87 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 88 | env_config [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 79 ~ [INFO] [stdout] 80 ~ EnvConfig { [INFO] [stdout] 81 + instance_name, [INFO] [stdout] 82 + redis_hostname, [INFO] [stdout] 83 + redis_port, [INFO] [stdout] 84 + redis_pop_timeout, [INFO] [stdout] 85 + retry_sleep, [INFO] [stdout] 86 + retry_limit, [INFO] [stdout] 87 + last_command_expire, [INFO] [stdout] 88 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/output.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return match self { [INFO] [stdout] 16 | | LogLevel::Error => 3, [INFO] [stdout] 17 | | LogLevel::Warning => 2, [INFO] [stdout] 18 | | LogLevel::Info => 1, [INFO] [stdout] 19 | | LogLevel::Debug => 0, [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ match self { [INFO] [stdout] 16 + LogLevel::Error => 3, [INFO] [stdout] 17 + LogLevel::Warning => 2, [INFO] [stdout] 18 + LogLevel::Info => 1, [INFO] [stdout] 19 + LogLevel::Debug => 0, [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/output.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | if &self.log_level.to_number() > &message_level.to_number() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 85 - if &self.log_level.to_number() > &message_level.to_number() { [INFO] [stdout] 85 + if self.log_level.to_number() > message_level.to_number() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `process_configs` [INFO] [stdout] --> src/worker.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..process_configs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..process_configs.len() { [INFO] [stdout] 41 + for in &process_configs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/worker.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | if !pulled_value.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `pulled_value.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:46 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:75:55 [INFO] [stdout] | [INFO] [stdout] 75 | match get_connection(&thread_number, &logger, &env_config) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | &thread_number, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &thread_number, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | &env_config, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `env_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &process_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `process_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | &logger, [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 161 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:198:23 [INFO] [stdout] | [INFO] [stdout] 198 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `thread_number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 198 | if check_stop(&thread_number, &logger) { [INFO] [stdout] | ^^^^^^^ help: change this to: `logger` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | logger.info(format!("All threads finished")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"All threads finished".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `other_queues` [INFO] [stdout] --> src/main.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 70 | for i in 0..other_queues.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 70 - for i in 0..other_queues.len() { [INFO] [stdout] 70 + for in &other_queues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:80:33 [INFO] [stdout] | [INFO] [stdout] 80 | fn get_remaining_queues(queues: &Vec, exclude: &QueueConfig) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn get_remaining_queues(queues: &Vec, exclude: &QueueConfig) -> Vec { [INFO] [stdout] 80 + fn get_remaining_queues(queues: &[QueueConfig], exclude: &QueueConfig) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `queues` [INFO] [stdout] --> src/main.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | for k in 0..queues.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 83 - for k in 0..queues.len() { [INFO] [stdout] 83 + for in &queues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.04s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.4.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "9efb51007d97bd82362254a20209b5c6fb8b0315cd6d8c04bb7487cf3a0d5444", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9efb51007d97bd82362254a20209b5c6fb8b0315cd6d8c04bb7487cf3a0d5444", kill_on_drop: false }` [INFO] [stdout] 9efb51007d97bd82362254a20209b5c6fb8b0315cd6d8c04bb7487cf3a0d5444