[INFO] cloning repository https://github.com/kassandraoftroy/stealthereum-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kassandraoftroy/stealthereum-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkassandraoftroy%2Fstealthereum-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkassandraoftroy%2Fstealthereum-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b81aa94bf3c724d0131d15148af5e36f3aebcaea [INFO] linting kassandraoftroy/stealthereum-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkassandraoftroy%2Fstealthereum-cli" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kassandraoftroy/stealthereum-cli [INFO] finished tweaking git repo https://github.com/kassandraoftroy/stealthereum-cli [INFO] tweaked toml for git repo https://github.com/kassandraoftroy/stealthereum-cli written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kassandraoftroy/stealthereum-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kassandraoftroy/stealthereum-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `edition` is set on binary `stealthereum` which is deprecated [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded alloy-network v0.9.2 [INFO] [stderr] Downloaded alloy-eip7702 v0.5.0 [INFO] [stderr] Downloaded alloy-rpc-types-any v0.9.2 [INFO] [stderr] Downloaded alloy-core v0.8.19 [INFO] [stderr] Downloaded alloy-contract v0.9.2 [INFO] [stderr] Downloaded alloy-rpc-client v0.9.2 [INFO] [stderr] Downloaded alloy-dyn-abi v0.8.19 [INFO] [stderr] Downloaded alloy-sol-types v0.8.19 [INFO] [stderr] Downloaded alloy-provider v0.9.2 [INFO] [stderr] Downloaded interprocess v2.2.2 [INFO] [stderr] Downloaded alloy-rpc-types-eth v0.9.2 [INFO] [stderr] Downloaded alloy-consensus v0.9.2 [INFO] [stderr] Downloaded alloy-primitives v0.8.19 [INFO] [stderr] Downloaded alloy-json-rpc v0.9.2 [INFO] [stderr] Downloaded alloy-json-abi v0.8.19 [INFO] [stderr] Downloaded syn-solidity v0.8.19 [INFO] [stderr] Downloaded alloy-chains v0.1.58 [INFO] [stderr] Downloaded alloy-genesis v0.9.2 [INFO] [stderr] Downloaded openssl v0.10.69 [INFO] [stderr] Downloaded alloy-rpc-types-engine v0.9.2 [INFO] [stderr] Downloaded alloy-rpc-types v0.9.2 [INFO] [stderr] Downloaded alloy-transport-ipc v0.9.2 [INFO] [stderr] Downloaded alloy-transport v0.9.2 [INFO] [stderr] Downloaded alloy v0.9.2 [INFO] [stderr] Downloaded alloy-trie v0.7.8 [INFO] [stderr] Downloaded alloy-network-primitives v0.9.2 [INFO] [stderr] Downloaded alloy-serde v0.9.2 [INFO] [stderr] Downloaded alloy-sol-macro-expander v0.8.19 [INFO] [stderr] Downloaded alloy-sol-type-parser v0.8.19 [INFO] [stderr] Downloaded alloy-eips v0.9.2 [INFO] [stderr] Downloaded alloy-sol-macro v0.8.19 [INFO] [stderr] Downloaded alloy-signer-local v0.9.2 [INFO] [stderr] Downloaded ecdsa v0.16.8 [INFO] [stderr] Downloaded crypto-bigint v0.5.3 [INFO] [stderr] Downloaded alloy-transport-http v0.9.2 [INFO] [stderr] Downloaded alloy-pubsub v0.9.2 [INFO] [stderr] Downloaded alloy-transport-ws v0.9.2 [INFO] [stderr] Downloaded alloy-consensus-any v0.9.2 [INFO] [stderr] Downloaded alloy-sol-macro-input v0.8.19 [INFO] [stderr] Downloaded eth-stealth-addresses v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2cd62fee532480c13a4de4dd7a05bb47bb9fddc00f2bd826971c6a86e695853 [INFO] running `Command { std: "docker" "start" "-a" "e2cd62fee532480c13a4de4dd7a05bb47bb9fddc00f2bd826971c6a86e695853", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2cd62fee532480c13a4de4dd7a05bb47bb9fddc00f2bd826971c6a86e695853", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2cd62fee532480c13a4de4dd7a05bb47bb9fddc00f2bd826971c6a86e695853", kill_on_drop: false }` [INFO] [stdout] e2cd62fee532480c13a4de4dd7a05bb47bb9fddc00f2bd826971c6a86e695853 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4eb8642fa27aec92ae6aa41a4a69c543c5f521165176e0c6614760e1f81b329 [INFO] running `Command { std: "docker" "start" "-a" "d4eb8642fa27aec92ae6aa41a4a69c543c5f521165176e0c6614760e1f81b329", kill_on_drop: false }` [INFO] [stderr] warning: `edition` is set on binary `stealthereum` which is deprecated [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking const-oid v0.9.5 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Compiling crunchy v0.2.3 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling winnow v0.6.26 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Checking tiny-keccak v2.0.2 [INFO] [stderr] Compiling indexmap v2.7.1 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Compiling httparse v1.10.0 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Compiling openssl v0.10.69 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking futures-utils-wasm v0.1.0 [INFO] [stderr] Compiling rustls v0.23.22 [INFO] [stderr] Compiling native-tls v0.2.13 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustversion v1.0.19 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking data-encoding v2.7.0 [INFO] [stderr] Checking webpki-roots v0.26.8 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling doctest-file v1.0.0 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Compiling c-kzg v1.0.3 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking schnellru v0.2.4 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling syn-solidity v0.8.19 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling alloy-rlp-derive v0.3.11 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling auto_impl v1.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking der v0.7.8 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling pin-project-internal v1.1.8 [INFO] [stderr] Compiling async-trait v0.1.86 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking spki v0.7.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking signature v2.1.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking scrypt v0.10.0 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking pin-project v1.1.8 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking elliptic-curve v0.13.5 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ecdsa v0.16.8 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking k256 v0.13.1 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking eth-stealth-addresses v0.1.0 [INFO] [stderr] Checking clap v4.4.3 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking const-hex v1.14.0 [INFO] [stderr] Checking alloy-sol-type-parser v0.8.19 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking nybbles v0.3.4 [INFO] [stderr] Compiling ruint v1.12.3 [INFO] [stderr] Checking alloy-rlp v0.3.11 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking eth-keystore v0.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Compiling alloy-primitives v0.8.19 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling alloy-json-abi v0.8.19 [INFO] [stderr] Checking alloy-eip7702 v0.5.0 [INFO] [stderr] Checking alloy-serde v0.9.2 [INFO] [stderr] Checking alloy-eip2930 v0.1.0 [INFO] [stderr] Checking alloy-trie v0.7.8 [INFO] [stderr] Checking alloy-signer v0.9.2 [INFO] [stderr] Checking alloy-chains v0.1.58 [INFO] [stderr] Checking alloy-eips v0.9.2 [INFO] [stderr] Compiling alloy-sol-macro-input v0.8.19 [INFO] [stderr] Checking alloy-consensus v0.9.2 [INFO] [stderr] Compiling alloy-sol-macro-expander v0.8.19 [INFO] [stderr] Checking alloy-network-primitives v0.9.2 [INFO] [stderr] Checking alloy-consensus-any v0.9.2 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.26.1 [INFO] [stderr] Checking interprocess v2.2.2 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Compiling alloy-sol-macro v0.8.19 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking alloy-sol-types v0.8.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking alloy-json-rpc v0.9.2 [INFO] [stderr] Checking alloy-rpc-types-eth v0.9.2 [INFO] [stderr] Checking alloy-dyn-abi v0.8.19 [INFO] [stderr] Checking alloy-transport v0.9.2 [INFO] [stderr] Checking alloy-core v0.8.19 [INFO] [stderr] Checking alloy-pubsub v0.9.2 [INFO] [stderr] Checking alloy-transport-http v0.9.2 [INFO] [stderr] Checking alloy-transport-ws v0.9.2 [INFO] [stderr] Checking alloy-transport-ipc v0.9.2 [INFO] [stderr] Checking alloy-rpc-client v0.9.2 [INFO] [stderr] Checking alloy-rpc-types-any v0.9.2 [INFO] [stderr] Checking alloy-rpc-types v0.9.2 [INFO] [stderr] Checking alloy-network v0.9.2 [INFO] [stderr] Checking alloy-provider v0.9.2 [INFO] [stderr] Checking alloy-signer-local v0.9.2 [INFO] [stderr] Checking alloy-contract v0.9.2 [INFO] [stderr] Checking alloy v0.9.2 [INFO] [stderr] Checking stealthereum-cli v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/stealth_transfer.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | tokens: tokens, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/stealth_transfer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/sync.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | latest_block: latest_block, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `latest_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/stealth_transfer.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | tokens: tokens, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/stealth_transfer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | values: values, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commands/sync.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | latest_block: latest_block, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `latest_block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils.rs:213:17 [INFO] [stdout] | [INFO] [stdout] 213 | value: value, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/utils.rs:213:17 [INFO] [stdout] | [INFO] [stdout] 213 | value: value, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/new_stealth_address.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/register.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `private_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/register.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/register.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / if account.is_some() { [INFO] [stdout] 67 | | if account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 68 | | password = prompt_password("Enter signer account password:") [INFO] [stdout] 69 | | .expect("Failed to read account password"); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 66 ~ if account.is_some() [INFO] [stdout] 67 ~ && account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 68 | password = prompt_password("Enter signer account password:") [INFO] [stdout] 69 | .expect("Failed to read account password"); [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/register.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 72 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_balances.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | ab.address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_balances.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 96 | public_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:123:10 [INFO] [stdout] | [INFO] [stdout] 123 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - rpc: &String, [INFO] [stdout] 123 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/commands/show_balances.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | let is_nft = match contract [INFO] [stdout] | __________________________^ [INFO] [stdout] 144 | | .clone() [INFO] [stdout] 145 | | .function( [INFO] [stdout] 146 | | "isApprovedForAll", [INFO] [stdout] ... | [INFO] [stdout] 157 | | Err(_) => false, [INFO] [stdout] 158 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 ~ let is_nft = contract [INFO] [stdout] 144 + .clone() [INFO] [stdout] 145 + .function( [INFO] [stdout] 146 + "isApprovedForAll", [INFO] [stdout] 147 + &[ [INFO] [stdout] 148 + DynSolValue::Address(addresses[0]), [INFO] [stdout] 149 + DynSolValue::Address(eth_address), [INFO] [stdout] 150 + ], [INFO] [stdout] 151 + ) [INFO] [stdout] 152 + .expect("Failed to create method call") [INFO] [stdout] 153 + .call() [INFO] [stdout] 154 ~ .await.is_ok(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands/show_balances.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | let decimals; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `decimals` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 159 ~ [INFO] [stdout] 160 ~ let decimals = if is_nft { [INFO] [stdout] 161 ~ 0 [INFO] [stdout] 162 | } else { [INFO] [stdout] 163 ~ match contract [INFO] [stdout] 164 | .function("decimals", &[]) [INFO] [stdout] ... [INFO] [stdout] 175 | Err(_) => 0, [INFO] [stdout] 176 ~ } [INFO] [stdout] 177 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:247:36 [INFO] [stdout] | [INFO] [stdout] 247 | fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 - fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] 247 + fn render_token_balances(balances: &[TokenValue], metadatas: &Vec, n: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:247:65 [INFO] [stdout] | [INFO] [stdout] 247 | fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 - fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] 247 + fn render_token_balances(balances: &Vec, metadatas: &[TokenMetadata], n: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/show_balances.rs:251:29 [INFO] [stdout] | [INFO] [stdout] 251 | let symbol = if metadatas[i].symbol == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadatas[i].symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/show_balances.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | if lines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/show_balances.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | let symbol = if metadatas[i].symbol == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadatas[i].symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/show_balances.rs:282:30 [INFO] [stdout] | [INFO] [stdout] 282 | balance.value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/show_balances.rs:286:8 [INFO] [stdout] | [INFO] [stdout] 286 | if lines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_stealth_addresses.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | public_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_stealth_addresses.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | stealth_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/new_stealth_address.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/commands/stealth_transfer.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / pub async fn run( [INFO] [stdout] 44 | | receiver: Option, [INFO] [stdout] 45 | | keystore: Option, [INFO] [stdout] 46 | | chain_id: Option, [INFO] [stdout] ... | [INFO] [stdout] 53 | | skip_approval: bool, [INFO] [stdout] 54 | | ) -> std::io::Result<()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/stealth_transfer.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `private_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/stealth_transfer.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | / if account.is_some() { [INFO] [stdout] 88 | | if account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 89 | | password = prompt_password("Enter signer account password:") [INFO] [stdout] 90 | | .expect("Failed to read account password"); [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 87 ~ if account.is_some() [INFO] [stdout] 88 ~ && account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 89 | password = prompt_password("Enter signer account password:") [INFO] [stdout] 90 | .expect("Failed to read account password"); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/stealth_transfer.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 93 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/stealth_transfer.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/stealth_transfer.rs:129:1 [INFO] [stdout] | [INFO] [stdout] 129 | / async fn stealth_transfer( [INFO] [stdout] 130 | | wallet: EthereumWallet, [INFO] [stdout] 131 | | rpc: &String, [INFO] [stdout] 132 | | contract: &String, [INFO] [stdout] ... | [INFO] [stdout] 138 | | skip_approval: bool, [INFO] [stdout] 139 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 131 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - rpc: &String, [INFO] [stdout] 131 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 ~ contract: &str, [INFO] [stdout] 133 | stealth_address: [u8; 20], [INFO] [stdout] ... [INFO] [stdout] 144 | let stealthereum = IStealthereum::new( [INFO] [stdout] 145 ~ Address::from_str(contract).unwrap(), [INFO] [stdout] 146 | provider.clone(), [INFO] [stdout] ... [INFO] [stdout] 160 | .approve( [INFO] [stdout] 161 ~ Address::from_str(contract).unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 137 | value: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - value: &String, [INFO] [stdout] 137 + value: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/register.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `private_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/register.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/register.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / if account.is_some() { [INFO] [stdout] 67 | | if account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 68 | | password = prompt_password("Enter signer account password:") [INFO] [stdout] 69 | | .expect("Failed to read account password"); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 66 ~ if account.is_some() [INFO] [stdout] 67 ~ && account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 68 | password = prompt_password("Enter signer account password:") [INFO] [stdout] 69 | .expect("Failed to read account password"); [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands/sync.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | let logfile: Logfile; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `logfile` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 36 ~ [INFO] [stdout] 37 ~ let logfile: Logfile = if !ks.join(ENCRYPTED_LOGS_FILENAME).exists() { [INFO] [stdout] 38 ~ Logfile { [INFO] [stdout] 39 | logs: vec![], [INFO] [stdout] 40 | latest_block: get_default_starting_block(&chain_id), [INFO] [stdout] 41 ~ } [INFO] [stdout] 42 | } else { [INFO] [stdout] 43 ~ load_encrypted_logfile(&password, &ks) [INFO] [stdout] 44 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/register.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 72 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/constants.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | return 11155111; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return 11155111; [INFO] [stdout] 61 + 11155111 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_balances.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | ab.address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_balances.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 96 | public_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:123:10 [INFO] [stdout] | [INFO] [stdout] 123 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - rpc: &String, [INFO] [stdout] 123 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/commands/show_balances.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | let is_nft = match contract [INFO] [stdout] | __________________________^ [INFO] [stdout] 144 | | .clone() [INFO] [stdout] 145 | | .function( [INFO] [stdout] 146 | | "isApprovedForAll", [INFO] [stdout] ... | [INFO] [stdout] 157 | | Err(_) => false, [INFO] [stdout] 158 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 ~ let is_nft = contract [INFO] [stdout] 144 + .clone() [INFO] [stdout] 145 + .function( [INFO] [stdout] 146 + "isApprovedForAll", [INFO] [stdout] 147 + &[ [INFO] [stdout] 148 + DynSolValue::Address(addresses[0]), [INFO] [stdout] 149 + DynSolValue::Address(eth_address), [INFO] [stdout] 150 + ], [INFO] [stdout] 151 + ) [INFO] [stdout] 152 + .expect("Failed to create method call") [INFO] [stdout] 153 + .call() [INFO] [stdout] 154 ~ .await.is_ok(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands/show_balances.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | let decimals; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `decimals` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 159 ~ [INFO] [stdout] 160 ~ let decimals = if is_nft { [INFO] [stdout] 161 ~ 0 [INFO] [stdout] 162 | } else { [INFO] [stdout] 163 ~ match contract [INFO] [stdout] 164 | .function("decimals", &[]) [INFO] [stdout] ... [INFO] [stdout] 175 | Err(_) => 0, [INFO] [stdout] 176 ~ } [INFO] [stdout] 177 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:247:36 [INFO] [stdout] | [INFO] [stdout] 247 | fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 - fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] 247 + fn render_token_balances(balances: &[TokenValue], metadatas: &Vec, n: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/commands/show_balances.rs:247:65 [INFO] [stdout] | [INFO] [stdout] 247 | fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 247 - fn render_token_balances(balances: &Vec, metadatas: &Vec, n: usize) { [INFO] [stdout] 247 + fn render_token_balances(balances: &Vec, metadatas: &[TokenMetadata], n: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/show_balances.rs:251:29 [INFO] [stdout] | [INFO] [stdout] 251 | let symbol = if metadatas[i].symbol == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadatas[i].symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/show_balances.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | if lines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/show_balances.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | let symbol = if metadatas[i].symbol == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `metadatas[i].symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/show_balances.rs:282:30 [INFO] [stdout] | [INFO] [stdout] 282 | balance.value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/show_balances.rs:286:8 [INFO] [stdout] | [INFO] [stdout] 286 | if lines.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_stealth_addresses.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | public_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/commands/show_stealth_addresses.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | stealth_address.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:129:10 [INFO] [stdout] | [INFO] [stdout] 129 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - rpc: &String, [INFO] [stdout] 129 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 130 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - contract: &String, [INFO] [stdout] 130 + contract: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | if decoded.inner.metadata.len() == 0 || ephem_pubkey_bytes.len() != 33 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `decoded.inner.metadata.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/utils.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | decoded.inner.metadata[0] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decoded.inner.metadata[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/utils.rs:185:35 [INFO] [stdout] | [INFO] [stdout] 185 | view_tag: decoded.inner.metadata[0] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decoded.inner.metadata[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:224:14 [INFO] [stdout] | [INFO] [stdout] 224 | address: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 - address: &String, [INFO] [stdout] 224 + address: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:225:10 [INFO] [stdout] | [INFO] [stdout] 225 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - rpc: &String, [INFO] [stdout] 225 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 226 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 226 - contract: &String, [INFO] [stdout] 226 + contract: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:261:61 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn store_encrypted_logfile(password: &String, keystore: &PathBuf, logfile: &Logfile) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 261 ~ pub fn store_encrypted_logfile(password: &String, keystore: &Path, logfile: &Logfile) { [INFO] [stdout] 262 | let mut salt = [0u8; SALT_SIZE]; [INFO] [stdout] ... [INFO] [stdout] 282 | [INFO] [stdout] 283 ~ fs::create_dir_all(keystore.to_path_buf()).expect("failed to create keystore directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:269:47 [INFO] [stdout] | [INFO] [stdout] 269 | let key = pbkdf2_hmac_array::(&password.as_bytes(), &salt, PBKDF2_ITERATIONS); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/commands/stealth_transfer.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / pub async fn run( [INFO] [stdout] 44 | | receiver: Option, [INFO] [stdout] 45 | | keystore: Option, [INFO] [stdout] 46 | | chain_id: Option, [INFO] [stdout] ... | [INFO] [stdout] 53 | | skip_approval: bool, [INFO] [stdout] 54 | | ) -> std::io::Result<()> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/stealth_transfer.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `private_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:295:60 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn load_encrypted_logfile(password: &String, keystore: &PathBuf) -> Logfile { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 295 - pub fn load_encrypted_logfile(password: &String, keystore: &PathBuf) -> Logfile { [INFO] [stdout] 295 + pub fn load_encrypted_logfile(password: &String, keystore: &Path) -> Logfile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:309:47 [INFO] [stdout] | [INFO] [stdout] 309 | let key = pbkdf2_hmac_array::(&password.as_bytes(), &salt, PBKDF2_ITERATIONS); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/stealth_transfer.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | / if account.is_some() { [INFO] [stdout] 88 | | if account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 89 | | password = prompt_password("Enter signer account password:") [INFO] [stdout] 90 | | .expect("Failed to read account password"); [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 87 ~ if account.is_some() [INFO] [stdout] 88 ~ && account != Some(ks.join(PUBLIC_ACCT_FILENAME).to_string_lossy().to_string()) { [INFO] [stdout] 89 | password = prompt_password("Enter signer account password:") [INFO] [stdout] 90 | .expect("Failed to read account password"); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:322:43 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn create_stealth_meta_keys(keystore: &PathBuf, password: &String, sk: [u8; 32], vk: [u8; 32]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 322 ~ pub fn create_stealth_meta_keys(keystore: &Path, password: &String, sk: [u8; 32], vk: [u8; 32]) { [INFO] [stdout] 323 ~ fs::create_dir_all(keystore.to_path_buf()).expect("failed to create keystore directory"); [INFO] [stdout] 324 | [INFO] [stdout] 325 | PrivateKeySigner::encrypt_keystore( [INFO] [stdout] 326 ~ keystore.to_path_buf(), [INFO] [stdout] 327 | &mut OsRng, [INFO] [stdout] ... [INFO] [stdout] 333 | PrivateKeySigner::encrypt_keystore( [INFO] [stdout] 334 ~ keystore.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | &sk, [INFO] [stdout] | ^^^ help: change this to: `sk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/stealth_transfer.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 93 | if !private_key.is_some() && password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | &vk, [INFO] [stdout] | ^^^ help: change this to: `vk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:343:36 [INFO] [stdout] | [INFO] [stdout] 343 | pub fn load_stealth_keys(keystore: &PathBuf, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 343 - pub fn load_stealth_keys(keystore: &PathBuf, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] 343 + pub fn load_stealth_keys(keystore: &Path, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/commands/stealth_transfer.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | if sma != "" { [INFO] [stdout] | ^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sma.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:344:49 [INFO] [stdout] | [INFO] [stdout] 344 | let sk = PrivateKeySigner::decrypt_keystore(&keystore.join(SECRET_KEY_FILENAME), password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `keystore.join(SECRET_KEY_FILENAME)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:346:49 [INFO] [stdout] | [INFO] [stdout] 346 | let vk = PrivateKeySigner::decrypt_keystore(&keystore.join(VIEWING_KEY_FILENAME), password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `keystore.join(VIEWING_KEY_FILENAME)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:363:27 [INFO] [stdout] | [INFO] [stdout] 363 | create_public_account(&sk.to_bytes().as_slice(), keystore, password); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sk.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | &privkey, [INFO] [stdout] | ^^^^^^^^ help: change this to: `privkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/stealth_transfer.rs:129:1 [INFO] [stdout] | [INFO] [stdout] 129 | / async fn stealth_transfer( [INFO] [stdout] 130 | | wallet: EthereumWallet, [INFO] [stdout] 131 | | rpc: &String, [INFO] [stdout] 132 | | contract: &String, [INFO] [stdout] ... | [INFO] [stdout] 138 | | skip_approval: bool, [INFO] [stdout] 139 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:131:10 [INFO] [stdout] | [INFO] [stdout] 131 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - rpc: &String, [INFO] [stdout] 131 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 132 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 ~ contract: &str, [INFO] [stdout] 133 | stealth_address: [u8; 20], [INFO] [stdout] ... [INFO] [stdout] 144 | let stealthereum = IStealthereum::new( [INFO] [stdout] 145 ~ Address::from_str(contract).unwrap(), [INFO] [stdout] 146 | provider.clone(), [INFO] [stdout] ... [INFO] [stdout] 160 | .approve( [INFO] [stdout] 161 ~ Address::from_str(contract).unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands/stealth_transfer.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 137 | value: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - value: &String, [INFO] [stdout] 137 + value: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:400:29 [INFO] [stdout] | [INFO] [stdout] 400 | if !std::fs::exists(&account).unwrap() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands/sync.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | let logfile: Logfile; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `logfile` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 36 ~ [INFO] [stdout] 37 ~ let logfile: Logfile = if !ks.join(ENCRYPTED_LOGS_FILENAME).exists() { [INFO] [stdout] 38 ~ Logfile { [INFO] [stdout] 39 | logs: vec![], [INFO] [stdout] 40 | latest_block: get_default_starting_block(&chain_id), [INFO] [stdout] 41 ~ } [INFO] [stdout] 42 | } else { [INFO] [stdout] 43 ~ load_encrypted_logfile(&password, &ks) [INFO] [stdout] 44 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/constants.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | return 11155111; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return 11155111; [INFO] [stdout] 61 + 11155111 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:129:10 [INFO] [stdout] | [INFO] [stdout] 129 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - rpc: &String, [INFO] [stdout] 129 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 130 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - contract: &String, [INFO] [stdout] 130 + contract: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | if decoded.inner.metadata.len() == 0 || ephem_pubkey_bytes.len() != 33 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `decoded.inner.metadata.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/utils.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | decoded.inner.metadata[0] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decoded.inner.metadata[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/utils.rs:185:35 [INFO] [stdout] | [INFO] [stdout] 185 | view_tag: decoded.inner.metadata[0] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decoded.inner.metadata[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:224:14 [INFO] [stdout] | [INFO] [stdout] 224 | address: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 - address: &String, [INFO] [stdout] 224 + address: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:225:10 [INFO] [stdout] | [INFO] [stdout] 225 | rpc: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - rpc: &String, [INFO] [stdout] 225 + rpc: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 226 | contract: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 226 - contract: &String, [INFO] [stdout] 226 + contract: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:261:61 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn store_encrypted_logfile(password: &String, keystore: &PathBuf, logfile: &Logfile) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 261 ~ pub fn store_encrypted_logfile(password: &String, keystore: &Path, logfile: &Logfile) { [INFO] [stdout] 262 | let mut salt = [0u8; SALT_SIZE]; [INFO] [stdout] ... [INFO] [stdout] 282 | [INFO] [stdout] 283 ~ fs::create_dir_all(keystore.to_path_buf()).expect("failed to create keystore directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:269:47 [INFO] [stdout] | [INFO] [stdout] 269 | let key = pbkdf2_hmac_array::(&password.as_bytes(), &salt, PBKDF2_ITERATIONS); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:295:60 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn load_encrypted_logfile(password: &String, keystore: &PathBuf) -> Logfile { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 295 - pub fn load_encrypted_logfile(password: &String, keystore: &PathBuf) -> Logfile { [INFO] [stdout] 295 + pub fn load_encrypted_logfile(password: &String, keystore: &Path) -> Logfile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:309:47 [INFO] [stdout] | [INFO] [stdout] 309 | let key = pbkdf2_hmac_array::(&password.as_bytes(), &salt, PBKDF2_ITERATIONS); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:322:43 [INFO] [stdout] | [INFO] [stdout] 322 | pub fn create_stealth_meta_keys(keystore: &PathBuf, password: &String, sk: [u8; 32], vk: [u8; 32]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 322 ~ pub fn create_stealth_meta_keys(keystore: &Path, password: &String, sk: [u8; 32], vk: [u8; 32]) { [INFO] [stdout] 323 ~ fs::create_dir_all(keystore.to_path_buf()).expect("failed to create keystore directory"); [INFO] [stdout] 324 | [INFO] [stdout] 325 | PrivateKeySigner::encrypt_keystore( [INFO] [stdout] 326 ~ keystore.to_path_buf(), [INFO] [stdout] 327 | &mut OsRng, [INFO] [stdout] ... [INFO] [stdout] 333 | PrivateKeySigner::encrypt_keystore( [INFO] [stdout] 334 ~ keystore.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | &sk, [INFO] [stdout] | ^^^ help: change this to: `sk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | &vk, [INFO] [stdout] | ^^^ help: change this to: `vk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:343:36 [INFO] [stdout] | [INFO] [stdout] 343 | pub fn load_stealth_keys(keystore: &PathBuf, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 343 - pub fn load_stealth_keys(keystore: &PathBuf, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] 343 + pub fn load_stealth_keys(keystore: &Path, password: &String) -> ([u8; 32], [u8; 32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:344:49 [INFO] [stdout] | [INFO] [stdout] 344 | let sk = PrivateKeySigner::decrypt_keystore(&keystore.join(SECRET_KEY_FILENAME), password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `keystore.join(SECRET_KEY_FILENAME)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:346:49 [INFO] [stdout] | [INFO] [stdout] 346 | let vk = PrivateKeySigner::decrypt_keystore(&keystore.join(VIEWING_KEY_FILENAME), password) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `keystore.join(VIEWING_KEY_FILENAME)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:363:27 [INFO] [stdout] | [INFO] [stdout] 363 | create_public_account(&sk.to_bytes().as_slice(), keystore, password); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sk.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | &privkey, [INFO] [stdout] | ^^^^^^^^ help: change this to: `privkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:400:29 [INFO] [stdout] | [INFO] [stdout] 400 | if !std::fs::exists(&account).unwrap() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `Command { std: "docker" "inspect" "d4eb8642fa27aec92ae6aa41a4a69c543c5f521165176e0c6614760e1f81b329", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4eb8642fa27aec92ae6aa41a4a69c543c5f521165176e0c6614760e1f81b329", kill_on_drop: false }` [INFO] [stdout] d4eb8642fa27aec92ae6aa41a4a69c543c5f521165176e0c6614760e1f81b329