[INFO] cloning repository https://github.com/karabulut18/karabulut18-codecrafters-shell-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/karabulut18/karabulut18-codecrafters-shell-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkarabulut18%2Fkarabulut18-codecrafters-shell-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkarabulut18%2Fkarabulut18-codecrafters-shell-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 924e94429aa09f477cdeaaeebe85423359ded0f7 [INFO] linting karabulut18/karabulut18-codecrafters-shell-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkarabulut18%2Fkarabulut18-codecrafters-shell-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/karabulut18/karabulut18-codecrafters-shell-rust [INFO] finished tweaking git repo https://github.com/karabulut18/karabulut18-codecrafters-shell-rust [INFO] tweaked toml for git repo https://github.com/karabulut18/karabulut18-codecrafters-shell-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/karabulut18/karabulut18-codecrafters-shell-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/karabulut18/karabulut18-codecrafters-shell-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.63 [INFO] [stderr] Downloaded proc-macro2 v1.0.86 [INFO] [stderr] Downloaded dirs-next v2.0.0 [INFO] [stderr] Downloaded fd-lock v3.0.13 [INFO] [stderr] Downloaded error-code v2.3.1 [INFO] [stderr] Downloaded str-buf v1.0.6 [INFO] [stderr] Downloaded thiserror v1.0.63 [INFO] [stderr] Downloaded clipboard-win v4.5.0 [INFO] [stderr] Downloaded anyhow v1.0.86 [INFO] [stderr] Downloaded libredox v0.1.10 [INFO] [stderr] Downloaded bytes v1.7.1 [INFO] [stderr] Downloaded rustyline v10.1.1 [INFO] [stderr] Downloaded syn v2.0.75 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded nix v0.25.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1be4e4be9d1c01083d637abe59acf2d7a28ed00ea9ca67d9be008dad2cc0862a [INFO] running `Command { std: "docker" "start" "-a" "1be4e4be9d1c01083d637abe59acf2d7a28ed00ea9ca67d9be008dad2cc0862a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1be4e4be9d1c01083d637abe59acf2d7a28ed00ea9ca67d9be008dad2cc0862a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1be4e4be9d1c01083d637abe59acf2d7a28ed00ea9ca67d9be008dad2cc0862a", kill_on_drop: false }` [INFO] [stdout] 1be4e4be9d1c01083d637abe59acf2d7a28ed00ea9ca67d9be008dad2cc0862a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fa00515c36a1ed6d44ba5c1753b5cf5290dd491f7eba4eb91a9116d826d812e [INFO] running `Command { std: "docker" "start" "-a" "5fa00515c36a1ed6d44ba5c1753b5cf5290dd491f7eba4eb91a9116d826d812e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rustyline v10.1.1 [INFO] [stderr] Checking codecrafters-shell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Shell` [INFO] [stdout] --> src/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | let config = Config::builder() [INFO] [stdout] 29 | | .completion_type(CompletionType::List) [INFO] [stdout] 30 | | .bell_style(BellStyle::Audible) [INFO] [stdout] ... | [INFO] [stdout] 52 | | Shell { editor: rl, history_append_files: HashMap::new() } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 25 + impl Default for Shell { [INFO] [stdout] 26 + fn default() -> Self { [INFO] [stdout] 27 + Self::new() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Shell` [INFO] [stdout] --> src/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | let config = Config::builder() [INFO] [stdout] 29 | | .completion_type(CompletionType::List) [INFO] [stdout] 30 | | .bell_style(BellStyle::Audible) [INFO] [stdout] ... | [INFO] [stdout] 52 | | Shell { editor: rl, history_append_files: HashMap::new() } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 25 + impl Default for Shell { [INFO] [stdout] 26 + fn default() -> Self { [INFO] [stdout] 27 + Self::new() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return None [INFO] [stdout] 62 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return None [INFO] [stdout] 62 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:68:79 [INFO] [stdout] | [INFO] [stdout] 68 | match OpenOptions::new().write(true).create(true).truncate(true).open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:68:79 [INFO] [stdout] | [INFO] [stdout] 68 | match OpenOptions::new().write(true).create(true).truncate(true).open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:237:24 [INFO] [stdout] | [INFO] [stdout] 237 | fn is_executable(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 237 - fn is_executable(path: &PathBuf) -> bool { [INFO] [stdout] 237 + fn is_executable(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:237:24 [INFO] [stdout] | [INFO] [stdout] 237 | fn is_executable(path: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 237 - fn is_executable(path: &PathBuf) -> bool { [INFO] [stdout] 237 + fn is_executable(path: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:380:38 [INFO] [stdout] | [INFO] [stdout] 380 | else if c.is_whitespace() && !quote_char.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `quote_char.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | return args [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return args [INFO] [stdout] 398 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:380:38 [INFO] [stdout] | [INFO] [stdout] 380 | else if c.is_whitespace() && !quote_char.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `quote_char.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | return args [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return args [INFO] [stdout] 398 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:408:34 [INFO] [stdout] | [INFO] [stdout] 408 | let raw_args = arg_parse(&cmd_string.trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `cmd_string.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:408:34 [INFO] [stdout] | [INFO] [stdout] 408 | let raw_args = arg_parse(&cmd_string.trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `cmd_string.trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | / fn run_single_command( [INFO] [stdout] 496 | | shell: &mut Shell, [INFO] [stdout] 497 | | command_args: &[String], [INFO] [stdout] 498 | | stdin_pipe: Option, // The stdin for this command [INFO] [stdout] ... | [INFO] [stdout] 503 | | is_last: bool, // True if this is the last command in the pipeline [INFO] [stdout] 504 | | ) -> Option{ [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:620:17 [INFO] [stdout] | [INFO] [stdout] 620 | / return execute_piped("printf", [INFO] [stdout] 621 | | &["%s", &std_out_s], [INFO] [stdout] 622 | | stdin_pipe, [INFO] [stdout] 623 | | None, [INFO] [stdout] ... | [INFO] [stdout] 626 | | false, [INFO] [stdout] 627 | | true) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 ~ execute_piped("printf", [INFO] [stdout] 621 + &["%s", &std_out_s], [INFO] [stdout] 622 + stdin_pipe, [INFO] [stdout] 623 + None, [INFO] [stdout] 624 + false, [INFO] [stdout] 625 + None, [INFO] [stdout] 626 + false, [INFO] [stdout] 627 + true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:535:40 [INFO] [stdout] | [INFO] [stdout] 535 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | / fn run_single_command( [INFO] [stdout] 496 | | shell: &mut Shell, [INFO] [stdout] 497 | | command_args: &[String], [INFO] [stdout] 498 | | stdin_pipe: Option, // The stdin for this command [INFO] [stdout] ... | [INFO] [stdout] 503 | | is_last: bool, // True if this is the last command in the pipeline [INFO] [stdout] 504 | | ) -> Option{ [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:620:17 [INFO] [stdout] | [INFO] [stdout] 620 | / return execute_piped("printf", [INFO] [stdout] 621 | | &["%s", &std_out_s], [INFO] [stdout] 622 | | stdin_pipe, [INFO] [stdout] 623 | | None, [INFO] [stdout] ... | [INFO] [stdout] 626 | | false, [INFO] [stdout] 627 | | true) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 ~ execute_piped("printf", [INFO] [stdout] 621 + &["%s", &std_out_s], [INFO] [stdout] 622 + stdin_pipe, [INFO] [stdout] 623 + None, [INFO] [stdout] 624 + false, [INFO] [stdout] 625 + None, [INFO] [stdout] 626 + false, [INFO] [stdout] 627 + true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:535:40 [INFO] [stdout] | [INFO] [stdout] 535 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:555:40 [INFO] [stdout] | [INFO] [stdout] 555 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:555:40 [INFO] [stdout] | [INFO] [stdout] 555 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:639:44 [INFO] [stdout] | [INFO] [stdout] 639 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:647:44 [INFO] [stdout] | [INFO] [stdout] 647 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:639:44 [INFO] [stdout] | [INFO] [stdout] 639 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/main.rs:647:44 [INFO] [stdout] | [INFO] [stdout] 647 | if let Some(arg) = parts.get(0) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:686:1 [INFO] [stdout] | [INFO] [stdout] 686 | / fn execute_piped( [INFO] [stdout] 687 | | command: &str, [INFO] [stdout] 688 | | args: &[&str], [INFO] [stdout] 689 | | mut stdin_pipe: Option, // Input from previous pipe [INFO] [stdout] ... | [INFO] [stdout] 694 | | create_pipe: bool, [INFO] [stdout] 695 | | ) -> Option [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:686:1 [INFO] [stdout] | [INFO] [stdout] 686 | / fn execute_piped( [INFO] [stdout] 687 | | command: &str, [INFO] [stdout] 688 | | args: &[&str], [INFO] [stdout] 689 | | mut stdin_pipe: Option, // Input from previous pipe [INFO] [stdout] ... | [INFO] [stdout] 694 | | create_pipe: bool, [INFO] [stdout] 695 | | ) -> Option [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.47s [INFO] running `Command { std: "docker" "inspect" "5fa00515c36a1ed6d44ba5c1753b5cf5290dd491f7eba4eb91a9116d826d812e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fa00515c36a1ed6d44ba5c1753b5cf5290dd491f7eba4eb91a9116d826d812e", kill_on_drop: false }` [INFO] [stdout] 5fa00515c36a1ed6d44ba5c1753b5cf5290dd491f7eba4eb91a9116d826d812e