[INFO] cloning repository https://github.com/kanra824/rust-kyopro [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kanra824/rust-kyopro" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkanra824%2Frust-kyopro", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkanra824%2Frust-kyopro'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 744ffbbe707295782b075740d229ff8f3d11c6a9 [INFO] linting kanra824/rust-kyopro against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkanra824%2Frust-kyopro" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kanra824/rust-kyopro [INFO] finished tweaking git repo https://github.com/kanra824/rust-kyopro [INFO] tweaked toml for git repo https://github.com/kanra824/rust-kyopro written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kanra824/rust-kyopro on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kanra824/rust-kyopro already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded superslice v1.0.0 [INFO] [stderr] Downloaded proconio v0.5.0 [INFO] [stderr] Downloaded permutohedron v0.2.4 [INFO] [stderr] Downloaded proconio-derive v0.2.1 [INFO] [stderr] Downloaded ac-library-rs v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcae1afb7453843f69ddfcc075a508348c0d92e9de20f3040c1548a730a529b9 [INFO] running `Command { std: "docker" "start" "-a" "dcae1afb7453843f69ddfcc075a508348c0d92e9de20f3040c1548a730a529b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcae1afb7453843f69ddfcc075a508348c0d92e9de20f3040c1548a730a529b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcae1afb7453843f69ddfcc075a508348c0d92e9de20f3040c1548a730a529b9", kill_on_drop: false }` [INFO] [stdout] dcae1afb7453843f69ddfcc075a508348c0d92e9de20f3040c1548a730a529b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b14378f9c0be1ea50665c722af74577bff0b480dd8928049fca692c4c3baa952 [INFO] running `Command { std: "docker" "start" "-a" "b14378f9c0be1ea50665c722af74577bff0b480dd8928049fca692c4c3baa952", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ac-library-rs v0.2.0 [INFO] [stderr] Checking permutohedron v0.2.4 [INFO] [stderr] Checking superslice v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Compiling proconio-derive v0.2.1 [INFO] [stderr] Checking proconio v0.5.0 [INFO] [stderr] Checking atcoder v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/fft.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 45 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/fft.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 126 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/ntt.rs:132:11 [INFO] [stdout] | [INFO] [stdout] 132 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/ntt.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/library/structure/union_find.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | UnionFind { n: n, par, sz } [INFO] [stdout] | ^^^^ help: replace it with: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/fft.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 45 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/fft.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 126 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/ntt.rs:132:11 [INFO] [stdout] | [INFO] [stdout] 132 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/library/number/ntt.rs:183:11 [INFO] [stdout] | [INFO] [stdout] 183 | while n <= sza + szb - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change it to: `n < sza + szb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/library/structure/union_find.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | UnionFind { n: n, par, sz } [INFO] [stdout] | ^^^^ help: replace it with: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/tests/others/rolling_hash_on_segtree.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | v[i] = ((xorshift(s[i] as u128 + 1), 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `(xorshift(s[i] as u128 + 1), 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/library/fps/bostan_mori.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | if np.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `np.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/library/fps/bostan_mori.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | for i in 0..k { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for i in 0..k { [INFO] [stdout] 77 + for in c.iter().take(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/library/fps.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod fps; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a_in` [INFO] [stdout] --> src/library/fps/fps.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | for i in 0..a_in.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 27 - for i in 0..a_in.len() { [INFO] [stdout] 27 + for in &a_in { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/fps/fps.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 62 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 62 - for i in 0..self.n { [INFO] [stdout] 62 + for (i, ) in a.iter_mut().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/library/fps/fps.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | if a.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/library/graph/dijkstra.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(now_cost) = res[now] { [INFO] [stdout] 20 | | if val > now_cost { [INFO] [stdout] 21 | | continue; [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(now_cost) = res[now] [INFO] [stdout] 20 ~ && val > now_cost { [INFO] [stdout] 21 | continue; [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/library/graph.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod graph; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:33:46 [INFO] [stdout] | [INFO] [stdout] 33 | build_lowlink(i, usize::MAX, &self, &mut visited, &mut order, &mut lowlink); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:104:57 [INFO] [stdout] | [INFO] [stdout] 104 | build_biconnected_components(i, usize::MAX, &self, &lowlink, &mut used, &mut tmp, &mut bc); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:104:64 [INFO] [stdout] | [INFO] [stdout] 104 | build_biconnected_components(i, usize::MAX, &self, &lowlink, &mut used, &mut tmp, &mut bc); [INFO] [stdout] | ^^^^^^^^ help: change this to: `lowlink` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:166:76 [INFO] [stdout] | [INFO] [stdout] 166 | build_two_edge_connected_components(i, usize::MAX, &mut k, &self, lowlink, &mut tec); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `num` [INFO] [stdout] --> src/library/graph/strongly_connected_components.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..self.n { [INFO] [stdout] 20 + for (i, ) in num.iter().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/library/graph/strongly_connected_components.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..self.n { [INFO] [stdout] 29 + for in v.iter().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/library/number/ext_gcd.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn ext_gcd(a: i64, b: i64, x: i64, y: i64) -> (i64, i64, i64) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/library/number/ext_gcd.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | let (y, x, g) = ext_gcd(b, a % b, y, x); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/library/number/ext_gcd.rs:4:40 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn ext_gcd(a: i64, b: i64, x: i64, y: i64) -> (i64, i64, i64) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/library/number/ext_gcd.rs:8:43 [INFO] [stdout] | [INFO] [stdout] 8 | let (y, x, g) = ext_gcd(b, a % b, y, x); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | fn fft(a: &Vec, inv: f64) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 ~ fn fft(a: &[Complex64], inv: f64) -> Vec { [INFO] [stdout] 7 | let n = a.len(); [INFO] [stdout] 8 | let mut res = vec![]; [INFO] [stdout] 9 | if n == 1 { [INFO] [stdout] 10 ~ return a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/number/fft.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 15 - for i in 0..n { [INFO] [stdout] 15 + for (i, ) in a.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:39:33 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 39 - pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 39 + pub fn convolution_butterfly(a: &[f64], b: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:39:47 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 39 - pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 39 + pub fn convolution_butterfly(a: &Vec, b: &[f64]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `bit_reverse` [INFO] [stdout] --> src/library/number/fft.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 80 - for i in 0..n { [INFO] [stdout] 80 + for (i, ) in bit_reverse.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 120 + pub fn convolution(a: &[f64], b: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:120:37 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 120 + pub fn convolution(a: &Vec, b: &[f64]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/library/number/fft.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 0..n { [INFO] [stdout] 150 + for in c.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/mint.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | res = res * mul; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `res *= mul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/library/number/mint.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | self.pow((self.p - 2) as i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((self.p - 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/library/number/moebius.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if ((i / p[i]) % p[i] == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(i / p[i]).is_multiple_of(p[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | fn ntt(a: &Vec, depth: i64, root: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 ~ fn ntt(a: &[Modint], depth: i64, root: &Vec) -> Vec { [INFO] [stdout] 45 | let n = a.len(); [INFO] [stdout] 46 | if n == 1 { [INFO] [stdout] 47 ~ return a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/number/ntt.rs:52:14 [INFO] [stdout] | [INFO] [stdout] 52 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 52 - for i in 0..n { [INFO] [stdout] 52 + for (i, ) in a.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | now = now * r; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `now *= r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] 76 + fn butterfly_ntt(a: &mut [Modint], root: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] 76 + fn butterfly_ntt(a: &mut Vec, root: &[Modint]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `h` is used to index `twiddles` [INFO] [stdout] --> src/library/number/ntt.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for h in 0..log2n { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for h in 0..log2n { [INFO] [stdout] 110 + for (h, ) in twiddles.iter().enumerate().take(log2n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `pv` [INFO] [stdout] --> src/library/number/ntt.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 138 - for i in 0..3 { [INFO] [stdout] 138 + for in pv.iter().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | a_mint[i] = a_mint[i] * b_mint[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_mint[i] *= b_mint[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a_mint` [INFO] [stdout] --> src/library/number/ntt.rs:160:18 [INFO] [stdout] | [INFO] [stdout] 160 | for i in 0..(sza + szb - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 160 - for i in 0..(sza + szb - 1) { [INFO] [stdout] 160 + for in a_mint.iter_mut().take((sza + szb - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | a_mint[i] = a_mint[i] * ninv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_mint[i] *= ninv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/library/number/ntt.rs:167:14 [INFO] [stdout] | [INFO] [stdout] 167 | for i in 0..v[0].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 167 - for i in 0..v[0].len() { [INFO] [stdout] 167 + for in v.iter().take(v[0].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `v` [INFO] [stdout] --> src/library/number/ntt.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | for j in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 169 - for j in 0..3 { [INFO] [stdout] 169 + for in v.iter().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | a[i] = a[i] * b[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] *= b[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/library/number/ntt.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 205 | for i in 0..(sza + szb - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 205 - for i in 0..(sza + szb - 1) { [INFO] [stdout] 205 + for in a.iter_mut().take((sza + szb - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | a[i] = a[i] * ninv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] *= ninv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/library/others/kitamasa.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn kitamasa(n: i64, a: Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/others/rolling_hash.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(s: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 ~ pub fn new(s: &[char]) -> Self { [INFO] [stdout] 29 | let mut hash = vec![0; s.len() + 1]; [INFO] [stdout] ... [INFO] [stdout] 38 | RollingHash { [INFO] [stdout] 39 ~ s: s.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/others/matrix.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..n { [INFO] [stdout] 34 + for (i, ) in a.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in 0..self.h { [INFO] [stdout] 48 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | for j in 0..self.w { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 49 - for j in 0..self.w { [INFO] [stdout] 49 + for (j, ) in res.iter_mut().enumerate().take(self.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 63 - for i in 0..self.h { [INFO] [stdout] 63 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | for j in 0..b.w { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 64 - for j in 0..b.w { [INFO] [stdout] 64 + for (j, ) in res.iter_mut().enumerate().take(b.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/others/matrix.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | res[i][j] = res[i][j] + self.a[i][k] * b.a[k][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res[i][j] += self.a[i][k] * b.a[k][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/others/matrix.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return usize::MAX; [INFO] [stdout] 97 + usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `rank` is used as a loop counter [INFO] [stdout] --> src/library/others/matrix.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | for col in 0..self.w { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (rank, col) in (0..self.w).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/others/matrix_i64.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..n { [INFO] [stdout] 29 + for (i, ) in a.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 43 - for i in 0..self.h { [INFO] [stdout] 43 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | for j in 0..self.w { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for j in 0..self.w { [INFO] [stdout] 44 + for (j, ) in res.iter_mut().enumerate().take(self.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 58 - for i in 0..self.h { [INFO] [stdout] 58 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:59:22 [INFO] [stdout] | [INFO] [stdout] 59 | for j in 0..b.w { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 59 - for j in 0..b.w { [INFO] [stdout] 59 + for (j, ) in res.iter_mut().enumerate().take(b.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/others/matrix_i64.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | res[i][j] = res[i][j] + self.a[i][k] * b.a[k][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res[i][j] += self.a[i][k] * b.a[k][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn build(&mut self, v: &Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn build(&mut self, v: &Vec) { [INFO] [stdout] 45 + pub fn build(&mut self, v: &[T]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `v` [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 47 - for i in 0..self.n { [INFO] [stdout] 47 + for (i, ) in v.iter().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - if r <= a || b <= l { [INFO] [stdout] 86 - return; [INFO] [stdout] 85 + if r <= a || b <= l { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | return self.e; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return self.e; [INFO] [stdout] 100 + self.e [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | return self.data[k]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self.data[k]; [INFO] [stdout] 102 + self.data[k] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return (self.f)(vl, vr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return (self.f)(vl, vr); [INFO] [stdout] 106 + (self.f)(vl, vr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:113:6 [INFO] [stdout] | [INFO] [stdout] 113 | ) -> LazySegmentTree< [INFO] [stdout] | ______^ [INFO] [stdout] 114 | | i64, [INFO] [stdout] 115 | | i64, [INFO] [stdout] 116 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 117 | | impl Fn(i64, i64, usize) -> i64, [INFO] [stdout] 118 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 119 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:125:6 [INFO] [stdout] | [INFO] [stdout] 125 | ) -> LazySegmentTree< [INFO] [stdout] | ______^ [INFO] [stdout] 126 | | i64, [INFO] [stdout] 127 | | i64, [INFO] [stdout] 128 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 129 | | impl Fn(i64, i64, usize) -> i64, [INFO] [stdout] 130 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 131 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/structure/segment_tree.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / for i in 0..n { [INFO] [stdout] 25 | | v_[n_ + i] = v[i]; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `v_[n_..(n + n_)].copy_from_slice(&v[..n]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/structure/segment_tree_ref.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for i in 0..n { [INFO] [stdout] 26 | | v_[n_ + i] = v[i].clone(); [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `v_[n_..(n + n_)].clone_from_slice(&v[..n]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/trie.rs:25:30 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn add(&mut self, s: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - pub fn add(&mut self, s: &Vec) { [INFO] [stdout] 25 + pub fn add(&mut self, s: &[char]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `s` [INFO] [stdout] --> src/library/structure/trie.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..s.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 28 - for i in 0..s.len() { [INFO] [stdout] 28 + for in &s { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/library/structure/trie.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | !self.child[idx].is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.child[idx].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/trie.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn calc_lcp_sum(&mut self, s: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn calc_lcp_sum(&mut self, s: &Vec) -> i64 { [INFO] [stdout] 48 + pub fn calc_lcp_sum(&mut self, s: &[char]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `s` [INFO] [stdout] --> src/library/structure/trie.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 53 | for i in 0..s.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for i in 0..s.len() { [INFO] [stdout] 53 + for in &s { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/structure/union_find.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | self.sz[y] = self.sz[x] + self.sz[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.sz[y] += self.sz[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / match ccw(&self.a, &self.b, p) { [INFO] [stdout] 38 | | CCW::CounterClockwise | CCW::Clockwise => false, [INFO] [stdout] 39 | | _ => true, [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 37 - match ccw(&self.a, &self.b, p) { [INFO] [stdout] 38 - CCW::CounterClockwise | CCW::Clockwise => false, [INFO] [stdout] 39 - _ => true, [INFO] [stdout] 40 - } [INFO] [stdout] 37 + !matches!(ccw(&self.a, &self.b, p), CCW::CounterClockwise | CCW::Clockwise) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / match ccw(&self.a, &self.b, p) { [INFO] [stdout] 102 | | CCW::OnSegment => true, [INFO] [stdout] 103 | | _ => false, [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - match ccw(&self.a, &self.b, p) { [INFO] [stdout] 102 - CCW::OnSegment => true, [INFO] [stdout] 103 - _ => false, [INFO] [stdout] 104 - } [INFO] [stdout] 101 + matches!(ccw(&self.a, &self.b, p), CCW::OnSegment) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCW` contains a capitalized acronym [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:253:6 [INFO] [stdout] | [INFO] [stdout] 253 | enum CCW { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ccw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/aho_corasick.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | fn make_goto(&mut self, patterns: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - fn make_goto(&mut self, patterns: &Vec>) { [INFO] [stdout] 43 + fn make_goto(&mut self, patterns: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `patterns` [INFO] [stdout] --> src/library/string/aho_corasick.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..patterns.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..patterns.len() { [INFO] [stdout] 45 + for (i, ) in patterns.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/library/string/aho_corasick.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | while let None = self.goto(now, x) { [INFO] [stdout] | ----------^^^^-------------------- help: try: `while self.goto(now, x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/aho_corasick.rs:111:36 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn query(&mut self, query: &Vec) -> std::collections::BTreeSet { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - pub fn query(&mut self, query: &Vec) -> std::collections::BTreeSet { [INFO] [stdout] 111 + pub fn query(&mut self, query: &[usize]) -> std::collections::BTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `query` [INFO] [stdout] --> src/library/string/aho_corasick.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 114 | for i in 0..query.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 114 - for i in 0..query.len() { [INFO] [stdout] 114 + for in &query { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/library/fps/bostan_mori.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | if np.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `np.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/manacher.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn manacher(s: &Vec) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn manacher(s: &Vec) -> Vec [INFO] [stdout] 1 + pub fn manacher(s: &[T]) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/library/fps/bostan_mori.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 77 | for i in 0..k { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for i in 0..k { [INFO] [stdout] 77 + for in c.iter().take(k) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/library/fps.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod fps; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/suffix_array.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn suffix_array(s: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn suffix_array(s: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn suffix_array(s: &[char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/string/suffix_array.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / for i in 0..=n { [INFO] [stdout] 49 | | rank[i] = tmp[i]; [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `rank[..(n + 1)].copy_from_slice(&tmp[..(n + 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a_in` [INFO] [stdout] --> src/library/fps/fps.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | for i in 0..a_in.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 27 - for i in 0..a_in.len() { [INFO] [stdout] 27 + for in &a_in { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/z_algorithm.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn z_algorithm(s: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn z_algorithm(s: &Vec) -> Vec { [INFO] [stdout] 1 + pub fn z_algorithm(s: &[char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests/fps.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod fps; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests/graph.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod graph; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/fps/fps.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 62 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 62 - for i in 0..self.n { [INFO] [stdout] 62 + for (i, ) in a.iter_mut().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/library/fps/fps.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | if a.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | fn update_min(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn update_min(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 66 + fn update_min(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in l..r { [INFO] [stdout] 67 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | fn update_max(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn update_max(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 72 + fn update_max(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 73 - for i in l..r { [INFO] [stdout] 73 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | fn add_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn add_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 78 + fn add_val(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 79 - for i in l..r { [INFO] [stdout] 79 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:84:46 [INFO] [stdout] | [INFO] [stdout] 84 | fn update_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - fn update_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 84 + fn update_val(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 85 - for i in l..r { [INFO] [stdout] 85 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | fn query_max(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn query_max(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 90 + fn query_max(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 92 - for i in l..r { [INFO] [stdout] 92 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:98:37 [INFO] [stdout] | [INFO] [stdout] 98 | fn query_min(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - fn query_min(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 98 + fn query_min(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 100 - for i in l..r { [INFO] [stdout] 100 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | fn query_sum(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn query_sum(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 106 + fn query_sum(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:108:14 [INFO] [stdout] | [INFO] [stdout] 108 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 108 - for i in l..r { [INFO] [stdout] 108 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | fn pr_vec(v: &Vec) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn pr_vec(v: &Vec) [INFO] [stdout] 42 + fn pr_vec(v: &[T]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/library/graph/dijkstra.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(now_cost) = res[now] { [INFO] [stdout] 20 | | if val > now_cost { [INFO] [stdout] 21 | | continue; [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(now_cost) = res[now] [INFO] [stdout] 20 ~ && val > now_cost { [INFO] [stdout] 21 | continue; [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/library/graph.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod graph; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:33:46 [INFO] [stdout] | [INFO] [stdout] 33 | build_lowlink(i, usize::MAX, &self, &mut visited, &mut order, &mut lowlink); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:104:57 [INFO] [stdout] | [INFO] [stdout] 104 | build_biconnected_components(i, usize::MAX, &self, &lowlink, &mut used, &mut tmp, &mut bc); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:104:64 [INFO] [stdout] | [INFO] [stdout] 104 | build_biconnected_components(i, usize::MAX, &self, &lowlink, &mut used, &mut tmp, &mut bc); [INFO] [stdout] | ^^^^^^^^ help: change this to: `lowlink` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/library/graph/lowlink.rs:166:76 [INFO] [stdout] | [INFO] [stdout] 166 | build_two_edge_connected_components(i, usize::MAX, &mut k, &self, lowlink, &mut tec); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `num` [INFO] [stdout] --> src/library/graph/strongly_connected_components.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..self.n { [INFO] [stdout] 20 + for (i, ) in num.iter().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/library/graph/strongly_connected_components.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..self.n { [INFO] [stdout] 29 + for in v.iter().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/library/number/ext_gcd.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn ext_gcd(a: i64, b: i64, x: i64, y: i64) -> (i64, i64, i64) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/library/number/ext_gcd.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | let (y, x, g) = ext_gcd(b, a % b, y, x); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/library/number/ext_gcd.rs:4:40 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn ext_gcd(a: i64, b: i64, x: i64, y: i64) -> (i64, i64, i64) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/library/number/ext_gcd.rs:8:43 [INFO] [stdout] | [INFO] [stdout] 8 | let (y, x, g) = ext_gcd(b, a % b, y, x); [INFO] [stdout] | ^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | fn fft(a: &Vec, inv: f64) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 ~ fn fft(a: &[Complex64], inv: f64) -> Vec { [INFO] [stdout] 7 | let n = a.len(); [INFO] [stdout] 8 | let mut res = vec![]; [INFO] [stdout] 9 | if n == 1 { [INFO] [stdout] 10 ~ return a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/number/fft.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 15 - for i in 0..n { [INFO] [stdout] 15 + for (i, ) in a.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:39:33 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 39 - pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 39 + pub fn convolution_butterfly(a: &[f64], b: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:39:47 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 39 - pub fn convolution_butterfly(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 39 + pub fn convolution_butterfly(a: &Vec, b: &[f64]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `bit_reverse` [INFO] [stdout] --> src/library/number/fft.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 80 - for i in 0..n { [INFO] [stdout] 80 + for (i, ) in bit_reverse.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 120 + pub fn convolution(a: &[f64], b: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/fft.rs:120:37 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - pub fn convolution(a: &Vec, b: &Vec) -> Vec { [INFO] [stdout] 120 + pub fn convolution(a: &Vec, b: &[f64]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `c` [INFO] [stdout] --> src/library/number/fft.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 0..n { [INFO] [stdout] 150 + for in c.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/mint.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | res = res * mul; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `res *= mul` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/library/number/mint.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | self.pow((self.p - 2) as i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((self.p - 2))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/library/number/moebius.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if ((i / p[i]) % p[i] == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(i / p[i]).is_multiple_of(p[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | fn ntt(a: &Vec, depth: i64, root: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 ~ fn ntt(a: &[Modint], depth: i64, root: &Vec) -> Vec { [INFO] [stdout] 45 | let n = a.len(); [INFO] [stdout] 46 | if n == 1 { [INFO] [stdout] 47 ~ return a.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/number/ntt.rs:52:14 [INFO] [stdout] | [INFO] [stdout] 52 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 52 - for i in 0..n { [INFO] [stdout] 52 + for (i, ) in a.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | now = now * r; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `now *= r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] 76 + fn butterfly_ntt(a: &mut [Modint], root: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/number/ntt.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - fn butterfly_ntt(a: &mut Vec, root: &Vec) { [INFO] [stdout] 76 + fn butterfly_ntt(a: &mut Vec, root: &[Modint]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `h` is used to index `twiddles` [INFO] [stdout] --> src/library/number/ntt.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for h in 0..log2n { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for h in 0..log2n { [INFO] [stdout] 110 + for (h, ) in twiddles.iter().enumerate().take(log2n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `pv` [INFO] [stdout] --> src/library/number/ntt.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 138 - for i in 0..3 { [INFO] [stdout] 138 + for in pv.iter().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | a_mint[i] = a_mint[i] * b_mint[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_mint[i] *= b_mint[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a_mint` [INFO] [stdout] --> src/library/number/ntt.rs:160:18 [INFO] [stdout] | [INFO] [stdout] 160 | for i in 0..(sza + szb - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 160 - for i in 0..(sza + szb - 1) { [INFO] [stdout] 160 + for in a_mint.iter_mut().take((sza + szb - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | a_mint[i] = a_mint[i] * ninv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_mint[i] *= ninv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/library/number/ntt.rs:167:14 [INFO] [stdout] | [INFO] [stdout] 167 | for i in 0..v[0].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 167 - for i in 0..v[0].len() { [INFO] [stdout] 167 + for in v.iter().take(v[0].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `v` [INFO] [stdout] --> src/library/number/ntt.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 169 | for j in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 169 - for j in 0..3 { [INFO] [stdout] 169 + for in v.iter().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | a[i] = a[i] * b[i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] *= b[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/library/number/ntt.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 205 | for i in 0..(sza + szb - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 205 - for i in 0..(sza + szb - 1) { [INFO] [stdout] 205 + for in a.iter_mut().take((sza + szb - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/number/ntt.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | a[i] = a[i] * ninv; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `a[i] *= ninv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/library/others/kitamasa.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn kitamasa(n: i64, a: Vec) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/others/rolling_hash.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(s: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 ~ pub fn new(s: &[char]) -> Self { [INFO] [stdout] 29 | let mut hash = vec![0; s.len() + 1]; [INFO] [stdout] ... [INFO] [stdout] 38 | RollingHash { [INFO] [stdout] 39 ~ s: s.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/others/matrix.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..n { [INFO] [stdout] 34 + for (i, ) in a.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in 0..self.h { [INFO] [stdout] 48 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | for j in 0..self.w { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 49 - for j in 0..self.w { [INFO] [stdout] 49 + for (j, ) in res.iter_mut().enumerate().take(self.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 63 - for i in 0..self.h { [INFO] [stdout] 63 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | for j in 0..b.w { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 64 - for j in 0..b.w { [INFO] [stdout] 64 + for (j, ) in res.iter_mut().enumerate().take(b.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/others/matrix.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | res[i][j] = res[i][j] + self.a[i][k] * b.a[k][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res[i][j] += self.a[i][k] * b.a[k][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/others/matrix.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return usize::MAX; [INFO] [stdout] 97 + usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `rank` is used as a loop counter [INFO] [stdout] --> src/library/others/matrix.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | for col in 0..self.w { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (rank, col) in (0..self.w).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `a` [INFO] [stdout] --> src/library/others/matrix_i64.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..n { [INFO] [stdout] 29 + for (i, ) in a.iter_mut().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 43 - for i in 0..self.h { [INFO] [stdout] 43 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | for j in 0..self.w { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for j in 0..self.w { [INFO] [stdout] 44 + for (j, ) in res.iter_mut().enumerate().take(self.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | for i in 0..self.h { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 58 - for i in 0..self.h { [INFO] [stdout] 58 + for (i, ) in res.iter_mut().enumerate().take(self.h) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `res` [INFO] [stdout] --> src/library/others/matrix_i64.rs:59:22 [INFO] [stdout] | [INFO] [stdout] 59 | for j in 0..b.w { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 59 - for j in 0..b.w { [INFO] [stdout] 59 + for (j, ) in res.iter_mut().enumerate().take(b.w) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/others/matrix_i64.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | res[i][j] = res[i][j] + self.a[i][k] * b.a[k][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res[i][j] += self.a[i][k] * b.a[k][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn build(&mut self, v: &Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn build(&mut self, v: &Vec) { [INFO] [stdout] 45 + pub fn build(&mut self, v: &[T]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `v` [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | for i in 0..self.n { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 47 - for i in 0..self.n { [INFO] [stdout] 47 + for (i, ) in v.iter().enumerate().take(self.n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - if r <= a || b <= l { [INFO] [stdout] 86 - return; [INFO] [stdout] 85 + if r <= a || b <= l { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | return self.e; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return self.e; [INFO] [stdout] 100 + self.e [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | return self.data[k]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self.data[k]; [INFO] [stdout] 102 + self.data[k] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return (self.f)(vl, vr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return (self.f)(vl, vr); [INFO] [stdout] 106 + (self.f)(vl, vr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:113:6 [INFO] [stdout] | [INFO] [stdout] 113 | ) -> LazySegmentTree< [INFO] [stdout] | ______^ [INFO] [stdout] 114 | | i64, [INFO] [stdout] 115 | | i64, [INFO] [stdout] 116 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 117 | | impl Fn(i64, i64, usize) -> i64, [INFO] [stdout] 118 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 119 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/library/structure/lazy_segment_tree.rs:125:6 [INFO] [stdout] | [INFO] [stdout] 125 | ) -> LazySegmentTree< [INFO] [stdout] | ______^ [INFO] [stdout] 126 | | i64, [INFO] [stdout] 127 | | i64, [INFO] [stdout] 128 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 129 | | impl Fn(i64, i64, usize) -> i64, [INFO] [stdout] 130 | | impl Fn(i64, i64) -> i64, [INFO] [stdout] 131 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/structure/segment_tree.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / for i in 0..n { [INFO] [stdout] 25 | | v_[n_ + i] = v[i]; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `v_[n_..(n + n_)].copy_from_slice(&v[..n]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/structure/segment_tree_ref.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / for i in 0..n { [INFO] [stdout] 26 | | v_[n_ + i] = v[i].clone(); [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `v_[n_..(n + n_)].clone_from_slice(&v[..n]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/trie.rs:25:30 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn add(&mut self, s: &Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - pub fn add(&mut self, s: &Vec) { [INFO] [stdout] 25 + pub fn add(&mut self, s: &[char]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `s` [INFO] [stdout] --> src/library/structure/trie.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..s.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 28 - for i in 0..s.len() { [INFO] [stdout] 28 + for in &s { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/library/structure/trie.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | !self.child[idx].is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.child[idx].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/structure/trie.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn calc_lcp_sum(&mut self, s: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn calc_lcp_sum(&mut self, s: &Vec) -> i64 { [INFO] [stdout] 48 + pub fn calc_lcp_sum(&mut self, s: &[char]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `s` [INFO] [stdout] --> src/library/structure/trie.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 53 | for i in 0..s.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 53 - for i in 0..s.len() { [INFO] [stdout] 53 + for in &s { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/library/structure/union_find.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | self.sz[y] = self.sz[x] + self.sz[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.sz[y] += self.sz[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / match ccw(&self.a, &self.b, p) { [INFO] [stdout] 38 | | CCW::CounterClockwise | CCW::Clockwise => false, [INFO] [stdout] 39 | | _ => true, [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 37 - match ccw(&self.a, &self.b, p) { [INFO] [stdout] 38 - CCW::CounterClockwise | CCW::Clockwise => false, [INFO] [stdout] 39 - _ => true, [INFO] [stdout] 40 - } [INFO] [stdout] 37 + !matches!(ccw(&self.a, &self.b, p), CCW::CounterClockwise | CCW::Clockwise) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | / match ccw(&self.a, &self.b, p) { [INFO] [stdout] 102 | | CCW::OnSegment => true, [INFO] [stdout] 103 | | _ => false, [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 101 - match ccw(&self.a, &self.b, p) { [INFO] [stdout] 102 - CCW::OnSegment => true, [INFO] [stdout] 103 - _ => false, [INFO] [stdout] 104 - } [INFO] [stdout] 101 + matches!(ccw(&self.a, &self.b, p), CCW::OnSegment) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCW` contains a capitalized acronym [INFO] [stdout] --> src/library/geometry/geometry_2d.rs:253:6 [INFO] [stdout] | [INFO] [stdout] 253 | enum CCW { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ccw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/aho_corasick.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | fn make_goto(&mut self, patterns: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - fn make_goto(&mut self, patterns: &Vec>) { [INFO] [stdout] 43 + fn make_goto(&mut self, patterns: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `patterns` [INFO] [stdout] --> src/library/string/aho_corasick.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..patterns.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..patterns.len() { [INFO] [stdout] 45 + for (i, ) in patterns.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/library/string/aho_corasick.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | while let None = self.goto(now, x) { [INFO] [stdout] | ----------^^^^-------------------- help: try: `while self.goto(now, x).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/aho_corasick.rs:111:36 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn query(&mut self, query: &Vec) -> std::collections::BTreeSet { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 111 - pub fn query(&mut self, query: &Vec) -> std::collections::BTreeSet { [INFO] [stdout] 111 + pub fn query(&mut self, query: &[usize]) -> std::collections::BTreeSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `query` [INFO] [stdout] --> src/library/string/aho_corasick.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 114 | for i in 0..query.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 114 - for i in 0..query.len() { [INFO] [stdout] 114 + for in &query { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/manacher.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn manacher(s: &Vec) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn manacher(s: &Vec) -> Vec [INFO] [stdout] 1 + pub fn manacher(s: &[T]) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/suffix_array.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn suffix_array(s: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn suffix_array(s: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn suffix_array(s: &[char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/library/string/suffix_array.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / for i in 0..=n { [INFO] [stdout] 49 | | rank[i] = tmp[i]; [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `rank[..(n + 1)].copy_from_slice(&tmp[..(n + 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/library/string/z_algorithm.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn z_algorithm(s: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn z_algorithm(s: &Vec) -> Vec { [INFO] [stdout] 1 + pub fn z_algorithm(s: &[char]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests/fps.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod fps; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests/graph.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod graph; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/tests/number/garner.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 17 - for i in 0..n { [INFO] [stdout] 17 + for in a.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `pv` [INFO] [stdout] --> src/tests/number/garner.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | for j in 0..2 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 19 - for j in 0..2 { [INFO] [stdout] 19 + for in pv.iter().take(2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/tests/number/ntt.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | let start = if idx >= n - 1 { idx - (n - 1) } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx.saturating_sub(n - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/tests/number/ntt.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | expected = expected + a[i] * b[idx - i]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected += a[i] * b[idx - i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `test_str` [INFO] [stdout] --> src/tests/others/rolling_hash.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 23 - for i in l..r { [INFO] [stdout] 23 + for in test_str.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `a` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for i in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for i in 0..n { [INFO] [stdout] 12 + for in a.iter_mut().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | fn update_min(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn update_min(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 66 + fn update_min(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in l..r { [INFO] [stdout] 67 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | fn update_max(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn update_max(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 72 + fn update_max(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 73 - for i in l..r { [INFO] [stdout] 73 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:78:43 [INFO] [stdout] | [INFO] [stdout] 78 | fn add_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn add_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 78 + fn add_val(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 79 - for i in l..r { [INFO] [stdout] 79 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:84:46 [INFO] [stdout] | [INFO] [stdout] 84 | fn update_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - fn update_val(l: usize, r: usize, x: i64, v: &mut Vec) { [INFO] [stdout] 84 + fn update_val(l: usize, r: usize, x: i64, v: &mut [i64]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:85:14 [INFO] [stdout] | [INFO] [stdout] 85 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 85 - for i in l..r { [INFO] [stdout] 85 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | fn query_max(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn query_max(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 90 + fn query_max(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:92:14 [INFO] [stdout] | [INFO] [stdout] 92 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 92 - for i in l..r { [INFO] [stdout] 92 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:98:37 [INFO] [stdout] | [INFO] [stdout] 98 | fn query_min(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - fn query_min(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 98 + fn query_min(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 100 - for i in l..r { [INFO] [stdout] 100 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | fn query_sum(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn query_sum(l: usize, r: usize, v: &Vec) -> i64 { [INFO] [stdout] 106 + fn query_sum(l: usize, r: usize, v: &[i64]) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/segment_tree_beats.rs:108:14 [INFO] [stdout] | [INFO] [stdout] 108 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 108 - for i in l..r { [INFO] [stdout] 108 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 25 - for i in l..r { [INFO] [stdout] 25 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 31 - for i in l..r { [INFO] [stdout] 31 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 62 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 62 - for i in l..r { [INFO] [stdout] 62 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 71 - for i in l..r { [INFO] [stdout] 71 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:101:22 [INFO] [stdout] | [INFO] [stdout] 101 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 101 - for i in l..r { [INFO] [stdout] 101 + for in v.iter_mut().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 105 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 105 - for i in l..r { [INFO] [stdout] 105 + for (i, ) in v.iter().enumerate().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/tests/structure/lazy_segment_tree.rs:111:22 [INFO] [stdout] | [INFO] [stdout] 111 | for i in l..r { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 111 - for i in l..r { [INFO] [stdout] 111 + for in v.iter().take(r).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | fn pr_vec(v: &Vec) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn pr_vec(v: &Vec) [INFO] [stdout] 42 + fn pr_vec(v: &[T]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests/number/fft.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | let expected = vec![2.0, 7.0, 16.0, 17.0, 12.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[2.0, 7.0, 16.0, 17.0, 12.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests/number/fft.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 21 | let expected = vec![2.0, 7.0, 16.0, 17.0, 12.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[2.0, 7.0, 16.0, 17.0, 12.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests/number/ntt.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | let a = vec![1, 2, 3]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `[1, 2, 3]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests/number/ntt.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | let b = vec![2, 3, 4]; [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `[2, 3, 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tests/number/ntt.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | let expected = vec![2, 7, 16, 17, 12]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[2, 7, 16, 17, 12]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.26s [INFO] running `Command { std: "docker" "inspect" "b14378f9c0be1ea50665c722af74577bff0b480dd8928049fca692c4c3baa952", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b14378f9c0be1ea50665c722af74577bff0b480dd8928049fca692c4c3baa952", kill_on_drop: false }` [INFO] [stdout] b14378f9c0be1ea50665c722af74577bff0b480dd8928049fca692c4c3baa952