[INFO] cloning repository https://github.com/kamalnayan10/redist [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kamalnayan10/redist" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkamalnayan10%2Fredist", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkamalnayan10%2Fredist'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16af874e8c60b7b0032fb6ebac653c6ad3cb47e3 [INFO] linting kamalnayan10/redist against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkamalnayan10%2Fredist" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kamalnayan10/redist [INFO] finished tweaking git repo https://github.com/kamalnayan10/redist [INFO] tweaked toml for git repo https://github.com/kamalnayan10/redist written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kamalnayan10/redist on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kamalnayan10/redist already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4e0e41eb7a492bf19351e05e6889da312c5faf284ae1fb75e466dcec9ea5299 [INFO] running `Command { std: "docker" "start" "-a" "e4e0e41eb7a492bf19351e05e6889da312c5faf284ae1fb75e466dcec9ea5299", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4e0e41eb7a492bf19351e05e6889da312c5faf284ae1fb75e466dcec9ea5299", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4e0e41eb7a492bf19351e05e6889da312c5faf284ae1fb75e466dcec9ea5299", kill_on_drop: false }` [INFO] [stdout] e4e0e41eb7a492bf19351e05e6889da312c5faf284ae1fb75e466dcec9ea5299 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4979cd35ede7c60889b9f808929c5dfd8a49aae869a7b3d29a9c4e67bf3cd6a [INFO] running `Command { std: "docker" "start" "-a" "f4979cd35ede7c60889b9f808929c5dfd8a49aae869a7b3d29a9c4e67bf3cd6a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling syn v2.0.69 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking redist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:58:50 [INFO] [stdout] | [INFO] [stdout] 58 | async fn handle_client(mut stream: TcpStream, db:Arc)>>>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if !time_arg.is_none() && time_arg.map(|c| c.eq_ignore_ascii_case("PX")).unwrap_or(false){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `time_arg.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if args.get(0).map(|s| s.eq_ignore_ascii_case("ECHO")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | else if args.get(0).map(|s| s.eq_ignore_ascii_case("SET")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | let reply = format!("+OK\r\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"+OK\r\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | else if args.get(0).map(|s| s.eq_ignore_ascii_case("GET")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:163:25 [INFO] [stdout] | [INFO] [stdout] 163 | let db: Arc)>>> = db.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:58:50 [INFO] [stdout] | [INFO] [stdout] 58 | async fn handle_client(mut stream: TcpStream, db:Arc)>>>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if !time_arg.is_none() && time_arg.map(|c| c.eq_ignore_ascii_case("PX")).unwrap_or(false){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `time_arg.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if args.get(0).map(|s| s.eq_ignore_ascii_case("ECHO")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | else if args.get(0).map(|s| s.eq_ignore_ascii_case("SET")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | let reply = format!("+OK\r\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"+OK\r\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | else if args.get(0).map(|s| s.eq_ignore_ascii_case("GET")).unwrap_or(false) && args.len() >= 2 { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:163:25 [INFO] [stdout] | [INFO] [stdout] 163 | let db: Arc)>>> = db.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.70s [INFO] running `Command { std: "docker" "inspect" "f4979cd35ede7c60889b9f808929c5dfd8a49aae869a7b3d29a9c4e67bf3cd6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4979cd35ede7c60889b9f808929c5dfd8a49aae869a7b3d29a9c4e67bf3cd6a", kill_on_drop: false }` [INFO] [stdout] f4979cd35ede7c60889b9f808929c5dfd8a49aae869a7b3d29a9c4e67bf3cd6a