[INFO] cloning repository https://github.com/kalleva/game_of_life_simple [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kalleva/game_of_life_simple" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkalleva%2Fgame_of_life_simple", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkalleva%2Fgame_of_life_simple'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f75611b198be4559e6f053c2349b2785a63aad44 [INFO] linting kalleva/game_of_life_simple against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkalleva%2Fgame_of_life_simple" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kalleva/game_of_life_simple [INFO] finished tweaking git repo https://github.com/kalleva/game_of_life_simple [INFO] tweaked toml for git repo https://github.com/kalleva/game_of_life_simple written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kalleva/game_of_life_simple on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kalleva/game_of_life_simple already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ctrlc v3.5.2 [INFO] [stderr] Downloaded dispatch2 v0.3.1 [INFO] [stderr] Downloaded nix v0.31.2 [INFO] [stderr] Downloaded objc2 v0.6.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd74ec6e700ddf247b25959bf85ca5c66a4d99f4e3da739825c7bc7059fc9ae3 [INFO] running `Command { std: "docker" "start" "-a" "cd74ec6e700ddf247b25959bf85ca5c66a4d99f4e3da739825c7bc7059fc9ae3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd74ec6e700ddf247b25959bf85ca5c66a4d99f4e3da739825c7bc7059fc9ae3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd74ec6e700ddf247b25959bf85ca5c66a4d99f4e3da739825c7bc7059fc9ae3", kill_on_drop: false }` [INFO] [stdout] cd74ec6e700ddf247b25959bf85ca5c66a4d99f4e3da739825c7bc7059fc9ae3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 560ed7f292aaffc9975c12af6267cc2101101b49a462393b2e34a89616f37608 [INFO] running `Command { std: "docker" "start" "-a" "560ed7f292aaffc9975c12af6267cc2101101b49a462393b2e34a89616f37608", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling nix v0.31.2 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking ctrlc v3.5.2 [INFO] [stderr] Checking game_of_life_simple v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use rand; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use rand; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | let next_cell = (current_cell [INFO] [stdout] | _____________________________^ [INFO] [stdout] 95 | | && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 | | || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = !(!current_cell && num_alive_neighbours != 3 || num_alive_neighbours != 3 && num_alive_neighbours != 2); [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = (num_alive_neighbours == 2 || num_alive_neighbours == 3) && (num_alive_neighbours == 3 || current_cell); [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = num_alive_neighbours == 3 || current_cell && num_alive_neighbours == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | let next_cell = (current_cell [INFO] [stdout] | _____________________________^ [INFO] [stdout] 95 | | && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 | | || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = !(!current_cell && num_alive_neighbours != 3 || num_alive_neighbours != 3 && num_alive_neighbours != 2); [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = (num_alive_neighbours == 2 || num_alive_neighbours == 3) && (num_alive_neighbours == 3 || current_cell); [INFO] [stdout] | [INFO] [stdout] 94 - let next_cell = (current_cell [INFO] [stdout] 95 - && (num_alive_neighbours == 3 || num_alive_neighbours == 2)) [INFO] [stdout] 96 - || (!current_cell && num_alive_neighbours == 3); [INFO] [stdout] 94 + let next_cell = num_alive_neighbours == 3 || current_cell && num_alive_neighbours == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.53s [INFO] running `Command { std: "docker" "inspect" "560ed7f292aaffc9975c12af6267cc2101101b49a462393b2e34a89616f37608", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "560ed7f292aaffc9975c12af6267cc2101101b49a462393b2e34a89616f37608", kill_on_drop: false }` [INFO] [stdout] 560ed7f292aaffc9975c12af6267cc2101101b49a462393b2e34a89616f37608