[INFO] cloning repository https://github.com/kaleidawave/build-trie [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/kaleidawave/build-trie" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaleidawave%2Fbuild-trie", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaleidawave%2Fbuild-trie'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8c8afefa60dc37f30598760102c8b4bce8af327a [INFO] linting kaleidawave/build-trie against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fkaleidawave%2Fbuild-trie" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/kaleidawave/build-trie [INFO] finished tweaking git repo https://github.com/kaleidawave/build-trie [INFO] tweaked toml for git repo https://github.com/kaleidawave/build-trie written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/kaleidawave/build-trie on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/kaleidawave/build-trie already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v1.0.62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8cbdef9125866894e5553ed1e2e7fa79035951c17dc235385ea96d14983d77a8 [INFO] running `Command { std: "docker" "start" "-a" "8cbdef9125866894e5553ed1e2e7fa79035951c17dc235385ea96d14983d77a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8cbdef9125866894e5553ed1e2e7fa79035951c17dc235385ea96d14983d77a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cbdef9125866894e5553ed1e2e7fa79035951c17dc235385ea96d14983d77a8", kill_on_drop: false }` [INFO] [stdout] 8cbdef9125866894e5553ed1e2e7fa79035951c17dc235385ea96d14983d77a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb14455d4e1fbd0bc1972e2c6fad5f430b5a4065b93f3573827c881802edfb5c [INFO] running `Command { std: "docker" "start" "-a" "eb14455d4e1fbd0bc1972e2c6fad5f430b5a4065b93f3573827c881802edfb5c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.62 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking quote v1.0.9 [INFO] [stderr] Checking build-trie v0.1.1 (/opt/rustwide/workdir/build-trie) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> build-trie/src/lib.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | while !(state_enum_name.is_some() [INFO] [stdout] | _______________^ [INFO] [stdout] 26 | | && result_enum_name.is_some() [INFO] [stdout] 27 | | && function_name.is_some() [INFO] [stdout] 28 | | && mappings.is_some() [INFO] [stdout] 29 | | && result_name.is_some()) [INFO] [stdout] 30 | | && !input.is_empty() [INFO] [stdout] | |________________________________^ help: try: `!(input.is_empty() || state_enum_name.is_some() && result_enum_name.is_some() && function_name.is_some() && mappings.is_some() && result_name.is_some())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> build-trie/src/lib.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | while !(state_enum_name.is_some() [INFO] [stdout] | _______________^ [INFO] [stdout] 26 | | && result_enum_name.is_some() [INFO] [stdout] 27 | | && function_name.is_some() [INFO] [stdout] 28 | | && mappings.is_some() [INFO] [stdout] 29 | | && result_name.is_some()) [INFO] [stdout] 30 | | && !input.is_empty() [INFO] [stdout] | |________________________________^ help: try: `!(input.is_empty() || state_enum_name.is_some() && result_enum_name.is_some() && function_name.is_some() && mappings.is_some() && result_name.is_some())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&chr).is_none()` [INFO] [stdout] --> build-trie/src/lib.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | if node.0.get(&chr).is_none() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!node.0.contains_key(&chr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&chr).is_none()` [INFO] [stdout] --> build-trie/src/lib.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | if node.0.get(&chr).is_none() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!node.0.contains_key(&chr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> build-trie/src/lib.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | while !(state_enum_name.is_some() [INFO] [stdout] | _______________^ [INFO] [stdout] 26 | | && result_enum_name.is_some() [INFO] [stdout] 27 | | && function_name.is_some() [INFO] [stdout] 28 | | && mappings.is_some() [INFO] [stdout] 29 | | && result_name.is_some()) [INFO] [stdout] 30 | | && !input.is_empty() [INFO] [stdout] | |________________________________^ help: try: `!(input.is_empty() || state_enum_name.is_some() && result_enum_name.is_some() && function_name.is_some() && mappings.is_some() && result_name.is_some())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&chr).is_none()` [INFO] [stdout] --> build-trie/src/lib.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 124 | if node.0.get(&chr).is_none() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!node.0.contains_key(&chr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking example v0.1.0 (/opt/rustwide/workdir/example) [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> example/src/main.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | if !matches!(chr, 'a'..='z' | 'A'..='Z') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if !matches!(chr, 'a'..='z' | 'A'..='Z') { [INFO] [stdout] 40 + if !chr.is_ascii_alphabetic() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> example/src/main.rs:47:54 [INFO] [stdout] | [INFO] [stdout] 47 | match get_symbol_from_state_and_char(&symbol_state, &chr) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> example/src/main.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | if !matches!(chr, 'a'..='z' | 'A'..='Z') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if !matches!(chr, 'a'..='z' | 'A'..='Z') { [INFO] [stdout] 40 + if !chr.is_ascii_alphabetic() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> example/src/main.rs:47:54 [INFO] [stdout] | [INFO] [stdout] 47 | match get_symbol_from_state_and_char(&symbol_state, &chr) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.01s [INFO] running `Command { std: "docker" "inspect" "eb14455d4e1fbd0bc1972e2c6fad5f430b5a4065b93f3573827c881802edfb5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb14455d4e1fbd0bc1972e2c6fad5f430b5a4065b93f3573827c881802edfb5c", kill_on_drop: false }` [INFO] [stdout] eb14455d4e1fbd0bc1972e2c6fad5f430b5a4065b93f3573827c881802edfb5c