[INFO] cloning repository https://github.com/k0zihyp3r/weatherapp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/k0zihyp3r/weatherapp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fk0zihyp3r%2Fweatherapp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fk0zihyp3r%2Fweatherapp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 27b1e502069f00e75cb3afbf179fbe3d6f3594e9 [INFO] linting k0zihyp3r/weatherapp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fk0zihyp3r%2Fweatherapp" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/k0zihyp3r/weatherapp [INFO] finished tweaking git repo https://github.com/k0zihyp3r/weatherapp [INFO] tweaked toml for git repo https://github.com/k0zihyp3r/weatherapp written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/k0zihyp3r/weatherapp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/k0zihyp3r/weatherapp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded iced_futures v0.4.1 [INFO] [stderr] Downloaded iced_core v0.5.0 [INFO] [stderr] Downloaded iced_winit v0.4.0 [INFO] [stderr] Downloaded iced_style v0.4.0 [INFO] [stderr] Downloaded window_clipboard v0.2.4 [INFO] [stderr] Downloaded iced_graphics v0.3.1 [INFO] [stderr] Downloaded mutate_once v0.1.2 [INFO] [stderr] Downloaded inplace_it v0.3.6 [INFO] [stderr] Downloaded wgpu-types v0.12.0 [INFO] [stderr] Downloaded glyph_brush_layout v0.2.4 [INFO] [stderr] Downloaded iced_wgpu v0.5.1 [INFO] [stderr] Downloaded kamadak-exif v0.5.5 [INFO] [stderr] Downloaded glyph_brush_draw_cache v0.1.6 [INFO] [stderr] Downloaded iced_native v0.5.1 [INFO] [stderr] Downloaded glyph_brush v0.7.12 [INFO] [stderr] Downloaded wgpu_glyph v0.16.0 [INFO] [stderr] Downloaded glam v0.10.2 [INFO] [stderr] Downloaded wgpu v0.12.0 [INFO] [stderr] Downloaded syn v2.0.109 [INFO] [stderr] Downloaded wgpu-core v0.12.2 [INFO] [stderr] Downloaded wgpu-hal v0.12.5 [INFO] [stderr] Downloaded iced v0.4.2 [INFO] [stderr] Downloaded ash v0.34.0+1.2.203 [INFO] [stderr] Downloaded naga v0.8.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1624ea24f90925a9ebe0ec7c02fb9af1e55886e05ed7509ef0f5210c19d8bf5a [INFO] running `Command { std: "docker" "start" "-a" "1624ea24f90925a9ebe0ec7c02fb9af1e55886e05ed7509ef0f5210c19d8bf5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1624ea24f90925a9ebe0ec7c02fb9af1e55886e05ed7509ef0f5210c19d8bf5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1624ea24f90925a9ebe0ec7c02fb9af1e55886e05ed7509ef0f5210c19d8bf5a", kill_on_drop: false }` [INFO] [stdout] 1624ea24f90925a9ebe0ec7c02fb9af1e55886e05ed7509ef0f5210c19d8bf5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec2f561835982ea2c5d7126b0b109fcc6fb9d06013dd691f54a30c975bac85bf [INFO] running `Command { std: "docker" "start" "-a" "ec2f561835982ea2c5d7126b0b109fcc6fb9d06013dd691f54a30c975bac85bf", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling syn v2.0.109 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling ash v0.34.0+1.2.203 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Compiling khronos-egl v4.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking gpu-alloc-types v0.2.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Compiling wgpu-core v0.12.2 [INFO] [stderr] Checking gpu-alloc v0.5.4 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking spirv v0.2.0+1.5.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling glam v0.10.2 [INFO] [stderr] Checking iced_core v0.5.0 [INFO] [stderr] Checking wgpu-types v0.12.0 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking inplace_it v0.3.6 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking renderdoc-sys v0.7.1 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking iced_style v0.4.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking nix v0.22.3 [INFO] [stderr] Compiling smithay-client-toolkit v0.15.4 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking copyless v0.1.5 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking memmap2 v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling winit v0.26.1 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking glyph_brush_draw_cache v0.1.6 [INFO] [stderr] Checking glyph_brush_layout v0.2.4 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking mutate_once v0.1.2 [INFO] [stderr] Checking svg_fmt v0.4.5 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking glyph_brush v0.7.12 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking calloop v0.9.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking naga v0.8.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking clipboard_x11 v0.4.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking iced_futures v0.4.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking iced_native v0.5.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking wgpu-hal v0.12.5 [INFO] [stderr] Checking iced_graphics v0.3.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking wgpu v0.12.0 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wgpu_glyph v0.16.0 [INFO] [stderr] Checking iced_wgpu v0.5.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking clipboard_wayland v0.2.2 [INFO] [stderr] Checking window_clipboard v0.2.4 [INFO] [stderr] Checking iced_winit v0.4.0 [INFO] [stderr] Checking iced v0.4.2 [INFO] [stderr] Checking weatherapp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | / for weather_opt in &self.random_cities_weather { [INFO] [stdout] 176 | | if let Some(weather) = weather_opt { [INFO] [stdout] 177 | | let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 178 | | random_cities_row = random_cities_row.push( [INFO] [stdout] ... | [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | / if let Some(weather) = weather_opt { [INFO] [stdout] 177 | | let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 178 | | random_cities_row = random_cities_row.push( [INFO] [stdout] 179 | | Column::new() [INFO] [stdout] ... | [INFO] [stdout] 184 | | ); [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 ~ for weather in self.random_cities_weather.iter().flatten() { [INFO] [stdout] 176 + let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 177 + random_cities_row = random_cities_row.push( [INFO] [stdout] 178 + Column::new() [INFO] [stdout] 179 + .align_items(Alignment::Center) [INFO] [stdout] 180 + .push(Text::new(format!("{}", weather.name)).color(iced::Color::WHITE)) [INFO] [stdout] 181 ~ .push(Text::new(format!("{:.1}°C", weather.main.temp)).color(iced::Color::WHITE)) [INFO] [stdout] 182 + .push(Image::new(icon_path).width(iced::Length::Units(50))), [INFO] [stdout] 183 + ); [INFO] [stdout] 184 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 181 | .push(Text::new(format!("{}", weather.name)).color(iced::Color::WHITE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `weather.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | fn view(&mut self) -> Element { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 129 | fn view(&mut self) -> Element<'_, Self::Message> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | / for weather_opt in &self.random_cities_weather { [INFO] [stdout] 176 | | if let Some(weather) = weather_opt { [INFO] [stdout] 177 | | let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 178 | | random_cities_row = random_cities_row.push( [INFO] [stdout] ... | [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | / if let Some(weather) = weather_opt { [INFO] [stdout] 177 | | let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 178 | | random_cities_row = random_cities_row.push( [INFO] [stdout] 179 | | Column::new() [INFO] [stdout] ... | [INFO] [stdout] 184 | | ); [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 ~ for weather in self.random_cities_weather.iter().flatten() { [INFO] [stdout] 176 + let icon_path = format!("assets/images/{}_t.png", weather.weather[0].icon); [INFO] [stdout] 177 + random_cities_row = random_cities_row.push( [INFO] [stdout] 178 + Column::new() [INFO] [stdout] 179 + .align_items(Alignment::Center) [INFO] [stdout] 180 + .push(Text::new(format!("{}", weather.name)).color(iced::Color::WHITE)) [INFO] [stdout] 181 ~ .push(Text::new(format!("{:.1}°C", weather.main.temp)).color(iced::Color::WHITE)) [INFO] [stdout] 182 + .push(Image::new(icon_path).width(iced::Length::Units(50))), [INFO] [stdout] 183 + ); [INFO] [stdout] 184 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 181 | .push(Text::new(format!("{}", weather.name)).color(iced::Color::WHITE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `weather.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/main.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | fn view(&mut self) -> Element { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 129 | fn view(&mut self) -> Element<'_, Self::Message> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `Command { std: "docker" "inspect" "ec2f561835982ea2c5d7126b0b109fcc6fb9d06013dd691f54a30c975bac85bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec2f561835982ea2c5d7126b0b109fcc6fb9d06013dd691f54a30c975bac85bf", kill_on_drop: false }` [INFO] [stdout] ec2f561835982ea2c5d7126b0b109fcc6fb9d06013dd691f54a30c975bac85bf