[INFO] cloning repository https://github.com/jtescher/aoc-2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jtescher/aoc-2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtescher%2Faoc-2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtescher%2Faoc-2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5665239abdf43a9413b16383645d496bfbabe007 [INFO] linting jtescher/aoc-2020 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtescher%2Faoc-2020" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jtescher/aoc-2020 [INFO] finished tweaking git repo https://github.com/jtescher/aoc-2020 [INFO] tweaked toml for git repo https://github.com/jtescher/aoc-2020 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jtescher/aoc-2020 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jtescher/aoc-2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 794f090be25142a7136e8612ea2dcdd6b34dc83a29e476c05d27f46654b521e9 [INFO] running `Command { std: "docker" "start" "-a" "794f090be25142a7136e8612ea2dcdd6b34dc83a29e476c05d27f46654b521e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "794f090be25142a7136e8612ea2dcdd6b34dc83a29e476c05d27f46654b521e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "794f090be25142a7136e8612ea2dcdd6b34dc83a29e476c05d27f46654b521e9", kill_on_drop: false }` [INFO] [stdout] 794f090be25142a7136e8612ea2dcdd6b34dc83a29e476c05d27f46654b521e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69ffaeaae5a5d870d9d13e0ea027bd6bf89a4f9c8e29738274a74081101c3a9b [INFO] running `Command { std: "docker" "start" "-a" "69ffaeaae5a5d870d9d13e0ea027bd6bf89a4f9c8e29738274a74081101c3a9b", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.34 [INFO] [stderr] Checking aoc-2020 v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_1.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | const INPUT: &'static str = include_str!("../data/day_1.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_10.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | const INPUT: &'static str = include_str!("../data/day_10.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_2.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | const INPUT: &'static str = include_str!("../data/day_2.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_3.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | const INPUT: &'static str = include_str!("../data/day_3.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_4.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | const INPUT: &'static str = include_str!("../data/day_4.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_5.rs:34:19 [INFO] [stdout] | [INFO] [stdout] 34 | const INPUT: &'static str = include_str!("../data/day_5.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_6.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | const INPUT: &'static str = include_str!("../data/day_6.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_7.rs:96:19 [INFO] [stdout] | [INFO] [stdout] 96 | const INPUT: &'static str = include_str!("../data/day_7.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_8.rs:77:19 [INFO] [stdout] | [INFO] [stdout] 77 | const INPUT: &'static str = include_str!("../data/day_8.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day_9.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | const INPUT: &'static str = include_str!("../data/day_9.txt"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day_11.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | fn adjacent_occupied_count(grid: &Vec>, row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 138 - fn adjacent_occupied_count(grid: &Vec>, row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] 138 + fn adjacent_occupied_count(grid: &[Vec], row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/day_11.rs:143:37 [INFO] [stdout] | [INFO] [stdout] 143 | row_idx.checked_sub(dx.abs() as usize).unwrap_or(usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `dx.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/day_11.rs:148:37 [INFO] [stdout] | [INFO] [stdout] 148 | col_idx.checked_sub(dy.abs() as usize).unwrap_or(usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `dy.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_13.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | (all_match && true, matching_id_product * id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `all_match` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | val = val | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | val = val & !(1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val &= !(1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | addr = addr | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/day_14.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | let mut new_addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | new_addr = new_addr | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_addr |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | new_addr = new_addr & !(1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_addr &= !(1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/day_4.rs:51:58 [INFO] [stdout] | [INFO] [stdout] 51 | ... "hcl" if value.len() == 7 && value.chars().nth(0) == Some('#') => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `value.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/day_5.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | seen[id as usize - min] = true; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day_7.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / dag.get(node).map_or(false, |edges| { [INFO] [stdout] 57 | | edges.iter().any(|edge| { [INFO] [stdout] 58 | | if edge.1 == target { [INFO] [stdout] 59 | | true [INFO] [stdout] ... | [INFO] [stdout] 65 | | }) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 56 - dag.get(node).map_or(false, |edges| { [INFO] [stdout] 56 + dag.get(node).is_some_and(|edges| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_8.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(0); [INFO] [stdout] 29 + Err(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day_11.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | fn adjacent_occupied_count(grid: &Vec>, row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 138 - fn adjacent_occupied_count(grid: &Vec>, row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] 138 + fn adjacent_occupied_count(grid: &[Vec], row_idx: usize, col_idx: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/day_11.rs:143:37 [INFO] [stdout] | [INFO] [stdout] 143 | row_idx.checked_sub(dx.abs() as usize).unwrap_or(usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `dx.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/day_11.rs:148:37 [INFO] [stdout] | [INFO] [stdout] 148 | col_idx.checked_sub(dy.abs() as usize).unwrap_or(usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `dy.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day_13.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | (all_match && true, matching_id_product * id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `all_match` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | val = val | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | val = val & !(1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val &= !(1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | addr = addr | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/day_14.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | let mut new_addr = addr.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | new_addr = new_addr | (1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_addr |= (1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day_14.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | new_addr = new_addr & !(1 << idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_addr &= !(1 << idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/day_4.rs:51:58 [INFO] [stdout] | [INFO] [stdout] 51 | ... "hcl" if value.len() == 7 && value.chars().nth(0) == Some('#') => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `value.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/day_5.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | seen[id as usize - min] = true; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day_7.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / dag.get(node).map_or(false, |edges| { [INFO] [stdout] 57 | | edges.iter().any(|edge| { [INFO] [stdout] 58 | | if edge.1 == target { [INFO] [stdout] 59 | | true [INFO] [stdout] ... | [INFO] [stdout] 65 | | }) [INFO] [stdout] 66 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 56 - dag.get(node).map_or(false, |edges| { [INFO] [stdout] 56 + dag.get(node).is_some_and(|edges| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day_8.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(0); [INFO] [stdout] 29 + Err(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `Command { std: "docker" "inspect" "69ffaeaae5a5d870d9d13e0ea027bd6bf89a4f9c8e29738274a74081101c3a9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69ffaeaae5a5d870d9d13e0ea027bd6bf89a4f9c8e29738274a74081101c3a9b", kill_on_drop: false }` [INFO] [stdout] 69ffaeaae5a5d870d9d13e0ea027bd6bf89a4f9c8e29738274a74081101c3a9b