[INFO] cloning repository https://github.com/jtcourtemarche/needleman-wunsch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jtcourtemarche/needleman-wunsch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcourtemarche%2Fneedleman-wunsch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcourtemarche%2Fneedleman-wunsch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 00b7719579818e30ecbe7d53f275048879f3a58f [INFO] linting jtcourtemarche/needleman-wunsch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcourtemarche%2Fneedleman-wunsch" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jtcourtemarche/needleman-wunsch [INFO] finished tweaking git repo https://github.com/jtcourtemarche/needleman-wunsch [INFO] tweaked toml for git repo https://github.com/jtcourtemarche/needleman-wunsch written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jtcourtemarche/needleman-wunsch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jtcourtemarche/needleman-wunsch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75d8e783f5326fb85c5e23a8b68646dec0d104f542bc323cf5d0e9370028db31 [INFO] running `Command { std: "docker" "start" "-a" "75d8e783f5326fb85c5e23a8b68646dec0d104f542bc323cf5d0e9370028db31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75d8e783f5326fb85c5e23a8b68646dec0d104f542bc323cf5d0e9370028db31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75d8e783f5326fb85c5e23a8b68646dec0d104f542bc323cf5d0e9370028db31", kill_on_drop: false }` [INFO] [stdout] 75d8e783f5326fb85c5e23a8b68646dec0d104f542bc323cf5d0e9370028db31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37d02eb867b24d217b80c7e1dfcaacd40e021435f7b4231cd4594b134f1a97cb [INFO] running `Command { std: "docker" "start" "-a" "37d02eb867b24d217b80c7e1dfcaacd40e021435f7b4231cd4594b134f1a97cb", kill_on_drop: false }` [INFO] [stderr] Checking edit-distance v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | !(a == b) as i32 [INFO] [stdout] | ^^^^^^^^^ help: try: `(a != b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:143:54 [INFO] [stdout] | [INFO] [stdout] 141 | if x.is_some() && y.is_some() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 142 | if i < self.N { [INFO] [stdout] 143 | result.push_str(&format!("{} - 2\n", x.unwrap())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `y` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:146:54 [INFO] [stdout] | [INFO] [stdout] 141 | if x.is_some() && y.is_some() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 146 | result.push_str(&format!("- {} 2\n", y.unwrap())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | matrix.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `matrix.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | M: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | !(a == b) as i32 [INFO] [stdout] | ^^^^^^^^^ help: try: `(a != b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `x` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:143:54 [INFO] [stdout] | [INFO] [stdout] 141 | if x.is_some() && y.is_some() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 142 | if i < self.N { [INFO] [stdout] 143 | result.push_str(&format!("{} - 2\n", x.unwrap())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `y` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:146:54 [INFO] [stdout] | [INFO] [stdout] 141 | if x.is_some() && y.is_some() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 146 | result.push_str(&format!("- {} 2\n", y.unwrap())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | matrix.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `matrix.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `N` should have a snake case name [INFO] [stdout] --> src/main.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | M: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s [INFO] running `Command { std: "docker" "inspect" "37d02eb867b24d217b80c7e1dfcaacd40e021435f7b4231cd4594b134f1a97cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37d02eb867b24d217b80c7e1dfcaacd40e021435f7b4231cd4594b134f1a97cb", kill_on_drop: false }` [INFO] [stdout] 37d02eb867b24d217b80c7e1dfcaacd40e021435f7b4231cd4594b134f1a97cb