[INFO] cloning repository https://github.com/jtcoolen/ecm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jtcoolen/ecm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcoolen%2Fecm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcoolen%2Fecm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a53b8a1509a0b73b5e9e69c8e26e79d83816dc7 [INFO] linting jtcoolen/ecm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjtcoolen%2Fecm" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jtcoolen/ecm [INFO] finished tweaking git repo https://github.com/jtcoolen/ecm [INFO] tweaked toml for git repo https://github.com/jtcoolen/ecm written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jtcoolen/ecm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jtcoolen/ecm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simple_logger v1.11.0 [INFO] [stderr] Downloaded hwloc v0.5.0 [INFO] [stderr] Downloaded az v1.1.0 [INFO] [stderr] Downloaded itertools v0.10.0 [INFO] [stderr] Downloaded rug v1.12.0 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e82dab3a6710bc3b3520213b6fe1937464c5ec0fa23d1fe484e7988f6989a1b [INFO] running `Command { std: "docker" "start" "-a" "2e82dab3a6710bc3b3520213b6fe1937464c5ec0fa23d1fe484e7988f6989a1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e82dab3a6710bc3b3520213b6fe1937464c5ec0fa23d1fe484e7988f6989a1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e82dab3a6710bc3b3520213b6fe1937464c5ec0fa23d1fe484e7988f6989a1b", kill_on_drop: false }` [INFO] [stdout] 2e82dab3a6710bc3b3520213b6fe1937464c5ec0fa23d1fe484e7988f6989a1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe245e2621093e3ced7170af12c8700dd2ff888a58d481231cfdd44ef37b3698 [INFO] running `Command { std: "docker" "start" "-a" "fe245e2621093e3ced7170af12c8700dd2ff888a58d481231cfdd44ef37b3698", kill_on_drop: false }` [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling gmp-mpfr-sys v1.4.3 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling hwloc v0.5.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling rug v1.12.0 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking errno v0.2.7 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking az v1.1.0 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking num-iter v0.1.42 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Compiling cast v0.2.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking rayon-core v1.9.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking rayon v1.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking serde_json v1.0.64 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking criterion v0.3.4 [INFO] [stderr] Checking ecm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/lib.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Returns a nontrivial factor of n upon success. [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | /// Notes: [INFO] [stdout] 15 | | /// The bound b1 (resp. b2) for stage 1 (resp. stage 2) must be even, [INFO] [stdout] ... | [INFO] [stdout] 18 | | /// The boolean found_factor is shared by all threads and set to false initially. [INFO] [stdout] 19 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn inversionless_ecm( [INFO] [stdout] | ------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the documentation should include the empty lines include them in the comment [INFO] [stdout] | [INFO] [stdout] 13 + /// [INFO] [stdout] 14 | /// Notes: [INFO] [stdout] 15 | /// The bound b1 (resp. b2) for stage 1 (resp. stage 2) must be even, [INFO] [stdout] 16 | /// and is usually taken s.t. b2 ~ 100*b1. [INFO] [stdout] 17 + /// [INFO] [stdout] 18 | /// The boolean found_factor is shared by all threads and set to false initially. [INFO] [stdout] 19 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/lib.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// Returns a nontrivial factor of n upon success. [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | /// Notes: [INFO] [stdout] 15 | | /// The bound b1 (resp. b2) for stage 1 (resp. stage 2) must be even, [INFO] [stdout] ... | [INFO] [stdout] 18 | | /// The boolean found_factor is shared by all threads and set to false initially. [INFO] [stdout] 19 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn inversionless_ecm( [INFO] [stdout] | ------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the documentation should include the empty lines include them in the comment [INFO] [stdout] | [INFO] [stdout] 13 + /// [INFO] [stdout] 14 | /// Notes: [INFO] [stdout] 15 | /// The bound b1 (resp. b2) for stage 1 (resp. stage 2) must be even, [INFO] [stdout] 16 | /// and is usually taken s.t. b2 ~ 100*b1. [INFO] [stdout] 17 + /// [INFO] [stdout] 18 | /// The boolean found_factor is shared by all threads and set to false initially. [INFO] [stdout] 19 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/arith/misc.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn eratosthenes(primes: &mut Vec, limit: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn eratosthenes(primes: &mut Vec, limit: usize) { [INFO] [stdout] 5 + pub fn eratosthenes(primes: &mut [bool], limit: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | r = r | div.1.to_u64().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= div.1.to_u64().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | acc = acc * &a_copy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &a_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | acc = acc * &a_copy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &a_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/modular_arithmetic.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | let rem = div_mod(&a, &modulo).1; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/modular_arithmetic.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | let rem = div_mod(&a, &modulo).1; [INFO] [stdout] | ^^^^^^^ help: change this to: `modulo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/arith/modular_arithmetic.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | a.invert_ref(modulo).and_then(|b| Some(Integer::from(b))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.invert_ref(modulo).map(|b| Integer::from(b))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/arith/montgomery_point.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | false; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/arith/misc.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn eratosthenes(primes: &mut Vec, limit: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn eratosthenes(primes: &mut Vec, limit: usize) { [INFO] [stdout] 5 + pub fn eratosthenes(primes: &mut [bool], limit: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/arith/montgomery_point.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | &Integer::from(&diff * Integer::from(&v + &self.a24 * &diff)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `(&diff * Integer::from(&v + &self.a24 * &diff))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `b` is only used to index `bv` [INFO] [stdout] --> src/arith/montgomery_point.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | for b in 1..bv.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 104 - for b in 1..bv.len() { [INFO] [stdout] 104 + for in bv.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/montgomery_point.rs:106:32 [INFO] [stdout] | [INFO] [stdout] 106 | q = p.addh(&q, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/montgomery_point.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | p = q.addh(&p, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn inversionless_ecm( [INFO] [stdout] 23 | | n: &Integer, [INFO] [stdout] 24 | | max_curves: &Option, [INFO] [stdout] 25 | | primes: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 30 | | found_factor: &AtomicBool, [INFO] [stdout] 31 | | ) -> Option { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | primes: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - primes: &Vec, [INFO] [stdout] 25 + primes: &[bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | r = r | div.1.to_u64().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= div.1.to_u64().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | acc = acc * &a_copy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &a_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arith/misc.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | acc = acc * &a_copy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &a_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/lib.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | &Integer::from((pow_mod(&diff, 3, n) * Integer::from(3 * &u + &v) * &inv) - 2), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `((pow_mod(&diff, 3, n) * Integer::from(3 * &u + &v) * &inv) - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/modular_arithmetic.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | let rem = div_mod(&a, &modulo).1; [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pow_mod(&v, 3, &n), [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/modular_arithmetic.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | let rem = div_mod(&a, &modulo).1; [INFO] [stdout] | ^^^^^^^ help: change this to: `modulo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/arith/modular_arithmetic.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | a.invert_ref(modulo).and_then(|b| Some(Integer::from(b))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.invert_ref(modulo).map(|b| Integer::from(b))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/lib.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | ... let f = Integer::from( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 162 | | ... Integer::from(&s.x - &points[d].x) [INFO] [stdout] 163 | | ... * Integer::from(&s.z + &points[d].z), [INFO] [stdout] 164 | | ... ) - &alpha [INFO] [stdout] | |_______________________^ help: consider removing `Integer::from()`: `(Integer::from(&s.x - &points[d].x) * Integer::from(&s.z + &points[d].z))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | g = g.gcd(&n); [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | &n, [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | &max_curves, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `max_curves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | &sigma, [INFO] [stdout] | ^^^^^^ help: change this to: `sigma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/arith/montgomery_point.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | false; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/arith/montgomery_point.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | &Integer::from(&diff * Integer::from(&v + &self.a24 * &diff)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `(&diff * Integer::from(&v + &self.a24 * &diff))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `b` is only used to index `bv` [INFO] [stdout] --> src/arith/montgomery_point.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | for b in 1..bv.len() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 104 - for b in 1..bv.len() { [INFO] [stdout] 104 + for in bv.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/montgomery_point.rs:106:32 [INFO] [stdout] | [INFO] [stdout] 106 | q = p.addh(&q, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/arith/montgomery_point.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | p = q.addh(&p, &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn inversionless_ecm( [INFO] [stdout] 23 | | n: &Integer, [INFO] [stdout] 24 | | max_curves: &Option, [INFO] [stdout] 25 | | primes: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 30 | | found_factor: &AtomicBool, [INFO] [stdout] 31 | | ) -> Option { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | primes: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - primes: &Vec, [INFO] [stdout] 25 + primes: &[bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/lib.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | &Integer::from((pow_mod(&diff, 3, n) * Integer::from(3 * &u + &v) * &inv) - 2), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Integer::from()`: `((pow_mod(&diff, 3, n) * Integer::from(3 * &u + &v) * &inv) - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | pow_mod(&v, 3, &n), [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `rug::Integer` [INFO] [stdout] --> src/lib.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | ... let f = Integer::from( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 162 | | ... Integer::from(&s.x - &points[d].x) [INFO] [stdout] 163 | | ... * Integer::from(&s.z + &points[d].z), [INFO] [stdout] 164 | | ... ) - &alpha [INFO] [stdout] | |_______________________^ help: consider removing `Integer::from()`: `(Integer::from(&s.x - &points[d].x) * Integer::from(&s.z + &points[d].z))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | g = g.gcd(&n); [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | &n, [INFO] [stdout] | ^^ help: change this to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | &max_curves, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `max_curves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | &sigma, [INFO] [stdout] | ^^^^^^ help: change this to: `sigma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | / match ecm_singlethreaded(&fermat, &None, b1, b2, &None) { [INFO] [stdout] 273 | | Some(factor) => { [INFO] [stdout] 274 | | print!("got {}\n", factor); [INFO] [stdout] 275 | | assert_eq!(div_mod(&fermat, &factor).1, Integer::from(0)) [INFO] [stdout] 276 | | } [INFO] [stdout] 277 | | None => (), [INFO] [stdout] 278 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 ~ if let Some(factor) = ecm_singlethreaded(&fermat, &None, b1, b2, &None) { [INFO] [stdout] 273 + print!("got {}\n", factor); [INFO] [stdout] 274 + assert_eq!(div_mod(&fermat, &factor).1, Integer::from(0)) [INFO] [stdout] 275 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 274 | print!("got {}\n", factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 274 - print!("got {}\n", factor); [INFO] [stdout] 274 + println!("got {}", factor); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use simple_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/main.rs:112:61 [INFO] [stdout] | [INFO] [stdout] 112 | if matches.is_present("single_threaded") || !sigma.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `sigma.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use simple_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 114 | Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 114 - Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] 114 + Some(f) => println!("Found factor {}.", f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | None => print!("No factor found.\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 115 - None => print!("No factor found.\n"), [INFO] [stdout] 115 + None => println!("No factor found."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:129:36 [INFO] [stdout] | [INFO] [stdout] 129 | Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 129 - Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] 129 + Some(f) => println!("Found factor {}.", f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | None => print!("No factor found.\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 130 - None => print!("No factor found.\n"), [INFO] [stdout] 130 + None => println!("No factor found."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/main.rs:112:61 [INFO] [stdout] | [INFO] [stdout] 112 | if matches.is_present("single_threaded") || !sigma.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `sigma.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 114 | Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 114 - Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] 114 + Some(f) => println!("Found factor {}.", f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | None => print!("No factor found.\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 115 - None => print!("No factor found.\n"), [INFO] [stdout] 115 + None => println!("No factor found."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:129:36 [INFO] [stdout] | [INFO] [stdout] 129 | Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 129 - Some(f) => print!("Found factor {}.\n", f), [INFO] [stdout] 129 + Some(f) => println!("Found factor {}.", f), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/bin/main.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | None => print!("No factor found.\n"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 130 - None => print!("No factor found.\n"), [INFO] [stdout] 130 + None => println!("No factor found."), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 07s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0, criterion v0.3.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 8` [INFO] running `Command { std: "docker" "inspect" "fe245e2621093e3ced7170af12c8700dd2ff888a58d481231cfdd44ef37b3698", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe245e2621093e3ced7170af12c8700dd2ff888a58d481231cfdd44ef37b3698", kill_on_drop: false }` [INFO] [stdout] fe245e2621093e3ced7170af12c8700dd2ff888a58d481231cfdd44ef37b3698