[INFO] cloning repository https://github.com/jsvcycling/advent-of-code-2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jsvcycling/advent-of-code-2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsvcycling%2Fadvent-of-code-2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsvcycling%2Fadvent-of-code-2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 25c5a2fd89e75c883e6d9a73322ec081bc8edc96 [INFO] linting jsvcycling/advent-of-code-2020 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsvcycling%2Fadvent-of-code-2020" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jsvcycling/advent-of-code-2020 [INFO] finished tweaking git repo https://github.com/jsvcycling/advent-of-code-2020 [INFO] tweaked toml for git repo https://github.com/jsvcycling/advent-of-code-2020 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jsvcycling/advent-of-code-2020 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jsvcycling/advent-of-code-2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41ac4f63bc34c9216cf47dc3bd6fd555f46adb72223b6ba819d77b13f00dafce [INFO] running `Command { std: "docker" "start" "-a" "41ac4f63bc34c9216cf47dc3bd6fd555f46adb72223b6ba819d77b13f00dafce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41ac4f63bc34c9216cf47dc3bd6fd555f46adb72223b6ba819d77b13f00dafce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41ac4f63bc34c9216cf47dc3bd6fd555f46adb72223b6ba819d77b13f00dafce", kill_on_drop: false }` [INFO] [stdout] 41ac4f63bc34c9216cf47dc3bd6fd555f46adb72223b6ba819d77b13f00dafce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4b25ee343d4bd138af9d6239f2feb7bde32e99936320a65776021ffd0074aad [INFO] running `Command { std: "docker" "start" "-a" "e4b25ee343d4bd138af9d6239f2feb7bde32e99936320a65776021ffd0074aad", kill_on_drop: false }` [INFO] [stderr] Checking advent-of-code-2020 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | v >= 1020 && v <= 2002 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1020..=2002).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | v >= 2010 && v <= 2020 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2010..=2020).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | v >= 2020 && v <= 2030 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2020..=2030).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | return v >= 59 && v <= 76; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `(59..=76).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | return v >= 150 && v <= 193; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(150..=193).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day_11.rs:39:10 [INFO] [stdout] | [INFO] [stdout] 39 | Some(v || (!v && count == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - Some(v || (!v && count == 0)) [INFO] [stdout] 39 + Some(!(!v && count != 0)) [INFO] [stdout] | [INFO] [stdout] 39 - Some(v || (!v && count == 0)) [INFO] [stdout] 39 + Some(v || count == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day_11.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] 65 + Some(!(!v && states.contains(&Some(true)))) [INFO] [stdout] | [INFO] [stdout] 65 - Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] 65 + Some(v || !states.contains(&Some(true))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/bin/day_14.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | .split(|c| c == '[' || c == ']' || c == ' ') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['[', ']', ' ']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day_11.rs:39:10 [INFO] [stdout] | [INFO] [stdout] 39 | Some(v || (!v && count == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - Some(v || (!v && count == 0)) [INFO] [stdout] 39 + Some(!(!v && count != 0)) [INFO] [stdout] | [INFO] [stdout] 39 - Some(v || (!v && count == 0)) [INFO] [stdout] 39 + Some(v || count == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day_11.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] 65 + Some(!(!v && states.contains(&Some(true)))) [INFO] [stdout] | [INFO] [stdout] 65 - Some(v || (!v && !states.contains(&Some(true)))) [INFO] [stdout] 65 + Some(v || !states.contains(&Some(true))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/bin/day_14.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | .split(|c| c == '[' || c == ']' || c == ' ') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['[', ']', ' ']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | v >= 1020 && v <= 2002 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1020..=2002).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | v >= 2010 && v <= 2020 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2010..=2020).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | v >= 2020 && v <= 2030 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2020..=2030).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | return v >= 59 && v <= 76; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `(59..=76).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/bin/day_04.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | return v >= 150 && v <= 193; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(150..=193).contains(&v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/bin/day_02.rs:34:56 [INFO] [stdout] | [INFO] [stdout] 34 | let rule_parts: Vec<&str> = parts[0].split(|c| c == '-' || c == ' ').collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', ' ']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/bin/day_02.rs:34:56 [INFO] [stdout] | [INFO] [stdout] 34 | let rule_parts: Vec<&str> = parts[0].split(|c| c == '-' || c == ' ').collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', ' ']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `Command { std: "docker" "inspect" "e4b25ee343d4bd138af9d6239f2feb7bde32e99936320a65776021ffd0074aad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4b25ee343d4bd138af9d6239f2feb7bde32e99936320a65776021ffd0074aad", kill_on_drop: false }` [INFO] [stdout] e4b25ee343d4bd138af9d6239f2feb7bde32e99936320a65776021ffd0074aad