[INFO] cloning repository https://github.com/jsimonrichard/node-module-version-checker-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jsimonrichard/node-module-version-checker-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsimonrichard%2Fnode-module-version-checker-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsimonrichard%2Fnode-module-version-checker-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fd0c8021ca9a28627f77795b387141bb46803ae3 [INFO] linting jsimonrichard/node-module-version-checker-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjsimonrichard%2Fnode-module-version-checker-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jsimonrichard/node-module-version-checker-rs [INFO] finished tweaking git repo https://github.com/jsimonrichard/node-module-version-checker-rs [INFO] tweaked toml for git repo https://github.com/jsimonrichard/node-module-version-checker-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jsimonrichard/node-module-version-checker-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jsimonrichard/node-module-version-checker-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded test-log v0.2.17 [INFO] [stderr] Downloaded anstyle-wincon v3.0.8 [INFO] [stderr] Downloaded test-log-macros v0.2.17 [INFO] [stderr] Downloaded ptree v0.5.2 [INFO] [stderr] Downloaded toml_datetime v0.6.9 [INFO] [stderr] Downloaded ordered-float v2.10.1 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded serde-value v0.7.0 [INFO] [stderr] Downloaded tracing-attributes v0.1.28 [INFO] [stderr] Downloaded globset v0.4.16 [INFO] [stderr] Downloaded toml_write v0.1.1 [INFO] [stderr] Downloaded owo-colors v4.2.1 [INFO] [stderr] Downloaded clap_derive v4.5.32 [INFO] [stderr] Downloaded miniz_oxide v0.8.8 [INFO] [stderr] Downloaded toml v0.8.22 [INFO] [stderr] Downloaded zerocopy-derive v0.8.25 [INFO] [stderr] Downloaded toml_edit v0.22.26 [INFO] [stderr] Downloaded pest v2.8.0 [INFO] [stderr] Downloaded clap_builder v4.5.38 [INFO] [stderr] Downloaded color-spantrace v0.2.2 [INFO] [stderr] Downloaded winnow v0.7.10 [INFO] [stderr] Downloaded serde_json v1.0.140 [INFO] [stderr] Downloaded clap v4.5.38 [INFO] [stderr] Downloaded colored v3.0.0 [INFO] [stderr] Downloaded zerocopy v0.8.25 [INFO] [stderr] Downloaded pest_meta v2.8.0 [INFO] [stderr] Downloaded tracing-core v0.1.33 [INFO] [stderr] Downloaded pest_derive v2.8.0 [INFO] [stderr] Downloaded semver v1.0.26 [INFO] [stderr] Downloaded bstr v1.12.0 [INFO] [stderr] Downloaded smallvec v1.15.0 [INFO] [stderr] Downloaded tint v1.0.1 [INFO] [stderr] Downloaded pest_generator v2.8.0 [INFO] [stderr] Downloaded color-eyre v0.6.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3dbda82470b73aaa78aac10e0d49a9528b9d6aff189bd30c3e97a44c172f377 [INFO] running `Command { std: "docker" "start" "-a" "b3dbda82470b73aaa78aac10e0d49a9528b9d6aff189bd30c3e97a44c172f377", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3dbda82470b73aaa78aac10e0d49a9528b9d6aff189bd30c3e97a44c172f377", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3dbda82470b73aaa78aac10e0d49a9528b9d6aff189bd30c3e97a44c172f377", kill_on_drop: false }` [INFO] [stdout] b3dbda82470b73aaa78aac10e0d49a9528b9d6aff189bd30c3e97a44c172f377 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d29517b8633fd57a41a82a6653b7022b2df227b8bed255d74237357733767de5 [INFO] running `Command { std: "docker" "start" "-a" "d29517b8633fd57a41a82a6653b7022b2df227b8bed255d74237357733767de5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Compiling crunchy v0.2.3 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking toml_write v0.1.1 [INFO] [stderr] Compiling owo-colors v4.2.1 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking winnow v0.7.10 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling color-spantrace v0.2.2 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking tint v1.0.1 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking rust-ini v0.20.0 [INFO] [stderr] Checking yaml-rust2 v0.8.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking globset v0.4.16 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling test-log-macros v0.2.17 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Compiling pest v2.8.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Compiling pest_meta v2.8.0 [INFO] [stderr] Checking tracing-error v0.2.1 [INFO] [stderr] Checking test-log v0.2.17 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking color-eyre v0.6.4 [INFO] [stderr] Compiling pest_generator v2.8.0 [INFO] [stderr] Compiling pest_derive v2.8.0 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.9 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking toml_edit v0.22.26 [INFO] [stderr] Checking toml v0.8.22 [INFO] [stderr] Checking config v0.14.1 [INFO] [stderr] Checking ptree v0.5.2 [INFO] [stderr] Checking node-module-version-checker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:74:59 [INFO] [stdout] | [INFO] [stdout] 74 | resolved_dependencies = self.resolve_deps(&dependencies, &sub_resolver)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:75:63 [INFO] [stdout] | [INFO] [stdout] 75 | resolved_dev_dependencies = self.resolve_deps(&dev_dependencies, &sub_resolver)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `dev_dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:77:59 [INFO] [stdout] | [INFO] [stdout] 77 | resolved_dependencies = self.resolve_deps(&dependencies, node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:78:63 [INFO] [stdout] | [INFO] [stdout] 78 | resolved_dev_dependencies = self.resolve_deps(&dev_dependencies, node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `dev_dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/dependency_resolver.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | self.packages.borrow().get(key).map(|r| r.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.packages.borrow().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:71:52 [INFO] [stdout] | [INFO] [stdout] 71 | let left = match package.satisfies(&version_req_left, Side::Left) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `version_req_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:76:53 [INFO] [stdout] | [INFO] [stdout] 76 | let right = match package.satisfies(&version_req_right, Side::Right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `version_req_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:94:42 [INFO] [stdout] | [INFO] [stdout] 94 | } => match package.satisfies(&version_req) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `version_req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:142:57 [INFO] [stdout] | [INFO] [stdout] 142 | .and_then(|version| version_req.matches(&version)), [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/diff.rs:174:23 [INFO] [stdout] | [INFO] [stdout] 174 | let name = if &self.left.name == &self.right.name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 174 - let name = if &self.left.name == &self.right.name { [INFO] [stdout] 174 + let name = if self.left.name == self.right.name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/diff.rs:180:30 [INFO] [stdout] | [INFO] [stdout] 180 | let version_str = if &self.left.version == &self.right.version { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 180 - let version_str = if &self.left.version == &self.right.version { [INFO] [stdout] 180 + let version_str = if self.left.version == self.right.version { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:334:16 [INFO] [stdout] | [INFO] [stdout] 334 | if !self.diffed_packages.borrow().get(&key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.diffed_packages.borrow().get(&key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:353:67 [INFO] [stdout] | [INFO] [stdout] 353 | return diffed_package.as_ref().map(|rc| Rc::downgrade(&rc)); [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/diff.rs:387:53 [INFO] [stdout] | [INFO] [stdout] 387 | .insert(key.clone(), diffed_package.map(|dp| Rc::new(dp))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Rc::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/diff.rs:394:18 [INFO] [stdout] | [INFO] [stdout] 394 | .map(|rc| Rc::downgrade(rc)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Rc::downgrade` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/diff.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | return dependencies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - return dependencies; [INFO] [stdout] 436 + dependencies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/diff.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 480 | / self.diffed_packages [INFO] [stdout] 481 | | .borrow() [INFO] [stdout] 482 | | .get(key) [INFO] [stdout] 483 | | .and_then(|dp| dp.as_ref()) [INFO] [stdout] 484 | | .map(|rc| rc.clone()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 480 ~ self.diffed_packages [INFO] [stdout] 481 + .borrow() [INFO] [stdout] 482 + .get(key) [INFO] [stdout] 483 + .and_then(|dp| dp.as_ref()).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return Self::SemVer(semver_req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Self::SemVer(semver_req); [INFO] [stdout] 15 + Self::SemVer(semver_req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] 17 + Self::Workspace(version_str[10..].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return Self::Or(version_reqs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Self::Or(version_reqs); [INFO] [stdout] 23 + Self::Or(version_reqs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return Self::Unchecked(version_str.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Self::Unchecked(version_str.to_string()); [INFO] [stdout] 25 + Self::Unchecked(version_str.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/extended_version_req.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/extended_version_req.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | } else if version_str.starts_with("workspace:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 16 ~ } else if let Some() = version_str.strip_prefix("workspace:") { [INFO] [stdout] 17 ~ return Self::Workspace(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/extended_version_req.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|version_str| Self::parse(version_str)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::parse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/node_modules.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | self.packages.get(name).map(|p| p.clone()).or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.packages.get(name).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are needlessly cloning iterator elements [INFO] [stdout] --> src/node_modules.rs:98:50 [INFO] [stdout] | [INFO] [stdout] 98 | .and_then(|p| p.get_package(name).map(|p| p.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the `map` call [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Self::from_folder_with_id(folder, id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Self::from_folder_with_id(folder, id); [INFO] [stdout] 37 + Self::from_folder_with_id(folder, id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | return Self::from_value(value, node_modules_id, folder); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Self::from_value(value, node_modules_id, folder); [INFO] [stdout] 42 + Self::from_value(value, node_modules_id, folder) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(None); [INFO] [stdout] 44 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/package_data.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|v| Version::parse(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Version::parse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/package_data.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | .map(|path| NodeModules::from_folder(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `NodeModules::from_folder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/package_data.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | / Ok(w.as_str().ok_or_else(|| { [INFO] [stdout] 166 | | eyre!( [INFO] [stdout] 167 | | "workspace entry in package.json in {} is not a string", [INFO] [stdout] 168 | | install_path.display() [INFO] [stdout] 169 | | ) [INFO] [stdout] 170 | | })?) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 165 ~ w.as_str().ok_or_else(|| { [INFO] [stdout] 166 | eyre!( [INFO] [stdout] ... [INFO] [stdout] 169 | ) [INFO] [stdout] 170 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ptree_impl/diff.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 40 - let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] 40 + let deduped_str = if self.package.as_ref().is_some_and(|p| *p.visited.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/ptree_impl/diff.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / self.get_children() [INFO] [stdout] 113 | | .into_iter() [INFO] [stdout] | | _________________________- [INFO] [stdout] 114 | || .cloned() [INFO] [stdout] 115 | || .filter(|c| c.should_display()) [INFO] [stdout] | ||___________________________________________^ [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | help: try: `.filter(|&c| c.should_display()).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/ptree_impl/diff.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ptree_impl/diff.rs:134:38 [INFO] [stdout] | [INFO] [stdout] 134 | .get_package(&key), [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/diff.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 152 | .map(|r| ChildOrDevDependencySeparator::Child(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/diff.rs:161:26 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|r| ChildOrDevDependencySeparator::Child(r)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/ptree_impl/diff.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | / self.get_children() [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] | | _________________________- [INFO] [stdout] 185 | || .cloned() [INFO] [stdout] 186 | || .filter(|c| c.should_display()) [INFO] [stdout] | ||___________________________________________^ [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | help: try: `.filter(|&c| c.should_display()).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/ptree_impl/diff.rs:184:14 [INFO] [stdout] | [INFO] [stdout] 184 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ptree_impl/package.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 18 - let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] 18 + let deduped_str = if self.package.as_ref().is_some_and(|p| *p.visited.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ptree_impl/package.rs:53:74 [INFO] [stdout] | [INFO] [stdout] 53 | self.dep_resolver.upgrade().unwrap().get_package(&key) [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/package.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|d| ChildOrDevDependencySeparator::Child(d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/package.rs:94:26 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|d| ChildOrDevDependencySeparator::Child(d)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/resolver.rs:52:50 [INFO] [stdout] | [INFO] [stdout] 52 | ... if !globset.is_match(&norm_for_glob(&package_path.to_string_lossy())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `norm_for_glob(&package_path.to_string_lossy())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:143:58 [INFO] [stdout] | [INFO] [stdout] 143 | let entry = dep_resolver.resolve_package(&package_data, &node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `package_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolver.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(builder.build()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(builder.build()?); [INFO] [stdout] 156 + Ok(builder.build()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/workspace_data.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / self.workspace_packages [INFO] [stdout] 32 | | .iter() [INFO] [stdout] 33 | | .find(|p| { [INFO] [stdout] 34 | | p.install_path [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | .map(|p| p.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 31 ~ self.workspace_packages [INFO] [stdout] 32 + .iter() [INFO] [stdout] 33 + .find(|p| { [INFO] [stdout] 34 + p.install_path [INFO] [stdout] 35 + .canonicalize() [INFO] [stdout] 36 + .ok() [INFO] [stdout] 37 + .map(|p| p == path) [INFO] [stdout] 38 + .unwrap_or(false) [INFO] [stdout] 39 + }).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/mod.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | fn children(&self) -> Cow<[C::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 50 | fn children(&self) -> Cow<'_, [C::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn get_children(&self) -> Cow<[ChildOrDevDependencySeparator]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 21 | fn get_children(&self) -> Cow<'_, [ChildOrDevDependencySeparator]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 103 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | fn get_children(&self) -> Cow<[ChildOrDevDependencySeparator]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 147 | fn get_children(&self) -> Cow<'_, [ChildOrDevDependencySeparator]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 176 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/package.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 35 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/package.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 74 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:74:59 [INFO] [stdout] | [INFO] [stdout] 74 | resolved_dependencies = self.resolve_deps(&dependencies, &sub_resolver)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:75:63 [INFO] [stdout] | [INFO] [stdout] 75 | resolved_dev_dependencies = self.resolve_deps(&dev_dependencies, &sub_resolver)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `dev_dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:77:59 [INFO] [stdout] | [INFO] [stdout] 77 | resolved_dependencies = self.resolve_deps(&dependencies, node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/dependency_resolver.rs:78:63 [INFO] [stdout] | [INFO] [stdout] 78 | resolved_dev_dependencies = self.resolve_deps(&dev_dependencies, node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `dev_dependencies` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/dependency_resolver.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | self.packages.borrow().get(key).map(|r| r.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.packages.borrow().get(key).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:71:52 [INFO] [stdout] | [INFO] [stdout] 71 | let left = match package.satisfies(&version_req_left, Side::Left) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `version_req_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:76:53 [INFO] [stdout] | [INFO] [stdout] 76 | let right = match package.satisfies(&version_req_right, Side::Right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `version_req_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:94:42 [INFO] [stdout] | [INFO] [stdout] 94 | } => match package.satisfies(&version_req) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `version_req` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:142:57 [INFO] [stdout] | [INFO] [stdout] 142 | .and_then(|version| version_req.matches(&version)), [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/diff.rs:174:23 [INFO] [stdout] | [INFO] [stdout] 174 | let name = if &self.left.name == &self.right.name { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 174 - let name = if &self.left.name == &self.right.name { [INFO] [stdout] 174 + let name = if self.left.name == self.right.name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/diff.rs:180:30 [INFO] [stdout] | [INFO] [stdout] 180 | let version_str = if &self.left.version == &self.right.version { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 180 - let version_str = if &self.left.version == &self.right.version { [INFO] [stdout] 180 + let version_str = if self.left.version == self.right.version { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:334:16 [INFO] [stdout] | [INFO] [stdout] 334 | if !self.diffed_packages.borrow().get(&key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.diffed_packages.borrow().get(&key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:353:67 [INFO] [stdout] | [INFO] [stdout] 353 | return diffed_package.as_ref().map(|rc| Rc::downgrade(&rc)); [INFO] [stdout] | ^^^ help: change this to: `rc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/diff.rs:387:53 [INFO] [stdout] | [INFO] [stdout] 387 | .insert(key.clone(), diffed_package.map(|dp| Rc::new(dp))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Rc::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/diff.rs:394:18 [INFO] [stdout] | [INFO] [stdout] 394 | .map(|rc| Rc::downgrade(rc)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Rc::downgrade` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/diff.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | return dependencies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - return dependencies; [INFO] [stdout] 436 + dependencies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/diff.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 480 | / self.diffed_packages [INFO] [stdout] 481 | | .borrow() [INFO] [stdout] 482 | | .get(key) [INFO] [stdout] 483 | | .and_then(|dp| dp.as_ref()) [INFO] [stdout] 484 | | .map(|rc| rc.clone()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 480 ~ self.diffed_packages [INFO] [stdout] 481 + .borrow() [INFO] [stdout] 482 + .get(key) [INFO] [stdout] 483 + .and_then(|dp| dp.as_ref()).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return Self::SemVer(semver_req); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Self::SemVer(semver_req); [INFO] [stdout] 15 + Self::SemVer(semver_req) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] 17 + Self::Workspace(version_str[10..].to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return Self::Or(version_reqs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Self::Or(version_reqs); [INFO] [stdout] 23 + Self::Or(version_reqs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/extended_version_req.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return Self::Unchecked(version_str.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Self::Unchecked(version_str.to_string()); [INFO] [stdout] 25 + Self::Unchecked(version_str.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/extended_version_req.rs:17:36 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::Workspace(version_str[10..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/extended_version_req.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | } else if version_str.starts_with("workspace:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 16 ~ } else if let Some() = version_str.strip_prefix("workspace:") { [INFO] [stdout] 17 ~ return Self::Workspace(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/extended_version_req.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|version_str| Self::parse(version_str)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::parse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/node_modules.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | self.packages.get(name).map(|p| p.clone()).or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.packages.get(name).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are needlessly cloning iterator elements [INFO] [stdout] --> src/node_modules.rs:98:50 [INFO] [stdout] | [INFO] [stdout] 98 | .and_then(|p| p.get_package(name).map(|p| p.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the `map` call [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return Self::from_folder_with_id(folder, id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Self::from_folder_with_id(folder, id); [INFO] [stdout] 37 + Self::from_folder_with_id(folder, id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | return Self::from_value(value, node_modules_id, folder); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Self::from_value(value, node_modules_id, folder); [INFO] [stdout] 42 + Self::from_value(value, node_modules_id, folder) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/package_data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(None); [INFO] [stdout] 44 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/package_data.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|v| Version::parse(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Version::parse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/package_data.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | .map(|path| NodeModules::from_folder(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `NodeModules::from_folder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/package_data.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | / Ok(w.as_str().ok_or_else(|| { [INFO] [stdout] 166 | | eyre!( [INFO] [stdout] 167 | | "workspace entry in package.json in {} is not a string", [INFO] [stdout] 168 | | install_path.display() [INFO] [stdout] 169 | | ) [INFO] [stdout] 170 | | })?) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 165 ~ w.as_str().ok_or_else(|| { [INFO] [stdout] 166 | eyre!( [INFO] [stdout] ... [INFO] [stdout] 169 | ) [INFO] [stdout] 170 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ptree_impl/diff.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 40 - let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] 40 + let deduped_str = if self.package.as_ref().is_some_and(|p| *p.visited.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/ptree_impl/diff.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / self.get_children() [INFO] [stdout] 113 | | .into_iter() [INFO] [stdout] | | _________________________- [INFO] [stdout] 114 | || .cloned() [INFO] [stdout] 115 | || .filter(|c| c.should_display()) [INFO] [stdout] | ||___________________________________________^ [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | help: try: `.filter(|&c| c.should_display()).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/ptree_impl/diff.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ptree_impl/diff.rs:134:38 [INFO] [stdout] | [INFO] [stdout] 134 | .get_package(&key), [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/diff.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 152 | .map(|r| ChildOrDevDependencySeparator::Child(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/diff.rs:161:26 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|r| ChildOrDevDependencySeparator::Child(r)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/ptree_impl/diff.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | / self.get_children() [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] | | _________________________- [INFO] [stdout] 185 | || .cloned() [INFO] [stdout] 186 | || .filter(|c| c.should_display()) [INFO] [stdout] | ||___________________________________________^ [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | help: try: `.filter(|&c| c.should_display()).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/ptree_impl/diff.rs:184:14 [INFO] [stdout] | [INFO] [stdout] 184 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ptree_impl/package.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 18 - let deduped_str = if self.package.as_ref().map_or(false, |p| *p.visited.borrow()) { [INFO] [stdout] 18 + let deduped_str = if self.package.as_ref().is_some_and(|p| *p.visited.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ptree_impl/package.rs:53:74 [INFO] [stdout] | [INFO] [stdout] 53 | self.dep_resolver.upgrade().unwrap().get_package(&key) [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/package.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|d| ChildOrDevDependencySeparator::Child(d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ptree_impl/package.rs:94:26 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|d| ChildOrDevDependencySeparator::Child(d)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `ChildOrDevDependencySeparator::Child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/resolver.rs:52:50 [INFO] [stdout] | [INFO] [stdout] 52 | ... if !globset.is_match(&norm_for_glob(&package_path.to_string_lossy())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `norm_for_glob(&package_path.to_string_lossy())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolver.rs:143:58 [INFO] [stdout] | [INFO] [stdout] 143 | let entry = dep_resolver.resolve_package(&package_data, &node_modules)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `package_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolver.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(builder.build()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(builder.build()?); [INFO] [stdout] 156 + Ok(builder.build()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/resolver.rs:177:34 [INFO] [stdout] | [INFO] [stdout] 177 | assert!(globset.is_match(&norm_for_glob("/packages/react-vite"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `norm_for_glob("/packages/react-vite")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/resolver.rs:178:34 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(globset.is_match(&norm_for_glob("/packages/react-vite/node_modules"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `norm_for_glob("/packages/react-vite/node_modules")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/workspace_data.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / self.workspace_packages [INFO] [stdout] 32 | | .iter() [INFO] [stdout] 33 | | .find(|p| { [INFO] [stdout] 34 | | p.install_path [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | .map(|p| p.clone()) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 31 ~ self.workspace_packages [INFO] [stdout] 32 + .iter() [INFO] [stdout] 33 + .find(|p| { [INFO] [stdout] 34 + p.install_path [INFO] [stdout] 35 + .canonicalize() [INFO] [stdout] 36 + .ok() [INFO] [stdout] 37 + .map(|p| p == path) [INFO] [stdout] 38 + .unwrap_or(false) [INFO] [stdout] 39 + }).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/mod.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | fn children(&self) -> Cow<[C::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 50 | fn children(&self) -> Cow<'_, [C::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn get_children(&self) -> Cow<[ChildOrDevDependencySeparator]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 21 | fn get_children(&self) -> Cow<'_, [ChildOrDevDependencySeparator]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 103 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | fn get_children(&self) -> Cow<[ChildOrDevDependencySeparator]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 147 | fn get_children(&self) -> Cow<'_, [ChildOrDevDependencySeparator]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/diff.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 176 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/package.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 35 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ptree_impl/package.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | fn children(&self) -> Cow<[Self::Child]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 74 | fn children(&self) -> Cow<'_, [Self::Child]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.67s [INFO] running `Command { std: "docker" "inspect" "d29517b8633fd57a41a82a6653b7022b2df227b8bed255d74237357733767de5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d29517b8633fd57a41a82a6653b7022b2df227b8bed255d74237357733767de5", kill_on_drop: false }` [INFO] [stdout] d29517b8633fd57a41a82a6653b7022b2df227b8bed255d74237357733767de5