[INFO] cloning repository https://github.com/jshuay/squidward [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jshuay/squidward" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjshuay%2Fsquidward", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjshuay%2Fsquidward'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d4281f0b6c5867fdffe4554caca84f1208a84119 [INFO] linting jshuay/squidward against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjshuay%2Fsquidward" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/jshuay/squidward [INFO] finished tweaking git repo https://github.com/jshuay/squidward [INFO] tweaked toml for git repo https://github.com/jshuay/squidward written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/jshuay/squidward on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/jshuay/squidward already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rkyv_derive v0.7.46 [INFO] [stderr] Downloaded rust_decimal_macros v1.40.0 [INFO] [stderr] Downloaded rkyv v0.7.46 [INFO] [stderr] Downloaded jiff-static v0.2.22 [INFO] [stderr] Downloaded jiff v0.2.22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e97f5b8989ff4beab0dc70efb0e3e8e674a6be2b4fb9eb7002dd1fc2d6b9fdcb [INFO] running `Command { std: "docker" "start" "-a" "e97f5b8989ff4beab0dc70efb0e3e8e674a6be2b4fb9eb7002dd1fc2d6b9fdcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e97f5b8989ff4beab0dc70efb0e3e8e674a6be2b4fb9eb7002dd1fc2d6b9fdcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e97f5b8989ff4beab0dc70efb0e3e8e674a6be2b4fb9eb7002dd1fc2d6b9fdcb", kill_on_drop: false }` [INFO] [stdout] e97f5b8989ff4beab0dc70efb0e3e8e674a6be2b4fb9eb7002dd1fc2d6b9fdcb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 160162ba1b2e641bd222721cdc79aed7cd0056d70968fd77da63288f4febabae [INFO] running `Command { std: "docker" "start" "-a" "160162ba1b2e641bd222721cdc79aed7cd0056d70968fd77da63288f4febabae", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking jiff v0.2.22 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling rust_decimal_macros v1.40.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking squidward v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:187:38 [INFO] [stdout] | [INFO] [stdout] 187 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:206:38 [INFO] [stdout] | [INFO] [stdout] 206 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:187:38 [INFO] [stdout] | [INFO] [stdout] 187 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:206:38 [INFO] [stdout] | [INFO] [stdout] 206 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Decimal` which implements the `Copy` trait [INFO] [stdout] --> src/payment_system/mod.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | *transaction.amount_mut() = Some(disputed_amount.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*disputed_amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | assert!(!output.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `output.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | assert!(!output.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `output.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | assert!(!exit_status.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `exit_status.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.35s [INFO] running `Command { std: "docker" "inspect" "160162ba1b2e641bd222721cdc79aed7cd0056d70968fd77da63288f4febabae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "160162ba1b2e641bd222721cdc79aed7cd0056d70968fd77da63288f4febabae", kill_on_drop: false }` [INFO] [stdout] 160162ba1b2e641bd222721cdc79aed7cd0056d70968fd77da63288f4febabae