[INFO] cloning repository https://github.com/joshvoigts/opt
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/joshvoigts/opt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshvoigts%2Fopt", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshvoigts%2Fopt'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] bac069cfe634cb438d355db52428eef29b83b284
[INFO] linting joshvoigts/opt against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjoshvoigts%2Fopt" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/joshvoigts/opt
[INFO] finished tweaking git repo https://github.com/joshvoigts/opt
[INFO] tweaked toml for git repo https://github.com/joshvoigts/opt written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/joshvoigts/opt on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/joshvoigts/opt already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 6fcf85177d088fa46a14cd7097e2733518536006d81bd80dcb905fa41f4262a5
[INFO] running `Command { std: "docker" "start" "-a" "6fcf85177d088fa46a14cd7097e2733518536006d81bd80dcb905fa41f4262a5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6fcf85177d088fa46a14cd7097e2733518536006d81bd80dcb905fa41f4262a5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6fcf85177d088fa46a14cd7097e2733518536006d81bd80dcb905fa41f4262a5", kill_on_drop: false }`
[INFO] [stdout] 6fcf85177d088fa46a14cd7097e2733518536006d81bd80dcb905fa41f4262a5
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] abe0d0d1dab611d0767c44508f20a92c9e2b740d1348f5e3a9860f6d2f355d13
[INFO] running `Command { std: "docker" "start" "-a" "abe0d0d1dab611d0767c44508f20a92c9e2b740d1348f5e3a9860f6d2f355d13", kill_on_drop: false }`
[INFO] [stderr]     Checking optz v0.10.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/opt.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary
[INFO] [stdout]    --> src/opt.rs:118:11
[INFO] [stdout]     |
[INFO] [stdout] 118 |   fn help(self: &Self) -> Result<()> {
[INFO] [stdout]     |           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type
[INFO] [stdout]     = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default
[INFO] [stdout] help: remove the type
[INFO] [stdout]     |
[INFO] [stdout] 118 -   fn help(self: &Self) -> Result<()> {
[INFO] [stdout] 118 +   fn help(&self) -> Result<()> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/opt.rs:279:7
[INFO] [stdout]     |
[INFO] [stdout] 279 |       long: long,
[INFO] [stdout]     |       ^^^^^^^^^^ help: replace it with: `long`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/opt.rs:289:7
[INFO] [stdout]     |
[INFO] [stdout] 289 |       long: long,
[INFO] [stdout]     |       ^^^^^^^^^^ help: replace it with: `long`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/opt.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary
[INFO] [stdout]    --> src/opt.rs:118:11
[INFO] [stdout]     |
[INFO] [stdout] 118 |   fn help(self: &Self) -> Result<()> {
[INFO] [stdout]     |           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type
[INFO] [stdout]     = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default
[INFO] [stdout] help: remove the type
[INFO] [stdout]     |
[INFO] [stdout] 118 -   fn help(self: &Self) -> Result<()> {
[INFO] [stdout] 118 +   fn help(&self) -> Result<()> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/opt.rs:279:7
[INFO] [stdout]     |
[INFO] [stdout] 279 |       long: long,
[INFO] [stdout]     |       ^^^^^^^^^^ help: replace it with: `long`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/opt.rs:289:7
[INFO] [stdout]     |
[INFO] [stdout] 289 |       long: long,
[INFO] [stdout]     |       ^^^^^^^^^^ help: replace it with: `long`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/opt.rs:215:14
[INFO] [stdout]     |
[INFO] [stdout] 215 |           if !res.is_ok() {
[INFO] [stdout]     |              ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/opt.rs:226:10
[INFO] [stdout]     |
[INFO] [stdout] 226 |       if !res.is_ok() {
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/opt.rs:217:15
[INFO] [stdout]     |
[INFO] [stdout] 215 |           if !res.is_ok() {
[INFO] [stdout]     |               ----------- the check is happening here
[INFO] [stdout] 216 |             return Err(OptzError::Parse(
[INFO] [stdout] 217 |               res.unwrap_err().to_string(),
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/opt.rs:227:37
[INFO] [stdout]     |
[INFO] [stdout] 226 |       if !res.is_ok() {
[INFO] [stdout]     |           ----------- the check is happening here
[INFO] [stdout] 227 |         return Err(OptzError::Parse(res.unwrap_err().to_string()));
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/opt.rs:212:7
[INFO] [stdout]     |
[INFO] [stdout] 212 | /       if !opt.values.is_empty() {
[INFO] [stdout] 213 | |         if let Some(handler) = opt.handler {
[INFO] [stdout] 214 | |           let res = handler(&self);
[INFO] [stdout] 215 | |           if !res.is_ok() {
[INFO] [stdout] ...   |
[INFO] [stdout] 221 | |       }
[INFO] [stdout]     | |_______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 212 ~       if !opt.values.is_empty()
[INFO] [stdout] 213 ~         && let Some(handler) = opt.handler {
[INFO] [stdout] 214 |           let res = handler(&self);
[INFO] [stdout] ...
[INFO] [stdout] 219 |           }
[INFO] [stdout] 220 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/opt.rs:215:14
[INFO] [stdout]     |
[INFO] [stdout] 215 |           if !res.is_ok() {
[INFO] [stdout]     |              ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/opt.rs:226:10
[INFO] [stdout]     |
[INFO] [stdout] 226 |       if !res.is_ok() {
[INFO] [stdout]     |          ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/opt.rs:217:15
[INFO] [stdout]     |
[INFO] [stdout] 215 |           if !res.is_ok() {
[INFO] [stdout]     |               ----------- the check is happening here
[INFO] [stdout] 216 |             return Err(OptzError::Parse(
[INFO] [stdout] 217 |               res.unwrap_err().to_string(),
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/opt.rs:227:37
[INFO] [stdout]     |
[INFO] [stdout] 226 |       if !res.is_ok() {
[INFO] [stdout]     |           ----------- the check is happening here
[INFO] [stdout] 227 |         return Err(OptzError::Parse(res.unwrap_err().to_string()));
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/opt.rs:212:7
[INFO] [stdout]     |
[INFO] [stdout] 212 | /       if !opt.values.is_empty() {
[INFO] [stdout] 213 | |         if let Some(handler) = opt.handler {
[INFO] [stdout] 214 | |           let res = handler(&self);
[INFO] [stdout] 215 | |           if !res.is_ok() {
[INFO] [stdout] ...   |
[INFO] [stdout] 221 | |       }
[INFO] [stdout]     | |_______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 212 ~       if !opt.values.is_empty()
[INFO] [stdout] 213 ~         && let Some(handler) = opt.handler {
[INFO] [stdout] 214 |           let res = handler(&self);
[INFO] [stdout] ...
[INFO] [stdout] 219 |           }
[INFO] [stdout] 220 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> tests/test_opt.rs:14:3
[INFO] [stdout]    |
[INFO] [stdout] 14 |   assert_eq!(result, true);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 14 -   assert_eq!(result, true);
[INFO] [stdout] 14 +   assert!(result);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> tests/test_opt.rs:44:3
[INFO] [stdout]    |
[INFO] [stdout] 44 |   assert_eq!(result, true);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 44 -   assert_eq!(result, true);
[INFO] [stdout] 44 +   assert!(result);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> tests/test_opt.rs:218:3
[INFO] [stdout]     |
[INFO] [stdout] 218 |   assert_eq!(result, true);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 218 -   assert_eq!(result, true);
[INFO] [stdout] 218 +   assert!(result);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s
[INFO] running `Command { std: "docker" "inspect" "abe0d0d1dab611d0767c44508f20a92c9e2b740d1348f5e3a9860f6d2f355d13", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "abe0d0d1dab611d0767c44508f20a92c9e2b740d1348f5e3a9860f6d2f355d13", kill_on_drop: false }`
[INFO] [stdout] abe0d0d1dab611d0767c44508f20a92c9e2b740d1348f5e3a9860f6d2f355d13